From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DBF4A0561; Thu, 18 Mar 2021 11:35:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E33A9406B4; Thu, 18 Mar 2021 11:35:48 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 2CDFF40698 for ; Thu, 18 Mar 2021 11:35:46 +0100 (CET) IronPort-SDR: fu0KYthlLh7Ib81JtUEkTQuUMfbJtURM/sgA4Atkl9jyurzNKgL1LCW0DQUn/+aDzWYo5p2Xxj UC4ZGwQdPJ0A== X-IronPort-AV: E=McAfee;i="6000,8403,9926"; a="189694984" X-IronPort-AV: E=Sophos;i="5.81,258,1610438400"; d="scan'208";a="189694984" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2021 03:35:45 -0700 IronPort-SDR: jggVQ96Dj5DYHAUpINK1wO+Vs5q/SK81CDsjHgD0MwmDR3NC6I0J/MWVPOCpE85FXzNbAI7JhD B4x9hBuAzL1w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,258,1610438400"; d="scan'208";a="379702990" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga007.fm.intel.com with ESMTP; 18 Mar 2021 03:35:45 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 18 Mar 2021 03:35:44 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 18 Mar 2021 03:35:44 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 18 Mar 2021 03:35:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TNMpsKXQqJHmHkLVJgc7c6zqlY0FnS+3APu1BML2CzoljUqQwayrUvbjvjEtuqj5538okaF+2NyaFaBPbO5dn9fprVi7pi4J7ZaalzciNosa4eToa7lvvIJCE4LlZl4FYnRkclkz/o0qOIIoAKEwGdoHZf21eKb06WWdAzc3VSrSm9OTiIV6s7eTit5huYcxVamZp6xpZ6wR0m4bE5uTpEr/6s7S9H+2uVvvHYa0spy6VB1XVEwSnRNI80+fS9+qgBiyDcvwFD7lbemPEwfM2R4MusEpzrDqGY8jPrY6zm2q1bclUwETizh0FCRMPM+qE4n76OhPEpq0xyNS/I+Ybw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=86Yn3hqErjdGbarw9Hm9z/pUOxRBuTfEyOtIAHdm+5o=; b=WBXajRxOsqeKY5u7QsmX50VLFKe/fDccDpeYw21TfI3W2JQUjV84Uxapp3NDX+e6/FjARPnxzbe6GFjzgOoEBpYMEse+GzFWdW2QoKEcZbePqSb1u8e/uI/OnYj3gppcXWcoixs75zdVJ9ZqLN21wYpPoq58REvb6t+HWiW8FY9QBZ7gifbHGMU0bZ/blAneIzALpQrUftXzwwOvT8ozT5JKuOoupbM+GGRDXQEeoM1AXJpeflz8owDkaPkOEWTFXK84KJa6o1wnXpjWrNgcz0Fdn6yoMqiu8ZisHG3cGC++VkL5EPieytZC9RL1gtytPGrSntgjAsZsSJSAVrCgvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=86Yn3hqErjdGbarw9Hm9z/pUOxRBuTfEyOtIAHdm+5o=; b=CzGtKu7QKQ4aTOSnRL34GGUQDbmIaKivN4k0u858UVOITPACtfBX340fjaOrl0mMj0xPkPh7X0IBLpigcDB4FGX7+j8bI8HJV9btw7Scjb2NpEzYT/xmdEjf/KlHTpzuJjKqhGIGpCtqbPPqWa0MYf9fe/YyuzuGT2Osn3QAd2c= Received: from BYAPR11MB3143.namprd11.prod.outlook.com (2603:10b6:a03:92::32) by SJ0PR11MB5181.namprd11.prod.outlook.com (2603:10b6:a03:2de::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3933.32; Thu, 18 Mar 2021 10:35:11 +0000 Received: from BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::8543:8483:f483:bcc7]) by BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::8543:8483:f483:bcc7%4]) with mapi id 15.20.3955.018; Thu, 18 Mar 2021 10:35:11 +0000 From: "Van Haaren, Harry" To: "Rong, Leyi" , "Zhang, Qi Z" , "Lu, Wenzhuo" CC: dpdk-dev Thread-Topic: [dpdk-dev] [PATCH 2/2] net/ice: add Rx AVX512 offload path Thread-Index: AQHXGxEM3BVyLqBryUC+wWfCSuqgEKqJi1UQ Date: Thu, 18 Mar 2021 10:35:11 +0000 Message-ID: References: <20210317091409.11725-1-leyi.rong@intel.com> <20210317091409.11725-3-leyi.rong@intel.com> In-Reply-To: <20210317091409.11725-3-leyi.rong@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [86.40.59.136] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4b0fd3eb-9578-49bf-8328-08d8e9f98267 x-ms-traffictypediagnostic: SJ0PR11MB5181: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zVvdBEF2sZt/5mFpJJm+azltqzUrLy614PdQIhOSLbQcTrKScsYfXrCByywxUSaaYaPd2PsPjBzuyHx0vb6kVjfdDp32wSa/7Chut99rFpKfIiop227YQ1XHRanBbljf0OuiFmzKTEBSL3uBwuffJbT8n/eN1dbBtXQf/K0hhkNsuDVYLGuOoNITnl8h+h1T9wCBZxrxHIflZW9W/IsEQ1dFNquBRtnwbJNEYQFQuxYEsWggw8TZqTz0SBWDji1++4Nvf4gQeOjNzb0eAvu0qi9wfsOLFi375j2/XGGKEJG7JWWQmtjlmuGjFzKFsr/Yx6uSHAsGmNeA7vC5D2PoKWagHubwaj9uBZLPGNo5+vooDn1IMtNYLw/1ff/wZtF0c3EW+7eaRWFoiSCWKZEG1obSufHQt455f4ToMakaeIXz+9g1DFvr3kfXSIZ3fUm19AQz0XcFD8cPaH1d0OUBOU3aCPB2xSkpuWERvJsTtWCWDX8+H809EjhDcXDWhrEi8cETT/cpCXojEh65SrpOZHzkQG3jgDNbNkokjjK0yqgewQMiWaMKPoMq6rXNYFOjs5DdNA32x693d6l+wZjDmvKIgGugFMVB6WzxubWouwjT46yF+FGZaGrLtO70C/GV x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3143.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(39860400002)(376002)(136003)(396003)(346002)(26005)(64756008)(316002)(71200400001)(6636002)(2906002)(66446008)(8936002)(66556008)(66946007)(38100700001)(6506007)(66476007)(4326008)(76116006)(53546011)(52536014)(86362001)(33656002)(8676002)(7696005)(83380400001)(478600001)(5660300002)(110136005)(9686003)(186003)(55016002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?6IzYs7P1I8cqVwC0Qw9d2CeEA5BuByHcPikGvVyEJEhNaJ9wNnXqXLODetum?= =?us-ascii?Q?FgQ5oRIAXQ4HbNY6KeaO5KKIaLBWFmk2pK7mj8FaGXNPPbXR0nIiEOwn0sJJ?= =?us-ascii?Q?zbGeJMqp3HvlXz67fjFlj+20xohxQJHRqcNhgvQgGXfdvQARcH4DiauwEo6H?= =?us-ascii?Q?MxcpSz/9X6qHZbEVA0lBiGPEMaPwQhQazEzdCPd7pyvwujEwPei0EvqjkkIx?= =?us-ascii?Q?EJRCA4y6osr28QQaI/wmxKDUoH8dTHsLOf/HILEk3C2RoNMIYVa+X2rCk1uP?= =?us-ascii?Q?81A4tL3OgvFemfm0jXYxr8IOYaHPg2/+6EjP+F9+h/zZfVpaguei4CiybfUh?= =?us-ascii?Q?ass7z7GMY3T8NE7FXuwCHWrPOd78qtIH+BostYN6a0ZSCmw1laHTSqOREfLY?= =?us-ascii?Q?/VytgbmwLV7FMVUrUYqvpd2v3eUZcj7LbfG9azXYZPAmtZ8oWgfNURXaYMfe?= =?us-ascii?Q?XR6GktUPYGpMayUBrp1dnyT+B1+qjC3qn+sVFhiLfL/69Zhzt6Nt5u17nA6t?= =?us-ascii?Q?QEId1RxpHjlEabDUcYf6DQKLVusIc8BQqmbU/OuVRwhoH/gKt43vWixJ6qUa?= =?us-ascii?Q?WYu+0ghnDDoqLnz1/1FSmgulWRszQ/Vblx4GSAjTkVph+am39/BHm8/E/iIB?= =?us-ascii?Q?v0j3EM2fuWP4QemouS2/i65B/4Etu6+I2UiHgZJXIY56fW6aJaCU9ExNVJPA?= =?us-ascii?Q?dybR9FKv31Yt1zpzTJX0XVBct/+SP5FQe2v1ZGsGKRsVOUFWeZgSfAdco+Gq?= =?us-ascii?Q?E/fdnKsqJsAyRLGsy/BPcp+MdcpN7kU2BcvivcM1hXnD4m1SGSHOxpfD8Dm8?= =?us-ascii?Q?TzL2yr35H8IM/2M6CX/UNDjG9EnxmMS+qGBsVwZpWIJyZWb/R7yu4HmqHrN7?= =?us-ascii?Q?FmiEn27k+7xsJYq/AcCSLKEhqx3egeaU4ajlDtCcIC06siDTu9hBlp4TthsJ?= =?us-ascii?Q?xxpwCD7I3NNw+cJbR8Xrcz2wMTDDY+yzHlI4uhjlks9kzAj1d7F4142WXh+V?= =?us-ascii?Q?KkQrkdLwinpW96QtEclvh36Qp4zjZT07MwDDjMSH6i0/qP4qxmxGdujcqATE?= =?us-ascii?Q?pT4mwSQmKHc3tcVPKkJz2YzhUgM8/vocDxbsmarI1K0/o2MVljoI64Ax/ihn?= =?us-ascii?Q?C8QPbHxlVRCOm8FHDOaoD/Nmltdvkyb4xH/3iCGt6Q4kNZxu1rBKw0cOROm4?= =?us-ascii?Q?8TYtBXu8o0ijutZDeFQi7CCskQXuvw59NjXB7JDVh42QQMZkRdHuyNKk2zCN?= =?us-ascii?Q?2OE6Tn3+smkNbAuBZTGweOkUsGm5A1OtRMvDZXV4DS6sRvIBNvxqNFvP72Wk?= =?us-ascii?Q?s5s=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3143.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4b0fd3eb-9578-49bf-8328-08d8e9f98267 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Mar 2021 10:35:11.3097 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EkCkwOQCqXxQ67a39wp5/ANH9PzfBtwUfcFEef/d3Fux0d2o0moXQz6HLQDkSTYJVHk28kdem4LPdwoup+eqRT+Rx37lYNcXAjFT9GorkGU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5181 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 2/2] net/ice: add Rx AVX512 offload path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Leyi Rong > Sent: Wednesday, March 17, 2021 9:14 AM > To: Zhang, Qi Z ; Lu, Wenzhuo > Cc: dev@dpdk.org; Rong, Leyi > Subject: [dpdk-dev] [PATCH 2/2] net/ice: add Rx AVX512 offload path >=20 > Split AVX512 Rx data path into two, one is for basic, > the other one can support additional Rx offload features, > including Rx checksum offload, Rx vlan offload, RSS offload. >=20 > Signed-off-by: Leyi Rong > Signed-off-by: Wenzhuo Lu Hi Leyi and Wenzhou, I'm a bit concerned over code-duplication of the RX datapath in this patch, as it duplicates the core desc-to-mbuf RX loop. I loaded the following functions, and compared in "meld" to view the diff side-by-side, and it should be possible to "specialize" away the difference= s: _ice_recv_raw_pkts_vec_avx512() /* original */ _ice_recv_raw_pkts_vec_avx512_offload() /* with offload */ Specializing the implementation (adding "do_offload" parameter to _ice_recv= _raw_pkts_vec_avx512()), and branch on it with an if(do_offload) when the offload and non-offload= paths behave differently. When inlining that function the compiler will remove the branches, and you'= ll only have one version of the code to maintain, without any performance penalty. If my suggestion around parameterizing, specializing and inlining isn't cle= ar, please ask and I can try to explain better. Regards, -Harry