From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 756A8A04BB; Tue, 6 Oct 2020 10:15:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C65A925B3; Tue, 6 Oct 2020 10:15:50 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 7498DB62 for ; Tue, 6 Oct 2020 10:15:48 +0200 (CEST) IronPort-SDR: V1lNoTaXcvj2x+O1z+a7ACDe7C3S2n8ITiKE0Rv/fOo1bKaVEQ5HGuNf8Fht02a+c8h4Mv3zOB cTRMH5yQ6L4A== X-IronPort-AV: E=McAfee;i="6000,8403,9765"; a="152174683" X-IronPort-AV: E=Sophos;i="5.77,342,1596524400"; d="scan'208";a="152174683" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 01:15:46 -0700 IronPort-SDR: NAEa4IZlS7mmUiULk4/Id//WrVb1oEvvLmFBWo+S8W9WXxx+2Cw+3WJwGkU0f3P27pCFtsZTXr 3XWUvxCT4qCA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,342,1596524400"; d="scan'208";a="311120931" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 06 Oct 2020 01:15:45 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 6 Oct 2020 01:15:45 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 6 Oct 2020 01:15:45 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 6 Oct 2020 01:15:45 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 6 Oct 2020 01:15:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Z2I9l3JkEEaaJQDhaw3gta/6pQGhvNn2qXawZScQZSZqPkh4KAQ272NBEXV+VaVEqtsxMMtFRy1BLHNZHx2IR0gGZb6Zi5mmUrt5UV1DqwZXG1fjvoXhpLXobmPfzeHaVFBdCBmOVcqsZHAqxFTwdVlQmjuCKLWqcW4Za37VpN5Jr5oPuYucI/2k6sHYwj+oqbMdZPDyRX5ey6hbjffekTJQ3k0XXPdsE27wB3Cg+MyWCySzzVfoLT8dk6liEYo5mRth7zGRNkbitrdmhNhB1CO7B2w3Sw0JtcLAqS53qvx6I1hu8U6edaTqe4GXwsJZYWq5j13ymjHSaN2BiqilbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ayzCK2hHBrO8Rvi5GncJM+s3n0We95aGNHcVrHFWIUc=; b=UMIx4WVffjrfz8hDfPdQHufyw1Sj3bMEy7o6NJ8FLHGZoCvrRq4YkwKinp9b6R5rc3ETE90KiHEZvH44K/gkSGoDU+BlCsLJRa6mtOt1VyfatzcW2vp28Tz0+awz47jLr47n4fB2TZ+P8asK5qeOkkQaQsVbF+WnwJseZdxmPmzV9sbiQJ2JCD+t+cuNxnb0yy6FKpIEXLtLcH5FoJVDn2utRC1Ot8D2jJIEW6P88jBjpXCxLwnjeEZEZoKQUcJcgBBu/HRGvFNsokoD5AgRKXUNIuRzjTIqCowZkJ80FZcqUYaIlhF3iQsDTsdN+KR7wB7RtaourxfbWxsq2/WZmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ayzCK2hHBrO8Rvi5GncJM+s3n0We95aGNHcVrHFWIUc=; b=Hfpoznve6Jlhw/d9RFFXmVC+8B9WnV8/nstpKdrk38XbUN1+rQGvLL2F3ZBy1fzRqPHvSAspNXYdgHWlBrkgWOKJBxPR3AtwfcWNMDULstbDWq0KsSbBPJ5On6koI1bZq+cZg1NZgx2YgdUN8BPYiOdtFiMeJFrhCv3+GsGHEcA= Received: from BYAPR11MB3143.namprd11.prod.outlook.com (2603:10b6:a03:92::32) by BYAPR11MB3654.namprd11.prod.outlook.com (2603:10b6:a03:b2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.43; Tue, 6 Oct 2020 08:15:20 +0000 Received: from BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::25c7:1828:b871:bb8]) by BYAPR11MB3143.namprd11.prod.outlook.com ([fe80::25c7:1828:b871:bb8%6]) with mapi id 15.20.3433.043; Tue, 6 Oct 2020 08:15:20 +0000 From: "Van Haaren, Harry" To: "McDaniel, Timothy" , Hemant Agrawal , Nipun Gupta , =?iso-8859-1?Q?Mattias_R=F6nnblom?= , "Jerin Jacob" , Pavan Nikhilesh , "Ma, Liang J" , "Mccarthy, Peter" , "Rao, Nikhil" , "Ray Kinsella" , Neil Horman CC: "dev@dpdk.org" , "Carrillo, Erik G" , "Eads, Gage" Thread-Topic: [PATCH v2 1/2] eventdev: eventdev: express DLB/DLB2 PMD constraints Thread-Index: AQHWm4HsgiB3vs5vk02tI6W7dSpU+KmKOIsQ Date: Tue, 6 Oct 2020 08:15:19 +0000 Message-ID: References: <1601929674-27662-1-git-send-email-timothy.mcdaniel@intel.com> <1601929674-27662-2-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1601929674-27662-2-git-send-email-timothy.mcdaniel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [86.40.59.136] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4aa27930-abe8-49e7-5cd5-08d869cff76a x-ms-traffictypediagnostic: BYAPR11MB3654: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:669; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: a1SG1lWmaaZ1Y0kcqg44UNexycL7xvRp3/jFkV/lSHbIk7vWl/0DslhnAXVlGIt4te+phRYwNE1lxfUeOFVnb69NGuSbxx1AD0yFBw1AdWGF83memfGwi2jFC54PA1Jf+rNZJs2MAAi1DhgEIz7bxXRWAzWF2dxgqXmRsruWijEbb+xHdXbBHeWN5o4Yp8e2J80DsgqmMIjtI6svhdoPmoejv9znUleNTq6EZR70RfUcXbvsNIASdIYOGgyQWQHzeeOrJq4FMiaXb9w7XhJNxISD3sYE+TJ8uLWOV2obioF2vmQoSTQHsJGQCVLjo1Pdv/Na2JcY6o5IoMXyt/MjXqBONwFppJDBoxnYzhRVKVP0MN4cUH4G87T7DGP7BuZz x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3143.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(346002)(136003)(366004)(39860400002)(64756008)(66556008)(66446008)(66476007)(76116006)(83380400001)(66946007)(55016002)(2906002)(478600001)(66574015)(8936002)(107886003)(9686003)(54906003)(53546011)(8676002)(71200400001)(33656002)(86362001)(6506007)(5660300002)(186003)(316002)(52536014)(26005)(110136005)(7696005)(4326008)(921003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: ZvUleQ49abLGtZ6kIF2xs3anqgFr2X1YNm06TcG2l+zteej0aag3sD4hTBl+fY8MiWOQnPtglh4l/10HMexWxduHmzv27ipStpoJ2kOWm36kAScAvvyQxrwdTxikucFMkpA9A4MilV8aiJQDuDFrEG+STfkgk2nMbD8cT+JuPEAK2V2GTDaLatC7qigo04Kz94X1wgNEEjH+g8lZ9n25nl6CD/8AEHk+63NYG8+QK2f7di7VV2rH4s7rgyechi0mIZt6COKZ9gF42ck9ekjn1jTfnfBwMQIkLpOMB4+1FBmFn+3nTh9QowHhbvtkkExg0SCFcnuY8uionoDsq6bSqYrrfuZZE4oBQWrqaJphZOAx7ouuWflnYUTbkjKUm/iRwm+yc3DuVIIC5f8xIoUGIDZSoXrUzKptSvVQ0CBz3h5QddLSxYfLthk5K1CE53MK2sboCnN+ZqNCafAsRhCAvDbbMMkciZTM1PdoPrTY3m0nHYQKNTrqs8MzmNbu10Y09DtdDcMGEzMh1sHsa8Q8FRi3AiZ65qN+uSYBbvaOb++xSE5fcvlDsgp76p/kuDm7QYma4LAQXZtS147zzQJ5X+3EcpIBNtghIURtd8/cEpiWu47s/59TU6E8Z8e5vY/qFYnl7RSWtFNX33scAmyKoA== Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3143.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4aa27930-abe8-49e7-5cd5-08d869cff76a X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2020 08:15:20.0146 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0seZ7ZJLuzK0nIOtJ738v7Ih4oGt8A8VyddHKQQzu/1JNMV8KUZbPq9HsMcpKspxfKbMdodEvn9xz/BEd5eUWe4ilaEcFG+AIV5JDfaxlJE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3654 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/2] eventdev: eventdev: express DLB/DLB2 PMD constraints X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: McDaniel, Timothy > Sent: Monday, October 5, 2020 9:28 PM > To: Hemant Agrawal ; Nipun Gupta > ; Mattias R=F6nnblom = ; > Jerin Jacob ; Pavan Nikhilesh ; > Ma, Liang J ; Mccarthy, Peter ; > Van Haaren, Harry ; Rao, Nikhil > ; Ray Kinsella ; Neil Horman > > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gag= e > > Subject: [PATCH v2 1/2] eventdev: eventdev: express DLB/DLB2 PMD constrai= nts >=20 > This commit implements the eventdev ABI changes required by > the DLB PMD. >=20 > Signed-off-by: Timothy McDaniel > --- I think patches 1/2 and 2/2 will have to be merged into a single patch. Reason is that compilation fails after 1/2 because apps/examples access the "disable_implicit_release" field, which is refactored in 1/2. For review, this split is quite convenient for reviewing - so suggesting we= can merge on apply if no changes are required? > drivers/event/sw/sw_evdev.c | 8 ++-- > drivers/event/sw/sw_evdev_selftest.c | 6 +-- For SW PMD component and selftests; Acked-by: Harry van Haaren > static void > diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c > index 98dae71..058f568 100644 > --- a/drivers/event/sw/sw_evdev.c > +++ b/drivers/event/sw/sw_evdev.c > @@ -175,7 +175,8 @@ sw_port_setup(struct rte_eventdev *dev, uint8_t port_= id, > } >=20 > p->inflight_max =3D conf->new_event_threshold; > - p->implicit_release =3D !conf->disable_implicit_release; > + p->implicit_release =3D !(conf->event_port_cfg & > + RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL); >=20 > /* check if ring exists, same as rx_worker above */ > snprintf(buf, sizeof(buf), "sw%d_p%u, %s", dev->data->dev_id, > @@ -508,7 +509,7 @@ sw_port_def_conf(struct rte_eventdev *dev, uint8_t > port_id, > port_conf->new_event_threshold =3D 1024; > port_conf->dequeue_depth =3D 16; > port_conf->enqueue_depth =3D 16; > - port_conf->disable_implicit_release =3D 0; > + port_conf->event_port_cfg =3D 0; > } >=20 > static int > @@ -615,7 +616,8 @@ sw_info_get(struct rte_eventdev *dev, struct > rte_event_dev_info *info) >=20 > RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE| > RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK | > RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT | > - RTE_EVENT_DEV_CAP_NONSEQ_MODE), > + RTE_EVENT_DEV_CAP_NONSEQ_MODE | > + RTE_EVENT_DEV_CAP_CARRY_FLOW_ID), > }; >=20 > *info =3D evdev_sw_info; > diff --git a/drivers/event/sw/sw_evdev_selftest.c > b/drivers/event/sw/sw_evdev_selftest.c > index 38c21fa..4a7d823 100644 > --- a/drivers/event/sw/sw_evdev_selftest.c > +++ b/drivers/event/sw/sw_evdev_selftest.c > @@ -172,7 +172,6 @@ create_ports(struct test *t, int num_ports) > .new_event_threshold =3D 1024, > .dequeue_depth =3D 32, > .enqueue_depth =3D 64, > - .disable_implicit_release =3D 0, > }; > if (num_ports > MAX_PORTS) > return -1; > @@ -1227,7 +1226,6 @@ port_reconfig_credits(struct test *t) > .new_event_threshold =3D 128, > .dequeue_depth =3D 32, > .enqueue_depth =3D 64, > - .disable_implicit_release =3D 0, > }; > if (rte_event_port_setup(evdev, 0, &port_conf) < 0) { > printf("%d Error setting up port\n", __LINE__); > @@ -1317,7 +1315,6 @@ port_single_lb_reconfig(struct test *t) > .new_event_threshold =3D 128, > .dequeue_depth =3D 32, > .enqueue_depth =3D 64, > - .disable_implicit_release =3D 0, > }; > if (rte_event_port_setup(evdev, 0, &port_conf) < 0) { > printf("%d Error setting up port\n", __LINE__); > @@ -3079,7 +3076,8 @@ worker_loopback(struct test *t, uint8_t > disable_implicit_release) > * only be initialized once - and this needs to be set for multiple run= s > */ > conf.new_event_threshold =3D 512; > - conf.disable_implicit_release =3D disable_implicit_release; > + conf.event_port_cfg =3D disable_implicit_release ? > + RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL : 0; >=20 > if (rte_event_port_setup(evdev, 0, &conf) < 0) { > printf("Error setting up RX port\n");