RE: [PATCH v6] app/procinfo: display eventdev xstats for PMD data

["Sevincer, Abdullah" <abdullah.sevincer@intel.com>]

1) What is the difference between "--edev-stats-enable" and  "--edev-device-stats" ?
	--edev-stats-enable enables xstats for evendev and exits from proc-info application (when this flag is enabled) after displaying xstats.  It is like show mempool flag so we don't want bunch of different information is dumped to the console. The intent of the flag is distinguish dump information between eventdev and eth dev. If this flag is not passed no eventdev info will be displayed.
	--edev-device-stats is a flag that dumps device stats like the other flags/commands introduced with this change.

2)Too all other comments following to simplify the code:
	Indeed all other commands in proc-info can be simplified but with below style we wanted easiness for user to remember commands and pass chain of commands. It is a trade of for user need to remember the format instead passing a name. I agree there is too much command in proc-info now. I will try to simplify command and code also considering something easy to remember from the users perspective.

Thanks.

-----Original Message-----
From: Pattan, Reshma <reshma.pattan@intel.com> 
Sent: Friday, March 3, 2023 2:58 AM
To: Sevincer, Abdullah <abdullah.sevincer@intel.com>; dev@dpdk.org
Cc: jerinj@marvell.com; stephen@networkplumber.org; Sevincer, Abdullah <abdullah.sevincer@intel.com>
Subject: RE: [PATCH v6] app/procinfo: display eventdev xstats for PMD data



> -----Original Message-----
> From: Abdullah Sevincer <abdullah.sevincer@intel.com>


> Subject: [PATCH v6] app/procinfo: display eventdev xstats for PMD data
> 

I see you are supporting evendev stats print. 
You can make the heading clear by removing "PMD data"


> +++ b/doc/guides/tools/proc_info.rst
> @@ -22,7 +22,9 @@ The application has a number of command line options:
>     --show-ring[=name] | --show-mempool[=name] | --iter-mempool=name |
>     --show-port-private | --version | --firmware-version | --show-rss-reta |
>     --show-module-eeprom | --show-rx-descriptor queue_id:offset:num |
> -   --show-tx-descriptor queue_id:offset:num ]
> +   --show-tx-descriptor queue_id:offset:num | --edev-stats-enable |
> +   --all-edev-queues | --edev-queue=queue_num | --all-edev-ports |
> +   --edev-port=port_num | --edev-dump | --edev-reset | 
> + --edev-device-stats]
> 

On the design , I guess command line parameters can be simplified. So you can simplify the code also.

1) What is the difference between "--edev-stats-enable" and  "--edev-device-stats" ? 

2) You no need to have 2 parameters to specify the port  info "--edev-port=port_num" and "--all-edev-ports"

3)Similarly no need to have 2 parameters to specify queue info "--all-edev-queues and --edev-queue=queue_num"

4)  No need of  "--edev-stats-enable".

5)You can perhaps have only 2 commands as below in place of all above commands.
In the below commands user can pass which "eventdev id" and "queue id" the stats should be displayed for.


Example:
a)show-eventdev-stats=(eventdev id, queue) 
	
	show-eventdev-stats=(*,*)   => Display all stats for all queues of all eventdev ids
	show-eventdev-stats=(*,1)   => Display stats of queue 1of  all eventdev ids 
	show-eventdev-stats=(1,*)   => Display stats of all queues of eventdev id 1 
	show-eventdev-stats=(1,1)   => Display stats of queue1 of eventdev id 1 

b)reset-eventdev-stats=( eventdev id,  queue)



Thanks,
Reshma