From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4900141DC9; Fri, 3 Mar 2023 17:22:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C6F940EE3; Fri, 3 Mar 2023 17:22:39 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 8E92A40ED9 for ; Fri, 3 Mar 2023 17:22:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677860557; x=1709396557; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=AR9i5Dzc7VsCBFhJ/YQWp2xDkGexsbQgkbvCC8Aalw8=; b=A05O5xJUnPw+C9BXzraxNc6zCWUBxLbluz494Z4GO/RyUNCsZqwVCe+f eqZA6MFH45kQseUlHnardSQlq72BSasjI+kPPoLirNpVKCsgAAOry4vfA QdshnwbPKgWDDeKLGLw7GUsKGe5nAVFjR7WI8HWT6Ans4cM57Zu0zTiEd XPFCrhwbaFQzSgED9vcO+HkrsfoyHkbg2TY9A/rPY+LY/QZVWBfvycA/0 fbM9JcHIsznfOfwdspg8uoqGnp0ORdEuzyAhWpnk4XgAEog+gqc3qqs8V b/x3l6XNIviHQVGCzXhm+cTHHjcldns++jsyklETHRbCiFNDlHnMEpg/A A==; X-IronPort-AV: E=McAfee;i="6500,9779,10638"; a="399892754" X-IronPort-AV: E=Sophos;i="5.98,231,1673942400"; d="scan'208";a="399892754" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2023 08:22:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10638"; a="707885518" X-IronPort-AV: E=Sophos;i="5.98,231,1673942400"; d="scan'208";a="707885518" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga001.jf.intel.com with ESMTP; 03 Mar 2023 08:22:36 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 3 Mar 2023 08:22:36 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 3 Mar 2023 08:22:35 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Fri, 3 Mar 2023 08:22:35 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Fri, 3 Mar 2023 08:22:35 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JDAxrdKHcO9t28TPsP9kEUffFrj6HdNddUzBDQN6hUlf+PT0OqB/CDgTuHVbGqTBzyG4yqYkcihGO+Ol5wJnaLhMv2DIURzl8rKi19j41cMpOmjJ3PateBHRYtgQkONpmnniesaHhAu1hdYIRosroRMDuYAaVa1h7/drS7w6MK2Tfosvg60ivhMv1eDYGi21pbmwXZKDtxViUOFhhKiRSN2ZRXrzoj3w0fn8Odz8VO/GJfjuEE2vono7MXNhWuuQPoQ7+G28cX+8YMAhOMrUtFUneSZqnzURBVhcKOP1V93ac4SKhwz/qdd7eH0C+Ixn8BmpPlIbr3EDcvdyJiOo0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x90CwZU4r828xpIHbElwOYVCU9Kh4vE4imZiRQAoNOg=; b=hlRqyjO8ZbtDnxsyo10Js+2XDWwDtrvBPbSj+OClXdzz4oE0c84qtfZFvvzkeTRXaVcpgFtR8wNHyOha/Mk8+IAzIh/PR0WIhJ21VWZsuCeWcUrqUg00inJiz6fa5fELhNUiE55+o6TlNw2EEbRkldu1Tb1v6tX91TkILFIzZkqDvTg8gJH4/YaWfbibBnAgq7PfejqueYYaBASGr9Zf5oV1/yp0yIRnwNY7SjJrcNfDi7uqhdvwGuUMQNDwKJuAjrK9Bq6BQ1GKzlepmkO3laJyRk6X1F4QmRwiYNvaEkY50cEmNTOA5D+qBNWuqDSc6Kb9FIuH+9M8QRRG2mcwvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3158.namprd11.prod.outlook.com (2603:10b6:a03:1c::29) by CY8PR11MB7338.namprd11.prod.outlook.com (2603:10b6:930:9e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.19; Fri, 3 Mar 2023 16:22:34 +0000 Received: from BYAPR11MB3158.namprd11.prod.outlook.com ([fe80::2f9c:a84e:88c9:e857]) by BYAPR11MB3158.namprd11.prod.outlook.com ([fe80::2f9c:a84e:88c9:e857%4]) with mapi id 15.20.6156.022; Fri, 3 Mar 2023 16:22:34 +0000 From: "Sevincer, Abdullah" To: "Pattan, Reshma" , "dev@dpdk.org" CC: "jerinj@marvell.com" , "stephen@networkplumber.org" Subject: RE: [PATCH v6] app/procinfo: display eventdev xstats for PMD data Thread-Topic: [PATCH v6] app/procinfo: display eventdev xstats for PMD data Thread-Index: AQHZRyNXBid0f5OiIk24j2Qpe0vbb67o798AgABUBhA= Date: Fri, 3 Mar 2023 16:22:33 +0000 Message-ID: References: <20220409153056.1010236-1-timothy.mcdaniel@intel.com> <20230223010819.4164765-1-abdullah.sevincer@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB3158:EE_|CY8PR11MB7338:EE_ x-ms-office365-filtering-correlation-id: 6df68a41-2061-4403-a9c7-08db1c037eb2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: digmy2HErGGV/WJvBmLdOiiBVcBlha64ObOIgWGo4UMLG0d9aksYTtQAAKYOlf5q2U8AGGNoUegzCRCR1ewnE8fhi/MAS5xvrmi8ITqWFGNxWk0A2J+8ZVO/+pSeUmHzaytjhHL+VaAj0CLWjb1+eI1uMU1K2unUNBlRbjczaRyjsM3MkJwRBrQu66kropWmOlk6LElD0OUERjdmulnkDvZpgSyjMkHDuCb0KKMBpZlf1FLDouKyHnPlqsCZRxY5U0okVsihLorJH2bLNbIOCpS7kVa7ctHcPV2p910LQ+IDR0+ho3D3x2swvTYNmVqfNhHN8uNZBL28iiLIA95gxJPuIdAdC+bWyqHm+JQbK3USVEcB7avHJcUg4ofiK4Bg8vGPXTmzCeZLDns/wnVNGmkMW2V7g2y8SPIB9Vpt4oPAOO6VHdyLDO3QfAcIH8rLrDhf1AmDTdtgmD43bAaggKoVxKhTZfqE3YjBgffhDlx0vS48YWRZekW72sxGHA7BD4G3jsS3hB0kopekm/KIhHAyIJAx4xEypBCbOEFkj5it9EHbRhSTpHWY20ET8qXOefp7yep6WTVATFlpS3MgYPL2tNbHvia7eJcGBJ0R9F/xLCGM6eUuojei0MmCCq+At+dqHCGfUaMb9JKeEFJfCSXbQiUVS+sbIxdZTqQPL3XIXk5/AAA223uiFatyjitMB3/KhapvcxPNEjq9JFSZTIDjaLUDONYiQFYatPp2hdM= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3158.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(346002)(136003)(39860400002)(366004)(396003)(451199018)(82960400001)(41300700001)(71200400001)(86362001)(6506007)(186003)(9686003)(26005)(478600001)(7696005)(38070700005)(53546011)(54906003)(316002)(110136005)(33656002)(38100700002)(2906002)(55016003)(8936002)(122000001)(66556008)(66946007)(66476007)(66446008)(83380400001)(8676002)(64756008)(52536014)(4326008)(5660300002)(76116006)(181643002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?KXalMkz6EDNd8a4iJ18J/te2zqccaTgH0hKwat8GnXLG6Y66R9k1Bq8ynXA0?= =?us-ascii?Q?SBU7AL5f9s70L1c/p1Je8YjK3IGy+lHtUteIjvGBM8sEEtEHyHqKz7gWmeLQ?= =?us-ascii?Q?f25WZFtlqC7PxgPvWaTYwh251HUzJXxpZwBvFufvA3QvPhdi7+TVxNfGeSIQ?= =?us-ascii?Q?Va7wZVriO+onOYdiQDdHI6bt4A9t6OaFWko2tnoVp4zRpLwnNizKiyktGyIv?= =?us-ascii?Q?hrlwnuvfREUjLLziZX+esP4DNIUNFixryhB++cBJ47JanfB2uWlU+f6OGzGv?= =?us-ascii?Q?NkYjtEV1kOtdKBMNWHm8/bLMvFJ1pS3q7pAtEhTHW9ju5KUXe3n2qpm2jhOm?= =?us-ascii?Q?Gcaudb+Ywl+D8FVBu4PIJvePVgtsl8DjLfSHHkZZmtAQ5ADF1NKvD/PkspjI?= =?us-ascii?Q?2RnIq0910zpRjjFaEY7T5FjSobAXijjvKBXRXirAnard7CjWJ812uDLi6W3Z?= =?us-ascii?Q?Y0EzL1WtOul5h5qD0XJEnSEkzzMTY6zl16OmOmJYK4+YJJmeNzKrHwnZ98YT?= =?us-ascii?Q?Fe+40hqrJQtlJ6rahThz/t3a/70KVfCk+CmS+PhZ3t1xa5DkyMpSFTyrQOUW?= =?us-ascii?Q?DNETrEwyUYz+4Xk9Bjn/G8eEi7nXDQY/xBJCc8lf0bPu75RxeNX1cYa8nKBx?= =?us-ascii?Q?hm06qmajP0dHicYp3bRE+tz1KGV4vVwAp5YOIvQLfLIug7gZpXaUo8A97XPl?= =?us-ascii?Q?ZSGnIs5lmQ91oBByNza7kWF8Lq25Yat6y3w23cCdMK/uc9pJp680C8VXaTJS?= =?us-ascii?Q?xLbt/XkdV38IfAp+0IAaFsGw7G6f87j7KCFWavFmzRfbFyNabBctsi1iNBy7?= =?us-ascii?Q?tCpYkfElxXfK+HZO3FfQONeXuqkRuvNK+Zx2yGKqe7w430fZFAvVUic7lb+s?= =?us-ascii?Q?x8DoudoPSkWdvAIKijBI3SLSIjpTAow2w7kvdNHepfjxnGpGIaXTL6yr36L+?= =?us-ascii?Q?1Ywj75nvErods5SwTPRaaZxOs1X+ecv9n21mrrWJ+Ydwtrx5ywvJNLyyyLSp?= =?us-ascii?Q?B74fKWjl5svf1fbAi/3HnTv/PTHmZOsdXFVbC7RWUtIEgJYcHvUxRhlCyXQ3?= =?us-ascii?Q?P19dBSv1fKegjoJeYRk9Djl1NkVKSjmV8UkKC8ddEGKEoSQZ0YOYMTVggCjT?= =?us-ascii?Q?VZ5EUknHB8MlzCbYG0hhnBRlfbugUxixY3w/y9fooK2h8497osiMSs7hYlDg?= =?us-ascii?Q?Oo+teL+uFgo/cCSLLtVLCvnhqBZxKa5pisBK+atg9tlbTK2AoPfNrW2uo+Kk?= =?us-ascii?Q?YSq9YZfhrySbfC8oiXmprZO+Qa1epybTBOk2Xf93+/lFS9UZoNEssjdYBt4+?= =?us-ascii?Q?3ZqSpffXOeqTc/WRDXZSRzJ84OuuVKXp8DfKvPt8HIgMczyiENyh6qIGra0w?= =?us-ascii?Q?3BcNyB0qG6Zq0KrL1mo88SzVDu9F5hd3X8oa+wPERYogjHA6c6Wtik7/nAKG?= =?us-ascii?Q?Dph6x5opK1drhiWtjcKLl+EsS6WiFoVmXzoMABUbtnXo+hDLDcBiv4SD12wu?= =?us-ascii?Q?XJtnk/4rfKmVi6ttrLwADOl9ZOnMoPd1q/Lac1b3UjJ1Luc00jrODUVj5RTU?= =?us-ascii?Q?vb7bbyERVuejShgLHQPxgO8l6bkMxyn4UTRLuvRgs1tn1YCq+zZYwCqOKeSd?= =?us-ascii?Q?qw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6df68a41-2061-4403-a9c7-08db1c037eb2 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2023 16:22:33.9018 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9GoqjDwiSdP3I7d+xlGS8FcBUVp7kFT8MBR8spi2tUyIcSZ1SEa5QrWOZIFFNtflaGbysYkRHhmFWFloy2pyqUhWDDYWJzEVsBmyRPxABYE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7338 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 1) What is the difference between "--edev-stats-enable" and "--edev-device= -stats" ? --edev-stats-enable enables xstats for evendev and exits from proc-info ap= plication (when this flag is enabled) after displaying xstats. It is like = show mempool flag so we don't want bunch of different information is dumped= to the console. The intent of the flag is distinguish dump information bet= ween eventdev and eth dev. If this flag is not passed no eventdev info will= be displayed. --edev-device-stats is a flag that dumps device stats like the other flags= /commands introduced with this change. 2)Too all other comments following to simplify the code: Indeed all other commands in proc-info can be simplified but with below st= yle we wanted easiness for user to remember commands and pass chain of comm= ands. It is a trade of for user need to remember the format instead passing= a name. I agree there is too much command in proc-info now. I will try to = simplify command and code also considering something easy to remember from = the users perspective. Thanks. -----Original Message----- From: Pattan, Reshma =20 Sent: Friday, March 3, 2023 2:58 AM To: Sevincer, Abdullah ; dev@dpdk.org Cc: jerinj@marvell.com; stephen@networkplumber.org; Sevincer, Abdullah Subject: RE: [PATCH v6] app/procinfo: display eventdev xstats for PMD data > -----Original Message----- > From: Abdullah Sevincer > Subject: [PATCH v6] app/procinfo: display eventdev xstats for PMD data >=20 I see you are supporting evendev stats print.=20 You can make the heading clear by removing "PMD data" > +++ b/doc/guides/tools/proc_info.rst > @@ -22,7 +22,9 @@ The application has a number of command line options: > --show-ring[=3Dname] | --show-mempool[=3Dname] | --iter-mempool=3Dnam= e | > --show-port-private | --version | --firmware-version | --show-rss-ret= a | > --show-module-eeprom | --show-rx-descriptor queue_id:offset:num | > - --show-tx-descriptor queue_id:offset:num ] > + --show-tx-descriptor queue_id:offset:num | --edev-stats-enable | > + --all-edev-queues | --edev-queue=3Dqueue_num | --all-edev-ports | > + --edev-port=3Dport_num | --edev-dump | --edev-reset |=20 > + --edev-device-stats] >=20 On the design , I guess command line parameters can be simplified. So you c= an simplify the code also. 1) What is the difference between "--edev-stats-enable" and "--edev-device= -stats" ?=20 2) You no need to have 2 parameters to specify the port info "--edev-port= =3Dport_num" and "--all-edev-ports" 3)Similarly no need to have 2 parameters to specify queue info "--all-edev-= queues and --edev-queue=3Dqueue_num" 4) No need of "--edev-stats-enable". 5)You can perhaps have only 2 commands as below in place of all above comma= nds. In the below commands user can pass which "eventdev id" and "queue id" the = stats should be displayed for. Example: a)show-eventdev-stats=3D(eventdev id, queue)=20 =09 show-eventdev-stats=3D(*,*) =3D> Display all stats for all queues of all= eventdev ids show-eventdev-stats=3D(*,1) =3D> Display stats of queue 1of all eventde= v ids=20 show-eventdev-stats=3D(1,*) =3D> Display stats of all queues of eventdev= id 1=20 show-eventdev-stats=3D(1,1) =3D> Display stats of queue1 of eventdev id = 1=20 b)reset-eventdev-stats=3D( eventdev id, queue) Thanks, Reshma