From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B620142E21; Sat, 8 Jul 2023 17:11:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 405AF40A8A; Sat, 8 Jul 2023 17:11:51 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 9FE9040156 for ; Sat, 8 Jul 2023 17:11:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688829109; x=1720365109; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=9uSAprdRFAn6MJquQaajFZsjw2wYIk4/TrYERI/7USQ=; b=EwtySfESPpD/jBNkzPP3z6RiH7ZEW4kjx0veu7d3r5OIPNhfz39E19++ dXqL4QrbL5MTADvtLKzz+BUqyQzu4bu7of9t3ySgRch/xKlD8FflZC2Dn bI6TwZRjpFnbO/lo05YTBETztoo9Pjt1YRnVD1rj42x+L8iTY4orLeJ+b XR3C9QTJRZtK/pdwWRBgJYK1xpxoSRv7hnZG1XR2cLbC51SA6EclaMdyx 451jst6j7I9XpjXxGy2Y22qJQYgqSR2gwgRw0tkt/qvg138nZ5budO83H ylwDlWX4bzkoVqeAPePwKUGTlgUxsWr4bT/90RNCH823i2tFlX2qZbwuu A==; X-IronPort-AV: E=McAfee;i="6600,9927,10765"; a="427755835" X-IronPort-AV: E=Sophos;i="6.01,191,1684825200"; d="scan'208";a="427755835" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2023 08:11:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10765"; a="720220837" X-IronPort-AV: E=Sophos;i="6.01,191,1684825200"; d="scan'208";a="720220837" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP; 08 Jul 2023 08:11:48 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Sat, 8 Jul 2023 08:11:47 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Sat, 8 Jul 2023 08:11:47 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Sat, 8 Jul 2023 08:11:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W81nLsnzTGyBkktIDvUxbMYJxIFYvoLffspM7aiI9ET3Bn8e6jQq0W9gwhxdHuq4PapBhSRetVoDy1OBTZaslA4S2mmNbPPwbA2Y4UTIe857yV+jffTXzVgDXI03v05pB4zL5KdUbliaZlY3tSi7WyiNhPjY99l4Ft8lgq9Y7fjd8/03Ol5NPs7fphpv+3t9zd12/v5N1bH1FIJdCRdTQyRxtGaeFVKwPSMgpojrs6QL1iEUTWVYJu9do7FhgyYz7LrISh1jRT3RkYY2zSPEwUlDuIoZtvIJH9q8cIYfhevvMyiwoKa3sthy8VxISZHmYeKUnE4U0BuvRGRcjeb8Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xhx/+5J/ejm0Jxfcrh0F754HQr8SRGaye4+MN8tamE0=; b=KaHj3SjdQALjsgS+T/UFIBZq8m+2HubYrI/r0UJzK+FwUGQSaDTZEXON6ITtnXEj1x0EiLsdxU0kHtyhL5XgFwde04NsnWbsUCUBmR6NcmaqJYy6SE7Z1BQraVk/ajOzvMYnr+lxpbKvkJLwstlQKOBDdGbJnNyReHXt8dxUvSh8kTX/+cuMzs/Tz+1ehsLyWMPoyHqRrD7Fus4g0XfqBOdJRgbbkIWq51CnwXW2+kMvW3JPSmxNmdcTXjMS/CwgUlc2wAg9l9jp/I45h1nfOmRWZSzgJs/ARPJ7kGjTrwNlgTLPvJMgdX99BmlMKrQ068+u+fbHLrsDgD45HbcgmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3158.namprd11.prod.outlook.com (2603:10b6:a03:1c::29) by IA1PR11MB8197.namprd11.prod.outlook.com (2603:10b6:208:446::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.26; Sat, 8 Jul 2023 15:11:46 +0000 Received: from BYAPR11MB3158.namprd11.prod.outlook.com ([fe80::69f1:db6b:11c0:b034]) by BYAPR11MB3158.namprd11.prod.outlook.com ([fe80::69f1:db6b:11c0:b034%5]) with mapi id 15.20.6565.026; Sat, 8 Jul 2023 15:11:45 +0000 From: "Sevincer, Abdullah" To: Stephen Hemminger , Thomas Monjalon CC: "dev@dpdk.org" , "jerinj@marvell.com" , "Pattan, Reshma" Subject: RE: [PATCH v17] app/procinfo: display eventdev xstats Thread-Topic: [PATCH v17] app/procinfo: display eventdev xstats Thread-Index: AQHZjzljTWIdHu08fUytKFwUJY3Dc69raoqAgELeIACAAF8XgIABlPVA Date: Sat, 8 Jul 2023 15:11:45 +0000 Message-ID: References: <20230525164127.3046135-1-abdullah.sevincer@intel.com> <20230525184731.3056328-1-abdullah.sevincer@intel.com> <20230525130713.3ecf0ded@hermes.local> <3736714.CbtlEUcBR6@thomas> <20230707075543.46a36fc4@hermes.local> In-Reply-To: <20230707075543.46a36fc4@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB3158:EE_|IA1PR11MB8197:EE_ x-ms-office365-filtering-correlation-id: f6a6660a-af56-44bc-4a44-08db7fc5a4be x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: saIkO4h/z+gaKdIG0hZ1a2ZZgM1oMkeXIPQzMp5trs9GLsm9wDqqB6pFBFU5jWBZfohjHTHObkUFPfwztvowOrT+dPOmHRGbQ2Y6HicSiskJ3Qwc45Te3Kcsr+MvvZFPM5V7Kex/wvc4fa2mbr5rgwPahBJRErSgY454FdeqEMyfQscURcvfG4GUSfjkISdtDQFVrHLOVC3+HUuQQdlFkSLl2RmglniPIsXThIjftr8Fxfno0sZqFMo8ngE6b/GoEcC7JVJlJR0gCGuS3k1OfvfpA2/UIo5VMVpH0O2eDHjpQMEXQ7LfFvb1kZNA6zE878a1VkiLc0xhK2FJXvO7TjUuri928HDDOxdEqHT5+knT2mea8X+L7WAUL3O7Sbcbcea6rLosQkE1FaZEVos7otG8N8NLeR+eyCidiWL0rvzDWx9YH1QCHrHza+GfCn+sL5b6L+GNlt9HCtHJ6T5Aal9hfQvhxh9TklpbUnmKWojmjiGa3gSNx2vw8k6pnIl1a0ELx2svmjk8deQupRbkPdvmsiuU4gtDfyF6lPw3riqNyT2UPkQi9j3Z8JlTX6Kx+cNLAngthNy3QzZ4V+Skgr0lWoY1gsOI7Dkva2mk19v6rUKJo/6of0n4H2y/F+lG x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3158.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(346002)(39860400002)(376002)(396003)(366004)(136003)(451199021)(4326008)(64756008)(66946007)(66556008)(66476007)(66446008)(76116006)(38100700002)(122000001)(107886003)(86362001)(186003)(38070700005)(6506007)(26005)(9686003)(82960400001)(33656002)(478600001)(71200400001)(7696005)(55016003)(110136005)(54906003)(4744005)(41300700001)(5660300002)(52536014)(8676002)(8936002)(2906002)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?rHJzaDbUBsCbDu8cB9/7MRYZFVWR5t8ums9GgX1w6rmYgr15zGY8I9ZRGsIV?= =?us-ascii?Q?G9Qzurcq3Q2dRYQwQoHH7GpSduvOzQQaL3MmguPpogHBVI7LG6BNwNRVTve+?= =?us-ascii?Q?uFBIpPlmxjc4S+Vj5Vu4iAXsvFAyZMSVPBPZhXoJ0Cd+PSFV5e6T5DzFrX7J?= =?us-ascii?Q?TqqfJgHwGbUveRRcjYkzhBVcd2nfW+mG1NUKoyNun3pgYiYsOlZinNMoYQRK?= =?us-ascii?Q?0MLPYvRgNRPXjM6m1An+8/qtMCL/Femr6ggfHAmfdqnIgMcpZEPbrd3q2AD5?= =?us-ascii?Q?nQjaflSiE112AJZo33jHm2IgrApdFfCUNUaV7NvKvux4GCTX73GEhp8ya2Vv?= =?us-ascii?Q?0iJpD+XldxUOdLTWyzmZH8rcKRNo0Xx9BeOQfTM+1dtZ3WTwSaCTyzDO3pH7?= =?us-ascii?Q?yMGMPCE+hUdrF844J0aIyffKiXxqMiQdBizjegLTRLJs4ewIijKJn9CDL+SS?= =?us-ascii?Q?DaG8UcIUZmf7h39D/UUkEzGITdjs4Eh18Dkr07V2VqdQf4ruG2Bro2bmUhN+?= =?us-ascii?Q?us4LqxdnZBUhk9vemKAh06iAFH5IhgEmcmP/wj2R6lpL0bydhhMKa4kXtFin?= =?us-ascii?Q?V8rzSPDkQmwJJ9WGjbv2AK4wVdwraTWc1epUFksBkaEV/7rPPOBnasMiQQAK?= =?us-ascii?Q?BeOt+rSOSyCy9m9R1kOqtKfYgvQKhZqdNcf/5Aqjp5d5v5HWSaHCHMQk6Goz?= =?us-ascii?Q?dAAsV+YVrKKgm6dXO21f559YYsa3HeSWbM32AuCMcjHc6WA4/EinM22wd73k?= =?us-ascii?Q?YUQJbhDbLPVp8rYMDjB/HRoa6H1R9OWksCu7WH6BCQ7rZrVQdLTmj1kzalEX?= =?us-ascii?Q?9cGlXypsK7TC0JsQiLog280Vv6hYtGELl0YElFLPzhVx/B9/kHhGqJ2Uns+j?= =?us-ascii?Q?rcSDSAru+U6JCoZPIsZcPhXF4zsccYgCz/QEXUO+QC7IzvjcVxfRjhe52zpy?= =?us-ascii?Q?4PH/yMtpScU9H5vEm0KoC2nUB9gvDKcUmWmf8uc5c4CFDDv4amGkpPKv1u5h?= =?us-ascii?Q?fW4SFlZqZ5KI19of72Gx3IDEXLeFKyJ/37BArDpCP1tNAddBh+QOXZ76NMXu?= =?us-ascii?Q?gDs13HKJzd5x3lTs1CyB82oQVLq66c9x11XhWexj6MW2q3S1VFvtbI4Vi41m?= =?us-ascii?Q?g1VFUfnOjKKesUBM6hYStmQbuWgQkJArRBiVEYI0Pbtrft8plRXBtGsXPdov?= =?us-ascii?Q?lZNvl340VB9Z5rIXVQ0EFeDuI7zaTodIHazoNUVAeIAtnYvAvzv9/u42fR8p?= =?us-ascii?Q?X8Vza+zl6SaH7t6KfRmhuE1kl35krt+/DJP0sJNb8gsYz/RmKL/wa1Joxpma?= =?us-ascii?Q?2edSpHtXlWzpbRaxnh0lymRNllqtjYbwlwmZSdC6NMBkk5rJou3Q5lzrLTHH?= =?us-ascii?Q?yr/iw3zWvv32pR7KcFHgivB4PD5AtbX4VPL5YnK9cA0FFDWJaZSPwvhp9Cgo?= =?us-ascii?Q?Te9IpEZqh+0LviejO7EkaYJeDbXhICUj7nUreoL64FI9MUowUolSCg2K2imF?= =?us-ascii?Q?NSurKznhMvNZbRV8LdbGzQrRyLSsPu6lHe+HUH8lGv3eTcmrsTYpejxPDvkp?= =?us-ascii?Q?STwkbKkVS0R9bvlDsxBrjfMw5wgCPWTKI41Tm8s45yYtF7Xi+OcesJYHeISM?= =?us-ascii?Q?kA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6a6660a-af56-44bc-4a44-08db7fc5a4be X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2023 15:11:45.2112 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: viU+SegbwhyB7i0WtRy3WzdYR0ka1WKf/cYf7tpJuxo7QQ/M39EfcTEojdd3Q1vDg8e6M6bATapk1uBpBLHk3h8MlGCMXi23ztp1FQDZPhg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8197 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >+Has new coverity issue. >+The reason is the boolean is set every time because it gets every time. >+Looks like code goes over eventdev_var[] even if no eventdevs are present= . >+Should only look for the number of eventdevs Thanks Stephen, I will add a condition at the top of the function like: evdevs =3D rte_event_dev_count(); if (!evdevs) return 0; This will ensure if there is no eventdev device function returns. I will also change the for loop to iterate only with the count of evdevs li= ke: for (i =3D 0; i < evdevs; i++) {....... instead of for (i =3D 0; i < RTE_EV= ENT_MAX_DEVS; i++) {. I still need that flag to be set when a user sets a value from command line= for a queue or port. The flag is needed to display and exit from the program. =20 if (process_eventdev_xstats()) return 0;