From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C046941CC1; Fri, 17 Feb 2023 16:59:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id ADBD241141; Fri, 17 Feb 2023 16:59:06 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 6424340EE3 for ; Fri, 17 Feb 2023 16:59:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676649545; x=1708185545; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=vdGc39dfhznyAG9DrILYUwNYYOxn8b7Y2/YOPL03M5s=; b=HkpYLWPl6W74efTRrdTsVlFhA2BXnpU5KA2J3+O4P/ERNvpEZPt4/47l CaWz8TZVY3uNvokX0JLCvVkHt9qy7xvOdj/sPuz+3hMGlSwsZ5Afbbh3d BzDuIpL+0FOAfdCPVsX+M9BdRVlvmGaF7oHv08j4TyorvdT18Yx4wpV53 A8jBwQf8/kFbtyGGPBZ1DsFiwhik1gvQtFUDoVIjCHc+R3G+XD8czlQIa RA2MpcKSnjyAfaVBPR5111yCcTop4jmUANRaui/UlQXrFpa+a5hFexPRx vKEh9pXvriMuNVHz4WCFyRm5EsJ98f+dl6KYOsGH7QHKvq77IXriR3sxZ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10624"; a="332018662" X-IronPort-AV: E=Sophos;i="5.97,306,1669104000"; d="scan'208";a="332018662" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2023 07:58:55 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10624"; a="663898007" X-IronPort-AV: E=Sophos;i="5.97,306,1669104000"; d="scan'208";a="663898007" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 17 Feb 2023 07:58:55 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 17 Feb 2023 07:58:55 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 17 Feb 2023 07:58:54 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 17 Feb 2023 07:58:54 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Fri, 17 Feb 2023 07:58:54 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QY7WYxcgUwsOLjFaexAV0eGB2EtoV5k38QpRrY/PfTE66ZSG1otIj1C5jE/5JfNiFWvS6iIa9IQgWsh1U0rp82SYfH2GTmSKDvJatyv5pC2HaVQc78qB/H4B4b0mXXooH+B0cjTv+ydsQhoK5EJBQQETMc2uuFTdtoFUIKWjoxMnYjdNdK3/Ofp662MIyK6CGwpCNHgf3adMb1rUtcCnVuOxAy5MUC4dWWl8GMsNnBG72aeL/lUygKagkBsf0pCvO9HjCg2hPj9jBHpIdFTYs/PI1qId4yFy/AyQVSV9JGjsnpU0/po15lbf8rcZTbxtaF+O3t1tkNJlg76eOCqNmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lCvlVPs45M0mf7kHhKb3bGuuBK6y3ZGmsv5XSpFT6Zc=; b=GR+IElviVAben+0kizPLcsI0oMNHePQQkhJMFGoWvweTwU/Rq0BWeUBPo3Or+ORnzObJrPdh0mD56sXAuZuVwqvObLDRZyHb0kcdH/M8kc+LNcSlNHkvy1iIrCfQc4BLe+6SLOuf6zcmp827F4X5ZFDCZX5vY4OpEmdmqBQjwzT+f1bpsZbzCkXh0uO4UBleqr2VJEtUHV5+q2jSMStiHWDTPe5sBJrJDB+QxPisj2YDggEI9jutqQTj4HTMROVTpTJCjHhOrPeqp+CrQKcZQjVon5YEB+KFh7XkWXTnZFlWIh9ndL2luCRVizUWCa9uk3IIRk+jVRRLXjFwsB3B7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3158.namprd11.prod.outlook.com (2603:10b6:a03:1c::29) by SJ0PR11MB4912.namprd11.prod.outlook.com (2603:10b6:a03:2ae::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.17; Fri, 17 Feb 2023 15:58:52 +0000 Received: from BYAPR11MB3158.namprd11.prod.outlook.com ([fe80::83a5:d291:ab75:23fc]) by BYAPR11MB3158.namprd11.prod.outlook.com ([fe80::83a5:d291:ab75:23fc%5]) with mapi id 15.20.6086.026; Fri, 17 Feb 2023 15:58:52 +0000 From: "Sevincer, Abdullah" To: "Sevincer, Abdullah" , Stephen Hemminger CC: "dev@dpdk.org" , "jerinj@marvell.com" Subject: RE: [PATCH v3] app/procinfo: display eventdev xstats for PMD data Thread-Topic: [PATCH v3] app/procinfo: display eventdev xstats for PMD data Thread-Index: AQHZOn+AbSZEmyGHgk+iQG5PBgS0gq7Cn4SAgAkeQ7CAB54FkA== Date: Fri, 17 Feb 2023 15:58:52 +0000 Message-ID: References: <20220409153056.1010236-1-timothy.mcdaniel@intel.com> <20230206230505.3029148-1-abdullah.sevincer@intel.com> <20230206162227.2a8234c3@hermes.local> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB3158:EE_|SJ0PR11MB4912:EE_ x-ms-office365-filtering-correlation-id: ed8ac858-5cdd-432e-c0b3-08db10ffddc0 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7WPWWFXJHXbUR9Er/h9C5CjFHI3XmfkfNh3U32YSh6YjzkQuouNRoymvZhIpH1ghomD9VN2n5emsEluZAlIug56a8eUkzEp9TjjFYEmlCc3J0bFCnUEQCUcSO5S+2hYkOBXjAYhOrnTpoHajfnP4KGCeBLbA6WNWmBdTc+GlHIRv2Ca3H/o7+1p53rHiJo+9mrIcdnI+xHS2pRJ3z5a3maZtKRHLB0VARhCHpt4CvFPGjb7q+GLfa4OjDOPtz4uaPblhotEZbllfzIfutJtt4xkRqflLBlbhKmEtufg0xtICCdnCPvChCm+4I+DQ3S5QxeeLnyi7h+0J9+B4HI0whLAiNKKd9sdTXFAXdA6/E+auS6TJwFwk1mvxj3rhpy5NEXroW0kgcZJD85yqFMEMGQ1+XUCL+mqzNVvhdI4QrPBZHiUhrM66GyBg3AcEvzqT5W8+64kWWbZK34Cq2iTecqpggFigBjBAnLqDmFsCOjiGTkoGN4Yf9ycHuxSt0T9kOtllt1n+Nk/hyDHWKEY78uulNcudNj+UrqWpg5P9OidAWkJhSp3UoIZQy0nS+pFKdZpY/CDtBJzJ6uDddy+5Xys/Z6pW44bAzRrXnGaxq+7/WuDPFFCzNLGqj711Hww3seLqPICwOdHzMi5v8bB9adhUQ7psxN+YaFDO5J/gZBGBzE43PEanb03b5u1fqzQSLcfV+AWXPXmbxLvcq2TnEvi656nJ8SEJvq1r2Eu1Mi0= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3158.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(366004)(39860400002)(136003)(346002)(376002)(396003)(451199018)(38100700002)(122000001)(33656002)(316002)(55016003)(110136005)(71200400001)(7696005)(54906003)(38070700005)(478600001)(82960400001)(83380400001)(186003)(26005)(9686003)(6506007)(53546011)(2906002)(5660300002)(52536014)(8936002)(41300700001)(4326008)(86362001)(66556008)(66946007)(66476007)(8676002)(76116006)(66446008)(64756008)(181643002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oD1ncPRm1Ua1NDfbCPPR6t4iaLZie/f3WCxGpjeIBeuca9Vg2+RR/MREWnJm?= =?us-ascii?Q?KlI/fXWUqINx3pZq41o64LL451LqERzKV4i6x+08NeJhe4o9WjefYA3csnLa?= =?us-ascii?Q?BYcPan/uJz1S0cn6QyR72ebaYCeGPd2TQolSbQ+yBQet85hxDoczdkqitoGO?= =?us-ascii?Q?3e0dn6jGA8o4HpDejmahba6voXmeiSdOtpQRDFd9mM9r6lNNYMdW0sZZHxZj?= =?us-ascii?Q?88PXUp1P9W/Rw2Wgjez9v4fEYUFhhYtscLZAhMYdR0R8CHNULSjwqnTWV8AI?= =?us-ascii?Q?I5LevwzyH42vBMhBzKPo6JJgK6ImeWJ0s7UZa79nH8QB8SBKDxENamz6mhAq?= =?us-ascii?Q?0DfSckTor7911AuNnTD4O9yvcedrq6y891DxYqaBHV1OZKUGInH7qcO2c4+o?= =?us-ascii?Q?Nx9cpIu7MSr1VzQhHtaPzIVlxxoJMId4cvlESBVCiWE2+mtLnnZwZe4779HV?= =?us-ascii?Q?TlE/SFfUOLAd6mF/eEjOMnBj+wkkS/8fSmuMUAaj5xCcEdAdQYzxlZ/Kp4sj?= =?us-ascii?Q?dL5sZofTzNTjPoKpCxaboLYx/DQeCNBHImENjJ07pW/qkrzaD/cq9+Q1Hoen?= =?us-ascii?Q?7MdMwRwKnuUKlEhJDFnA7uxg4aKdjIs/uuBSy4GVcwojWPfpNkzGRoVcl4MV?= =?us-ascii?Q?kiaUvSv0dbhNb6xs2VnJF9kTPBpmz2qAhE315rstBGWCQ6ETAbmRo841bXVe?= =?us-ascii?Q?caZquurLnBhLCFxWMCf+Inbtf2EO/xgv5Trqx7VbonzCY9fy0lARZrhINjca?= =?us-ascii?Q?pW9RUR91BO4n6POUK6UZUZbyCM/OleG7cNPN2m6eIXc6PRS9D4GUVqDYwUwm?= =?us-ascii?Q?04awC5TwElwCB++jW4njXrejTXtNSHj45JltUTkbqeV9HSwtS2HU7m7ydATz?= =?us-ascii?Q?oBl1JQuT0wvoDQOzHo+RhUFhazf+dRCPR3ss3KRptCKEHUPNmJXQ1Rv2PCkw?= =?us-ascii?Q?9NpnfEBYA4sHl5KEakTo8AVeBcHF+9Il92t52iLVMFh6U0fQineAY2A5K/rf?= =?us-ascii?Q?v9CJyCG4QEm/alCiqgxDUO2lFvpTQ1wg1MI/cvQkRSTI3DgmIkwyxdRSJ9EB?= =?us-ascii?Q?rhH0uqNh9YRGUfboB8lh3hqHF5PiZ7YA668BjZHT7PqAachQMNl61hlV8VAV?= =?us-ascii?Q?o4aVZa+z1NwoPkEqM+HBfsJnQYIhoReLNz+QMQNm9OzBRg0wCnvBWZxbyuH6?= =?us-ascii?Q?O3Ya4KkPATbeylmlWaLDHjlGKxq2k354y161XmDK0OKf0Tf+Lh/uZqCJn7Xu?= =?us-ascii?Q?gNE7cBkqPcJhynIyArKSVJXDjfsgH8Iczp0+zm6xS4e54nUgAz+GoPZrOrH6?= =?us-ascii?Q?JA9OH1gJa3s6xo/MeTiGijRavbD5d/mrTwCPgD27nzexEml1l/jJ/CPT3WyH?= =?us-ascii?Q?JTGojXUuguoVxcbWn4ro5jd9QkRiYA0/pSvlr+w1yH+seVmNDfVoprGZ61QT?= =?us-ascii?Q?mAlC349mWil//qq6npQRsMUGgZOs3EnHpP3quUJvOAoQbkJqea10Zi5Mr1Pe?= =?us-ascii?Q?JqZuDWHfrMRcU4yLmjLkwG+OW6dF1143H/WIBqfEnWCMKF7ulp0nhsr/ePGo?= =?us-ascii?Q?G9dOpCwtDZSLtyzHIGVwc0Keql9vSrQwVNab/5WEBhK6J88bPOGxcKGca7pR?= =?us-ascii?Q?Uw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3158.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed8ac858-5cdd-432e-c0b3-08db10ffddc0 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2023 15:58:52.5690 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: go8ZUU2ShavDXycUpU8/QxHH38KTTc7wtR6scz+Tu+VJpdw4FcnGhA4bkgDGNRkaMyZZWc/mBvbqlpz25A/BCfcVheEeWJTbe0fwgji1tS0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4912 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi folks, Any chance to look at this commit? Any other feedback before I push V6? (wi= ll remove extra line there below in the commit) -----Original Message----- From: Sevincer, Abdullah =20 Sent: Sunday, February 12, 2023 11:44 AM To: Stephen Hemminger Cc: dev@dpdk.org; jerinj@marvell.com Subject: RE: [PATCH v3] app/procinfo: display eventdev xstats for PMD data Thanks Stephen, I will remove extra line there. Instead malloc using of calloc is required or just suggestion?=20 I can see allocation is done in same way with malloc in lib\eventdev\rte_ev= entdev.c (reference to eventdev_build_telemetry_data function). I will keep malloc as it is if there is no opposition. Thanks, Abdullah. -----Original Message----- From: Stephen Hemminger =20 Sent: Monday, February 6, 2023 4:22 PM To: Sevincer, Abdullah Cc: dev@dpdk.org; jerinj@marvell.com Subject: Re: [PATCH v3] app/procinfo: display eventdev xstats for PMD data On Mon, 6 Feb 2023 17:05:05 -0600 Abdullah Sevincer wrote: > + > + size =3D (unsigned int)ret; /* number of names */ > + > + /* Get memory to hold stat names, IDs, and values */ > + > + xstats_names =3D malloc(sizeof(struct rte_event_dev_xstats_name) * size= ); > + ids =3D malloc(sizeof(unsigned int) * size); > + > + > + if (!xstats_names || !ids) > + rte_panic("unable to alloc memory for stats retrieval\n"); You might want to use calloc() here. Seems like lots of extra blank lines.