From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BB555A04D7; Thu, 3 Sep 2020 11:09:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 157751C0AF; Thu, 3 Sep 2020 11:09:47 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 6D0A01C0AE for ; Thu, 3 Sep 2020 11:09:45 +0200 (CEST) IronPort-SDR: Tz1Y4lmn+THclN5K5PgX+S8ctRcRo16XaHvQ+lRxAGOVI6XeRelFWf3XEBNLpiveYYQ8Op6fsH NnbuVkjtm1yA== X-IronPort-AV: E=McAfee;i="6000,8403,9732"; a="137062070" X-IronPort-AV: E=Sophos;i="5.76,386,1592895600"; d="scan'208";a="137062070" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Sep 2020 02:09:44 -0700 IronPort-SDR: yoLiIIz3Xy2OwZVjbgJrpzW1GUDXG+QV3OPW6t5J+q3xShwKV3U4ZyBwZjMmLHClAeYSEfOuFA ICd0mQtpwDPA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,386,1592895600"; d="scan'208";a="334407398" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga002.fm.intel.com with ESMTP; 03 Sep 2020 02:09:44 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 3 Sep 2020 02:09:43 -0700 Received: from orsmsx151.amr.corp.intel.com (10.22.226.38) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 3 Sep 2020 02:09:43 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by ORSMSX151.amr.corp.intel.com (10.22.226.38) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 3 Sep 2020 02:09:43 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 3 Sep 2020 02:09:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VwrZHvrNrE10MtWzH1DJKaOlNsx4L19ye6sGM90YJI80g7ciMC1Mz49aHhvfuMORXrAxr69uUyBVhhMDvhpR1yiGagtOC6ejPU7UHTPSXq6tQYzTtAjf0l27+bznQDGNUecvbNUtByzDavBRIiUS988wYJJk9i85Mg9ND031dJDzjdbmdvqAYcgcBMFdgVDcppNhatVHGeh6pTK+lxmt7UsL2AI3uQB+OCvnTG8gzoKsv3TaJIpSMa27iaVNG7qXQFRmhsZh6hBpwhke055hIn/djANo1yGQDeVofAgMdk13cpNsftrsk8ErWOvA17+AKO+Bj9x7/mWkWKu2HM3H8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+GVsuGWv9gyxxwCbsPFSZ9DMszNuWhA7YzEAiYmirCM=; b=XfIknqWsiGSFHuikeQLkSEB2ybPzl7tQuLPmwCf87pjpnkv9tNXI5BlnxdFx0k9ljWpvsN1ExppW69VcncU+jLMfDsAKjSfdALW88xP+VBp6eN/x4GFOdGbVaMgGf8ULIo+V8gd87SuGML0xMq0isWAEND0snUgkIHV7yxoV8qevLsbCJONGugrD40nKCwjda68bz1fJh+AvnY2/tWIazNaJ2/NdIofZPFxAfDJWv5XbB540MLTtAwaK9FznrvTZBXifF8SpaSpmhmaU3OqhlgXpvbC8PjzTdNS00iuynl+9IYWMDbsXdv3fNNM676/sdn0HoVMWl5G0x+rTR0VOvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+GVsuGWv9gyxxwCbsPFSZ9DMszNuWhA7YzEAiYmirCM=; b=UuhiSYWHH8jtK6269RgOPCCNTUAOFmI82as2o4dFMI8RYaEl2VrwODy0tIMNdDxAOdvahEUBGv07WyenWgcwI8dQJnLqQL742+wW/38JGd4CBDTF702ZgT3RBcRtR2tIVu3zF0FTG5QLVSmI+rHTieeLFTZvUZ2dj5/QQweDpE8= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BY5PR11MB4387.namprd11.prod.outlook.com (2603:10b6:a03:1cb::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3348.15; Thu, 3 Sep 2020 09:09:42 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f43b:a137:dab8:8b0b]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f43b:a137:dab8:8b0b%6]) with mapi id 15.20.3348.015; Thu, 3 Sep 2020 09:09:42 +0000 From: "Ananyev, Konstantin" To: "Xu, Rosen" , "Chautru, Nicolas" , "dev@dpdk.org" , "akhil.goyal@nxp.com" CC: "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH v3 05/11] baseband/acc100: add LDPC processing functions Thread-Index: AQHWffVBLw/FDkKw90u53wHMQlmsYqlPYOgAgAbYqwCAAG4EMA== Date: Thu, 3 Sep 2020 09:09:41 +0000 Message-ID: References: <1597796731-57841-1-git-send-email-nicolas.chautru@intel.com> <1597796731-57841-6-git-send-email-nicolas.chautru@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [46.7.39.127] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 82d6a986-7acf-4c47-5aae-08d84fe917ec x-ms-traffictypediagnostic: BY5PR11MB4387: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2958; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ujOFId9jc5i6GeZZXNkYr1RunBgWIxXCvHCgJzK9iMcwWIT1fcQ8aNnxtYYsuNd9YHIlpyLze/DLTrzqbU9jqCXecYThmvtSODlGjyRmVUMaHFra0yhCjBl/QM/HwpVXYIxOu5R++9RALrEl8lepMLK/JNZsJdVP5eohB/3dcV1zWJ4WCwaTZKM83Vb+J5CRV8FbhmSH6sRNUWwmW5wBmT7WzkLtd/MFzJ10O3EHS/TyjWMrUGauwrdqJckxP/DyM0o6c0qUI0ACkTcr70FXc4kZwAXmyrbCkOSK5/GHTpZ82uuDg+U1XCsdhHG5T41CBrXRdg1eO/CmQk6ciK0wJA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(366004)(346002)(376002)(136003)(71200400001)(316002)(53546011)(66476007)(66556008)(33656002)(6506007)(186003)(26005)(9686003)(55016002)(83380400001)(4326008)(107886003)(66946007)(76116006)(66446008)(64756008)(7696005)(478600001)(5660300002)(110136005)(2906002)(8936002)(86362001)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 3GRjddFezEAFpS6EsUbaT9Dg8F6dQOyAcdRdAxyGuPzTc0dWIJzh0y7QXupdqY91DMES5Q4dmxUbDQaeSswAU9JkzpuKuR3lm/w6tzP7KcwrxzU7eeSHro2gy2f2gdFpg6WD8Q5FdiRRYBOAo2VNV/mC31sGqVwxVpGmHxcMf5wq7//avMgNyUppfnzbPiuD0Dv+aePMRHUNYmKOHPGNgcbGgoSV2KZItfRArIMsSHSteVFrYIxOvHbIl0nX1aMaHp6JX8WtKg8AjYsBt8yOoBmTHChCVM0IVhwrPLpLBRavvgQEJDdAmYvvA3YiGbe0kwa8P7Bb4DOz+CWHJOb4Y5UhCd6frUXNSsrbnNNwviFRgQtzwmC1eEQYbtzpdZmJdDHjFQq2BzBHYTfCQo2cGT2jv3Ahy1ZUtWv6yB1bYqDVGGhRmUgmjz7hzvqetZn8ogBbBzMA9PDZyaSUFahRvoB0NuYW6+myeQfy+RdokHbaxjrci//pIN0qtzLbtkOZY73rVFdS+CWpTxu6xeHM+aJ97VyXjw8sXGJHr/qLGO84l1Dzl9DuaKYseEDJH+biZZMYN8Ks5wKJZBr1iX/bpv42I5ZFUA013+/qyxaq//7PdgpjqEkP9gRYJKKoVURmASyRhcu5hNXsRCqwDP5+3w== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82d6a986-7acf-4c47-5aae-08d84fe917ec X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Sep 2020 09:09:41.8872 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 023SGwCArVK+Z7tAwOoy75gVVlI9OiQVMbDdis0zqAF/oaRDfj7wJsxLAvFQTVpc9TXqSaRUMzFjjGg9vkklGDWnlhB2Jzo5qgR8t5Ys2Uo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4387 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 05/11] baseband/acc100: add LDPC processing functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Xu, Rosen > Sent: Thursday, September 3, 2020 3:34 AM > To: Chautru, Nicolas ; dev@dpdk.org; akhil.goy= al@nxp.com > Cc: Richardson, Bruce > Subject: Re: [dpdk-dev] [PATCH v3 05/11] baseband/acc100: add LDPC proces= sing functions >=20 > Hi, >=20 > > -----Original Message----- > > From: Chautru, Nicolas > > Sent: Sunday, August 30, 2020 2:01 > > To: Xu, Rosen ; dev@dpdk.org; akhil.goyal@nxp.com > > Cc: Richardson, Bruce > > Subject: RE: [dpdk-dev] [PATCH v3 05/11] baseband/acc100: add LDPC > > processing functions > > > > Hi Rosen, > > > > > From: Xu, Rosen > > > > > > Hi, > > > > > > > -----Original Message----- > > > > From: dev On Behalf Of Nicolas Chautru > > > > Sent: Wednesday, August 19, 2020 8:25 > > > > To: dev@dpdk.org; akhil.goyal@nxp.com > > > > Cc: Richardson, Bruce ; Chautru, Nicola= s > > > > > > > > Subject: [dpdk-dev] [PATCH v3 05/11] baseband/acc100: add LDPC > > > > processing functions > > > > > > > > Adding LDPC decode and encode processing operations > > > > > > > > Signed-off-by: Nicolas Chautru > > > > --- > > > > drivers/baseband/acc100/rte_acc100_pmd.c | 1625 > > > > +++++++++++++++++++++++++++++- > > > > drivers/baseband/acc100/rte_acc100_pmd.h | 3 + > > > > 2 files changed, 1626 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c > > > > b/drivers/baseband/acc100/rte_acc100_pmd.c > > > > index 7a21c57..5f32813 100644 > > > > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > > > > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > > > > @@ -15,6 +15,9 @@ > > > > #include > > > > #include > > > > #include > > > > +#ifdef RTE_BBDEV_OFFLOAD_COST > > > > +#include > > > > +#endif > > > > > > > > #include > > > > #include > > > > @@ -449,7 +452,6 @@ > > > > return 0; > > > > } > > > > > > > > - > > > > /** > > > > * Report a ACC100 queue index which is free > > > > * Return 0 to 16k for a valid queue_idx or -1 when no queue is > > > > available @@ -634,6 +636,46 @@ > > > > struct acc100_device *d =3D dev->data->dev_private; > > > > > > > > static const struct rte_bbdev_op_cap bbdev_capabilities[] =3D { > > > > + { > > > > + .type =3D RTE_BBDEV_OP_LDPC_ENC, > > > > + .cap.ldpc_enc =3D { > > > > + .capability_flags =3D > > > > + RTE_BBDEV_LDPC_RATE_MATCH | > > > > + RTE_BBDEV_LDPC_CRC_24B_ATTACH > > > > | > > > > + > > > > RTE_BBDEV_LDPC_INTERLEAVER_BYPASS, > > > > + .num_buffers_src =3D > > > > + > > > > RTE_BBDEV_LDPC_MAX_CODE_BLOCKS, > > > > + .num_buffers_dst =3D > > > > + > > > > RTE_BBDEV_LDPC_MAX_CODE_BLOCKS, > > > > + } > > > > + }, > > > > + { > > > > + .type =3D RTE_BBDEV_OP_LDPC_DEC, > > > > + .cap.ldpc_dec =3D { > > > > + .capability_flags =3D > > > > + RTE_BBDEV_LDPC_CRC_TYPE_24B_CHECK | > > > > + RTE_BBDEV_LDPC_CRC_TYPE_24B_DROP | > > > > + > > > > RTE_BBDEV_LDPC_HQ_COMBINE_IN_ENABLE | > > > > + > > > > RTE_BBDEV_LDPC_HQ_COMBINE_OUT_ENABLE | > > > > +#ifdef ACC100_EXT_MEM > > > > + > > > > RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_IN_ENABLE | > > > > + > > > > RTE_BBDEV_LDPC_INTERNAL_HARQ_MEMORY_OUT_ENABLE | > > > > +#endif > > > > + > > > > RTE_BBDEV_LDPC_ITERATION_STOP_ENABLE | > > > > + RTE_BBDEV_LDPC_DEINTERLEAVER_BYPASS > > > > | > > > > + RTE_BBDEV_LDPC_DECODE_BYPASS | > > > > + RTE_BBDEV_LDPC_DEC_SCATTER_GATHER | > > > > + > > > > RTE_BBDEV_LDPC_HARQ_6BIT_COMPRESSION | > > > > + RTE_BBDEV_LDPC_LLR_COMPRESSION, > > > > + .llr_size =3D 8, > > > > + .llr_decimals =3D 1, > > > > + .num_buffers_src =3D > > > > + > > > > RTE_BBDEV_LDPC_MAX_CODE_BLOCKS, > > > > + .num_buffers_hard_out =3D > > > > + > > > > RTE_BBDEV_LDPC_MAX_CODE_BLOCKS, > > > > + .num_buffers_soft_out =3D 0, > > > > + } > > > > + }, > > > > RTE_BBDEV_END_OF_CAPABILITIES_LIST() > > > > }; > > > > > > > > @@ -669,9 +711,14 @@ > > > > dev_info->cpu_flag_reqs =3D NULL; > > > > dev_info->min_alignment =3D 64; > > > > dev_info->capabilities =3D bbdev_capabilities; > > > > +#ifdef ACC100_EXT_MEM > > > > dev_info->harq_buffer_size =3D d->ddr_size; > > > > +#else > > > > + dev_info->harq_buffer_size =3D 0; > > > > +#endif > > > > } > > > > > > > > + > > > > static const struct rte_bbdev_ops acc100_bbdev_ops =3D { > > > > .setup_queues =3D acc100_setup_queues, > > > > .close =3D acc100_dev_close, > > > > @@ -696,6 +743,1577 @@ > > > > {.device_id =3D 0}, > > > > }; > > > > > > > > +/* Read flag value 0/1 from bitmap */ static inline bool > > > > +check_bit(uint32_t bitmap, uint32_t bitmask) { > > > > + return bitmap & bitmask; > > > > +} > > > > + > > > > +static inline char * > > > > +mbuf_append(struct rte_mbuf *m_head, struct rte_mbuf *m, uint16_t > > > > +len) { > > > > + if (unlikely(len > rte_pktmbuf_tailroom(m))) > > > > + return NULL; > > > > + > > > > + char *tail =3D (char *)m->buf_addr + m->data_off + m->data_len; > > > > + m->data_len =3D (uint16_t)(m->data_len + len); > > > > + m_head->pkt_len =3D (m_head->pkt_len + len); > > > > + return tail; > > > > +} > > > > > > Is it reasonable to direct add data_len of rte_mbuf? > > > > > > > Do you suggest to add directly without checking there is enough room in= the > > mbuf? We cannot rely on the application providing mbuf with enough > > tailroom. >=20 > What I mentioned is this changes about mbuf should move to librte_mbuf. > And it's better to align Olivier Matz. There is already rte_pktmbuf_append() inside rte_mbuf.h. Wouldn't it suit? >=20 > > In case you ask about the 2 mbufs, this is because this function is use= d to also > > support segmented memory made of multiple mbufs segments. > > Note that this function is also used in other existing bbdev PMDs. In c= ase you > > believe there is a better way to do this, we can certainly discuss and = change > > these in several PMDs through another serie. > > > > Thanks for all the reviews and useful comments. > > Nic