From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1492A052A; Tue, 26 Jan 2021 12:43:48 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 352C114145E; Tue, 26 Jan 2021 12:43:48 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 1092F14145D for ; Tue, 26 Jan 2021 12:43:44 +0100 (CET) IronPort-SDR: p6gZJG5p06xJ2QnodoMFLcfplyhJebT90rNFjP4bJcryzNMOwh6a5GIt1n9EsRVq6ovSMsM0/2 rAuqrtJz4UTg== X-IronPort-AV: E=McAfee;i="6000,8403,9875"; a="159663503" X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="159663503" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jan 2021 03:43:44 -0800 IronPort-SDR: 9PkYjgL9rDF1zu2fjJpl9nw0kypDpi43nWh4KMMawJeDUBwfSSgUk1UVxxm3NzXzsRzbJbXYVt T/v28dz8nl4w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,375,1602572400"; d="scan'208";a="410126008" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by FMSMGA003.fm.intel.com with ESMTP; 26 Jan 2021 03:43:43 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 26 Jan 2021 03:43:42 -0800 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 26 Jan 2021 03:43:42 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 26 Jan 2021 03:43:42 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 26 Jan 2021 03:43:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EwjPYe9NLnVQusZG1yaQgUiyR1Aj7jPxGeGodfVNA+OXphfsM3MnPX94/SR+qHcO8WADH5u6bYjGp1F7fxNvKZilUlfviGApnsRHgSbXjlfEDTWU+qovdnHiSyiZcS4/v9AdsqJq8aeFhFdxfJ6jlVMf2UmiOQizgHR/uGCssDI1Btgse2zITbHJVXM/ppPgprneB7i+3z4sKcFU4pVgW4gYIjpIy4knWAdowqy8tozq/uI3ShnE971IiynNhyIJZ8eJZmdpRy3Wkdwcrb/poEmG3Ub+DnJMsoS6IsGzWey/zAmUCbxNxjbGL3WgiWFEzCOn4iH5phHOxmvb2iVY6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4QatUcNy5FBJIgTdgV8E6692AhvNQNokTlJkMJJ3M24=; b=MbsM8yHmCSFLGkbDUBkM9C3RMa7LOKd8lExJ7BUn3QtW9TRxY7Q1tep+IPwP5uAPtNGlp8Ylfq0ahqIbW0ezoZ0eBKzdIRLqPW8qF9OTUtR0Y0C7QouqzQ9P2516YHK2kqqy02BXO01KbqwYHbnYZqMztMokGO07lC0oJyWAAhD3Spq/DTBpHQUkpvHjAt2UaqAXKXmLZ16WfVyFpOZPhgnZPErGIxgnJlk6ugRLOMfB8Jfhq6b8SddKNAaKGIgQ9S68OkbYcIGTqCHd5HFZMvZ/Yty4gDvD+G+H+1POwICpI+Zwaky8Glebjm7tnSz3Qoda56Wx55jXDCpPxeojpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4QatUcNy5FBJIgTdgV8E6692AhvNQNokTlJkMJJ3M24=; b=WrftcfD4lSYDVTCK77SqEf0zkWaGISWJS5gxyfw2NnAVYtJT7F75+uzPaLYVxKxBQwHqPDvH/cMZNuPLvD2Zrk3DS92bz9jn6Z9RExvHe+r8k1MmrffWl0wRFvxbP4yhf3Nlmshagjyi6enmWXgTuWLLDucPLlcoA3eIuZT2UHE= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB3814.namprd11.prod.outlook.com (2603:10b6:a03:fb::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3784.12; Tue, 26 Jan 2021 11:43:41 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::1152:1426:8a4f:c755]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::1152:1426:8a4f:c755%4]) with mapi id 15.20.3784.019; Tue, 26 Jan 2021 11:43:41 +0000 From: "Ananyev, Konstantin" To: Feifei Wang , Honnappa Nagarahalli CC: "dev@dpdk.org" , "nd@arm.com" , "Honnappa Nagarahalli" , Ruifeng Wang Thread-Topic: [PATCH v2 3/3] ring: refactor ring library Thread-Index: AQHW87vMVdsJvAVrJUysdtJN7NV9Nao5yS2Q Date: Tue, 26 Jan 2021 11:43:41 +0000 Message-ID: References: <20201221111359.22013-1-feifei.wang2@arm.com> <20210126081746.1580627-1-feifei.wang2@arm.com> <20210126081746.1580627-4-feifei.wang2@arm.com> In-Reply-To: <20210126081746.1580627-4-feifei.wang2@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [46.7.39.127] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 470fbd58-cff1-4ff6-42e8-08d8c1efa0d2 x-ms-traffictypediagnostic: BYAPR11MB3814: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2276; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wRTdwpPork30dDMDnmX6cfdkgHOEZCz4RDBdsPNm1xM+Mz9fy+RQ3yknZeEks1b25G9cKeWESgdbMwDYApeOf+Bdh417lzaoQDAc6tuIXXfSSgVkpP8Nm6Na/M9CE0UTqoAumLaOzxk6JxdSR/Hk7FJbLZKcnxujzX9nSFp/T9ZjkzCprbW+0Xnj91H9lz+Z6jWqgUCInav4gE9LTxxVzI5GAEsUIa39YmHikzeP/K8UPanXuk7rZl1duArCMfHD66+Fz+E8i5a6vyXGE+uWIavHcLfqZcCdOmZxIzWL+9At3qeP1O8a6oocf0fX1fMbeevjy3a7MANKYNMqj0NJWESn+GFlxoX1wXQdaLv0HemtI1B0UG7qbOv7ViZXuMui89eOfaS6wQJok5c/OVCyhw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(136003)(376002)(39860400002)(366004)(396003)(5660300002)(33656002)(2906002)(6506007)(186003)(83380400001)(66946007)(76116006)(4744005)(8936002)(8676002)(7696005)(66476007)(66556008)(66446008)(64756008)(71200400001)(55016002)(316002)(9686003)(4326008)(478600001)(54906003)(52536014)(110136005)(86362001)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?phMzvQPRsoVknHCkSvs9onVk0xCuPnq2taGdVlBLSM9F22KdQaEXb/4iw7b2?= =?us-ascii?Q?eGYvYjnagCENuMEiqkumt5AeCFOpCYbp7j+kgtf9FNz5MHEXphAYzZsfHc0h?= =?us-ascii?Q?yoGw87Yuxw9Hr45ydiuHZBEUN4E62eNVmihnc6Wv+dKBB8AvGInI7LaPnS/y?= =?us-ascii?Q?S9k1EmrPtRl9Ihfxib9uGfvZRUKs6puQn8hTFU6jGntMNfUiqoCGlo2DmWS1?= =?us-ascii?Q?Gzq0ZECJlDpouQRvx3r9NZcz/8ih5ag+11ZtP4FQl3aJ6t3qcqBlo8A6qjiq?= =?us-ascii?Q?M1O0VocJRa9VzrdgAeZFCN1ObSSFNgvnv7ZYuiIFCHPe9HQOyJQzdW4ONWg4?= =?us-ascii?Q?2bqXhKa1OLGqCxrzRh/I5CHBc6r77MUvlnq1wszymVwrQz9eFZzCdFddiIT5?= =?us-ascii?Q?7HTtJHCCmPtwu/Jty78ljjodzgSstKtFWXPfcBRa8pXQ8u5HTEOfhhVb5WJ1?= =?us-ascii?Q?ls5cEF2d0Y8W9wqaqODG7zOsmidBgad8yGMn5m7no08KU+T8Dc8xEjZ5nyoR?= =?us-ascii?Q?ciFu1s50PgGIJt9XTZfcTM0Wa18LP9ip9dJhF3515kYdl77qk4OkWqZC0huX?= =?us-ascii?Q?7ORK/M+q+Oxe8kwhz4dQ/8G/03ZhK0xEVqVxVKhEGuYXUz0EEAFxJkBpfgS5?= =?us-ascii?Q?g40WRZ78jbqvhVxlfIxTZrS0t0GrDWecL4nweCBtdhzb4RYY5EXxo2AjgXFU?= =?us-ascii?Q?7DaK5tHt1kTGPwUHlgQhP+0rUWBTjyXrn0wS01177pDYHGdewOWSQsg51lLd?= =?us-ascii?Q?PBWr0gk97syqyzbHdMuVbNDHSrDosnT5ET6QDOpQfgIszWrlYtSeEINsHYjp?= =?us-ascii?Q?nNTfRIHHIVMa/8fx2YiIyPlOUae/zmxNsxXz/B0xr6bEUfaLfNFFlg8C/VEX?= =?us-ascii?Q?EKG4SIw0Z52Ysy1mIq3KqTCoefwYCOJ9JqVfHmUjuj1L2njHNXjHWgRUGPyU?= =?us-ascii?Q?u6i2ikfkaF2dSFGxmSqyeL97KjXFTLicSHB1fKT/JjT3KiZkGJUCIF5Yh/bc?= =?us-ascii?Q?kGhyU9gQFKYgYjUlOx/1+xbzkHj+8cW1/MK5T0qSdE7W2DA=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 470fbd58-cff1-4ff6-42e8-08d8c1efa0d2 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jan 2021 11:43:41.1274 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ulQ/OVL207SCzrNsxZ1QC3yiPRZa85d6FK8y9d7cpQnKqmfIQ5eWvdHmWlGOtWAw+2BOR/WirtPJK6WPM7/GTM/4zdKMxywXSWjbtVUko94= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3814 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 3/3] ring: refactor ring library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > For legacy modes, rename ring_generic/c11 to ring_generic/c11_pvt. > Furthermore, add new file ring_elem_pvt.h which includes ring_do_eq/deq > and ring element copy/delete APIs. >=20 > For other modes, rename xx_c11_mem to xx_elem_pvt. Move all private APIs > into these new header files. >=20 > Finally, the external APIs and internal APIs will be separated from each > other. This can remind users not to use internal APIs and make ring > library easier to maintain. >=20 > Suggested-by: Honnappa Nagarahalli > Signed-off-by: Feifei Wang > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Ruifeng Wang > --- Acked-by: Konstantin Ananyev > -- > 2.25.1