From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C213CA04DD; Wed, 28 Oct 2020 13:56:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A2F66CAC3; Wed, 28 Oct 2020 13:56:01 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 999BDC9C0; Wed, 28 Oct 2020 13:55:57 +0100 (CET) IronPort-SDR: xOF1OoKyi7UPXJLUB6tzsLvFag29UBGNdLZfuCZ5+RouWWkm0w8JGjq7LimufJk7akKEtcfBip 1TtCd6cCSleQ== X-IronPort-AV: E=McAfee;i="6000,8403,9787"; a="168348200" X-IronPort-AV: E=Sophos;i="5.77,426,1596524400"; d="scan'208";a="168348200" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2020 05:55:55 -0700 IronPort-SDR: HKpq3RK9EQG4SccKF3jmHgIZRsIqY/TPFglELeteDwFH0ksLaNBHViS0EMtB/Am6+is0uyJoT7 ZfD3Rj1aB3pA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,426,1596524400"; d="scan'208";a="536220050" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga005.jf.intel.com with ESMTP; 28 Oct 2020 05:55:55 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 28 Oct 2020 05:55:55 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 28 Oct 2020 05:55:55 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.58) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 28 Oct 2020 05:55:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j3fZXSHNHZ6udjLDKq63rh/uBU8aw8nfyl5arP0Tn2N1unUdv5U+Mg5QxsQEe++1oE6Uwvuj64XrSvuedC2AQbtXEj/+tX1qTCr955H75E1SsNfdDrZVkO7OF4Gk3WiGrEljRkjpJn7wkbJ/vxoQcU0fW0y/S/4K/m3WgO+YW6Z0mB0kiuIuYhDgwd8H0RdJ/QB3N3KObnWGpCRivNOi6prPKC6UoBHJVdSWhliBONas6xMSYCY3w3YjBveF9r/3XRhu82xjwOZq8wL4h48xcyVHWmvrFxOw/iZoVF2UZN+YOpZ/2REWJmuTGReP721jtV7GKdlv3/qDUyv7h/XRAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sI+YK4RAm7jdXrzxP43GTRljNy01fFkCvU0whIlaN2M=; b=R3B+JEQZU8fOtUUeeTl3OvlqXyyxeAOaML0KE0uojjuWDGb2GOrlngqXdIf3jUdupz92xZrEBOi/7UQ3CduE5lo2O3D/VbOuuhIendycWJHLk7cSndHAlMG3Fvl7X7s3skwpmZrRgha9zom1M97Va42C5YOBYmripvCwdWxaNelIKMyxM0lDIgyYQVYLepQcAAHpLBS4keF/e+HVwYfxilbRzqjtkc0G/t5I7y+CbF8okZN/DC2FIqzBVTuJn1Uinn1GLM/mDKkgjhHRStdjSO2DxgrUISQCeMbbiFuHTfuqdyzSEumjPCwgl2B2y3/yWDXRFJZS3x/dyv3b6/ur3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sI+YK4RAm7jdXrzxP43GTRljNy01fFkCvU0whIlaN2M=; b=SlMcnyMS2OJi1cg3UNjvGHRzZc3aTeiC9Eyc20vG4a4cYyuHnLyQ8/xTSyNHbeV+hoibNxOx89zq+XEA2ZpgsKB1U2AUUINttMieF5DmayIuk9LhqbIb+kO1m7tf8xQFWiGf/Pe1Dm6A6QtxrKLHIDkTMUMNuoptpEv1XxGTG2s= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB2630.namprd11.prod.outlook.com (2603:10b6:a02:c2::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.21; Wed, 28 Oct 2020 12:55:53 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f5a4:3f6b:ade3:296b]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f5a4:3f6b:ade3:296b%3]) with mapi id 15.20.3499.027; Wed, 28 Oct 2020 12:55:53 +0000 From: "Ananyev, Konstantin" To: "Gujjar, Abhinandan S" , Akhil Goyal , "dev@dpdk.org" , "Doherty, Declan" , "Honnappa.Nagarahalli@arm.com" , "techboard@dpdk.org" CC: "Vangati, Narender" , "jerinj@marvell.com" Thread-Topic: [v4 1/3] cryptodev: support enqueue callback functions Thread-Index: AQHWq8khoep63TjTukOc0FF/ZoXkNKmrxnGAgADogwCAAD4K0A== Date: Wed, 28 Oct 2020 12:55:53 +0000 Message-ID: References: <1603619090-118652-1-git-send-email-abhinandan.gujjar@intel.com> <1603619090-118652-2-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [46.7.39.127] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 13561619-b2eb-49ed-1554-08d87b40cdf0 x-ms-traffictypediagnostic: BYAPR11MB2630: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UyKTrDgue39MZhEttgcBw8ijhU+nGM6AhwFGchRMUC/8RfRGLYJ84pSj8ubtEdXv1LTNeZW+A3Clvvnd/l5UmsWR9BLI0Tz2HJ5y36E7vpwChhhfmgfKBcrK8LXEjNYlQigisDbMGYCvkh7UIFOnIt9Qi+SYSGsEKYEKyi5Gmw+ryJf6T2JI5RLRavyEhJdozJEo82SeQAtphARniThQvNbhxEessK8vtk1mMVumbJjTMXoZYOLX/hJyRoPmbPcLggGP+/szQY7L7nWRNHNLA8GvqaRMfFO4vAKdlD8K2w1MuC+qMQfvqegRUnnOewDuyN/F3QxRfpVftWreAQDvuxA5GYP3P+UiK8Op54lxXk1oWcRilUK6cc2q/rmlwxISXtGQSJZlPtDHXochDo451w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(39860400002)(366004)(136003)(396003)(9686003)(66556008)(186003)(7696005)(64756008)(4326008)(66476007)(83380400001)(66946007)(8936002)(54906003)(76116006)(8676002)(71200400001)(52536014)(66446008)(6506007)(53546011)(55016002)(5660300002)(478600001)(110136005)(316002)(33656002)(26005)(2906002)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 7pvtTUFQ6MSvXup30O1LkwkurVqrI2K05aYbc3pjYXEgkM5ndlX6g0DUWVgTXNmWZjsHw1q2Z4kxWoFYKw7z50G/4UvaCiSW0zywteCdYDv+7kqSaRUwAIYNIxHl5iOQee07dW/Vcm9zLPd215iCwaqjV7GGGSuDVfcRg0ee2NrSF80zPHi3979TFzcWh01/oLDKbmfnR+PMku/bcAGsnk7lbrIaC4xXeOP+N4wIcmzmKG45AeEhOAOQ3WVUb2R3iD91xTYO/OFeLAjVTFVCnEx3eAwCvcUnC2/Y3JhXnVW9PL/mqc2itFZ5JC3CNlziDmSOyD6JkdNEESxb+eLcXCC3SVpbLrNrwOtzuY8u/uuMKjrZqi3ZM5N5L4bu0iLvpenDwwda1bLCjNGCNQOdCPcdH+1RNkRHOWAZRIRii9MNZIdbfD3w7c8bNqrBosL0D0B2CH46DjK18n+070zkTshrtzN8utCIdOnHy2N34ssEQY8OHOu80ySk6pW1rcTQhjbuRSAIMEBGSLk+w2voyY5TlVGzFWfNHvSqWr6N6M+ZmJZt7GbetKW2heSn4nB7v3WBB5ca2x8DSyPm44QkSTWB4GIwIhUZTx2kDjD3SJA4uxENmejhltNHhl7w1IffIdLlDlhHLSiGkON1AsEFNQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 13561619-b2eb-49ed-1554-08d87b40cdf0 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2020 12:55:53.5442 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W5NGjF0EA9K3wOyQj4tU9Ldf5GkXkU/d4VlaNRcWFOXUxm5mpvP18Fb/EIiexcwcEBEoo776DMH3f4smvAkzbQeaSbkjh9/qquBOthk/i+w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2630 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Hi Tech board members, >=20 > Could you please clarify the concern? > The latest patch (https://patches.dpdk.org/patch/82536/) supports both en= queue and dequeue callback functionality. >=20 > Thanks > Abhinandan >=20 > > -----Original Message----- > > From: Akhil Goyal > > Sent: Tuesday, October 27, 2020 11:59 PM > > To: Gujjar, Abhinandan S ; dev@dpdk.org; > > Doherty, Declan ; > > Honnappa.Nagarahalli@arm.com; Ananyev, Konstantin > > ; techboard@dpdk.org > > Cc: Vangati, Narender ; jerinj@marvell.com > > Subject: RE: [v4 1/3] cryptodev: support enqueue callback functions > > > > Hi Tech board members, > > > > I have a doubt about the ABI breakage in below addition of field. > > Could you please comment. > > > > > /** The data structure associated with each crypto device. */ struc= t > > > rte_cryptodev { > > > dequeue_pkt_burst_t dequeue_burst; > > > @@ -867,6 +922,10 @@ struct rte_cryptodev { > > > __extension__ > > > uint8_t attached : 1; > > > /**< Flag indicating the device is attached */ > > > + > > > + struct rte_cryptodev_enq_cb_rcu *enq_cbs; > > > + /**< User application callback for pre enqueue processing */ > > > + > > > } __rte_cache_aligned; > > > > Here rte_cryptodevs is defined in stable API list in map file which is = a pointer > > To all rte_cryptodev and the above change is changing the size of the s= tructure. While this patch adds new fields into rte_cryptodev structure, it doesn't change the size of it. struct rte_cryptodev is cache line aligned, so it's current size: 128B for 64-bit systems, and 64B(/128B) for 32-bit systems. So for 64-bit we have 47B implicitly reserved, and for 32-bit we have 19B r= eserved. That's enough to add two pointers without changing size of this struct.=20 > > IMO, it seems an ABI breakage, but not sure. So wanted to double check. > > Now if it is an ABI breakage, then can we allow it? There was no deprec= ation > > notice Prior to this release. Yes, there was no deprecation note in advance. Though I think the risk is minimal - size of the struct will remain unchang= ed (see above). My vote to let it in for 20.11. > > Also I think if we are allowing the above change, then we should also a= dd > > another Field for deq_cbs also for post crypto processing in this patch= only. +1 for this. I think it was already addressed in v5. Konstantin