From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 06780A04B5; Tue, 27 Oct 2020 18:20:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D792F2D41; Tue, 27 Oct 2020 18:20:48 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 18BB42C01 for ; Tue, 27 Oct 2020 18:20:45 +0100 (CET) IronPort-SDR: cgx6hpmItEX66D9bCfvsYEKxIteT8YbuiTGq+CKkpEBch/w4adA5KlT+JSf0Ldww2QVnz7QOA7 fokrIjUeTD0w== X-IronPort-AV: E=McAfee;i="6000,8403,9787"; a="168224066" X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="168224066" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 10:20:45 -0700 IronPort-SDR: mPQOd06xNVnm7RJrgyCrkO3VTnmRVekLzkvpTRXcZEF7g3I0/SCeEnPDRJ8RDCHXEPRbHoIrn7 ifePnf3ilCfw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="318299329" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga003.jf.intel.com with ESMTP; 27 Oct 2020 10:20:44 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 27 Oct 2020 10:20:44 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 27 Oct 2020 10:20:44 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 27 Oct 2020 10:20:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Md60Hj91BeFe/Z+BggixZMuIwGs2WXNMmUskiT7xMTi+t9m/rTR3BPazokljAFTgAZIeGJv6lkhUDU6BbNKCqF7Xe0/KmwFvhkV4ojxvDf6/NWCWr5c4794hImrmseIYpMipnlStUukj53TBmHATHbW1QoNPVoQwognvx7PoP62KS3QPr7sIIMeHMcC+eS9YEMzV+FeJnFLHKQHJ/SgFONX9y3/+qmLygTnOLKmyL+5VrXLCgw6EDjTnjBS7ihB6ErRcaUIorN8DBh2jo46ITpBU35BqqqSHzV/3IGSxPftIv4MpvkTp9ZrCYPWEf8fHHfQB5XWH8oxteP6kOmDj0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C34gF5kpKsZrVMBWVjrsSimpIUr4s7o1Ng98gOF0Nm0=; b=XPu9R7WY7JB6KixtQMq4nMvrUWjmp2Yhf+3Gmy1uUcDMC+GCbK3kT8TZv+0z9qaKfAo98YaYOeLr88l3xRStqm1PzYvy2N8ta89xoc0/LSBvpnDvfoN3BBsaXP2yAcyaLQnaVQUp5JEXFksiEXxb/FIx9/O2BEd64ALoxfcDNJYN+2GzejSeJOVSXdXCjBbPNNQOH6kWUGqIXH9Lu3ZExKdD/9D9Vq8Aa8k+LfUZ/xQJfIdwE4Ep59Gg+z9LWoD2/LFstVg4SxHPUrpsFPAJnxI7hkp/I2RGn11jyd+3yl2X4TmXSMbtMyGXcMc3jHZfHrFQEij9SP9VejzP10l9sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=C34gF5kpKsZrVMBWVjrsSimpIUr4s7o1Ng98gOF0Nm0=; b=mGn0zKZmcXMMAJNMlpFTP9DNCaYYJc6+KBku1oGwFZqf/2phoU0Yt+UNydxm6DRT8B7zUgQk802IoTALA7JNkurR9Fvd4+kP5+p1N9abynp/SjQ/6CntbaElPQ5uiuQCOwEcx+8jacFCptDqVmHvb2odVPAmu8WxTRdfo12GMuY= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BY5PR11MB3910.namprd11.prod.outlook.com (2603:10b6:a03:185::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Tue, 27 Oct 2020 17:20:41 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f5a4:3f6b:ade3:296b]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f5a4:3f6b:ade3:296b%3]) with mapi id 15.20.3499.018; Tue, 27 Oct 2020 17:20:41 +0000 From: "Ananyev, Konstantin" To: "Gujjar, Abhinandan S" , "dev@dpdk.org" , "Doherty, Declan" , "akhil.goyal@nxp.com" , "Honnappa.Nagarahalli@arm.com" CC: "Vangati, Narender" , "jerinj@marvell.com" Thread-Topic: [v4 1/3] cryptodev: support enqueue callback functions Thread-Index: AQHWq8khoep63TjTukOc0FF/ZoXkNKmrYp/AgABPlwCAAAELcA== Date: Tue, 27 Oct 2020 17:20:41 +0000 Message-ID: References: <1603619090-118652-1-git-send-email-abhinandan.gujjar@intel.com> <1603619090-118652-2-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [46.7.39.127] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 544cae01-e14d-4268-93c9-08d87a9ca13f x-ms-traffictypediagnostic: BY5PR11MB3910: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +5D4eqLZQgZ873I5luJpWcIdf7vPp9OalrJ/VGaqULJYBJstp9fj47FCX26ekYVKIjTr0p3m+Cvn93mblGJ6dhnNQFouE8+7AbJWuIezG+ZXkbY2A+UZNWxU+j7wohABB9wPnQ1evc/KHyEgqLM6JU2sAdnAoqZb8V70nmFNGV4+2UnEY3Q7ehRuma2SyLmPHKwDg4dOORujcFQ4AehvvGTT/ntsnZxudut3eFwLyD2rVmFEh5ZMaAFOnk+Zbm9o8KlBM72M+B4TQ927Jn7O1B+pVNL83kkmMJs+JNs7pH4BhFSJoVRG4uhFx65jrYva x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(396003)(376002)(39860400002)(136003)(110136005)(30864003)(478600001)(71200400001)(66946007)(66476007)(64756008)(66556008)(316002)(66446008)(9686003)(8936002)(186003)(33656002)(53546011)(26005)(86362001)(2906002)(52536014)(54906003)(6506007)(7696005)(83380400001)(5660300002)(55016002)(76116006)(8676002)(4326008)(579004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: tsFs1VhUBCo0tadtYxs3kntmiIFt2BWCAUMc/++KHSS6Lzu+Sl+Ngi6zf0eZ2pvUzLNk9RgLfj27y4Qs4a2qjBUUQ2SLuSbw0+J/+nv8KIGEVJO3o8zlKxc6JCAsPdlt53fn/5jQjS+g/Y33RI6QK+Ow/I0fKT+G9SEA1jn2Cb18k/qx28pOrdC78r4u/YKLeIEhURV0xvdcPYr04netivqREewGrc/+iH1ZJez/odqCZ3zKVjfxeOTt1WAVHYcJvfOZwX9GzDfx8orXYEUO2oBCckk3jYao2EjoEd01ogAQGWdR3yxfvMY4H6MGryApnjG/T+vzAjp0lWmnEgJyogsp1F3kOh5N6tvJrPBROrUZ8Yl1DZBlJ47bvXDPs2ovbHJFgRdCwXjQRWXyuoTfYibPnpgJ29PdWTXyiY6HiiFQCqqtyaYiCnI4I3tNKm5ZRTE/iI/ewJLMMQBIbA2fJdJbqOEEfTzxBeQE1FwjK8Jgwr0b91CqMB+/t+WObFgF0mvkhXZO6hOEplSUwBMZZ9JuQfuWIYm49lN4bRLGm1HWJhMhx5gvtXU8j8EU0b8EUqQ/LT1G3NMj8U0yoo3sknUB1wsjyKvmMrVx49RI0roJ2BqtEgN79zsJzkL/PxYnkqLIqXK1sfSGulUDn71BfA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 544cae01-e14d-4268-93c9-08d87a9ca13f X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 17:20:41.0601 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9n+8agCrlj9tdLYMkFtVph+onTgXQr/LRJDdzhIKw5nD7BQ68AUrVBZ/jcOp/xQdLb3LhGOVFPqCsTE4j9mOfFG8/DUSvUpJeYOUEyHPA7E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3910 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > > -----Original Message----- > > From: Ananyev, Konstantin > > Sent: Tuesday, October 27, 2020 6:18 PM > > To: Gujjar, Abhinandan S ; dev@dpdk.org; > > Doherty, Declan ; akhil.goyal@nxp.com; > > Honnappa.Nagarahalli@arm.com > > Cc: Vangati, Narender ; jerinj@marvell.com > > Subject: RE: [v4 1/3] cryptodev: support enqueue callback functions > > > > > > > > > > This patch adds APIs to add/remove callback functions. The callback > > > function will be called for each burst of crypto ops received on a > > > given crypto device queue pair. > > > > > > Signed-off-by: Abhinandan Gujjar > > > --- > > > config/rte_config.h | 1 + > > > lib/librte_cryptodev/meson.build | 2 +- > > > lib/librte_cryptodev/rte_cryptodev.c | 230 > > +++++++++++++++++++++++++ > > > lib/librte_cryptodev/rte_cryptodev.h | 158 +++++++++++++++= +- > > > lib/librte_cryptodev/rte_cryptodev_version.map | 2 + > > > 5 files changed, 391 insertions(+), 2 deletions(-) > > > > > > diff --git a/config/rte_config.h b/config/rte_config.h index > > > 03d90d7..e999d93 100644 > > > --- a/config/rte_config.h > > > +++ b/config/rte_config.h > > > @@ -61,6 +61,7 @@ > > > /* cryptodev defines */ > > > #define RTE_CRYPTO_MAX_DEVS 64 > > > #define RTE_CRYPTODEV_NAME_LEN 64 > > > +#define RTE_CRYPTO_CALLBACKS 1 > > > > > > /* compressdev defines */ > > > #define RTE_COMPRESS_MAX_DEVS 64 > > > diff --git a/lib/librte_cryptodev/meson.build > > > b/lib/librte_cryptodev/meson.build > > > index c4c6b3b..8c5493f 100644 > > > --- a/lib/librte_cryptodev/meson.build > > > +++ b/lib/librte_cryptodev/meson.build > > > @@ -9,4 +9,4 @@ headers =3D files('rte_cryptodev.h', > > > 'rte_crypto.h', > > > 'rte_crypto_sym.h', > > > 'rte_crypto_asym.h') > > > -deps +=3D ['kvargs', 'mbuf'] > > > +deps +=3D ['kvargs', 'mbuf', 'rcu'] > > > diff --git a/lib/librte_cryptodev/rte_cryptodev.c > > > b/lib/librte_cryptodev/rte_cryptodev.c > > > index 3d95ac6..0880d9b 100644 > > > --- a/lib/librte_cryptodev/rte_cryptodev.c > > > +++ b/lib/librte_cryptodev/rte_cryptodev.c > > > @@ -448,6 +448,91 @@ struct > > rte_cryptodev_sym_session_pool_private_data { > > > return 0; > > > } > > > > > > +#ifdef RTE_CRYPTO_CALLBACKS > > > +/* spinlock for crypto device enq callbacks */ static rte_spinlock_t > > > +rte_cryptodev_callback_lock =3D RTE_SPINLOCK_INITIALIZER; > > > + > > > +static void > > > +cryptodev_cb_cleanup(struct rte_cryptodev *dev) { > > > + struct rte_cryptodev_cb **prev_cb, *curr_cb; > > > + struct rte_cryptodev_enq_cb_rcu *list; > > > + uint16_t qp_id; > > > + > > > + if (dev->enq_cbs =3D=3D NULL) > > > + return; > > > + > > > + for (qp_id =3D 0; qp_id < dev->data->nb_queue_pairs; qp_id++) { > > > + list =3D &dev->enq_cbs[qp_id]; > > > + prev_cb =3D &list->next; > > > + > > > + while (*prev_cb !=3D NULL) { > > > + curr_cb =3D *prev_cb; > > > + /* Remove the user cb from the callback list. */ > > > + __atomic_store_n(prev_cb, curr_cb->next, > > > + __ATOMIC_RELAXED); > > > + rte_rcu_qsbr_synchronize(list->qsbr, > > > + RTE_QSBR_THRID_INVALID); > > > > You call this function (cb_cleanup) only at dev_confiture(). > > At that moment DP threads can't do enqueue/dequeue anyway. > > So you can safely skip all this synchronization code here and just do: > > > > cb =3D list->next; > > while (cb !=3D NULL) { > > next =3D cb->next; > > rte_free(cb); > > cb =3D next; > > } > > > Ok > > > > > + rte_free(curr_cb); > > > > One thing that makes it sort of grey area: > > we do free() for cb itself, but user provided data will be sort of 'los= t'. > > As it is not referenced from our cb struct anymore... > > I see two options here - first just document explicitly that callbacks = wouldn't > > survive cryptodev_configure() and it is user responsibility to remove a= ll > > installed callbacks before doing dev_configure() to avoid possible memo= ry > > leakage. > Ok. I will update the documentation for this and send a new patch set. Ok, please keep my ack on your new version. > > Another option - add user provided cleanup() function pointer into stru= ct > > rte_cryptodev_cb and call it here if provided: > > struct rte_cryptodev_cb { > > struct rte_cryptodev_cb *next; > > /** < Pointer to next callback */ > > rte_cryptodev_callback_fn fn; > > /** < Pointer to callback function */ > > void *arg; > > /** < Pointer to argument */ > > void (*cleanup)(void *); > > }; > > > > And here: > > If (curr_cb->cleanup !=3D NULL) > > curr_cb->cleanup(curr_cb->arg); > > > > rte_free(curr_cb); > > > > Rest of the code - LGTM. > > So with that addressed: > > Acked-by: Konstantin Ananyev > > > > > + } > > > + > > > + rte_free(list->qsbr); > > > + } > > > + > > > + rte_free(dev->enq_cbs); > > > + dev->enq_cbs =3D NULL; > > > +} > > > + > > > +static int > > > +cryptodev_cb_init(struct rte_cryptodev *dev) { > > > + struct rte_cryptodev_enq_cb_rcu *list; > > > + struct rte_rcu_qsbr *qsbr; > > > + uint16_t qp_id; > > > + size_t size; > > > + > > > + /* Max thread set to 1, as one DP thread accessing a queue-pair */ > > > + const uint32_t max_threads =3D 1; > > > + > > > + dev->enq_cbs =3D rte_zmalloc(NULL, > > > + sizeof(struct rte_cryptodev_enq_cb_rcu) * > > > + dev->data->nb_queue_pairs, 0); > > > + if (dev->enq_cbs =3D=3D NULL) { > > > + CDEV_LOG_ERR("Failed to allocate memory for callbacks"); > > > + rte_errno =3D ENOMEM; > > > + return -1; > > > + } > > > + > > > + /* Create RCU QSBR variable */ > > > + size =3D rte_rcu_qsbr_get_memsize(max_threads); > > > + > > > + for (qp_id =3D 0; qp_id < dev->data->nb_queue_pairs; qp_id++) { > > > + list =3D &dev->enq_cbs[qp_id]; > > > + qsbr =3D rte_zmalloc(NULL, size, RTE_CACHE_LINE_SIZE); > > > + if (qsbr =3D=3D NULL) { > > > + CDEV_LOG_ERR("Failed to allocate memory for RCU > > on " > > > + "queue_pair_id=3D%d", qp_id); > > > + goto cb_init_err; > > > + } > > > + > > > + if (rte_rcu_qsbr_init(qsbr, max_threads)) { > > > + CDEV_LOG_ERR("Failed to initialize for RCU on " > > > + "queue_pair_id=3D%d", qp_id); > > > + goto cb_init_err; > > > + } > > > + > > > + list->qsbr =3D qsbr; > > > + } > > > + > > > + return 0; > > > + > > > +cb_init_err: > > > + rte_errno =3D ENOMEM; > > > + cryptodev_cb_cleanup(dev); > > > + return -1; > > > + > > > +} > > > +#endif > > > > > > const char * > > > rte_cryptodev_get_feature_name(uint64_t flag) @@ -927,6 +1012,11 @@ > > > struct rte_cryptodev * > > > > > > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->dev_configure, - > > ENOTSUP); > > > > > > +#ifdef RTE_CRYPTO_CALLBACKS > > > + rte_spinlock_lock(&rte_cryptodev_callback_lock); > > > + cryptodev_cb_cleanup(dev); > > > + rte_spinlock_unlock(&rte_cryptodev_callback_lock); > > > +#endif > > > /* Setup new number of queue pairs and reconfigure device. */ > > > diag =3D rte_cryptodev_queue_pairs_config(dev, config- > > >nb_queue_pairs, > > > config->socket_id); > > > @@ -936,6 +1026,15 @@ struct rte_cryptodev * > > > return diag; > > > } > > > > > > +#ifdef RTE_CRYPTO_CALLBACKS > > > + rte_spinlock_lock(&rte_cryptodev_callback_lock); > > > + diag =3D cryptodev_cb_init(dev); > > > + rte_spinlock_unlock(&rte_cryptodev_callback_lock); > > > + if (diag) { > > > + CDEV_LOG_ERR("Callback init failed for dev_id=3D%d", dev_id); > > > + return -ENOMEM; > > > + } > > > +#endif > > > rte_cryptodev_trace_configure(dev_id, config); > > > return (*dev->dev_ops->dev_configure)(dev, config); } @@ -1136,6 > > > +1235,137 @@ struct rte_cryptodev * > > > socket_id); > > > } > > > > > > +#ifdef RTE_CRYPTO_CALLBACKS > > > +struct rte_cryptodev_cb * > > > +rte_cryptodev_add_enq_callback(uint8_t dev_id, > > > + uint16_t qp_id, > > > + rte_cryptodev_callback_fn cb_fn, > > > + void *cb_arg) > > > +{ > > > + struct rte_cryptodev *dev; > > > + struct rte_cryptodev_enq_cb_rcu *list; > > > + struct rte_cryptodev_cb *cb, *tail; > > > + > > > + if (!cb_fn) > > > + return NULL; > > > + > > > + if (!rte_cryptodev_pmd_is_valid_dev(dev_id)) { > > > + CDEV_LOG_ERR("Invalid dev_id=3D%d", dev_id); > > > + return NULL; > > > + } > > > + > > > + dev =3D &rte_crypto_devices[dev_id]; > > > + if (qp_id >=3D dev->data->nb_queue_pairs) { > > > + CDEV_LOG_ERR("Invalid queue_pair_id=3D%d", qp_id); > > > + return NULL; > > > + } > > > + > > > + cb =3D rte_zmalloc(NULL, sizeof(*cb), 0); > > > + if (cb =3D=3D NULL) { > > > + CDEV_LOG_ERR("Failed to allocate memory for callback on " > > > + "dev=3D%d, queue_pair_id=3D%d", dev_id, qp_id); > > > + rte_errno =3D ENOMEM; > > > + return NULL; > > > + } > > > + > > > + rte_spinlock_lock(&rte_cryptodev_callback_lock); > > > + > > > + cb->fn =3D cb_fn; > > > + cb->arg =3D cb_arg; > > > + > > > + /* Add the callbacks in fifo order. */ > > > + list =3D &dev->enq_cbs[qp_id]; > > > + tail =3D list->next; > > > + > > > + if (tail) { > > > + while (tail->next) > > > + tail =3D tail->next; > > > + /* Stores to cb->fn and cb->param should complete before > > > + * cb is visible to data plane. > > > + */ > > > + __atomic_store_n(&tail->next, cb, __ATOMIC_RELEASE); > > > + } else { > > > + /* Stores to cb->fn and cb->param should complete before > > > + * cb is visible to data plane. > > > + */ > > > + __atomic_store_n(&list->next, cb, __ATOMIC_RELEASE); > > > + } > > > + > > > + rte_spinlock_unlock(&rte_cryptodev_callback_lock); > > > + > > > + return cb; > > > +} > > > + > > > +int > > > +rte_cryptodev_remove_enq_callback(uint8_t dev_id, > > > + uint16_t qp_id, > > > + struct rte_cryptodev_cb *cb) > > > +{ > > > + struct rte_cryptodev *dev; > > > + struct rte_cryptodev_cb **prev_cb, *curr_cb; > > > + struct rte_cryptodev_enq_cb_rcu *list; > > > + int ret; > > > + > > > + ret =3D -EINVAL; > > > + > > > + if (!cb) { > > > + CDEV_LOG_ERR("cb is NULL"); > > > + return ret; > > > + } > > > + > > > + if (!rte_cryptodev_pmd_is_valid_dev(dev_id)) { > > > + CDEV_LOG_ERR("Invalid dev_id=3D%d", dev_id); > > > + return ret; > > > + } > > > + > > > + dev =3D &rte_crypto_devices[dev_id]; > > > + if (qp_id >=3D dev->data->nb_queue_pairs) { > > > + CDEV_LOG_ERR("Invalid queue_pair_id=3D%d", qp_id); > > > + return ret; > > > + } > > > + > > > + rte_spinlock_lock(&rte_cryptodev_callback_lock); > > > + if (dev->enq_cbs =3D=3D NULL) { > > > + CDEV_LOG_ERR("Callback not initialized"); > > > + goto cb_err; > > > + } > > > + > > > + list =3D &dev->enq_cbs[qp_id]; > > > + if (list =3D=3D NULL) { > > > + CDEV_LOG_ERR("Callback list is NULL"); > > > + goto cb_err; > > > + } > > > + > > > + if (list->qsbr =3D=3D NULL) { > > > + CDEV_LOG_ERR("Rcu qsbr is NULL"); > > > + goto cb_err; > > > + } > > > + > > > + prev_cb =3D &list->next; > > > + for (; *prev_cb !=3D NULL; prev_cb =3D &curr_cb->next) { > > > + curr_cb =3D *prev_cb; > > > + if (curr_cb =3D=3D cb) { > > > + /* Remove the user cb from the callback list. */ > > > + __atomic_store_n(prev_cb, curr_cb->next, > > > + __ATOMIC_RELAXED); > > > + ret =3D 0; > > > + break; > > > + } > > > + } > > > + > > > + if (!ret) { > > > + /* Call sync with invalid thread id as this is part of > > > + * control plane API > > > + */ > > > + rte_rcu_qsbr_synchronize(list->qsbr, > > RTE_QSBR_THRID_INVALID); > > > + rte_free(cb); > > > + } > > > + > > > +cb_err: > > > + rte_spinlock_unlock(&rte_cryptodev_callback_lock); > > > + return ret; > > > +} > > > +#endif > > > > > > int > > > rte_cryptodev_stats_get(uint8_t dev_id, struct rte_cryptodev_stats > > > *stats) diff --git a/lib/librte_cryptodev/rte_cryptodev.h > > > b/lib/librte_cryptodev/rte_cryptodev.h > > > index 0935fd5..1b7d7ef 100644 > > > --- a/lib/librte_cryptodev/rte_cryptodev.h > > > +++ b/lib/librte_cryptodev/rte_cryptodev.h > > > @@ -23,6 +23,7 @@ > > > #include "rte_dev.h" > > > #include > > > #include > > > +#include > > > > > > #include "rte_cryptodev_trace_fp.h" > > > > > > @@ -522,6 +523,34 @@ struct rte_cryptodev_qp_conf { > > > /**< The mempool for creating sess private data in sessionless mode > > > */ }; > > > > > > +#ifdef RTE_CRYPTO_CALLBACKS > > > +/** > > > + * Function type used for pre processing crypto ops when enqueue > > > +burst is > > > + * called. > > > + * > > > + * The callback function is called on enqueue burst immediately > > > + * before the crypto ops are put onto the hardware queue for process= ing. > > > + * > > > + * @param dev_id The identifier of the device. > > > + * @param qp_id The index of the queue pair in which ops are > > > + * to be enqueued for processing. The value > > > + * must be in the range [0, nb_queue_pairs - 1] > > > + * previously supplied to > > > + * *rte_cryptodev_configure*. > > > + * @param ops The address of an array of *nb_ops* pointers > > > + * to *rte_crypto_op* structures which contain > > > + * the crypto operations to be processed. > > > + * @param nb_ops The number of operations to process. > > > + * @param user_param The arbitrary user parameter passed in by the > > > + * application when the callback was originally > > > + * registered. > > > + * @return The number of ops to be enqueued to the > > > + * crypto device. > > > + */ > > > +typedef uint16_t (*rte_cryptodev_callback_fn)(uint16_t dev_id, uint1= 6_t > > qp_id, > > > + struct rte_crypto_op **ops, uint16_t nb_ops, void > > *user_param); > > > +#endif > > > + > > > /** > > > * Typedef for application callback function to be registered by app= lication > > > * software for notification of device events @@ -822,7 +851,6 @@ > > > struct rte_cryptodev_config { > > > enum rte_cryptodev_event_type event, > > > rte_cryptodev_cb_fn cb_fn, void *cb_arg); > > > > > > - > > > typedef uint16_t (*dequeue_pkt_burst_t)(void *qp, > > > struct rte_crypto_op **ops, uint16_t nb_ops); > > > /**< Dequeue processed packets from queue pair of a device. */ @@ > > > -839,6 +867,33 @@ typedef uint16_t (*enqueue_pkt_burst_t)(void *qp, > > > /** Structure to keep track of registered callbacks */ > > > TAILQ_HEAD(rte_cryptodev_cb_list, rte_cryptodev_callback); > > > > > > +#ifdef RTE_CRYPTO_CALLBACKS > > > +/** > > > + * @internal > > > + * Structure used to hold information about the callbacks to be > > > +called for a > > > + * queue pair on enqueue. > > > + */ > > > +struct rte_cryptodev_cb { > > > + struct rte_cryptodev_cb *next; > > > + /** < Pointer to next callback */ > > > + rte_cryptodev_callback_fn fn; > > > + /** < Pointer to callback function */ > > > + void *arg; > > > + /** < Pointer to argument */ > > > +}; > > > + > > > +/** > > > + * @internal > > > + * Structure used to hold information about the RCU for a queue pair= . > > > + */ > > > +struct rte_cryptodev_enq_cb_rcu { > > > + struct rte_cryptodev_cb *next; > > > + /** < Pointer to next callback */ > > > + struct rte_rcu_qsbr *qsbr; > > > + /** < RCU QSBR variable per queue pair */ }; #endif > > > + > > > /** The data structure associated with each crypto device. */ struc= t > > > rte_cryptodev { > > > dequeue_pkt_burst_t dequeue_burst; > > > @@ -867,6 +922,10 @@ struct rte_cryptodev { > > > __extension__ > > > uint8_t attached : 1; > > > /**< Flag indicating the device is attached */ > > > + > > > + struct rte_cryptodev_enq_cb_rcu *enq_cbs; > > > + /**< User application callback for pre enqueue processing */ > > > + > > > } __rte_cache_aligned; > > > > > > void * > > > @@ -989,6 +1048,31 @@ struct rte_cryptodev_data { { > > > struct rte_cryptodev *dev =3D &rte_cryptodevs[dev_id]; > > > > > > +#ifdef RTE_CRYPTO_CALLBACKS > > > + if (unlikely(dev->enq_cbs !=3D NULL)) { > > > + struct rte_cryptodev_enq_cb_rcu *list; > > > + struct rte_cryptodev_cb *cb; > > > + > > > + /* __ATOMIC_RELEASE memory order was used when the > > > + * call back was inserted into the list. > > > + * Since there is a clear dependency between loading > > > + * cb and cb->fn/cb->next, __ATOMIC_ACQUIRE memory order > > is > > > + * not required. > > > + */ > > > + list =3D &dev->enq_cbs[qp_id]; > > > + rte_rcu_qsbr_thread_online(list->qsbr, 0); > > > + cb =3D __atomic_load_n(&list->next, __ATOMIC_RELAXED); > > > + > > > + while (cb !=3D NULL) { > > > + nb_ops =3D cb->fn(dev_id, qp_id, ops, nb_ops, > > > + cb->arg); > > > + cb =3D cb->next; > > > + }; > > > + > > > + rte_rcu_qsbr_thread_offline(list->qsbr, 0); > > > + } > > > +#endif > > > + > > > rte_cryptodev_trace_enqueue_burst(dev_id, qp_id, (void **)ops, > > nb_ops); > > > return (*dev->enqueue_burst)( > > > dev->data->queue_pairs[qp_id], ops, nb_ops); @@ - > > 1730,6 +1814,78 > > > @@ struct rte_crypto_raw_dp_ctx { > > > rte_cryptodev_raw_dequeue_done(struct rte_crypto_raw_dp_ctx *ctx, > > > uint32_t n); > > > > > > +#ifdef RTE_CRYPTO_CALLBACKS > > > +/** > > > + * @warning > > > + * @b EXPERIMENTAL: this API may change without prior notice > > > + * > > > + * Add a user callback for a given crypto device and queue pair whic= h > > > +will be > > > + * called on crypto ops enqueue. > > > + * > > > + * This API configures a function to be called for each burst of > > > +crypto ops > > > + * received on a given crypto device queue pair. The return value is > > > +a pointer > > > + * that can be used later to remove the callback using > > > + * rte_cryptodev_remove_enq_callback(). > > > + * > > > + * Multiple functions are called in the order that they are added. > > > + * > > > + * @param dev_id The identifier of the device. > > > + * @param qp_id The index of the queue pair in which ops are > > > + * to be enqueued for processing. The value > > > + * must be in the range [0, nb_queue_pairs - 1] > > > + * previously supplied to > > > + * *rte_cryptodev_configure*. > > > + * @param cb_fn The callback function > > > + * @param cb_arg A generic pointer parameter which will be > > passed > > > + * to each invocation of the callback function on > > > + * this crypto device and queue pair. > > > + * > > > + * @return > > > + * NULL on error. > > > + * On success, a pointer value which can later be used to remove t= he > > callback. > > > + */ > > > + > > > +__rte_experimental > > > +struct rte_cryptodev_cb * > > > +rte_cryptodev_add_enq_callback(uint8_t dev_id, > > > + uint16_t qp_id, > > > + rte_cryptodev_callback_fn cb_fn, > > > + void *cb_arg); > > > + > > > + > > > +/** > > > + * @warning > > > + * @b EXPERIMENTAL: this API may change without prior notice > > > + * > > > + * Remove a user callback function for given crypto device and queue= pair. > > > + * > > > + * This function is used to removed callbacks that were added to a > > > +crypto > > > + * device queue pair using rte_cryptodev_add_enq_callback(). > > > + * > > > + * > > > + * > > > + * @param dev_id The identifier of the device. > > > + * @param qp_id The index of the queue pair in which ops are > > > + * to be enqueued for processing. The value > > > + * must be in the range [0, nb_queue_pairs - 1] > > > + * previously supplied to > > > + * *rte_cryptodev_configure*. > > > + * @param cb Pointer to user supplied callback created via > > > + * rte_cryptodev_add_enq_callback(). > > > + * > > > + * @return > > > + * - 0: Success. Callback was removed. > > > + * - -EINVAL: The dev_id or the qp_id is out of range, or the cal= lback > > > + * is NULL or not found for the crypto device queue pa= ir. > > > + */ > > > + > > > +__rte_experimental > > > +int rte_cryptodev_remove_enq_callback(uint8_t dev_id, > > > + uint16_t qp_id, > > > + struct rte_cryptodev_cb *cb); > > > + > > > +#endif > > > + > > > #ifdef __cplusplus > > > } > > > #endif > > > diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map > > > b/lib/librte_cryptodev/rte_cryptodev_version.map > > > index 7e4360f..5d8d6b0 100644 > > > --- a/lib/librte_cryptodev/rte_cryptodev_version.map > > > +++ b/lib/librte_cryptodev/rte_cryptodev_version.map > > > @@ -101,6 +101,7 @@ EXPERIMENTAL { > > > rte_cryptodev_get_qp_status; > > > > > > # added in 20.11 > > > + rte_cryptodev_add_enq_callback; > > > rte_cryptodev_configure_raw_dp_ctx; > > > rte_cryptodev_get_raw_dp_ctx_size; > > > rte_cryptodev_raw_dequeue; > > > @@ -109,4 +110,5 @@ EXPERIMENTAL { > > > rte_cryptodev_raw_enqueue; > > > rte_cryptodev_raw_enqueue_burst; > > > rte_cryptodev_raw_enqueue_done; > > > + rte_cryptodev_remove_enq_callback; > > > }; > > > -- > > > 1.9.1