From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 736C2A04B5; Tue, 27 Oct 2020 13:52:00 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A74495937; Tue, 27 Oct 2020 13:51:48 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id CF0C758F9 for ; Tue, 27 Oct 2020 13:51:46 +0100 (CET) IronPort-SDR: te6zn0HFl+xGSQ0g2auVR3uQMhs+XpMmNq+x8kO0w83EygJLU1JnCsd1Zg+mi2na0ZBwnGgFsv yni3SHuDurAg== X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="229708602" X-IronPort-AV: E=Sophos;i="5.77,423,1596524400"; d="scan'208";a="229708602" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Oct 2020 05:51:44 -0700 IronPort-SDR: ce3EMyPhRp+9SHAKhUD7BaczeZkCM46l1L6i00Vc0mnql5Z3aEPKCMQM3cxLs0Isry2G7yTEOp qN8V4ZMC3PWw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,423,1596524400"; d="scan'208";a="303740007" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga008.fm.intel.com with ESMTP; 27 Oct 2020 05:51:44 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 27 Oct 2020 05:51:43 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 27 Oct 2020 05:51:43 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 27 Oct 2020 05:51:43 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 27 Oct 2020 05:51:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UxNL+aENjNkATsfh6iC4dbNR0OR1oeYWWF+klpGwWxwqT7+7uKKOkXhQTRylGbgS9t8A6GoE5Jm2ED8JE9F/IVkdYUXGFSzyscQ1Asa5b+/l6Of+z177TQe5aCLUPUTP3fPpQ1nmt0MDoeGo4gF56075OgFC0myuzAuyemTLMyTZ0poKYK7f7QVl+59PQ2SIWhXJoCQWZYPbUQ7zM3Ua/NvHd51AgPAJTbpIQhiofeJG4WWtCnxdNKlqwBdBSMfQjTtmBmXKotK21B+g4mldssdBqPSaXjHpz0WMlh9LxyA1dE5JpxSR2MqsEf7+To4dtljNK3crf/wMl0h8tYu1Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aEQeBmtCYrwWiZo0AFMaVUeAQlJs/MhseC9FAwF6WG0=; b=nKIzCAm3+MZ6icHBdWAqjoHF+Ewg6mDIlMWaIXH7JmYidnCM2L0PErKe1n2SDKAmaAFC6hDKM5jwuqTyolujZ5SNpTsCu/KZBq5kBDIHJiJi2KdMY1GUq6RIWaVCdngkfTUES3JkpjCBpq9SaZ1Fyvi2aWbRVhxDTNrhOsPX6wxPLotlP4osPbQLFWUA3OQGzIIhVbeIuU9VfRGcLsaTAZkqpnKd7Ewrmj1pbA9ANE1W3Jiw7eAmq1Jn8ajvBh2Tw4mnPzEc2UTHVzsnsVrLUfgMn6JSCEVQI9QAIuzXqw5PykM/gl8YU8+cOTDkyUNIcISKNUDBayHHGh7Cy2Wjzw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aEQeBmtCYrwWiZo0AFMaVUeAQlJs/MhseC9FAwF6WG0=; b=EFTtJ07LweQnWMCAOghTu192wu0jibnRw9YXFGSHretVeIOG8B/KpIZkN+anGhxpIg7APe0+KzkowdaSUmbBiGORXgJDuGe5NPo6xB5SYF8R9bynB+IH7pnJDYKbJMi+cZiFqjOfmKu8puZ1JWsfGR3+sIaS0BgVHVl8kT4aQkA= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB3607.namprd11.prod.outlook.com (2603:10b6:a03:b2::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.28; Tue, 27 Oct 2020 12:51:37 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f5a4:3f6b:ade3:296b]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f5a4:3f6b:ade3:296b%3]) with mapi id 15.20.3499.018; Tue, 27 Oct 2020 12:51:37 +0000 From: "Ananyev, Konstantin" To: "Gujjar, Abhinandan S" , "dev@dpdk.org" , "Doherty, Declan" , "akhil.goyal@nxp.com" , "Honnappa.Nagarahalli@arm.com" CC: "Vangati, Narender" , "jerinj@marvell.com" Thread-Topic: [v4 3/3] doc: add enqueue callback APIs Thread-Index: AQHWq8kqZuKIG9hYCUCbCd/9IUMVRamrZ3zg Date: Tue, 27 Oct 2020 12:51:37 +0000 Message-ID: References: <1603619090-118652-1-git-send-email-abhinandan.gujjar@intel.com> <1603619090-118652-4-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: <1603619090-118652-4-git-send-email-abhinandan.gujjar@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [46.7.39.127] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: af24ca24-1b50-496d-ba39-08d87a770b0f x-ms-traffictypediagnostic: BYAPR11MB3607: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5lUpHV1pEaQO7y/kWCQkBtAhhNbKAKYXXvKxHzZ3szTDZrWRkGRWTONysbmkUBAZko5T0lcPcKeITIHC7Di24YromerFyLtUP+jgZzzk9pOLjgFo2/bpcP9+pS8Lvq+oOqgbty3NIIzRpnY9gQYZUIN/6QE5WjO4ZQnQ6JlTNj2f3l4If20PWy9hoYtE8Bax2KBp0WXlNCMp9l9D0UZBsonUSsA4HIkI4bJ16BJc1Dx0MnFoG8gsf+cV7G/zA9PBTjw5XTAoQtvZ3C1YQDWXfsFhyEatCi1eYASxmkhgd71JeMlP/szKXHQVWWd+EQ+VO31M+xCk3dWbgIPeEQu8Mg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(396003)(376002)(136003)(366004)(39860400002)(66556008)(86362001)(64756008)(76116006)(8676002)(8936002)(5660300002)(66476007)(66946007)(66446008)(6506007)(54906003)(2906002)(316002)(26005)(9686003)(186003)(110136005)(4326008)(52536014)(7696005)(71200400001)(83380400001)(33656002)(478600001)(55016002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: R43WQgDofQ7n3b/sM0alYMtSumTqzPRX6g09/EPf7LUV3NQVb1YotURNkT8vU2W+H2h6Ylzye25AeQ8fiBMNVTVSx3cGttskXBCvIOKSu5ehmD8zCJR0atCHbhD5FLD7x88FRwY42d21msaAWYBgHFL2axOVUfuKG+BYVuPj5IPGdbPwUZEK/xid/JW/jd7U1esxP78WjWclkRlkXMld2ajpFfZNrQ9Be4WWyN5dqzc8DJWIiaWOv4NnPv8PuQyAzy2bGPxOKZbWRxirIeYEHJjooetQ7agspo3DsCrBvwFL0v9MKBzRXExgjIalWeUFOJ6aNK6FiLk+8bo9fWH6G52p4Ck2g/DE8eU9ua4gTmFAgLp4LgqbA6CsQMqk54dmLOlcCGWKyv7UrZrPf31dWzjigTsJRpGgIIKw63uwAE3Zjo7Ty5f6tmN+ZuivypsWD5JWslyI+P8xOS41CScZKpCZnZLZoM1ZqJfIBWlWNyv24/SAEV4GoiG3tQG3G1m0LzNP3Uv1TcohryZ/OISVxOGgQ1M7QsUZJaBMnyL02vhMRk3NOFf+0uw5FSoIA/OEPQoxLUDL6rhLhuXRqgQDrUhli6/8m7cDV5jLD3UjLfHI9dt0kbLb8dnxlW3YV/cRjXFXzk93slXntvRzqqkErw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: af24ca24-1b50-496d-ba39-08d87a770b0f X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2020 12:51:37.7252 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NjazvEFuX5uyFo/dZL2yJIr32Q+aa65e4ij1nhIybZkQIXCzuBRu2UE5OqDP6Vm21dVI57R2p4AWvcC6+O8tzzx42/637a7E0iw5+wEC6vI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3607 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [v4 3/3] doc: add enqueue callback APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Add enqueue callback support for cryptodev library >=20 > Signed-off-by: Abhinandan Gujjar > --- > doc/guides/prog_guide/cryptodev_lib.rst | 22 ++++++++++++++++++++++ > doc/guides/rel_notes/release_20_11.rst | 5 +++++ > 2 files changed, 27 insertions(+) >=20 > diff --git a/doc/guides/prog_guide/cryptodev_lib.rst b/doc/guides/prog_gu= ide/cryptodev_lib.rst > index 72129e4..bb3de61 100644 > --- a/doc/guides/prog_guide/cryptodev_lib.rst > +++ b/doc/guides/prog_guide/cryptodev_lib.rst > @@ -366,6 +366,28 @@ can never be larger than ``nb_ops``. > uint16_t rte_cryptodev_dequeue_burst(uint8_t dev_id, uint16_t qp_id, > struct rte_crypto_op **ops, uint= 16_t nb_ops) >=20 > +User callback APIs > +~~~~~~~~~~~~~~~~~~ > +The add API configures a callback function to be called for each burst o= f crypto > +ops received on a given crypto device queue pair. The return value is a = pointer > +that can be used later to remove the callback using rte_cryptodev_remove= _enq_callback(). > +Multiple callback functions can be added for a given queue pair. > + > +.. code-block:: c > + > + struct rte_cryptodev_cb * > + rte_cryptodev_add_enq_callback(uint8_t dev_id, > + uint16_t qp_id, > + rte_cryptodev_callback_fn cb_fn, > + void *cb_arg); > + > +The remove API removes a callback function added by rte_cryptodev_add_en= q_callback(). > + > +.. code-block:: c > + > + int rte_cryptodev_remove_enq_callback(uint8_t dev_id, > + uint16_t qp_id, > + struct rte_cryptodev_cb *cb); Please add explicit statement that all installed callbacks wouldn't suruviv= e dev_configure(). So it is user responsibility to: remove them before dev_configure() and (re= )install after. With that in place: Acked-by: Konstantin Ananyev >=20 > Operation Representation > ~~~~~~~~~~~~~~~~~~~~~~~~ > diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_note= s/release_20_11.rst > index 48717ee..7e2fd30 100644 > --- a/doc/guides/rel_notes/release_20_11.rst > +++ b/doc/guides/rel_notes/release_20_11.rst > @@ -285,6 +285,11 @@ New Features > * Added scatter gather support. > * Added NIST GCMVS complaint GMAC test method support. >=20 > +* **Added enqueue callback APIs for cryptodev library.** > + > + Cryptodev is added with enqueue callback APIs to enable applications > + to add/remove user callbacks which gets called for every enqueue > + operations. >=20 > Removed Items > ------------- > -- > 1.9.1