From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"Dharmappa, Savinay" <savinay.dharmappa@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"david.marchand@redhat.com" <david.marchand@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v4] test/ipsec: measure libipsec performance
Date: Tue, 21 Apr 2020 10:21:45 +0000 [thread overview]
Message-ID: <BYAPR11MB3301399967E99A581A1E5B9F9AD50@BYAPR11MB3301.namprd11.prod.outlook.com> (raw)
In-Reply-To: <2018185.irdbgypaU6@thomas>
>
> 21/04/2020 04:29, Thomas Monjalon:
> > 06/03/2020 08:08, Savinay Dharmappa:
> > > test app to measures the performance of libipsec
> > > api rte_ipsec_pkt_crypto and rte_ipsec_pkt_process.
> >
> > Please make sentences in commit logs.
> >
> > > Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
> > > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > > ---
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -1259,6 +1259,8 @@ F: lib/librte_ipsec/
> > > M: Bernard Iremonger <bernard.iremonger@intel.com>
> > > F: app/test/test_ipsec.c
> > > F: doc/guides/prog_guide/ipsec_lib.rst
> > > +M: Savinay Dharmappa <savinay.dharmappa@intel.com>
> > > +F: app/test/test_ipsec_perf.c
> > > M: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> > > F: app/test/test_ipsec_sad.c
> > > F: app/test-sad/
> >
> > Repeating what I said on v3:
> > Having one different maintainer per test file is quite ridiculous.
> > The maintainers of a lib are expected to maintain the related tests.
>
>
> In addition, reading the first lines of the file, I see two mistakes:
>
> > --- /dev/null
> > +++ b/app/test/test_ipsec_perf.c
> > @@ -0,0 +1,619 @@
> > +/* SPDX-License-Identifier: BSD-3-Clause
> > + * Copyright(c) 2010-2014 Intel Corporation
>
> The Copyright year should be 2020 I guess.
>
> > + */
> > +
> > +#include <stdio.h>
> > +#include <rte_ip.h>
> > +#include <rte_malloc.h>
> > +#include <rte_ring.h>
> > +#include <rte_mbuf.h>
> > +#include <rte_malloc.h>
>
> rte_malloc.h is already included 3 lines above.
>
>
> I have a bad feeling about this patch,
> I think it should be dropped from 20.05-rc1.
If you feel patch is not good enough - sure feel free to drop it,
we'll try to fix the issues and resubmit it for rc2.
About having separate MAINTAINER for the test -
honestly I don't understand why it is a problem for you.
Obviously we would like to spread the load - what's wrong with it?
Konstantin
next prev parent reply other threads:[~2020-04-21 10:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 10:53 [dpdk-dev] [PATCH v1] app: test: " Savinay Dharmappa
2020-03-02 11:43 ` [dpdk-dev] [PATCH v2] " Savinay Dharmappa
2020-03-02 12:51 ` David Marchand
2020-03-02 14:40 ` Medvedkin, Vladimir
2020-03-03 15:34 ` Ananyev, Konstantin
2020-03-05 7:15 ` [dpdk-dev] [PATCH v3] " Savinay Dharmappa
2020-03-05 11:45 ` Ananyev, Konstantin
2020-03-05 17:11 ` Thomas Monjalon
2020-03-05 22:51 ` Ananyev, Konstantin
2020-03-06 8:58 ` Thomas Monjalon
2020-03-10 13:24 ` Ananyev, Konstantin
2020-03-10 20:14 ` Thomas Monjalon
2020-03-06 7:08 ` [dpdk-dev] [PATCH v4] test/ipsec: " Savinay Dharmappa
2020-04-19 21:43 ` Akhil Goyal
2020-04-21 2:29 ` Thomas Monjalon
2020-04-21 2:35 ` Thomas Monjalon
2020-04-21 10:21 ` Ananyev, Konstantin [this message]
2020-04-21 10:28 ` Thomas Monjalon
2020-04-21 11:07 ` Ananyev, Konstantin
2020-04-21 11:49 ` Thomas Monjalon
2020-04-21 12:04 ` Ananyev, Konstantin
2020-04-21 12:58 ` Thomas Monjalon
2020-04-23 15:25 ` [dpdk-dev] [PATCH v5] " Savinay Dharmappa
2020-04-24 10:06 ` Ananyev, Konstantin
2020-05-09 21:46 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB3301399967E99A581A1E5B9F9AD50@BYAPR11MB3301.namprd11.prod.outlook.com \
--to=konstantin.ananyev@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=savinay.dharmappa@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).