From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 945C6A00C5; Fri, 8 May 2020 14:57:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 764371DABB; Fri, 8 May 2020 14:57:10 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 6474A1D965 for ; Fri, 8 May 2020 14:57:09 +0200 (CEST) IronPort-SDR: FmxINr9D5kUSXaRsu8GN3jWnXJRsa4ZlxwwYq1NxHp2Qr5bmu96zW4bDrIhqCQSsZyUgMR0UrV NbcvJDr8zfjQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2020 05:57:08 -0700 IronPort-SDR: UWK1pqALH8LlTwvD99SdkuB7ZsdD36nOYxHrq4Uxh9uTGFw7jcRfuwb2TiKGYlzo1KgdS/H7gX +TAmifz3zwwQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,367,1583222400"; d="scan'208";a="296095713" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 08 May 2020 05:57:08 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 05:57:08 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 05:57:08 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.53) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 05:57:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fIOSbLrFk+0TWyPTKNerv6C+lrDruFWqFT/zcuh3liyhQGgKzoY7xV3uEgWIjsOKz1NNn2QtpM0ZNnHvnnwDEE4icImGAA36kHz1dPBlqFu8zjD6cb13Ba9Cp0cFy3SRFLosi60VIynF5TwjjIFhRLmpd+TPR13uzA3vacGwHr1zLHmGO1BQeh1azOV+ozjn9HuwL4PQC64nzpf1lo7Xo18mowJ7djLhvGkFL7mHLbduoeO8ysiC22J4vWs22fG4PsVD98waa0Gc6JPOanNX/sap8u9pWXkZoQp8eCqYH0D6O820N+1BWdM0Qce2zVb9kyI9hHWGZeIFPRAuwQNASQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PUuYolWQ/zxsUR2FHVec5nAPyiuoo3ceBhufxGzUP9A=; b=gEkV0tmBolGc/hDCMwZvQddMgHFcSAsfJN0jQyknMnds7a7y/SAX3SeuHdMbvHwKr53eBo6DAoRG9PQl6HGLUGMgw0SmKN3puR5QSm20c6J8mYwUIeXN/TccC/QTHYj5ldtRsq+/At4wsOWlRGTUb0nEbRWvYJGpo98zsyF4IKDrCtc99jw0imF/5NM1rIxibrwFQkaiHApKzMufeuWfdCzfbOjwKCEq5bDuVFQSbh/dW5wDMkRn3XsbnHSqU6M7iP4aUnnneK7gcP+uP6o/GqOxgo4n8wkF42QG9l5pwZrU9J85lEY3kISxSk0t8Hl9CmUxVPYaaQI6+KPBAd8xGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PUuYolWQ/zxsUR2FHVec5nAPyiuoo3ceBhufxGzUP9A=; b=ZYw2O4oXG8+DM19l1VU2cGuOwzcwtUcoO8syscdKyfuZopT+NaWw3HTXkaIPdHtHDhu+rSzOtZ7QBd4oopuXMkttljScVghoxrnT0S74DkZPqJXvKblgSq/AR4L9+gK2/1EUzp4zaDKjti2bTQICKl8khDi1lwjO7LFtK0/Px6s= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB2869.namprd11.prod.outlook.com (2603:10b6:a02:c0::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.20; Fri, 8 May 2020 12:57:06 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4%6]) with mapi id 15.20.2958.035; Fri, 8 May 2020 12:57:06 +0000 From: "Ananyev, Konstantin" To: Honnappa Nagarahalli , "dev@dpdk.org" CC: Ruifeng Wang , "Feifei Wang (Arm Technology China)" , nd , Dharmik Thakkar , nd Thread-Topic: rte_ring work Thread-Index: AdYj2/yEUDvXLCvbSjmLQfkOx8WHHgAfYkpwAA2yNXAAATxDAAAYeeugABA9S7A= Date: Fri, 8 May 2020 12:57:06 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.175] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 17f49203-d78b-4b27-18fd-08d7f34f5000 x-ms-traffictypediagnostic: BYAPR11MB2869: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 039735BC4E x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1d2JnHx1RDMMvUMnET3sNtn167tiGJZI1gn7iCh2Krjg3fr2e3hGBFKjtcRNkDzMZ+SLgeRt02o14zcS9Bdyjrg4wmWC29XC5jdB2OEpSbCKwJXfpwc/YvTSWyOH7SR0QCxYbyRBR4DCzAp/Ge/Qj9QyhG3IDp0qNFXIheZxn+RNcH7Le65m3k8STruhFbG+tBBWTPxXRUO5FCw2ZP/DZ3KgbYgt4fE8VlWUYLwyME9GFPJRv5DKyTO9qEkGQ2wNvF+yj7AqxwG8j0XmvRTrU+Iae/VmkHSjIWSkbyAxozEG5CuhFrPYa0vPOIUz/6aH/30eLmMFCiEyuMpsStLceTCZDMQj9VAtejF+AOXO+j+eqXTZW8DJRbcri3w/FLqC+pImDZeJlhMYpbDcJtBgqrsGmAZ6Nqj1UfIaU8oQJyPO0jA6QFu0rBtjYx2iMpLR8q8/gXrM81iFUwu1Tn9DDY8fgE5M1DTO5dGhNW67ALPg8XQRwpJHWz1WiiH9u3Jwqq3c6JCKwd+NGOUzSQcsTdHUZKafsKMcO2GmfhgFabdUl0aW6kzJY66bcAkUJy+IOqZTkdskCtaS1GYmFB6EY3NSO1WFzWJ4R7NP8T/60jYD/tXsrerRZX76xumhjnbj x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(376002)(396003)(136003)(346002)(39860400002)(366004)(33430700001)(186003)(8676002)(7116003)(110136005)(54906003)(71200400001)(316002)(26005)(478600001)(9686003)(6506007)(33440700001)(8936002)(86362001)(33656002)(83290400001)(2906002)(83280400001)(83310400001)(83320400001)(66946007)(64756008)(5660300002)(66476007)(66556008)(966005)(76116006)(66446008)(52536014)(4326008)(55016002)(83300400001)(7696005)(21314003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: aaEac7JfnoH4h85g0HrHV+RdJDru8bJ91JTk0pajjKHZISsrtMrzdDEVjmAWi6M6kCqlfN9sGcVALNL8D9ukzCepuG0tj8gHaiP4+eH/aKf/hC7ME6vsUDNSPgU4u2H7kdQo4INpXi5JHlov043Jqzqc/20dnQDdO5UxjzE3jtPhd+bAOZ4Wl/EhtgqtxViD2JJIV1l3p2P7fsj4uGrk+kNRFhqxeB6d13NHQTZvZfYrT5ATunWZx6DYrpDQMMPySQl7GeJ4282Dm7jhsMTxKIgxAQPalTvQgZJ0/gVINZKVenfNrMbNxSUJbXJZHAZSrQtEFwgDRlQFFraejuko2lL27ekMDtXhRvaIV2PsSPE7sKw5In09+79Fljdrz2SlJmbvbmVVsujsucGPLMjF6L7WUjgRpCZ5Ihg2jxYLAzr9ZRua8voeZ79DEkrA2Tnnt5wDvRC7WsD6gVcVQ/D62wtCduLp5gqVa4L5H4CzDZ2PkTyVohiKKhWt2HjZvzXg x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 17f49203-d78b-4b27-18fd-08d7f34f5000 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2020 12:57:06.4465 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: m953Yp7gtJyRmdYawoeujhgA7n2glA4hRDeM2JdkUdWSa4V5JP40EO5g180mhedxirFOZ6MA3B97de2H6F717BTzAb7f3SYVrm8zCjwaLVc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2869 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] rte_ring work X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > Some cleanup activity (assuming above things are successful) > > > > > > > > > > 1) Remove the detailed comments on top of the internal functions = - > > > > > it is hard to maintain, the parameters are already > > > > > self-explanatory > > > > > 3) Files need some re-org > > > > > a) rte_ring.h, rte_ring_hts.h, rte_ring_rts.h, rte_ring_peek.h - > > > > > will have legacy format APIs written as wrappers around xxx_elem = APIs > > > > > b) rte_ring_elem.h, rte_ring_hts_elem.h, rte_ring_rts_elem.h, > > > > rte_ring_peek_elem.h - will have xxx_elem APIs > > > > > c) ring_elem_pvt.h, ring_hts_elem_pvt.h, ring_rts_elem_pvt.h, > > > > ring_peek_elem_pvt.h > > > > > - these will contain the internal functions including the c11 > > > > functions to manipulate the head/tail pointers. > > > > > The files with xxx_c11_mem.h will disappear. Make sure > > > > private > > > > > functions have __rte prefix > > > > > > > > Basically you'd plan to: > > > > a) rename rte_ring_*_c11_mem.h to rte_ring_*_pvt.h > > > > b) get rid of rte_ring_generic.h > > > > Correct? > > > Yes > > > > If there would be no perf drops, I have no objections. > Agree > > Though recently there was a discussion is it ok to remove > > dpdk installable headers (even ones marked as internal). > Do you remember any conclusions? I tried to search, could not find the di= scussion. http://patches.dpdk.org/patch/69560/