From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9274A04B7; Tue, 13 Oct 2020 16:24:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EC9AE1DCDC; Tue, 13 Oct 2020 16:24:50 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id E35981DCD6 for ; Tue, 13 Oct 2020 16:24:48 +0200 (CEST) IronPort-SDR: cEq6278UpUmBztBT3+Fla/1jkVA6wbOIdf5F24IKHM9zUD3Zo9ylZChtxXMc8MeMlUbezq4hUI KHykd0WKPVKw== X-IronPort-AV: E=McAfee;i="6000,8403,9772"; a="145234541" X-IronPort-AV: E=Sophos;i="5.77,371,1596524400"; d="scan'208";a="145234541" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 07:24:47 -0700 IronPort-SDR: CxsJvZfXGOEO0t63IeXPiIxclxWA52VWXydU1Ec0E3TSYuInsXqfoesTxKJduYCFazlIlqSc9C Qf+FbmB/KNcg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,371,1596524400"; d="scan'208";a="299616739" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga008.fm.intel.com with ESMTP; 13 Oct 2020 07:24:46 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 13 Oct 2020 07:24:46 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 13 Oct 2020 07:24:46 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.53) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 13 Oct 2020 07:24:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nudY+S3JS3tV9I2GJnTCyDLYXdyIW9R6Dcj+kSrI5Rz7/gWQYocYU5uTV/q73VWZQ1fmaPB6fsuS+SWYDoIjd6yC0nbYMsjvCcuAghu0Obo3myELDM3VP0qtNbRy/BOqjU78KyTJDZcTCtKkrJGwt6s20OJl2x8mY//a+uCg6nOrGxkJ6sykljZ5SBqg3Kfq52FegbCfOx61CxFKesnbuX/KZ/78QoRj3RTgj879gvJJJAHMzf9HnrQdlszD7WZusa36tiN4QxZ7fEt7RrHhBO3szfk5x1jhtggxXbbzmbGwM2dttr2ZC/spz0JptTFToAEEt+LqLKNG398mykoL8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EogwjxhprV0AWvbSWD7NyjM8iA0UIoWPq3EyTc1N+3w=; b=P95O4H9EPwdWjZDfgK0zrZ3zwiLDpZTbxIpAh5uK6VTdLeIG9/siPESbFfa7h27vz82+MTAahvNd3feXW3Me06yAgAz+FZXqJNnuKs3aYzoiBQrI2bT2bL/OfGMao8Lwg8jFnJ+QQDfUJdImnvnrnIMM42vI8/+RWT1h24tA4Nw8MEtVUOLGsX8Ea9WQ9mz1v8M8vhFRPen198WTzpE5zwFHypNiD+Kf6nzkrw8Q3LwW2fDaZaZrI0V3REt6CQQMqdCWc3IRw9NJdumd1qLNfsQwJCp7Lx/tcnVyhAYw1CKfcp9nNMdBPDpyuRD67OSPD8KsniFi3QYPyJ4FfOdzUQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EogwjxhprV0AWvbSWD7NyjM8iA0UIoWPq3EyTc1N+3w=; b=YNnw7b1TX0SpUW28fvdTXD83J3xN7FpW6QYy2vKYKxqYi0+j6GdePzYfywryNgIcFn/g0Z21NMQrN+2UgP2bLuUv4KdTc1dxewiz6sHDD1W8V6wStr4dGpB8JTtMl2y4WGQwfGxXRoMLVCaxzdNVUaeK4SbCR2aawjMYWl2i1NI= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by SJ0PR11MB5085.namprd11.prod.outlook.com (2603:10b6:a03:2db::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.30; Tue, 13 Oct 2020 14:24:41 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f5a4:3f6b:ade3:296b]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f5a4:3f6b:ade3:296b%3]) with mapi id 15.20.3455.030; Tue, 13 Oct 2020 14:24:41 +0000 From: "Ananyev, Konstantin" To: Honnappa Nagarahalli , "dev@dpdk.org" , "phil.yang@arm.com" , "thomas@monjalon.net" , "arybchenko@solarflare.com" , "Yigit, Ferruh" CC: "Gujjar, Abhinandan S" , "nd@arm.com" Thread-Topic: [dpdk-dev] [PATCH 1/2] lib/ethdev: replace full barrier with relaxed barrier Thread-Index: AQHWmFArNErXet8hsk6e1wXVyFaub6mVqFOA Date: Tue, 13 Oct 2020 14:24:41 +0000 Message-ID: References: <20201002000711.41511-1-honnappa.nagarahalli@arm.com> In-Reply-To: <20201002000711.41511-1-honnappa.nagarahalli@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [46.7.39.127] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3afbfe26-448a-40a9-bcf6-08d86f83b94a x-ms-traffictypediagnostic: SJ0PR11MB5085: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2276; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LRSBtvu19y2EKoTWP1B4+BTlMglqQexdTiDj1TCioqSwqYxHL/m6O2BqSOrSJsQgwds+TzuUm+vCzRD24SRI6x+mnQZ8kHrXNi3jJ9tnuBnpX1gDwWe9FD0to8EMSbdczUBBY8aWlEg9nHaiFrGodMOf84cwOmn24E+rnEplqIAy5A99SD42yOUMhy+lXJfvr7M2i3hjsGukFb/AFvYwUG2iMJi1fo/VUFLY+0O5SptXl1UsgJWixaJCXdFTlq4blP2HoXbunW+WxSJ7Y8GMyBWD9IPdbpLaZZ4RvfDaox3uAxjf/dEQ3okyeFBc7GQpY24KZClpMGqxsvMsTwOYMg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(376002)(346002)(39860400002)(366004)(396003)(83380400001)(52536014)(55016002)(5660300002)(26005)(316002)(2906002)(110136005)(186003)(54906003)(6636002)(8936002)(6506007)(66446008)(66476007)(64756008)(9686003)(33656002)(71200400001)(4326008)(478600001)(86362001)(66946007)(66556008)(7696005)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: XARQZBn/vX2IXeiw29r0m3A1/ukrQJacd/RGwJlpgPZKkLdnd5UCcReF95NRztJM/eZ9J4foCFtZimpoNjMjJEzwF3G28Sy1WtMo1rT2b3VOwLIOltD+t8Soy7cH8f44STKaCGzHRLZZkNqIDfQPOCR5Ib0ExwfCBOO48DW3eZ6yr/7f1gMb4PKloV9XmTPQzRCqK1/gRS4FZb1BdWhEi9kl7RRJI9JMf5ukaRD/A+m9cbndEOq0Ou0kZe46xEoiZTfZ8J2W/iELyY/CrVqxuHnYXJl/UKEayarwPHaO89g5yJBi60cVxKMUZ/nJfyvI8kTmGm/gQ33B1EF+x8TpopoBE6f2phgXcHTkyDGThxWoBOukDZNQVNCfQeex3he5OWyqVQCUx+qjKnAAM+nofWUCc/I7HkZqDyWmaetfUpXifxQkr82eNQ/NIuwEl5CiKxQW4Q5v9SbPe7s3Ee5Ikra1VrGn932OsZI25eoQHW+ZvQAyfoo3ehA2FT4lF0iyEhYFCtrMpriFDbNxfpYi+P0YX6XhLb0k6fAbgefh42kd9SVPoB5fxIvTW3j4je8qshFdnLttdmIV3grmOUHFcv30nWTGpqPsu6eiMQM3JOmT91fsTq07ufdmoGD0PEs2sWdEPZGWrMnMUtJB2VPE6A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3afbfe26-448a-40a9-bcf6-08d86f83b94a X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Oct 2020 14:24:41.0558 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZEYwARbZpdLanjM9ZMd3O9wTvhDA12iC0kQz+Uo4ESxrZ2iDc5+2jF9SNdZaOPvNct0NkucZ5TtPKg2Vv4Eburus4h7eiiOfrXHiR9hMnfI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5085 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/2] lib/ethdev: replace full barrier with relaxed barrier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > From: Phil Yang >=20 > While registering the call back functions full write barrier > can be replaced with one-way write barrier. >=20 > Signed-off-by: Phil Yang > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Ruifeng Wang > --- > lib/librte_ethdev/rte_ethdev.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) >=20 > diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethde= v.c > index 7858ad5f1..59a41c07f 100644 > --- a/lib/librte_ethdev/rte_ethdev.c > +++ b/lib/librte_ethdev/rte_ethdev.c > @@ -26,7 +26,6 @@ > #include > #include > #include > -#include > #include > #include > #include > @@ -4527,8 +4526,12 @@ rte_eth_add_first_rx_callback(uint16_t port_id, ui= nt16_t queue_id, > rte_spinlock_lock(&rte_eth_rx_cb_lock); > /* Add the callbacks at first position */ > cb->next =3D rte_eth_devices[port_id].post_rx_burst_cbs[queue_id]; > - rte_smp_wmb(); > - rte_eth_devices[port_id].post_rx_burst_cbs[queue_id] =3D cb; > + /* Stores to cb->fn, cb->param and cb->next should complete before > + * cb is visible to data plane threads. > + */ > + __atomic_store_n( > + &rte_eth_devices[port_id].post_rx_burst_cbs[queue_id], > + cb, __ATOMIC_RELEASE); > rte_spinlock_unlock(&rte_eth_rx_cb_lock); >=20 > return cb; > -- Acked-by: Konstantin Ananyev > 2.17.1