From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8DAE6A00C5; Thu, 7 May 2020 19:38:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3B1C81DA6E; Thu, 7 May 2020 19:38:29 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 23BBA1DA68 for ; Thu, 7 May 2020 19:38:27 +0200 (CEST) IronPort-SDR: ygzUCqxCVNEx8WqKwAEuIlTJxFZ6K7vSHakQ0LttPdeMkHqTKpe4KEq816oS83E6yixveI+yJq yBEp26fH0pqg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 10:38:27 -0700 IronPort-SDR: qzkmOTeTeKs7wBQd99kRC1SVWG5mH0DztCUnS5Ay7mBgtssAk8ucPMxcIhZfPPBI1n9e+tDjy4 4To+PU0CE1JQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,364,1583222400"; d="scan'208";a="305182544" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 07 May 2020 10:38:27 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 10:38:26 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 7 May 2020 10:38:26 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 7 May 2020 10:38:26 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 10:38:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ULzUAEZ0TU3vOX2WPEDBR/bCXNuZxmnOvQPxw2ADwm2FlAL21cuzdCVQFqtxxG4bKrOkJA7rlmkapAoqVve0gfCYFs8oZ3QzX3DmJ0ayJ648WMykxfncARJEgS/KnqaxnHPmW7ULRg4bwiu0Uf/YDIYkvJDh/5iqabJ4eBn+WtY+2d1RjdlFU9x64b6BYHy4j2f1hvLDmP/83u34Cnd3sk9KYETXcjkXN9iVWoyWVLv4JRMeBzj3INhjF8Am3GndTzdBI/sRDFNPwqhbnsRTjoKr0ZeXl4dQwNM7WUGouFCnGd8v0vikaCRt3ssYi3jS8TJkKXTgn5kWCxvyRwYdKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sg988EbfqihoEzt20cH+MJQGExhAlN+EduveCUdp9dw=; b=dcMrO/n4A3Mjxt7l4oKJftqLXNV5b2ysH2jjGEl7gWyYWC0xZu4RLESNL1e8RKtStjIGIHWZTneKB03kzb+B+ylQv8Q2kpS6iyJ8/HWjD1H1G1e3RKT2tDNmjzhm05mCqctiTpaXbx3G0lG1hRXuNfFE1RCdv17+kfr7siSWV1EHXeKEH0kP6cqJLe+HroJmppNEjkyXiErSqnkSh+UHhrhLsuRU6NvniXJrETVow0s/j36OepukOeBVGtzbKTy97F/7p7NTCDyzMIek6nODq5aSS+FInygJw+DaS36+imOkXE1dIRZ2VXd4JGl8lKO5ZRadKwqf3MlpoK5DmWZPRA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sg988EbfqihoEzt20cH+MJQGExhAlN+EduveCUdp9dw=; b=GYXw85QKB/95CkxW6RQSuxI5gWJbm3Q12ncP9oxUevBdj2KKZh4jPkLtJWxs4cJ2Q0r2s7vQ9Tu3bKSD0DvY5zeCihTmv1MrXSTs9RqPT+qPyPOyJlgKBG5drVRmJZuNBNhmL5YzJ2r/mmNbbzSfrUVJ3T3WubYAR9XJE3UP7eI= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB3575.namprd11.prod.outlook.com (2603:10b6:a03:b3::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Thu, 7 May 2020 17:38:21 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4%6]) with mapi id 15.20.2958.030; Thu, 7 May 2020 17:38:21 +0000 From: "Ananyev, Konstantin" To: Honnappa Nagarahalli , "dev@dpdk.org" CC: Ruifeng Wang , "Feifei Wang (Arm Technology China)" , nd , nd Thread-Topic: rte_ring work Thread-Index: AdYj2/yEUDvXLCvbSjmLQfkOx8WHHgAfYkpwAA2yNXAAATxDAA== Date: Thu, 7 May 2020 17:38:21 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.188] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e392a0b3-0efa-4dc6-9e22-08d7f2ad6ff6 x-ms-traffictypediagnostic: BYAPR11MB3575: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 03965EFC76 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /l6DnAgRIscqpFgxyWzW0T46E5Bpcs7+g9ZlVGutCOr/czjtb4O42F/k9F+dkc05+prgP3sx6byi0UNr+JEC9grnj0IKX4lbvVjABveZnX/aw97pzcLY5musGi6OG94lmv93zevVEhtX8zTg7ONUHjRee0Ai/rZ56ucENnWVFfi7XQWPNXY26IPMKH0wSEptYaaJ58qLqUg73BFp0mGu+oDcJXeTdOuYxvM86wEL3WCewcjOiaPNSnSqkj+XrWFpWawgCAR2t0Zww5a17IGe/QQ9aieyLVYrnu1fs+JalfKJtL76uWH1urry/4D5bWxnY9r3waPrX31NGGlWK5uGyw6UUUBZdAQ9npjQRzQDoVdp7lv/ZDHHqsfe1e84JhVjufDwjYXY/hn57Kugih2jG6q1G8Hb6e+PFNmt5sBuB21WhtyXLjUyECTw8GKYU4fOYr4IyXT3qwsQf9mpPaUFrhy3dkZTXD2odPvmf7TGqrCJtmrLIX6N4hcGmmz4lvPFmkHrXFL4c/a9JBUbrLm47ayy+kYui0jPeXiHTfQklvQCq7zEAb/e66njCm+yecTM x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(396003)(346002)(376002)(136003)(39860400002)(366004)(33430700001)(66946007)(9686003)(478600001)(33656002)(55016002)(86362001)(52536014)(4326008)(2906002)(8936002)(7116003)(8676002)(76116006)(71200400001)(316002)(26005)(66476007)(64756008)(33440700001)(7696005)(83310400001)(83290400001)(110136005)(186003)(6506007)(66556008)(83320400001)(83280400001)(5660300002)(83300400001)(66446008)(54906003)(21314003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: XvRND6d/gYUtVd+SYyflTz7umjAnr7Upk9S29MqKhWwSZf1ElutKqJn2gFr9JwgPX4GjXKlQzLOq11wmDLj6HMw39YhqcuMl/nv6mbhoLp6wA6QUwNJFVK3r1ZoEVLrk+SAMwuoPQcUiQHrpCWEOFShbR0RClVFYx91SbtvjFZPJD5yhpxdLczQXFqFZV9vHtpymnmiQ67HlK7RQsbusYPh9Tqtc5cBDlp9L+D/QntzaMM7wbgQCGKx+NE/H0WZLsFANnZy1/Mh2UwS4tBfYuyJatcul7E/eeG2QrnyZSAgFCoEZjiyKfLK1jCE+vSMwdLmoUjNwtSQ2JUoJVjuUd5Ar5J8o8sgN4QjFPXVpX8mBQ68XKGz9fgu7v5xVfAxet/Exfj37oHABmCULn4AtLc4oJy3rCCQzqkz8ZcMOsupYzguX7SCQSYPKDATIBumgXRqk9QfVcr//K2ujgM+xSPsfCiH0yYmdF+mkwLhg4vy4NzWhEWn/PSzAyIPuPHZPEdSt3aCseWfNhF7IlNJJSqG78HLX8xUC1CHKcRAtRKkdqUty2RKjjpugJNSq5cc7ZAvaUEfxPtHg9zQEx111VJ2T3nOWKvyAHCT0mVy6Zoup5toCclVgc9hjR1ym3dMOT2Mz18bCYGR1oK2w3MZ2b+FckOntyyrG4uG9UKTVZfhAdfAtd6HoixYQXe7fAl6wM715Cibot7lLcnC5QAkskGWs7UHzMloniGiwtCfB1xIhJPf0ebAf5lWNDXqAOIkrfG1SzqoBMtBZ5nLrI/RziPJMs5AtC8WN6CkYqSI19czQcD6XhIjuY085bGdmXPrd x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: e392a0b3-0efa-4dc6-9e22-08d7f2ad6ff6 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2020 17:38:21.6372 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: H0gUJhR/CS0GTOg/a4tC0VqBgveGeqN5LpKWLGXeo1x+ZKVtvF/ROrllyMpAvBt9SDC6evZ5oyvCsRk0D46luKw9sm4bi/CwUNMvwKOYzDs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3575 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] rte_ring work X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > Hi Honnappa, > > > > > > > > Hi Konstantin, > > > Just to make sure we are coordinating the work on rte_ring, I plan t= o > > > get the following things done for 20.08. Please let me know if you ha= ve any > > comments. > > > > Thanks for sharing your plans. > > In general, looks reasonable to me. > > Few comments/questions below. > > From my side - I have just few rte_ring related plans for 20.08: > > 1) Try to integrate hts/rts ring mode into mempool_ring (new flags for > > mempool_create or so). > > 2) Use peek API into crypto/scheduler PMD. > > 3) Plus few ideas how to improve ring performance in particular usage > > scenarios. > > Don't know yet would it boil to something real or not (might be new syn= c > > mode or so). > > > > > 1) Remove experimental tag on rte_ring_xxx_elem APIs - they have been > > around for 2 releases now. > > > 2) Make the legacy APIs use elem APIs > > > 3) Check the possibility to remove rte_ring_generic.h implementation. > > > This can be done if the legacy API performance between the generic an= d > > C11 implementations is not much. > > > 4) Peek APIs for RTS > > > > Due to nature of RTS I don't think it is possible to implement peek API= for it. > > But might be I am missing something here. > I think we have talked about it, probably a patch will make it clear. Ok, will wait for the patch then. =20 > > > > BTW, do you guys plan to continue with WFE API adoption in rte_ring? > Yes, we plan to. I thought you might not be interested in it and removed = it here. There are new requirements on the rte_wait_until_xxx API > due to the new sync modes. We might have to revisit the API definition. >=20 > > > > > Some cleanup activity (assuming above things are successful) > > > > > > 1) Remove the detailed comments on top of the internal functions - it > > > is hard to maintain, the parameters are already self-explanatory > > > 3) Files need some re-org > > > a) rte_ring.h, rte_ring_hts.h, rte_ring_rts.h, rte_ring_peek.h - wil= l > > > have legacy format APIs written as wrappers around xxx_elem APIs > > > b) rte_ring_elem.h, rte_ring_hts_elem.h, rte_ring_rts_elem.h, > > rte_ring_peek_elem.h - will have xxx_elem APIs > > > c) ring_elem_pvt.h, ring_hts_elem_pvt.h, ring_rts_elem_pvt.h, > > ring_peek_elem_pvt.h > > > - these will contain the internal functions including the c11 > > functions to manipulate the head/tail pointers. > > > The files with xxx_c11_mem.h will disappear. Make sure > > private > > > functions have __rte prefix > > > > Basically you'd plan to: > > a) rename rte_ring_*_c11_mem.h to rte_ring_*_pvt.h > > b) get rid of rte_ring_generic.h > > Correct? > Yes If there would be no perf drops, I have no objections. Though recently there was a discussion is it ok to remove dpdk installable headers (even ones marked as internal). =20