From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51DC5A0352; Fri, 8 May 2020 20:05:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CFC881D711; Fri, 8 May 2020 20:04:59 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id A4A421D706 for ; Fri, 8 May 2020 20:04:57 +0200 (CEST) IronPort-SDR: uxSjMgx7XTQOoeyIX3ZB9qQPrvG7/fl2Il+SW/zfXQTJk9DNHTqsQOAsU7REkUOKUmDoxjBMQq I0n6bTdVPLQg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 May 2020 11:04:56 -0700 IronPort-SDR: XyQ4o9Xv1is0PQ5mqlWqCibYqScZMlp6AT73IgLcDdT7QLZ2dH0/x71R9h4Tp/cee6vJhgRMwy ahQlZVqmi8QA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,368,1583222400"; d="scan'208";a="261073816" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga003.jf.intel.com with ESMTP; 08 May 2020 11:04:56 -0700 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 11:04:55 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 11:04:55 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 8 May 2020 11:04:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RPI84LUsjTSxtmshtjNrF+E1uJ5e5NzC6HXAd9ykPAdDT9rOUpk9+ob8w9Ddzrm3VF5ktSwo1I621ixOFWLlxPAAekMErcwBHhJ1dKcQ8MqJCfsDH85lcSWOyxkaT6OsnsY5aVx7S6u7UtgS1kaqCI5cd7UizHroD4jfaqaJYgMNV1y86AgEZTbak4IpIpyyLbfwiI+kooq4gXIj69+Lazb5ZPapwQS4usISU5Z3C69ARxO3/UBiErHzboLstejaiKOuteI0EWZN/WBBZWSjIIAu4rP2RW/rntmhi+zVaOiUFad6OoclvaD8OZI+1LxH0JG90hiNQ841x1hEZqTVdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w6Zx7Ad9kz8niBDh5zKZhDp+87Mu/PHFaHOpS1kq0X4=; b=EWYPZAXrQp0nRsBnXwn75P2H5gJyRp+KOf9uGGs2it3v+VWN6t/a1kks2AHpy1dONzcEKpk6cGtSotijTCySNRutqA288c92IYO18xM8Yv1ylgCFZJWGHeWJt4O5VlDNwAJdx+rRdGEzVEW7tNkz3freeTdk/cEBnr8CFzugRB0Pk7MHKkhtHH7nWARfQbNm7D8IQIyM/BuDGxFvDIAmwT9fhj/HMSivF/1ngBJFpeixVn3F825wTDppK0vQSgT+6fAbx9Eu0RRFp5RyV0WXNJk5KtagGHMIPpZ7evoLrqSuIzwsW16wnRAkMYT/Uprl5e93qWf3x1q4uFmm/fzNcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=w6Zx7Ad9kz8niBDh5zKZhDp+87Mu/PHFaHOpS1kq0X4=; b=lKzBf5AR53oxRqidso0805UdXqveilTBoJHNyERpZoOS/QYh2hCujeKHjrbnBw7eqWqR6OqmlY8s4HL/V9lZie/RnLA1Nr8JIrAGXnRHAxhYSlpjl4Cn5q5gEs2A73BAWOTtO5TOXfLCRP9L3nBmihO6N4rlsJJKSJchMJZkylE= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB2822.namprd11.prod.outlook.com (2603:10b6:a02:c8::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.26; Fri, 8 May 2020 18:04:53 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4%6]) with mapi id 15.20.2958.035; Fri, 8 May 2020 18:04:53 +0000 From: "Ananyev, Konstantin" To: Honnappa Nagarahalli , "dev@dpdk.org" CC: Ruifeng Wang , "Feifei Wang (Arm Technology China)" , nd , Dharmik Thakkar , nd Thread-Topic: rte_ring work Thread-Index: AdYj2/yEUDvXLCvbSjmLQfkOx8WHHgAfYkpwAA2yNXAAATxDAAAYeeugABA9S7AAClJ08AAAaJ2A Date: Fri, 8 May 2020 18:04:53 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.175] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f35e5b17-8a6c-4e0f-2659-08d7f37a4f52 x-ms-traffictypediagnostic: BYAPR11MB2822: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 039735BC4E x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: C8/ZNKRl0jL+EtYhyrxbyFF/p7xcPQBooKyy+0diH16jg9sVFA+9hfBc+a66NvuRoKpU43Q28txdTWMFRYxbteBSmMbXcOAnyYLZREXChfVmYMNNl5GoN+PhaD+mqgu0rX7vvELlLC/xVafzRywvPJHNnft/s4YZOhAbhiLTvZ7vSZTge2OmYDmoaIvpuhx8aqciIoixNw6mum0bS/n1/BAqY6bgO9D1S2GErCqYoSzPDd313W9XKb0KQAJ3tBUtlYaZ+tf0zRrwFq7lYsEvA6GdqGNupT/BwlM4bo2pWCErbfq5R0GSNnszzCHivN/ahOYK8JeIZI5rFlTBZb2J1WzzokbFL5LAsAelosty8rHRMX1ZDPIm1A7FoZutcmDLp9yKihiAV1mmRWVewt2nwdQ3wpmXr4OUcYYR6xVfwIpaAcODO8vXcnHrykGFT7Iv3BgD3Rpvj0/WXbWkAXo5azLag8HONK1q/BwP6hNvhzdGURRkiaZaNlVwVF3R6RDyKhqKWfuPZ3wWuIznxhTAcNwIngZ61KeAzLgZRPrRXR7ic8ijy3eu/iSccJ98DHU9TYhwtosVxJyieV8uwJIk6TldypmOU/Hdp9VQFoI2G58INGs+42VRv7lMJLE1r9xq x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(376002)(346002)(39860400002)(136003)(366004)(396003)(33430700001)(4326008)(316002)(7696005)(54906003)(110136005)(7116003)(33440700001)(71200400001)(33656002)(66946007)(5660300002)(86362001)(2906002)(55016002)(9686003)(8936002)(478600001)(83280400001)(66476007)(8676002)(966005)(83320400001)(6506007)(52536014)(26005)(186003)(64756008)(66556008)(66446008)(83300400001)(83290400001)(76116006)(83310400001)(21314003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 92lJjLsC7tPxgysMo0KVEvDSZPiumZ+Mq/5XkCo8KWjDtlgILSHrYggGvuB2f8EGNdLjWtRyUiiYya69vf+96zIYdbDDcz47qvo7h2MTns8G5t1cqWsqCXvlRSouyngswhe8z563PJqwTwleQwhGEaPc+zO6PrjTl7Qdhr+s5x3rhJbH8HnHKsVV4gVjfeA60i7geiSIA+VR0lrKXySkIGgqUoqHVtg8smBEu9PLwrskTX4OYKAucfJOWsHlMG6ZkC9OaHneSfm4UtTmW5jIyMcAf15Tmjx7HUuI41AkYUGOyq6fbuDUbaivuOEblVdtPUKdMdaUuUppEAy8mj5/5c9dBcmHKMQ1taFUi40MSIx+tVU1xlRogDn8ScrkgMZA3Nrp7GFRDYoXd9EAVA5zodeg1xLeg+ydZR/8tKQNxxwtdqyfazB/IYD+i2uvyD/rflJ1UAZ76ENRRI5deuVaaZrx87JUffH83iA+VGlw8jCTQYRYgQdFfPSe0NF1Ff6o x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f35e5b17-8a6c-4e0f-2659-08d7f37a4f52 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 May 2020 18:04:53.7798 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: R3XAkAZVF7Wgnj5Cuhvi43AfY0w8Aas28NKDOF06V4Z8GbAmogJcDTxrn3GMYuZuwCAKYjHepn9TIpmkDus/NBRMb6gihTtWcgJGa2+iidI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2822 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] rte_ring work X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > > > Some cleanup activity (assuming above things are successful) > > > > > > > > > > > > > > 1) Remove the detailed comments on top of the internal > > > > > > > functions - it is hard to maintain, the parameters are alread= y > > > > > > > self-explanatory > > > > > > > 3) Files need some re-org > > > > > > > a) rte_ring.h, rte_ring_hts.h, rte_ring_rts.h, > > > > > > > rte_ring_peek.h - will have legacy format APIs written as wra= ppers > > around xxx_elem APIs > > > > > > > b) rte_ring_elem.h, rte_ring_hts_elem.h, rte_ring_rts_elem.h= , > > > > > > rte_ring_peek_elem.h - will have xxx_elem APIs > > > > > > > c) ring_elem_pvt.h, ring_hts_elem_pvt.h, ring_rts_elem_pvt.h= , > > > > > > ring_peek_elem_pvt.h > > > > > > > - these will contain the internal functions including > > the > > > > > > > c11 > > > > > > functions to manipulate the head/tail pointers. > > > > > > > The files with xxx_c11_mem.h will disappear. Make > > sure > > > > > > private > > > > > > > functions have __rte prefix > > > > > > > > > > > > Basically you'd plan to: > > > > > > a) rename rte_ring_*_c11_mem.h to rte_ring_*_pvt.h > > > > > > b) get rid of rte_ring_generic.h Correct? > > > > > Yes > > > > > > > > If there would be no perf drops, I have no objections. > > > Agree > > > > Though recently there was a discussion is it ok to remove dpdk > > > > installable headers (even ones marked as internal). > > > Do you remember any conclusions? I tried to search, could not find th= e > > discussion. > > > > http://patches.dpdk.org/patch/69560/ > Thank you. rte_ring library has called out clearly if a particular file s= hould be included or not. If the users have included other files despite > that, may be DPDK should not be held accountable? Agree.