From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F14B0A04C3; Mon, 28 Sep 2020 13:21:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A25121D8FD; Mon, 28 Sep 2020 13:21:48 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 4D3951C0D0; Mon, 28 Sep 2020 13:21:45 +0200 (CEST) IronPort-SDR: NMjCrz8js/9ZGajATN/J5t5Kb2kzh9aZgNty6mogYYneFIi9ifPprAx7OrC1sfyzUVejb94lnY 5ppxo39zswXg== X-IronPort-AV: E=McAfee;i="6000,8403,9757"; a="246717572" X-IronPort-AV: E=Sophos;i="5.77,313,1596524400"; d="scan'208";a="246717572" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Sep 2020 04:21:42 -0700 IronPort-SDR: 5QdWg/XcFR3X3X9LTW2eTVJ7pV5dGLyxnvGgPCviT1ERncygVl3hOxCx8dvAE+YGdZ+3knSkMF BHW0gsgTq+vw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,313,1596524400"; d="scan'208";a="456786149" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga004.jf.intel.com with ESMTP; 28 Sep 2020 04:21:42 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 28 Sep 2020 04:21:42 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 28 Sep 2020 04:21:41 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 28 Sep 2020 04:21:41 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 28 Sep 2020 04:21:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KmOE+L6F9E76/ZfGB03Z4+xa5B5ZT7FU2FF+5xGTnwqIVntvjiulH9X/BkrAytELRQUlvNQIlRmOV6Ck3mTxpTpYPIunwSWUN7p9mStx2zHq4Ag9eJI6kVT3dEQKlU2Ed+me04pM/MTbByy3S3xSmSN2piem6RsDMVKQDctjlrZoscgYE3wiz6D+0gVneRP/ooVb+9+crYYHjilHLYteSkh2Jsls2F7ouBzBVfPKMs7uKTy4hAx0MX2quH87sDlFaoQF7PiLtcImJj83YANuFDcyAdfopKPJKswDRRLoRU8ArsnUe6NLUtnl9aW4QcrZjsai+C61evuPfBzVHM+Wvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I8Kgt5bV8f0oL6/WwHNvNwZ5lQIubHRWFwrVvJ6B1ak=; b=MFGze57TB4bLYUvJhMddbPoIRnCZ7xr3NXFw3sLLnahi7+c6sA/CHp/7arLwpY+Q8mv8yOuEHn0+gqT4Ac35AqiqEdtjo7ZDx+8+7c7chQL+4GV5Zqy/AsPaUUwjGdSFm8kUjuDiVbbVyz2cM/E+74+VQIBH8RRZk0gB2hDBtAV8JGMx6tG//gzDEml/xqgj/f6zUan8CH3aZHSmP6LxMpVBxgQQujkO/uU7vdTNMXRcXeH5Rx6NwSskq5liq2Pyy23Biu5QIPNXOWUWOXj7xF5Ot6tbDjAXt0W/cFedWULvqKPOdvRATIftU+8gOqlS5FqKKUso584pYtMJY7l6dg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=I8Kgt5bV8f0oL6/WwHNvNwZ5lQIubHRWFwrVvJ6B1ak=; b=K0NRZCyT3c7MnMLJ55ICCDVteSsco+HohV+qcKGD5KAW8jIZg2ubEvgYmzyYRFIhfejS2pSZYgbvXjASZiMCZSrBL4AfpPnea+YzLeqY++d5MiSeF+U2c4DOsWENHNjHLxIO6suLe6l92GoOxeWOhgtK1E6pJRb3ld8Ar2bDL3s= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB2838.namprd11.prod.outlook.com (2603:10b6:a02:cc::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.25; Mon, 28 Sep 2020 11:21:37 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f5a4:3f6b:ade3:296b]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f5a4:3f6b:ade3:296b%3]) with mapi id 15.20.3412.026; Mon, 28 Sep 2020 11:21:37 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon , "dev@dpdk.org" , "techboard@dpdk.org" CC: "david.marchand@redhat.com" , "Richardson, Bruce" , Ray Kinsella , "Neil Horman" Thread-Topic: [dpdk-techboard] [PATCH v2] eal: simplify exit functions Thread-Index: AQHWlSqSB4bpskiaiUmwP+xqBZ5R+6l96ADw Date: Mon, 28 Sep 2020 11:21:37 +0000 Message-ID: References: <20200624093627.2603992-1-thomas@monjalon.net> <20200928000049.3245920-1-thomas@monjalon.net> In-Reply-To: <20200928000049.3245920-1-thomas@monjalon.net> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [46.7.39.127] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a034f297-572c-4e78-438e-08d863a0aa38 x-ms-traffictypediagnostic: BYAPR11MB2838: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ii5+X2YamyRW7zD/7Y2aefR2gvnrLQdHjvFCNYdwERN6F1Pvwu4k65dCv0w7AD/4S4JbaVqo9PeeaZ3E2tDDah3oOvCLwIPOuKJr/mfDolmgr/z3rpH+pxHm8iH3Dqe3LxI4NDZsJ4If9PQ+itE62nTx4s7o7dE/Z1rc4X7sCUNZj8OIInH2uPdxskfx3hN+dQYMZjEXciBiEeU5/nu5vRuD6mZAI/quiJLsyWLoEvesB1aETfzjWA9KfLV7zl4qVmkK/B773JhY2gcfw27NX1VqUcMlTY4kDYuHnPjDCtCRcytYs2BSSoKgkjFA9ypdpkBz7pS67wdSW6Zr+5DCr7OpxVcgMQM6VYF0+2gDPxvbNDrOItnn2wOSqOp87D+k x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(346002)(39860400002)(366004)(396003)(8936002)(7696005)(478600001)(9686003)(316002)(186003)(76116006)(33656002)(86362001)(83380400001)(66446008)(64756008)(6506007)(26005)(66556008)(66476007)(4326008)(5660300002)(66946007)(54906003)(110136005)(8676002)(71200400001)(2906002)(52536014)(55016002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: BFj7M/4nfvElCZwJERl62QKHrTmHNWz5Bfo4N+4b7ZqolRGdxDWewHtWoYQmLq/jxPRsyhU7KyskQ9pDC6QVl7exCEl43+OsgiT9CoYhnBb7QPPYAxhaeULRPQoM9p4pcnv7hfa2KnJgiG1l6dpKy8NLwG/fFsyw44LzyZ6N06ULTHuXp2ZePZpjqJPaBzONfsIVcekbKYp7WyJS4ZRPEejoah5m9y692CtxWriGt+V/dsMPtRvJXd7O2mMhcTl9PTMNYuz1t03tI7vTDxftVAsEGznokqAyhXo1F2y5BitxiMrMONgT8mrJRNHRjoHFmPdFUun8yrMLggRmsQe5vwFMT4WewpjIVWPtPfAOm3XEtX6UMK9rS2bs7OJv57pFM/ZXIZcXPLLfHu9dbEDNaN3YK68chmeRgaCzuqIvF0RFXK3xZnH8SVioQwvFqjknYovicH0/iEzZV5quLQSNk6V0T+QazVUd+/nByzgg9fikGrh2ems4TAOVaYBbHU28CIr21A1h38G3LUNXvaGSi+tz7kJKBxa2qOADfH+PjKtWfwXYnWZOHr+ZV7lWdJkgofpHcTx7S9DCswDN6iHlnqP7+uQ9EJwsvQLZ+nMz1vXGwgcXwrdMn1KiRtlzMrP//p03aFnd2gPsdnhI4A6BVw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a034f297-572c-4e78-438e-08d863a0aa38 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Sep 2020 11:21:37.2997 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UuhirVnMokOJefx0MPMsD3G2qsVnZweC/o8ZTmXkO6MdEVsAv1tpySrhsvzaCYUUoL1MO43Y7Hfro/5pXUvij+X+blLrg3UYFJlWCOlOTSM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2838 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-techboard] [PATCH v2] eal: simplify exit functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > The option RTE_EAL_ALWAYS_PANIC_ON_ERROR was off by default, > and not customizable with meson. It is completely removed. >=20 > The function rte_dump_registers is a trace of the bare metal support > era, and was not supported in userland. It is completely removed. >=20 > Signed-off-by: Thomas Monjalon > Acked-by: Ray Kinsella > --- > The deprecation notice for this removal has been missed. > I assume it would not hurt anybody to remove this useless function > from DPDK 20.11. Asking the Technical Board for confirmation. > --- > app/test/test_debug.c | 3 --- > doc/guides/howto/debug_troubleshoot.rst | 2 +- > doc/guides/rel_notes/release_20_11.rst | 2 ++ > lib/librte_eal/common/eal_common_debug.c | 17 +---------------- > lib/librte_eal/include/rte_debug.h | 7 ------- > lib/librte_eal/rte_eal_version.map | 1 - > 6 files changed, 4 insertions(+), 28 deletions(-) >=20 > diff --git a/app/test/test_debug.c b/app/test/test_debug.c > index 25eab97e2a..834a7386f5 100644 > --- a/app/test/test_debug.c > +++ b/app/test/test_debug.c > @@ -66,13 +66,11 @@ test_exit_val(int exit_val) > } > wait(&status); > printf("Child process status: %d\n", status); > -#ifndef RTE_EAL_ALWAYS_PANIC_ON_ERROR > if(!WIFEXITED(status) || WEXITSTATUS(status) !=3D (uint8_t)exit_val){ > printf("Child process terminated with incorrect status (expected =3D %= d)!\n", > exit_val); > return -1; > } > -#endif > return 0; > } >=20 > @@ -113,7 +111,6 @@ static int > test_debug(void) > { > rte_dump_stack(); > - rte_dump_registers(); > if (test_panic() < 0) > return -1; > if (test_exit() < 0) > diff --git a/doc/guides/howto/debug_troubleshoot.rst b/doc/guides/howto/d= ebug_troubleshoot.rst > index 5a46f5fba3..50bd32a8ef 100644 > --- a/doc/guides/howto/debug_troubleshoot.rst > +++ b/doc/guides/howto/debug_troubleshoot.rst > @@ -314,7 +314,7 @@ Custom worker function :numref:`dtg_distributor_worke= r`. > * For high-performance execution logic ensure running it on correct N= UMA > and non-master core. >=20 > - * Analyze run logic with ``rte_dump_stack``, ``rte_dump_registers`` a= nd > + * Analyze run logic with ``rte_dump_stack`` and > ``rte_memdump`` for more insights. >=20 > * Make use of objdump to ensure opcode is matching to the desired sta= te. > diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_note= s/release_20_11.rst > index f377ab8e87..c0b83e9554 100644 > --- a/doc/guides/rel_notes/release_20_11.rst > +++ b/doc/guides/rel_notes/release_20_11.rst > @@ -184,6 +184,8 @@ ABI Changes > Also, make sure to start the actual text at the margin. > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D >=20 > +* eal: Removed the not implemented function ``rte_dump_registers()``. > + > * ``ethdev`` changes >=20 > * Following device operation function pointers moved > diff --git a/lib/librte_eal/common/eal_common_debug.c b/lib/librte_eal/co= mmon/eal_common_debug.c > index 722468754d..15418e957f 100644 > --- a/lib/librte_eal/common/eal_common_debug.c > +++ b/lib/librte_eal/common/eal_common_debug.c > @@ -7,14 +7,6 @@ > #include > #include >=20 > -/* not implemented */ > -void > -rte_dump_registers(void) > -{ > - return; > -} > - > -/* call abort(), it will generate a coredump if enabled */ > void > __rte_panic(const char *funcname, const char *format, ...) > { > @@ -25,8 +17,7 @@ __rte_panic(const char *funcname, const char *format, .= ..) > rte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap); > va_end(ap); > rte_dump_stack(); > - rte_dump_registers(); > - abort(); > + abort(); /* generate a coredump if enabled */ > } >=20 > /* > @@ -46,14 +37,8 @@ rte_exit(int exit_code, const char *format, ...) > rte_vlog(RTE_LOG_CRIT, RTE_LOGTYPE_EAL, format, ap); > va_end(ap); >=20 > -#ifndef RTE_EAL_ALWAYS_PANIC_ON_ERROR > if (rte_eal_cleanup() !=3D 0) > RTE_LOG(CRIT, EAL, > "EAL could not release all resources\n"); > exit(exit_code); > -#else > - rte_dump_stack(); > - rte_dump_registers(); > - abort(); > -#endif > } > diff --git a/lib/librte_eal/include/rte_debug.h b/lib/librte_eal/include/= rte_debug.h > index 50052c5a90..c4bc71ce28 100644 > --- a/lib/librte_eal/include/rte_debug.h > +++ b/lib/librte_eal/include/rte_debug.h > @@ -26,13 +26,6 @@ extern "C" { > */ > void rte_dump_stack(void); >=20 > -/** > - * Dump the registers of the calling core to the console. > - * > - * Note: Not implemented in a userapp environment; use gdb instead. > - */ > -void rte_dump_registers(void); > - > /** > * Provide notification of a critical non-recoverable error and terminat= e > * execution abnormally. > diff --git a/lib/librte_eal/rte_eal_version.map b/lib/librte_eal/rte_eal_= version.map > index c32461c663..cd1a90b95f 100644 > --- a/lib/librte_eal/rte_eal_version.map > +++ b/lib/librte_eal/rte_eal_version.map > @@ -38,7 +38,6 @@ DPDK_21 { > rte_devargs_remove; > rte_devargs_type_count; > rte_dump_physmem_layout; > - rte_dump_registers; > rte_dump_stack; > rte_dump_tailq; > rte_eal_alarm_cancel; > -- Acked-by: Konstantin Ananyev > 2.28.0