From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 27526A00C3; Fri, 15 May 2020 12:00:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E50D31DADE; Fri, 15 May 2020 12:00:52 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 741FF1DAD3 for ; Fri, 15 May 2020 12:00:49 +0200 (CEST) IronPort-SDR: 9ojkUVnDU3upqxPX3VqaGfEYfdI3SxFkSsmoFjg9dqx36VAjQhFClcu8U+RmYgHXvo3FtF0FiM jUQebIya7R5g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2020 03:00:49 -0700 IronPort-SDR: eZ3C201/QO0V7767VyDijOe/hcxkE8FM9iiBPv+8sm9c35H0UM8JWwdbZLJ+1yteK7gs/HHqQr qH7qRSEA9seQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,394,1583222400"; d="scan'208";a="253753993" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga008.fm.intel.com with ESMTP; 15 May 2020 03:00:48 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 May 2020 03:00:48 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 May 2020 03:00:48 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 15 May 2020 03:00:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MJnD+iBRkXbThvv9ECjrDAJb2qluS7OJV3122+TZtLMlXazRh/G1sJK7VI7m4EPw9SkmBIZlxtHNl/PmA7Fkf7QGGIBdefIasrNnRNe2jWW1evnv5VQEXF4xpK7oQcyU3PdTZ707qN4o0edw2d2R98aFjoeNiUMkOtCdySLdYP0qxxv3c39g1bMyURWC8kCW3KjaMLCqVhyTdPv8NLAkq16kTFzN4uVVpcOdS+pvcPMBwomjI/CWYv6AkB6QpVHozWihSi+c7ENIEh6x4F0gRUFE3UGsDFS6pKdkalhNp33OW1skUM8XwSyZJVjLTXxpBxQ4mTkt+3dgHW7OmHkrcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gm6XF0fCyk6ZpjKbalRjNKS2BYhng7UCJhdqPlJAzZE=; b=PMZ4TrCwXjOyptR1EGAxQLDAMq1ay8HEQsFvF07ykkq2gkVXrPVU3ty6Z7XHNbcXtFZc1gXl3/6OYaJywq5Ax/Gytw0b0PQDQVznYdoJGKeGYW+rQVAag6Umhf03+1bEIbADqGuGrW/YcsAyECeHipUFzOjoLy557FWjLXVTUWhfoO1nGDHhqs7SUMGQov3WEkdmcpbNrQikVat6SterYPaIbTr8t6G+Jm7GzV6vQuzMCs6af7u3ny3c6As0wUUyBy6fUZ+S5ydsLCxqcIziZv8QWMfQGvr/GZYfr8thDDDR9fmSd4eHHWHJ+POjFYkfFibUlWI57VgB4KY9Jr+KtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gm6XF0fCyk6ZpjKbalRjNKS2BYhng7UCJhdqPlJAzZE=; b=Y4GITVHWnaZ/9AJqQAEZ/vUZdrK3qsm8t6Gafb74GOkXUECdsz3qGSVuis0IcKTEromx2RWuqODhJzALWUKby4gVQNeGbdE6T1+fQG3y5myD2P/NBNE3chXtrSdweLkOxvHUbaf2p301lKX52a9xgYbF5A6Dy58Ye3Hq3bzMWUI= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB3638.namprd11.prod.outlook.com (2603:10b6:a03:f8::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3000.26; Fri, 15 May 2020 10:00:46 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4%6]) with mapi id 15.20.3000.016; Fri, 15 May 2020 10:00:46 +0000 From: "Ananyev, Konstantin" To: Apeksha Gupta , "dev@dpdk.org" CC: "Ruifeng.Wang@arm.com" , "Doherty, Declan" , "asomalap@amd.com" , "anoobj@marvell.com" , "Zhang, Roy Fan" , "Trahe, Fiona" , "rnagadheeraj@marvell.com" , "adwivedi@marvell.com" , "jianjay.zhou@huawei.com" , "De Lara Guarch, Pablo" , "Dybkowski, AdamX" , "akhil.goyal@nxp.com" Thread-Topic: [dpdk-dev] [PATCH v3] Test/crypto: check valid test_stats before running test Thread-Index: AQHWKo5rU/ezUbzZkU6WxzwUhHaBfKio6buw Date: Fri, 15 May 2020 10:00:46 +0000 Message-ID: References: <20200515073242.24720-1-apeksha.gupta@nxp.com> <20200515075606.25709-1-apeksha.gupta@nxp.com> In-Reply-To: <20200515075606.25709-1-apeksha.gupta@nxp.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.183] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 338e213c-4200-459a-a7b6-08d7f8b6d68d x-ms-traffictypediagnostic: BYAPR11MB3638: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-forefront-prvs: 04041A2886 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qgNS1+NiNNdKZ8gICJJHLw6G4/qdREAISFISqUiMKKOEM3BmH1pnXkxfqzQKcGVXVQYo5crHghVLFRyTXJLBpW3x/2MQK1o0NdC9WaJ+y3qull1y7uW5qL0yWi75/0CuNmcpH66FTVfkncxKa9yL2ILA+XiD1yVFrqmBfoBlwd7W5dNcIByEcvjU4GLDc1LiuI265rk2m5RiyYUUKviYpai9SM7j/BubsmhRLRjCVZEIhT3+KN9m9X4Q51EYdtnI3Rb4e6BOd/EvEeykaJGM0jCwMcSFUBvpmmrJHXh7DfxcNdXK3OcbzWVjYtt3kDd5c4+WDkThS+4m7Rhp1jTi9iNMhov4JR0Pk0EHuFddw3NWJ5wRScGAQvxiyS8jKvgJEe+23NXd+4axBxVlCKH67uzZudlW/vliZ5WPFiOlCWJ1JGCUpEj5YWI1n+rUbf7y x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(39860400002)(366004)(136003)(396003)(346002)(376002)(4326008)(55016002)(9686003)(2906002)(33656002)(66446008)(52536014)(5660300002)(66556008)(71200400001)(186003)(64756008)(66476007)(26005)(7696005)(6506007)(76116006)(66946007)(478600001)(8936002)(86362001)(110136005)(54906003)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: xyFJSPA8p1ESfDDVfoSQhgVscvfdKnKhNwRtL1rZE7a0gcXnt8mL1Ot2hfYMn8eLRsmUG7M0gOI7bOQKn9uYwptS6ccMYlEPAms11wrkovn74W2V0KBt93euABaK+xUSyEQQUCbx8zexdiTMjN7c3T8ixoXaq9tFcIjoBwSOWabVrNRFe7Xt8WHogFqqB+2QFROwIuP9hYuvDi5Ucie5+fHgoA4bHa0LqVYCJMVYiV1JNY3levD611vmQH6fnIcG14bYCRkF0CyKl024M0Xe+HXdKTCxqUFfVdC2r5j4OVBIUzstZL+k7+mrDmM9YfURYD1synVUhsZAeWRb4ESUuLuOPf8os5ycV2aua1y2LTI76b8IY39PFM3DfMGcO29igHNYCsX6ZYY98kbAub9Gmn+PsJD45YQzhKkwImBLIot3QU27YL2qPuZptUBqUq9wzbK82NgT7omVtVRXeqk59oF/xSm2qdZweAlYxah8pR9573HB3e8uo4DrfbRJNXpq Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 338e213c-4200-459a-a7b6-08d7f8b6d68d X-MS-Exchange-CrossTenant-originalarrivaltime: 15 May 2020 10:00:46.2379 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wzIuBlInsACZJCd19fEZMftlEQQY8KRb2LtaZmgUjv77vyjDfOy05RX/I7wY6WNmygBey0WqybW4lLCYt4KWHKTy3sgaiNS2oZ4HG1yfsNM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3638 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] Test/crypto: check valid test_stats before running test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Test_stats is an optional cryptodev op and if it is not defined by the > PMD, it should not run the test cases for it. >=20 > Signed-off-by: Apeksha Gupta > --- > app/test/test_cryptodev.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > index c624018ee..1ad650675 100644 > --- a/app/test/test_cryptodev.c > +++ b/app/test/test_cryptodev.c > @@ -8801,6 +8801,10 @@ test_stats(void) > if (gbl_action_type =3D=3D RTE_SECURITY_ACTION_TYPE_CPU_CRYPTO) > return -ENOTSUP; >=20 > + dev =3D &rte_cryptodevs[ts_params->valid_devs[0]]; > + if (dev->dev_ops->stats_get =3D=3D 0) > + return -ENOTSUP; > + > =20 rte_cryptodevs[] and dev_ops supposed to be internal for cryptodev (though in practice they are not). It is not a good practice for the app to access them directly. /* Verify the capabilities */ > struct rte_cryptodev_sym_capability_idx cap_idx; > cap_idx.type =3D RTE_CRYPTO_SYM_XFORM_AUTH; > @@ -8820,7 +8824,6 @@ test_stats(void) > "rte_cryptodev_stats_get invalid dev failed"); > TEST_ASSERT((rte_cryptodev_stats_get(ts_params->valid_devs[0], 0) !=3D = 0), > "rte_cryptodev_stats_get invalid Param failed"); > - dev =3D &rte_cryptodevs[ts_params->valid_devs[0]]; > temp_pfn =3D dev->dev_ops->stats_get; > dev->dev_ops->stats_get =3D (cryptodev_stats_get_t)0; > TEST_ASSERT((rte_cryptodev_stats_get(ts_params->valid_devs[0], &stats) > -- > 2.17.1