From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 61A2EA00BE; Tue, 7 Jul 2020 16:46:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AA22C1DE74; Tue, 7 Jul 2020 16:45:57 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 888AD1DE73 for ; Tue, 7 Jul 2020 16:45:55 +0200 (CEST) IronPort-SDR: WjnI72I4Dq/17h6gNIF7cdxiyX9OEqICXPSiV32wPARJUVHCeubBGZ+8J3XBS7mXzQfYR867dG +O4Gaf3kxXqA== X-IronPort-AV: E=McAfee;i="6000,8403,9675"; a="135073143" X-IronPort-AV: E=Sophos;i="5.75,324,1589266800"; d="scan'208";a="135073143" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2020 07:45:54 -0700 IronPort-SDR: wAqd27FEBTf9zwMJ6NJEqmY6LZ/ULyNW0aA9q3Yu4muNYEBdAadPjIUBqVW2XgP4U4Tr+ZFcMY U7aSJacLSstA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,324,1589266800"; d="scan'208";a="297407523" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga002.jf.intel.com with ESMTP; 07 Jul 2020 07:45:54 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 7 Jul 2020 07:45:53 -0700 Received: from orsmsx110.amr.corp.intel.com (10.22.240.8) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 7 Jul 2020 07:45:53 -0700 Received: from orsmsx152.amr.corp.intel.com (10.22.226.39) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 7 Jul 2020 07:45:53 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX152.amr.corp.intel.com (10.22.226.39) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 7 Jul 2020 07:45:53 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 7 Jul 2020 07:45:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FrrX8GHS5CSZF3CoIywypgJJ2TbyiwUzcfZiTse1auAPdv1lYKvVrqoy0Xvh7eyOtkhdO1Pw+kiiQKPtei8LetbFF6TK+N6XWvFcWFU3aOHjxSx2VOs/kSi5s9GAKOhOUaxeDLUr3Poi2R0FfFIWBCsmgx52qRTg/OHQ9hmiAwEDvULiuj1S3EWABYsxjYNpBQmuxOf8AecQKBguzkkWTYjaifWjl1DSzuiCQktTMZGgkgLlIRuHuHhQ+8kPtSGWJ/Bkbv1Ag7HpPZzKCQrMlLvB4E+6OKxfYBqlSHACIerQrRyRHIG6esG9T+8sAKVk1eT2jf6qJ0fEzkUzOi3UTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A2655TBIdz2xiXORCght5wyMeFbKlaG8uU3wyBjvfjw=; b=d2f5WUqQertax3+ZEs3MQEcPYf13Dj0aJKyF8FrQjIwdxrMPnDHuYlv7Q3d8wXIvm0H2JU8fTlFazhJcdcZ5cOnHoh55KJE7DyYQiREUBYKYUmzldg7PI44uFD+zbefl5yxh53yEmSQVg1CG4IUyJwIZyguSG2MVyjtKSTx4d1wu6o2bADX+EAwRDeity1UEAyZgIL8Wxamf1oW1J3UUsPxHcYc9uN9niPni+Lopceo+ehiStoSSodpGHhG6VJPCi7qmXFnA/a/xiiRetr2gPSp9t9KQmXWDh52/ZsqWPHybj0AKYMn/Yg0zlwXKRpWL1AhbfG5AjThlmNzOYwp7sg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=A2655TBIdz2xiXORCght5wyMeFbKlaG8uU3wyBjvfjw=; b=r3855o9pK6Ca8i3fRF1Av5wcFY+IzRzVMTjNvSTv5G6YKF3fNf9VXUv1YXyYBCIEoBuMVw7CVrhc8uPB3usa0/ScJfP9G7IITHeTS4eZ4sZdgZax2Al870m60eP0clVAQ812plnkZ658xhCluXwJagMU/wqORUguRWVMy4SkDcU= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB3671.namprd11.prod.outlook.com (2603:10b6:a03:b3::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.20; Tue, 7 Jul 2020 14:45:52 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f160:29ab:b8f9:4189]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f160:29ab:b8f9:4189%6]) with mapi id 15.20.3153.029; Tue, 7 Jul 2020 14:45:52 +0000 From: "Ananyev, Konstantin" To: Feifei Wang , Honnappa Nagarahalli CC: "dev@dpdk.org" , "nd@arm.com" Thread-Topic: [PATCH 3/3] ring: use element APIs to implement legacy APIs Thread-Index: AQHWUSSM8adxDbkzOUi+h3UPzGKBWKj8OAzQ Date: Tue, 7 Jul 2020 14:45:52 +0000 Message-ID: References: <20200703102651.8918-1-feifei.wang2@arm.com> <20200703102651.8918-4-feifei.wang2@arm.com> In-Reply-To: <20200703102651.8918-4-feifei.wang2@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.178] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c2cd653c-4fd8-46ff-def3-08d82284724f x-ms-traffictypediagnostic: BYAPR11MB3671: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 0457F11EAF x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i1UtbxleYaSBWR7PE4fJQF0EcaNBDLvRLbvv3B1uHTif0KwY3VyxTtz/xvreB2boOyIg9J1+8YfVXN3MYHQnUDsQLiLzMWqHXctrc/bqLtLlxRYSzMeCQ9ORSk7XXJVW4Z5IEu+k41dF4uaDtSemZJOIKyqUFIWaYMnTkBqcwjOym/fZ3fixHqtWjRq50j9fumoj7V+NWs72Cxg4hmuiC0YjtLKOt6B+cGhIS95aCMmZTuzOzGb6zlyRbFTDwro2+3SuHoc29hGRIZKWzOPxfjPBxmpPIg6HvgWeGzOgFhZoy+LPVmrIvPtFjmUPeKaMHs2wOxOBVtRsaSPH5qf1emY5ik8lZmgCzfeAQSF2urJI866asm37E5kSekxS++E0 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(376002)(366004)(346002)(396003)(39860400002)(8676002)(54906003)(2906002)(8936002)(33656002)(66946007)(66446008)(66476007)(64756008)(316002)(110136005)(66556008)(76116006)(86362001)(478600001)(5660300002)(71200400001)(7696005)(9686003)(4326008)(26005)(55016002)(6506007)(186003)(52536014)(21314003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: Cm9lLKVv5Osxr3jrZQ85UZKjjAs0SquRWPuIzCVzhF40MdS5gG4/UfFYRKItXuDNtUfPTIQTJv4kahRCETaBYfahAHWumVc5OI5jnfW3NI3UlIVizgUktnvE1F6i8bwR0S20+lJ7QuMGPw2w+bo7Y2Gi3FCiwnMY89FMKhlRS1NGhuBMWIwdyPJz63QhFRTuSwJHxakyqssrMq9j8CKBMfzRJLPqQOXHTeZJUywHTmzXgNxZj6hLeql7AAOE2tbaOXJYQJAQ4eTVsk3CHy4q/54y+KKOetaq9d8H2nbKoR6Cldb8PTRdHV8H3UEK9m+4QGQKBYc/SLbnlxFnq6bDf1cxZ8hRaYfVMlHE507jkDznDDfjI3rqLpo+7pcUhpYj0+uS30vilzxjuFN08efQ6eCLChZyowIqlbBBlbuiwC85loN9rAAj1qgUfF22qOTh66Q7FGBL9G6CmvaaHASlQAdTEXnz9ohRfypmPb2NUZgguZgErijsjyDFw0ABLdBv x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2cd653c-4fd8-46ff-def3-08d82284724f X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2020 14:45:52.0170 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kA3HBmQEs+DogYNNw+wcZVSIimHVdErkFvOLORxzwvvwD5embpAkWAXIKtnSV3+hMro0p+6EXgyl0y5IjHLUbBBdigV0P0DAx3MaOCQNQpc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3671 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 3/3] ring: use element APIs to implement legacy APIs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > Use rte_ring_xxx_elem_xxx APIs to replace legacy API implementation. > This reduces code duplication and improves code maintenance. >=20 > aarch64: > HW:N1sdp, 1 socket, 4 cores, 1 thread/core, 2.6GHz > OS:Ubuntu 18.04.1 LTS, Kernel: 5.4.0+ > DPDK: 20.05-rc3, Configuration: arm64-n1sdp-linux-gcc > gcc:9.2.1 >=20 > $sudo ./arm64-n1sdp-linux-gcc/app/test -l 1-2 > RTE>>ring_perf_autotest >=20 > test results on aarch64 in the case of esize 4: >=20 > without this patch with this patch > Testing burst enq/deq > legacy APIs: SP/SC: burst (size: 8): 1.11 1.10 > legacy APIs: SP/SC: burst (size: 32): 1.95 1.97 > legacy APIs: MP/MC: burst (size: 8): 1.86 1.94 > legacy APIs: MP/MC: burst (size: 32): 2.65 2.69 > Testing bulk enq/deq > legacy APIs: SP/SC: bulk (size: 8): 1.08 1.09 > legacy APIs: SP/SC: bulk (size: 32): 1.89 1.90 > legacy APIs: MP/MC: bulk (size: 8): 1.85 1.98 > legacy APIs: MP/MC: bulk (size: 32): 2.65 2.69 >=20 > x86: > HW: dell, CPU Intel(R) Xeon(R) Gold 6240, 2 sockets, 18 cores/socket, > 1 thread/core, 3.3GHz > OS: Ubuntu 20.04 LTS, Kernel: 5.4.0-37-generic > DPDK: 20.05-rc3, Configuration: x86_64-native-linuxapp-gcc > gcc: 9.3.0 >=20 > $sudo ./x86_64-native-linuxapp-gcc/app/test -l 14,16 > RTE>>ring_perf_autotest >=20 > test results on x86 in the case of esize 4: >=20 > without this patch with this patch > Testing burst enq/deq > legacy APIs: SP/SC: burst (size: 8): 29.35 27.78 > legacy APIs: SP/SC: burst (size: 32): 73.11 73.39 > legacy APIs: MP/MC: burst (size: 8): 62.36 62.37 > legacy APIs: MP/MC: burst (size: 32): 101.01 101.03 > Testing bulk enq/deq > legacy APIs: SP/SC: bulk (size: 8): 25.94 29.55 > legacy APIs: SP/SC: bulk (size: 32): 70.00 78.87 > legacy APIs: MP/MC: bulk (size: 8): 63.41 62.48 > legacy APIs: MP/MC: bulk (size: 32): 105.86 103.84 >=20 > Summary: > In aarch64 server with this patch, there is almost no performance > difference. > In x86 server with this patch, in some cases, the performance slightly > improve, in other cases, the performance slightly drop. >=20 > Signed-off-by: Feifei Wang > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Ruifeng Wang > --- Acked-by: Konstantin Ananyev > 2.17.1