From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F345A04B5; Tue, 12 Jan 2021 17:11:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D0627140E61; Tue, 12 Jan 2021 17:11:56 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id D87CF140E51 for ; Tue, 12 Jan 2021 17:11:54 +0100 (CET) IronPort-SDR: yxBhX6Jq/5kI+timlfoU71MZndsXVwrY2DTQYoa6N7ru8fqEX387F/fqF9ulPVCf7Clnq+o/Jv AwCF+giFO+sQ== X-IronPort-AV: E=McAfee;i="6000,8403,9862"; a="239605955" X-IronPort-AV: E=Sophos;i="5.79,341,1602572400"; d="scan'208";a="239605955" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2021 08:10:04 -0800 IronPort-SDR: wsvr19IdxbIqvceUUgDpsrvikSn19rNTvfs8VkUj20sY9073YBx9TxahrqmusEYCuUza+juWw/ hwGpBwi9PpJQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,341,1602572400"; d="scan'208";a="569127826" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga006.fm.intel.com with ESMTP; 12 Jan 2021 08:10:03 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 12 Jan 2021 08:10:02 -0800 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 12 Jan 2021 08:10:02 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 12 Jan 2021 08:10:02 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 12 Jan 2021 08:10:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T1eEgFUQk8fzcxNohlzz9iam12fm/pf6QD+vE3Vvn8zQZ4OXvklfFBLf6rKkCc0NBSzbVO5Iwu4TlI2iuG3GZVhKV19ozgHJqsnn13yAzAggfccLaVnwNhhlUiHXZQxcpXMtIvVtfCBss8V+NkzcIrpKK++fH6VrndIPc0QHtmhv74S0dYeCZqRhapPGqKTGVvJPKXSQ9+LGklsVMon28+KwW6uhtpJIH7LZxU7MiCBGlS21EnhD4SA7wShKijkagGZ49te/k47Lp8hILhZfUPg43UI+jMg9cTiqY931Ae/hUxlpOIKwiyZw9mxijTzbSkj7US9I0UV0r84LXZ0dgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eKLcPDc57KOnLHl+zlkuXZ7lmQ6qE0Ou+Z9leO/YrZo=; b=O49PcAZseYQs+og5mL1zeTRNKI2AxZG7Sxq5dYlNUkAYvro86TNVMXucy9jjiCyLX4GhuYnHuAxojQac/S9XDged9WWD5cm0n8JP0/yKTRga1r3HiU8X8rGJ6W04YLKQ3gtCcM0i5Wl5MHz4FcH281bjZp4jTFrTwwyze+aa1pgL95bLQ09jDu3rksMG0gpIkxziy3IskDhtgydiMJcyJBhwT0/z15pfzGMb7bd2g11OnsxISkXMC5x3SEhdEsJDW1AmFaLsO3s14bA4CTCliyzyzPuML4eIkrATtNp9vke92D8adf+pdMOpItiLvZn6l13GaQ3pCObby4fIWWwk4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eKLcPDc57KOnLHl+zlkuXZ7lmQ6qE0Ou+Z9leO/YrZo=; b=yh7U5m8o59048X+RirUM7P5kA81m6cSAm5bXPuF4nL+MRUqB73ZaQenVUoy7opPG1cjnpvo0g2SD12zVy5uD+DE/bahV6nwNCtYo9q2463OEq0wyQbUm1OLCdNJRyuyaQs45WX7njXazvdEts0q9cld/3fVzuu47Z808VsG1mc0= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB3112.namprd11.prod.outlook.com (2603:10b6:a03:85::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.12; Tue, 12 Jan 2021 16:09:59 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::1152:1426:8a4f:c755]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::1152:1426:8a4f:c755%4]) with mapi id 15.20.3742.012; Tue, 12 Jan 2021 16:09:59 +0000 From: "Ananyev, Konstantin" To: "Burakov, Anatoly" , "dev@dpdk.org" CC: Jan Viktorin , Ruifeng Wang , Jerin Jacob , David Christensen , Ray Kinsella , Neil Horman , "Richardson, Bruce" , "thomas@monjalon.net" , "McDaniel, Timothy" , "Hunt, David" , "Macnamara, Chris" Thread-Topic: [PATCH v15 01/11] eal: uninline power intrinsics Thread-Index: AQHW6CpTmXAftKdC80K94VtG8IyqVaokKbhQ Date: Tue, 12 Jan 2021 16:09:59 +0000 Message-ID: References: <18244c0453adf9a216f88e8edc14f1e68b53053b.1610377084.git.anatoly.burakov@intel.com> In-Reply-To: <18244c0453adf9a216f88e8edc14f1e68b53053b.1610377084.git.anatoly.burakov@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [46.7.39.127] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 06c63368-da73-4601-725a-08d8b71482be x-ms-traffictypediagnostic: BYAPR11MB3112: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NGbuK7a+nxu+UNC5uOGe+ZqN8fuo6xxR3p/3HOGUvR5xbsb34QECRwc3EFDE8SxkoX4rXWBbbug/i/DvfP3Rv+lQToTXL8O/0KbyilLZq3Oe0G8/sQUZEBZh+s6JRkugszClTAGqdH+R32VVQgW5gRo9dwARcc565x13HEomuNbLPYBphrvpbIkcIwYjK4DmV9ID/HEWw5Avs3vuvYifQjyIoVw+QlUt2xYykcoRgvRd7ajh/FOv0GHcNZa6hTNvQnCzbXSo92zzq2E2kVvEvpezwWhYc6vCyUZVcBUvi/zswOYwDnxC+rzjL+C3jVRellywWOmJ/pCHgBMF0N7fpX9F6OtZnZWJ2SNCKrDh6FHywMNqeIHLWnIr5YMgP/9YC20JqcXuYFLD9M+J78RDhg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(366004)(396003)(39860400002)(136003)(316002)(4326008)(7696005)(478600001)(110136005)(86362001)(107886003)(5660300002)(66446008)(33656002)(66476007)(6506007)(8936002)(55016002)(186003)(71200400001)(8676002)(66946007)(76116006)(2906002)(66556008)(64756008)(9686003)(52536014)(54906003)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?3wl6m1ZLxr+2HDGSuZV2caslYIc2RieXIMv9ruDOfgYrPJc/JwZv1xW2td4V?= =?us-ascii?Q?tF9/i02kKP2utiPHA9mbocmz7qSi5CcXgD2LZ8nMzdKJIEiVCQO/9g3mmdXW?= =?us-ascii?Q?2mhkjFeew7FlvcL0ybWOLRml7ZVsxW/iN49YWJTqnA2G9hBL9s9bIZA/kP4K?= =?us-ascii?Q?TxJ2ov8yDNmVkqynDLHfzwuV1XkTE8laNfgIX5PGGPy0nrMdvyiOrsB5nKSh?= =?us-ascii?Q?d/266S4x1FWj7aefXg8iXEEYdniLRGHXhFaygop296rEAOSKzGRmQZLxhpp6?= =?us-ascii?Q?YgxRKNcujSRmb/+0R4iJAqvWcwLh1wg6B+NFPlEdvRQnQ7PmO9p2HYeL0UM0?= =?us-ascii?Q?xgDJBw7jrpFu3nucb2IL/Fvik81Kt3YpIhVkXjruYSg95/xl6xStcJZy+ITO?= =?us-ascii?Q?RVSDbxZ7jk1Iwsq+AI8KAxchyo/8Guug7WsJJp37GC2lOstGBqg9HzuChAbs?= =?us-ascii?Q?/5GucIBKy1paDQyEuQagy/5pcChxLJwsA/ZdgJAP4Pi9qZfC+4WrVedIqeA+?= =?us-ascii?Q?mxl2tADU4zxh+mwMtmsjuzQ3AHWOpv5fLycrsRJXw8our+uCZgo4Rc8UA2lq?= =?us-ascii?Q?4ngJIMJs5DAo5bwtOVSMug0fARLALfIgHMzS7xXuw6I7NbEkzBoGmd1JJc+I?= =?us-ascii?Q?AdcpepbIiA02I/5dwxPSUbAKZeP4i4PfKdOilI08emkzTQZzAvKu1zHFjY0i?= =?us-ascii?Q?k6IctHALHFPSFm7RspbMOc+ErwoP+NvLwfxaB7XkW9TyA1oDAhtquVi20CJD?= =?us-ascii?Q?bWhX8tKxZV9EmEYQdyMzFk1FL4BHYvpRJkYWwIi8l+WEAIZIwxC/7ULD7ebu?= =?us-ascii?Q?K6znWIGCTRfTtadkQFHAjCQG7BGxbgxFJ4OFG1cW44NqXajRBNtc8t6ZZPYN?= =?us-ascii?Q?oJNYgttyrHS9p4/BabTmYgqnCw4gia0SOWgz84UDQzvIcJAhIuwXEAynHQIo?= =?us-ascii?Q?FpB6VLAECQsNrQucPBBjytC1A/vCk6+lSw5X8Z5R33w=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 06c63368-da73-4601-725a-08d8b71482be X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2021 16:09:59.2474 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7loXj+PrtJrnRQCa82E8jAXIyKojVRtW1CSXaWQWBgGK5raLC/v34XP2XzfzRPSY7fu4lXLy34yIcq9Tuj50w8+OpyI/1gAgz8pACC+dr+0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3112 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v15 01/11] eal: uninline power intrinsics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > diff --git a/lib/librte_eal/x86/rte_power_intrinsics.c b/lib/librte_eal/x= 86/rte_power_intrinsics.c > new file mode 100644 > index 0000000000..34c5fd9c3e > --- /dev/null > +++ b/lib/librte_eal/x86/rte_power_intrinsics.c > @@ -0,0 +1,120 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2020 Intel Corporation > + */ > + > +#include "rte_power_intrinsics.h" > + > +static inline uint64_t > +__get_umwait_val(const volatile void *p, const uint8_t sz) > +{ > + switch (sz) { > + case sizeof(uint8_t): > + return *(const volatile uint8_t *)p; > + case sizeof(uint16_t): > + return *(const volatile uint16_t *)p; > + case sizeof(uint32_t): > + return *(const volatile uint32_t *)p; > + case sizeof(uint64_t): > + return *(const volatile uint64_t *)p; > + default: > + /* this is an intrinsic, so we can't have any error handling */ > + RTE_ASSERT(0); > + return 0; Nearly forgot - as now this function is not inline anymore, we can probably get rid of assert and return some error code instead? > + } > +} > +