Re: [dpdk-dev] [PATCH v1 2/3] ring: add rte prefix before update tail API

["Ananyev, Konstantin" <konstantin.ananyev@intel.com>]

> Add __rte prefix before update_tail API because it is a internal
> function.
> 
> Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
> Reviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
>  lib/librte_ring/rte_ring_c11_mem.h | 4 ++--
>  lib/librte_ring/rte_ring_elem.h    | 4 ++--
>  lib/librte_ring/rte_ring_generic.h | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/librte_ring/rte_ring_c11_mem.h b/lib/librte_ring/rte_ring_c11_mem.h
> index 0fb73a337..7f5eba262 100644
> --- a/lib/librte_ring/rte_ring_c11_mem.h
> +++ b/lib/librte_ring/rte_ring_c11_mem.h
> @@ -11,8 +11,8 @@
>  #define _RTE_RING_C11_MEM_H_
> 
>  static __rte_always_inline void
> -update_tail(struct rte_ring_headtail *ht, uint32_t old_val, uint32_t new_val,
> -		uint32_t single, uint32_t enqueue)
> +__rte_ring_update_tail(struct rte_ring_headtail *ht, uint32_t old_val,
> +		uint32_t new_val, uint32_t single, uint32_t enqueue)
>  {
>  	RTE_SET_USED(enqueue);
> 
> diff --git a/lib/librte_ring/rte_ring_elem.h b/lib/librte_ring/rte_ring_elem.h
> index 7034d29c0..57344d47d 100644
> --- a/lib/librte_ring/rte_ring_elem.h
> +++ b/lib/librte_ring/rte_ring_elem.h
> @@ -423,7 +423,7 @@ __rte_ring_do_enqueue_elem(struct rte_ring *r, const void *obj_table,
> 
>  	__rte_ring_enqueue_elems(r, prod_head, obj_table, esize, n);
> 
> -	update_tail(&r->prod, prod_head, prod_next, is_sp, 1);
> +	__rte_ring_update_tail(&r->prod, prod_head, prod_next, is_sp, 1);
>  end:
>  	if (free_space != NULL)
>  		*free_space = free_entries - n;
> @@ -470,7 +470,7 @@ __rte_ring_do_dequeue_elem(struct rte_ring *r, void *obj_table,
> 
>  	__rte_ring_dequeue_elems(r, cons_head, obj_table, esize, n);
> 
> -	update_tail(&r->cons, cons_head, cons_next, is_sc, 0);
> +	__rte_ring_update_tail(&r->cons, cons_head, cons_next, is_sc, 0);
> 
>  end:
>  	if (available != NULL)
> diff --git a/lib/librte_ring/rte_ring_generic.h b/lib/librte_ring/rte_ring_generic.h
> index 953cdbbd5..37c62b8d6 100644
> --- a/lib/librte_ring/rte_ring_generic.h
> +++ b/lib/librte_ring/rte_ring_generic.h
> @@ -11,8 +11,8 @@
>  #define _RTE_RING_GENERIC_H_
> 
>  static __rte_always_inline void
> -update_tail(struct rte_ring_headtail *ht, uint32_t old_val, uint32_t new_val,
> -		uint32_t single, uint32_t enqueue)
> +__rte_ring_update_tail(struct rte_ring_headtail *ht, uint32_t old_val,
> +		uint32_t new_val, uint32_t single, uint32_t enqueue)
>  {
>  	if (enqueue)
>  		rte_smp_wmb();
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 2.17.1