From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D146A04DD; Wed, 28 Oct 2020 15:53:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 61742CBB4; Wed, 28 Oct 2020 15:53:13 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id BD02BCB42; Wed, 28 Oct 2020 15:53:10 +0100 (CET) IronPort-SDR: OymRBuPw/eu9K3UfFCjnh1uc77SUrcga5iug/h9UyzQGSgxNyVl4Y2roHZ1tD/6bptWtw+Foid jZQkIF1yi5zw== X-IronPort-AV: E=McAfee;i="6000,8403,9788"; a="229908934" X-IronPort-AV: E=Sophos;i="5.77,426,1596524400"; d="scan'208";a="229908934" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2020 07:52:47 -0700 IronPort-SDR: Bs2gWKd4GUSmP97DjOUcM349BLq9VOks+3HTaTiQJFDI5+D0z8yU7AdTxPezDALmO+DxWHZq98 5M3R2F0ZC63g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,426,1596524400"; d="scan'208";a="394846613" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga001.jf.intel.com with ESMTP; 28 Oct 2020 07:52:47 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 28 Oct 2020 07:52:47 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 28 Oct 2020 07:52:47 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 28 Oct 2020 07:52:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cLY4QMTK27VT30f9Qy3JJf5X15Gi7tql1P8OxGsUQPLc+xBjVZDZz7Zc82kl1cFTLa0fySTJFxH06WSI+FaQ0vFhQf1TN2htNW1JryJ0rnSsHsjbz25qrWOBZdKIlEQT/V0DzbEDe5vSCOGtJnp3Og88f9gkcoPrRui/cx4FOTNHlik07cNTCWTT7XqSFHUtjwm3rWEh52sKNiNz+O9BonD2g0FZ50sGMK1gVbBMiXwAOULqs0FRgvcK+uOKzQL8XpsFT8DdsdzhrWT4w5/jcP02u14bV+2AmWBllHXkrErRDCxKO3rPN0EiOTLZnNlqql5J2EXk78YLzahrkYUKpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YtyDeHQGj7C2fH/JPG60n6rAgsB4Hv6PdI3bn7n8pwE=; b=QBwuH2fV/5AGApMk2YBWeJ+Y/Rq0BsTNBE8ulpxqfbDRmcpM1XlbOzwXDUYccibdEBuhth3HxCMNTxThF9xepXYYeFg45AhdNSvugaiRcoN9CGR4uGvGod/E5H3Gxm0XwCQEa/WnXHgpV/qKzmY3scQMycrPBXnBFCJMk47EcUEcZBJDcSfEL4qwU1TUh+9Ur6HkyoWiW3TURHUMuzml/HKpWS1Ggs5oGxV0zrdOln75Fsh7Hl7CcoDPfF9JPeHddRpiPrQCaHTWeAuN1vLOVJ6kxbyfwuKJyt5+PS5iiwrsYKDjJ8T+dIJCeYRwCyhH0i9JGXU86xp1CIBN+rR9iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YtyDeHQGj7C2fH/JPG60n6rAgsB4Hv6PdI3bn7n8pwE=; b=uUGvf6hFZx6H2L1NDuIPQVGhtajhtMW/jeYJlR+53gluWt/i9C9faIHIJnVQtBCTocgX/ZUZ6TxlacGdp8xbFL23elIFGxDUQi0LrUAAznG1VTJn7axtGc/R2fspLQ0I7HZn71JWKBZNG8SneP0hAMrfuO+YOglhNg+xWeTX1OA= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BY5PR11MB4184.namprd11.prod.outlook.com (2603:10b6:a03:192::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20; Wed, 28 Oct 2020 14:52:44 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f5a4:3f6b:ade3:296b]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f5a4:3f6b:ade3:296b%3]) with mapi id 15.20.3499.027; Wed, 28 Oct 2020 14:52:44 +0000 From: "Ananyev, Konstantin" To: Akhil Goyal , "Gujjar, Abhinandan S" , "dev@dpdk.org" , "Doherty, Declan" , "Honnappa.Nagarahalli@arm.com" , "techboard@dpdk.org" CC: "Vangati, Narender" , "jerinj@marvell.com" Thread-Topic: [v4 1/3] cryptodev: support enqueue callback functions Thread-Index: AQHWq8khoep63TjTukOc0FF/ZoXkNKmrxnGAgADogwCAAD4K0IAAKLWAgAADWiA= Date: Wed, 28 Oct 2020 14:52:44 +0000 Message-ID: References: <1603619090-118652-1-git-send-email-abhinandan.gujjar@intel.com> <1603619090-118652-2-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: nxp.com; dkim=none (message not signed) header.d=none;nxp.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [46.7.39.127] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7fc85f0a-9741-4dce-86bc-08d87b5120b1 x-ms-traffictypediagnostic: BY5PR11MB4184: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: t0gcYaKQTQKc9xYdbhH9237VDMu3Am3Lw8Xi+PLhmdAHHVeYElrhKvyyyGqX/Ok9Vap1FJUBcfOQ4LIIGQ9kxtYZtKtq5wN0OZSupivgcCXLK/WG2GVC+hDvBJ0i+1XR1cqQKRXIXPNNGmLt6N+hBemFPFn/tjcBosTtT1H4mhm3/1eO8IHBGAOshyiZc4dHpednOyhCcVvBapCqgud97yVsHyl4jZq1Tm0eOPge2v8v7xXT4nYBclGJm+Kq+34bWJSDpFjwCO2ZBnRUhMqNIBTCeLQ9YPHwhVWTZtJKLEag/mbcV5YEfEtWCjX0eQVyXtHUZz02AZkyYli/JTGKQw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(366004)(136003)(396003)(39860400002)(66946007)(8936002)(66476007)(9686003)(64756008)(76116006)(66556008)(66446008)(26005)(52536014)(8676002)(7696005)(186003)(33656002)(86362001)(55016002)(478600001)(6506007)(5660300002)(110136005)(54906003)(4326008)(83380400001)(316002)(71200400001)(2906002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: uZpGPggJvMSxj6V5aIHvsxR4/qO0bx7ABzpl3ekmKQFGDsuaEZAR2/cBjSBFyoBAFQfxIbo/bXRHee1nVieLVF1wQ+izQ0ERS5wjLwaIOjMGYb88FIqPRBNzgjX1hZvip1yGvmXUgZOGBgwrHDVJOMJaGFDSCIICu9enGlTVEZCKJozA8g5OsqUk/FTLk10nEBCPTwDjTZf/NyVePKiUKiJoW32QU1wTdG8XnVvj+M5DUk8rOCoeZJRHO/tSJ7PWwV7pGYsp/RlM+NpX60nJY3UF2kxqnR+8UAHZk2OqYBCEs8ft6gKHalCOGvELU7X/UQ+b8VYq+FEKx1EeT/jj/OBYfjkztdf9mfHbuglY4FlM/qi6hvDc0WmhyojsaRWq9JQC9Qt3ppTyt2mvCstSZc3XhaXr3GaT7QQB423n5FIqomnMaZR4Rf3Yj+vfN33QAtgEPHknXHiE8WMI5CszgHtJq1OllHOMR6AgnSWoZJppi6nYUNfwdqbvPE1CU7hS7X0fzoCM8WcMJ9amu75cNhgdy3i9xWRM7Ph4Bt2Csg4FSCO18QDOpK/kBfkLoJSWBT5L9IV31bKUYmuQoBeRRMuJFdpZroyP/awf60R7mVex4rX+TcjL5TUs3DhQu5fBLLQ4wP8HmYTgo2QTDe/zyQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7fc85f0a-9741-4dce-86bc-08d87b5120b1 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2020 14:52:44.2488 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 87RzmTEVbfwFrEHoN+J9KZYPn2MpfahOzcI5bAoqYJxYsADiT35mVq1m8WwOVozFBDynw2hmOz34Auq/S/CdqGQmwotS9Yq4JU/St2ZyZ5I= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4184 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [v4 1/3] cryptodev: support enqueue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Akhil, =20 > Hi Konstantin, >=20 > > > > Hi Tech board members, > > > > > > > > I have a doubt about the ABI breakage in below addition of field. > > > > Could you please comment. > > > > > > > > > /** The data structure associated with each crypto device. */ s= truct > > > > > rte_cryptodev { > > > > > dequeue_pkt_burst_t dequeue_burst; > > > > > @@ -867,6 +922,10 @@ struct rte_cryptodev { > > > > > __extension__ > > > > > uint8_t attached : 1; > > > > > /**< Flag indicating the device is attached */ > > > > > + > > > > > + struct rte_cryptodev_enq_cb_rcu *enq_cbs; > > > > > + /**< User application callback for pre enqueue processing */ > > > > > + > > > > > } __rte_cache_aligned; > > > > > > > > Here rte_cryptodevs is defined in stable API list in map file which= is a pointer > > > > To all rte_cryptodev and the above change is changing the size of t= he > > structure. > > > > While this patch adds new fields into rte_cryptodev structure, > > it doesn't change the size of it. > > struct rte_cryptodev is cache line aligned, so it's current size: > > 128B for 64-bit systems, and 64B(/128B) for 32-bit systems. > > So for 64-bit we have 47B implicitly reserved, and for 32-bit we have 1= 9B > > reserved. > > That's enough to add two pointers without changing size of this struct. > > >=20 > The structure is cache aligned, and if the cache line size in 32Byte and = the compilation > is done on 64bit machine, then we will be left with 15Bytes which is not = sufficient for 2 > pointers. > Do we have such systems?=20 AFAIK - no, minimal supported cache-line size: 64B: lib/librte_eal/include/rte_common.h:#define RTE_CACHE_LINE_MIN_SIZE 64 > Am I missing something? > The reason I brought this into techboard is to have a consensus on such c= hange > As rte_cryptodev is a very popular and stable structure. Any changes to i= t may > Have impacts which one person cannot judge all use cases. +1 here. I also think it would be good to get other TB members opinion about propose= d changes. =20 > > > > IMO, it seems an ABI breakage, but not sure. So wanted to double ch= eck. > > > > Now if it is an ABI breakage, then can we allow it? There was no de= precation > > > > notice Prior to this release. > > > > Yes, there was no deprecation note in advance. > > Though I think the risk is minimal - size of the struct will remain unc= hanged (see > > above). > > My vote to let it in for 20.11. > > > > > > Also I think if we are allowing the above change, then we should al= so add > > > > another Field for deq_cbs also for post crypto processing in this p= atch only. > > > > +1 for this. > > I think it was already addressed in v5. > > > > Konstantin