From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41EFDA00C2; Wed, 22 Apr 2020 10:25:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A88441C0AD; Wed, 22 Apr 2020 10:25:55 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 728F71C036 for ; Wed, 22 Apr 2020 10:25:54 +0200 (CEST) IronPort-SDR: kT8aLkBHTphKx4ImHWSHcyMClkcjReNJmaxNu0w0HVhDNMlupra7EIAAYVgueihWWmN0WcPbUs 015813AnDA+A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2020 01:25:53 -0700 IronPort-SDR: 6zl+VBZeuPqYedZE8Yfy2U9x4wou9ZmPPY9614k+AlVypSjkDlWuuJMbs3qZZeAuRuSWqORrK0 C4/OiJbeIjGA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,413,1580803200"; d="scan'208";a="290755089" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 22 Apr 2020 01:25:53 -0700 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 22 Apr 2020 01:25:53 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 22 Apr 2020 01:25:52 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 22 Apr 2020 01:25:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FXWaqrS8R5kdfUJW7PWjKFdKiNJJsSzt5DGDoRnn/8ps8U6TczbBlnB5NsmCONflJkD6NyCuEBlq7u4ObXm6LZK7FhSrp0zO9l9bwY+Wc9Q/0iN47rBGCxEfFhEaPDkn13rohpTD2Q12sJlNSFTVGMs6rr4ksB1KMwijd2/xeHbG91sKP5Zua8dI/7LzzshSviF+lHnTUrdSaukcbEw4DVpl+zi+DhHJQzMzr9CBGK1S/1BkGALMQOXE6SQqd2hXjaLEQeQpBUqr1fpzs3zK70u8tl1cut7ciDrVEPBDmGw2jF0s0P0JE3IsX3C8NpSA0VSV8tI3BABg9FilMYhpmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dw+R8rGgHfUYCvz/tC6hmXGiXq8ma8yvO9eIHrQUn/E=; b=Zr/WlT+2zHbOzs9RzPVdAjNp0G+/yxAp5H4as/P5AzU7bu9Gco6qK5ISLG8pEMMsKgOZDcR6cILiKVYKW3OVWwvWK0B7VRBiMwOtXQiS7O7XZ0y9eC6gM9eC2dvYTUkoMxQGPC9YaY3KdZn21RSjXr1g8jcBRX631tcinc4YR/Fa8EaDz2D+LPp39V/3xyw68WKPe8K4HuCTiPAFpXCpfcMmbfsYo+TuxVOqLiiksLykiq0k28//0EOrdrX8YPvmBjR/6GmfpLxzbTVSf7UJ+iwD2E0j2MGelV5/e8iNi+7i6PuAU81OwYJ1c/hNoHOvZGNCUulT8Rox8IWnG1BKzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dw+R8rGgHfUYCvz/tC6hmXGiXq8ma8yvO9eIHrQUn/E=; b=KlJcW8qNUg7rsmKtKjtxgWKLjQiFsZfBMPeNQIYgnpA73ZISPUfeZfQmfsgFJUPNN7/TgO7M5GUen+JnPterdfxwtOApQNK1rHVIg8r1RDB+HN1NdolOLCKoZoL2h8LXLl+cLSFTEd36C5sdRJ5ZleTNDZntQEbUHhQYniGRpwI= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB2855.namprd11.prod.outlook.com (2603:10b6:a02:ca::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.27; Wed, 22 Apr 2020 08:25:51 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f8cb:58cd:e958:fff4%6]) with mapi id 15.20.2937.012; Wed, 22 Apr 2020 08:25:51 +0000 From: "Ananyev, Konstantin" To: Honnappa Nagarahalli , "stephen@networkplumber.org" , "Medvedkin, Vladimir" , "dev@dpdk.org" CC: "david.marchand@redhat.com" , "ruifeng.wang@arm.com" , "dharmik.thakkar@arm.com" , "nd@arm.com" Thread-Topic: [PATCH v5 4/4] lib/rcu: add additional debug logs Thread-Index: AQHWGFZ1SeXJggxYC0u8xdBJKdppwqiEzmvA Date: Wed, 22 Apr 2020 08:25:50 +0000 Message-ID: References: <20191001062917.35578-1-honnappa.nagarahalli@arm.com> <20200422033006.1124-1-honnappa.nagarahalli@arm.com> <20200422033006.1124-5-honnappa.nagarahalli@arm.com> In-Reply-To: <20200422033006.1124-5-honnappa.nagarahalli@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=konstantin.ananyev@intel.com; x-originating-ip: [192.198.151.168] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c5159bd6-53c8-420f-3bf8-08d7e696c46a x-ms-traffictypediagnostic: BYAPR11MB2855: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:327; x-forefront-prvs: 03818C953D x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(346002)(396003)(376002)(136003)(39860400002)(366004)(8936002)(8676002)(316002)(66446008)(76116006)(64756008)(52536014)(7696005)(66946007)(66556008)(66476007)(54906003)(110136005)(6506007)(186003)(478600001)(26005)(55016002)(81156014)(33656002)(9686003)(4326008)(2906002)(86362001)(5660300002)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aDxmFG/hPaIuFQ/B11XRRFqN3Z/6flwRsIxXpYqFiPaloB0YYUasqOgnoUfZBqR2ZPzHkl5olaVEAgAyikuR634dl5841eVfxFwLmOO0OAaJzIMmIMQ0im5YAMYn7eOPtMom6e1a2WeA3bQYH0i4E7S4WyI27bOxUoHucYeZo/mBaZ2Aj1CXir4A+9NOuFzRXszI1gN27CWhtXGKjdfN0Fn5vPhKkik/vVLo3jAtep2pWFy6Lj7UKHkcnz1mrHRHpHWI/nCf+sJY+VmWm8bAKhqdWgJsrtQixv4onGl3TMnaD2ej31UYzCosFTytujqxCJPC4UVbCdzMeXKPzR35/hk69ZVPJGWuh27P8M8KVgmoNtTGXdXN/frt0KNuLC0B3JEK61fupTTynX5TUJ/pzdADvmJxEwBu7LeL90sw8lJ0tDig38J+sAIAgWQrc11B x-ms-exchange-antispam-messagedata: xAM4o35C6WMMc+OptylZh31gf9RwH5b8lp7Qft7eNQn/ylfNCOgFAs4tNyJdrUiefZ94dvWmlfj2cfN1ah7fejU6E4LC5gTN5lWu+XQMqwl5A03J20fYDbJ99e27aiWXuyaOkMMjvMbRDg9gAOR4+w== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: c5159bd6-53c8-420f-3bf8-08d7e696c46a X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Apr 2020 08:25:50.9055 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tUsMwXmUv9Dxl/DvLIOgO0op+4za+mpFpV5o2Swk1oqf/96U3LgWbIrOZ8A2GkdpAghT7O1ZH5zAO2RjKKbn2VFR62w+jTsIydKRWOJT9+c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2855 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v5 4/4] lib/rcu: add additional debug logs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Added additional debug logs. These helped in debugging RCU > defer APIs. >=20 > Signed-off-by: Honnappa Nagarahalli > Reviewed-by: Gavin Hu > Reviewed-by: Ruifeng Wang > --- > lib/librte_rcu/rte_rcu_qsbr.h | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) >=20 > diff --git a/lib/librte_rcu/rte_rcu_qsbr.h b/lib/librte_rcu/rte_rcu_qsbr.= h > index e2fc7f83e..9524915fa 100644 > --- a/lib/librte_rcu/rte_rcu_qsbr.h > +++ b/lib/librte_rcu/rte_rcu_qsbr.h > @@ -718,8 +718,15 @@ rte_rcu_qsbr_check(struct rte_rcu_qsbr *v, uint64_t = t, bool wait) > RTE_ASSERT(v !=3D NULL); >=20 > /* Check if all the readers have already acknowledged this token */ > - if (likely(t <=3D v->acked_token)) > + if (likely(t <=3D v->acked_token)) { > + __RTE_RCU_DP_LOG(DEBUG, > + "%s: check: token =3D %"PRIu64", wait =3D %d", > + __func__, t, wait); > + __RTE_RCU_DP_LOG(DEBUG, > + "%s: status: least acked token =3D %"PRIu64"", > + __func__, v->acked_token); > return 1; > + } >=20 > if (likely(v->num_threads =3D=3D v->max_threads)) > return __rte_rcu_qsbr_check_all(v, t, wait); > -- Acked-by: Konstantin Ananyev > 2.17.1