From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id B91A2A04DD;
Tue, 20 Oct 2020 19:26:14 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 4E4957F6C;
Tue, 20 Oct 2020 19:26:12 +0200 (CEST)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
by dpdk.org (Postfix) with ESMTP id 6D9A472F6
for <dev@dpdk.org>; Tue, 20 Oct 2020 19:26:09 +0200 (CEST)
IronPort-SDR: 9hSK9HderBf9eJwAU1U3aqBbQXrWyvfjk5TqOo6sT6KDd3Ce2Pp3Jy3AAsjww3HbNQhKetFJIE
Z6X52zW337Tw==
X-IronPort-AV: E=McAfee;i="6000,8403,9780"; a="167339161"
X-IronPort-AV: E=Sophos;i="5.77,398,1596524400"; d="scan'208";a="167339161"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
20 Oct 2020 10:26:08 -0700
IronPort-SDR: UV97YVHWZAQJCHfSVd+cc2J/qZu7myzeMz+4rv3oyu9sqP+FT55pekbJnYVfRfoV4ulQ3eBsvE
8zq6EcWhVySQ==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.77,398,1596524400"; d="scan'208";a="466004173"
Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16])
by orsmga004.jf.intel.com with ESMTP; 20 Oct 2020 10:26:08 -0700
Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by
ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.1713.5; Tue, 20 Oct 2020 10:26:07 -0700
Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by
orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5
via Frontend Transport; Tue, 20 Oct 2020 10:26:07 -0700
Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176)
by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.1713.5; Tue, 20 Oct 2020 10:26:06 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=NjzXmwYb9L/83Qyo0vs6wqAGSoREt5IxBUZrjw4tetShVofrl4qE0pH+EDj5TxSs8Jm7v1ZI9ssjiU4xQfmtrSUoh20stWpM7NCVx+0bgFPtxvf0HNe3d4PX/8TszQPuQ9FDRojVjNhUYs1pHDErCR80DtlM2zuXw6/kMW7nL6YQoLDKYIcWqqscIOu0jwPkgLbiOQdLsguVChtaNoaT5PLrDILW6pFj/PEmOuZ0eKjUq9VY6fRLYLNxwqF3iPdW6FqhYrVfRWYTunCm6JInT4j0AbXPfYBd+iHPv6GMzGKDJisMsBT0zAr9t8AIPuVKFw5cb+HfOmUWGpYPOcbHHA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=yWXM+cDc8BTwAqykdA208bDvuhk12eqmdfcSPEG3Ym4=;
b=SIeWLZ/CTGiaOmwjSTkwmSgXstUp+HbIUBEDmdFQzKu3LArXzaX7cYUtOT1jRNZ7MIBOhJqaD2pPlMlahfRdPWUhPe4DpFX1RhSvZVi0Lx6uHvHvp9ZVM2IP9BiC+s3rumfN/xlsqbZggJn/ceoxNZ8/kNY0mIFoKSbjuxXfRobnwBGeEOoTZcFDagJUfulZkwH3t6pQ+LZnuLUyhUZ6KijPtPal6hZGDZKiFTCAE4WhwTAnMRjzhRAHGPxLNC+Hxp9rTpxaVa/7ZXMadKNPagOPty/uPz1aLd9SdBpRGdEWiebjAguuVDOdW+6dmwzC6XPaXhUVpezi1FlvK0772Q==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=yWXM+cDc8BTwAqykdA208bDvuhk12eqmdfcSPEG3Ym4=;
b=imh4HUKu0XlFQnb20bXjp+w2fbgG3cAReY6/GGWX06VkupCoATQH3Ychi1oJg0BRcU/kbGEqi9atgbcpVdyxyQWGee1Umv/y9qHXniQ9zbfw6K1fqnAlHMP5zNtbo2nOlMI9d/pzzh08psMMtT21gUbixLKJ+XfSZZVzKm77aXk=
Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26)
by BYAPR11MB2918.namprd11.prod.outlook.com (2603:10b6:a03:92::20)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.24; Tue, 20 Oct
2020 17:26:04 +0000
Received: from BYAPR11MB3301.namprd11.prod.outlook.com
([fe80::f5a4:3f6b:ade3:296b]) by BYAPR11MB3301.namprd11.prod.outlook.com
([fe80::f5a4:3f6b:ade3:296b%3]) with mapi id 15.20.3477.028; Tue, 20 Oct 2020
17:26:04 +0000
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, "Hunt, David" <david.hunt@intel.com>
CC: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>, Ruifeng Wang
<Ruifeng.Wang@arm.com>, "dev@dpdk.org" <dev@dpdk.org>, "Ma, Liang J"
<liang.j.ma@intel.com>, Jan Viktorin <viktorin@rehivetech.com>, "David
Christensen" <drc@linux.vnet.ibm.com>, "Richardson, Bruce"
<bruce.richardson@intel.com>, "jerinjacobk@gmail.com"
<jerinjacobk@gmail.com>, "McDaniel, Timothy" <timothy.mcdaniel@intel.com>,
"Eads, Gage" <gage.eads@intel.com>, "Macnamara, Chris"
<chris.macnamara@intel.com>, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>, nd <nd@arm.com>
Thread-Topic: [dpdk-dev] [PATCH v7 02/10] eal: add power management intrinsics
Thread-Index: AQHWoutbh1UenvEhME+MzDl9WKxJO6mfc1GAgABeN4CAAE/GAIAAa8UAgAAEqQCAAARhgIAALp+A
Date: Tue, 20 Oct 2020 17:26:04 +0000
Message-ID: <BYAPR11MB3301BEEDE2ACF7B5F0D72C229A1F0@BYAPR11MB3301.namprd11.prod.outlook.com>
References: <da3fe4e5bbe976882c56a71d20a9055c1600e6aa.1602763439.git.anatoly.burakov@intel.com>
<73102e35-00d3-fb5e-0169-ba7015880ed8@intel.com>
<7d18f72e-9078-1eb9-ab6f-d88992ac082c@intel.com> <2249719.vHQDUtK1Li@thomas>
In-Reply-To: <2249719.vHQDUtK1Li@thomas>
Accept-Language: en-GB, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
authentication-results: monjalon.net; dkim=none (message not signed)
header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com;
x-originating-ip: [46.7.39.127]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b808b6fc-8c7d-4ae9-83b9-08d8751d391a
x-ms-traffictypediagnostic: BYAPR11MB2918:
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <BYAPR11MB29183904A3E387D76FF1E8759A1F0@BYAPR11MB2918.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: fsGMz+npdIj69QkOQIdOvJULHddSDu0CMhFMQ8RBexpADgObwwKD1KSPQWZ//1H5QcA49rg1amde+2XdPczkkndrltJQZc0mWwbXb0ZlXVhfVeyCMAJUCL4heXaNACKp+ay0rjkgPYcHLHwNzO1Sx2icXj/My4wyj7sooLf0i4J+CmykzxpLB0nxRGCr4v84mdG2dd71NO/rLUCBKRGUPZ48hGcNP7/SVEt8K7PMEMgOxayKjeZbwtQ3tlixRPNxsE/opcmBG67wV5jnSas8tm8KykeTPVo0eWLoF//dfSB8zhojm7DO+xJ++rETYMen
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(366004)(136003)(376002)(396003)(346002)(39860400002)(6636002)(66946007)(316002)(55016002)(9686003)(66476007)(66556008)(64756008)(4326008)(86362001)(26005)(54906003)(66446008)(2906002)(110136005)(52536014)(7696005)(8936002)(53546011)(6506007)(33656002)(186003)(478600001)(76116006)(5660300002)(71200400001)(8676002)(83380400001);
DIR:OUT; SFP:1102;
x-ms-exchange-antispam-messagedata: 7fvfJk4OFkXpIpl432CKyn8SNSyTMvITKFnei/OExidwZsulG90ezbaRjB+45VuA1a3AujxVUwy/Unq8M0RpZ92LYmRwtO5/TI/VAUOArQKqpBX6PnGi9YhDa49mmZZ3zcMlYirV0pHE0X7aQCgCJQkN/UOCYxW5gjIsJ/NaHd8V+wSzwNgw281mTYRItWLz/BO8lN+UlB9xvTnajVg+aoPnTcaO2sjX8qZhIbiXbawMzAbXq00DvTNEt0yDrBfk+RJIM1hXWPHsElb/dB4Y8TA7iPONFR9CbZZWLbWQ8kNSBFHkVYf22Ew/5nzOynhbOqkcCbj+nLeFuiI6rluOXZABOTtgzdVQIWWydLHiV7KJAU6PQ38k5VfcBlU0SOZ1RvX3Nwsm74MkCfMyvOUst2on061NE/JkksoZ9Syl/fvI4HKH6Sxxk1xHxv+bzFCAddHLTdijRiyk8qxAtUBQyuQhU/o4Ostd2ElQApoSKpxpG3/63mX5yvf4o5ZDiM2TqDiemFdNTyyweLUzJcislo/7fax2FT//g4GGf6gID9qSjw3C4Zim/kS90iQMjk2hsnEpaKBUdfNfJFll9ASFM+ukhwGNm+NTPSrwz75fv/xbhPx8RZBUGCfpMU6IWO1ioymRz6HuEzVuKB5BaoLSSA==
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b808b6fc-8c7d-4ae9-83b9-08d8751d391a
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2020 17:26:04.4216 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BDjX7H+a5jQTsMexCX9yP+kOizqnOQ4/p9aHqsZ8ejJpqSp+I7oke0oQI6nXs52+bje9Iy4Fu3dkSszoaELmUjE3rJBfGiBq2kjuEuZsgOU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2918
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH v7 02/10] eal: add power management intrinsics
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
=20
> 20/10/2020 16:17, David Hunt:
> > On 20/10/2020 3:01 PM, David Hunt wrote:
> > > On 20/10/2020 8:35 AM, Thomas Monjalon wrote:
> > >> 20/10/2020 04:49, Ruifeng Wang:
> > >>> From: Thomas Monjalon <thomas@monjalon.net>
> > >>>> 15/10/2020 14:04, Anatoly Burakov:
> > >>>>> +/**
> > >>>>> + * This function is not supported on ARM.
> > >>>>> + */
> > >>>>> +static inline void
> > >>>>> +rte_power_monitor(const volatile void *p, const uint64_t
> > >>>> expected_value,
> > >>>>> + const uint64_t value_mask, const uint64_t
> > >>>>> tsc_timestamp,
> > >>>>> + const uint8_t data_sz) {
> > >>>>> + RTE_SET_USED(p);
> > >>>>> + RTE_SET_USED(expected_value);
> > >>>>> + RTE_SET_USED(value_mask);
> > >>>>> + RTE_SET_USED(tsc_timestamp);
> > >>>>> + RTE_SET_USED(data_sz);
> > >>>>> +}
> > >>>> Are you sure it cannot be partially supported with WFE instruction=
?
> > >>>>
> > >>> Armv8 WFE instruction can support monitoring of specific address fo=
r
> > >>> changes,
> > >>> but not monitoring of TSC timestamp.
> > >> So it is a partial support.
> > >>
> > >> We must try hard to unify architectures support
> > >> to avoid #ifdef everywhere.
> > >>
> > >> I don't agree with how are managed new instructions recently.
> > >> Please look further.
> > >>
> > >
> > > Hi Thomas,
> > >
> > > We believe this is ready for -rc1, can we discuss this with the
> > > technical board before the RC1 tag is applied?
> > >
> >
> > Hi Thomas,
> > By way of further follow-up, here are the reasons why we believe
> > it's ready for merge.
> >
> > There are 18 Acks for the 10 patches, with the two critical patches
> > getting 4 acks each.
> > These acks are from ARM, Marvell, IBM and Intel.
> > There have been 7 revisions, with quite a lot of discussion, and all
> > comments have been addressed and Ack'd.
> > From what I can see, the community are in agreement that this patch
> > should be merged.
>=20
> The problem is that I don't agree,
Thomas, could you explain about what exactly you don't agree with?
Is it about WFE? Something else?=20
Konstantin
> and I feel you tried to avoid comments from others at the beginning.
>=20
> Now I don't want to spend more time on it before tagging -rc1.
>=20
> Next time, you'll make sure to Cc and reply everybody.
>=20