From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44A97A04CC; Mon, 21 Sep 2020 13:45:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 272DA1C190; Mon, 21 Sep 2020 13:45:14 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 408841C134 for ; Mon, 21 Sep 2020 13:45:12 +0200 (CEST) IronPort-SDR: FITPvVvFdKj9RQ9QYQRlnDuJVGJhOmsSIAlB4ZDLuy+2Fa5ATeEmp2STeph7CY0mtVrSmpbAck wlbyuTA5DawA== X-IronPort-AV: E=McAfee;i="6000,8403,9750"; a="139856177" X-IronPort-AV: E=Sophos;i="5.77,286,1596524400"; d="scan'208";a="139856177" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2020 04:45:08 -0700 IronPort-SDR: H80Jjfms7I3LHpjjkBT2f5a3klUCCSB4mRAlnyjqFzjy8Us3iN4zb0Zpn5yhtyYMnUW40wfC01 QVy1+FhdxQog== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,286,1596524400"; d="scan'208";a="334371827" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga004.fm.intel.com with ESMTP; 21 Sep 2020 04:45:08 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 21 Sep 2020 04:45:08 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 21 Sep 2020 04:45:07 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 21 Sep 2020 04:45:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=V+OQr+tyZKxve8Ru2J2459gU52k5Sl9PXXrAxCptSmIvlkAUfCa2GYP5sY9tvliUw4Igl1xkuruJC7ANmsNpcy0FQZLRniVaCfpp39phtfBu6K8UHh1L3+udQ5wEGalEnwOcC+9QdipNCfCkJ+hYFvZ6abPIoXSOdToJrS/aFNvfZTrYyieIZ2CvNsjtQUflYgv3dxaJnQrYV+7AahcoVRVLjnqLg9pH+Y0ZdFez5KZWHbzG/09lDT8uQ/h2DzYX4XEo0H/jRsT6LL7goWDX2VQfZneDWUcSBwmsd34D8Drif6R679IBxld529lo+ErbLSMGPEeTgoaEL3dqpfbemg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZJVx/Sxj2ANiTavO2or4gMWBYSoRqxWjC5lm5fkLsjI=; b=C6wqaHCM+LpI4/lA4pbhz+jhVffPHqdC6v9LSU37tsjZTePNGL3+WFg60SgtolCcUlKDKKqMleLuguf614C+MDE2WYsugNNOlwjmbdHbdPT6rM5qZbZa6pCk3s9G2a/sVKaKtQiKEEn5p9AQrYWCPGeZ8OHAZcYjBJlGrCRgF4vjMPX2bFYevBfqaK26N9cwzZQUmx4QovqN9BJeDuVIOGgEP/lcXfUstBICJ0XCkVUMKUZctRns4RYvZ61DJi3LUV5c0Yu4WhIYomGow/CLdVcotgMl5CZcNAqG/wEeBpdvi7CC4zfsQz8LMbYpCiyvEjAQW9KfqP3MRfQk8tIu4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZJVx/Sxj2ANiTavO2or4gMWBYSoRqxWjC5lm5fkLsjI=; b=sG/6NexaIUc5S9ortYmAcYSTP6nKysArWNXyLS5vose9Ufwkd/O1YwKIZMcOLRJWccWRnB1pXTyjw/Lw6GHM7366l6BuGblVPzFL6UmsA9K1V/46w4kpQYOavSQoPkvh2hyVUgVXMEHLiiqYZGyfsZ0qvkLp7XyAYT/eDpfS+E0= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB2901.namprd11.prod.outlook.com (2603:10b6:a03:91::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.24; Mon, 21 Sep 2020 11:45:04 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f43b:a137:dab8:8b0b]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f43b:a137:dab8:8b0b%6]) with mapi id 15.20.3391.011; Mon, 21 Sep 2020 11:45:04 +0000 From: "Ananyev, Konstantin" To: "Gujjar, Abhinandan S" , "dev@dpdk.org" , "Doherty, Declan" , "Honnappa Nagarahalli" CC: "jerinj@marvell.com" , "akhil.goyal@nxp.com" , "Vangati, Narender" Thread-Topic: [dpdk-dev] [v2 1/2] cryptodev: support enqueue callback functions Thread-Index: AQHWhsTbY+pAzzKww0euN2orABmUValrRWzAgAAl9gCAAW0pMIAGJnUAgAAH/lA= Date: Mon, 21 Sep 2020 11:45:04 +0000 Message-ID: References: <1599549024-195051-1-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [46.7.39.127] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 89f8c8b7-56ec-409f-9073-08d85e23c7ff x-ms-traffictypediagnostic: BYAPR11MB2901: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uacbIIESvYwSGSxQk6KWi0IehPYHo9ujKHToJROy2DBTcT2AA7VQZMxZwXXNmNDG8CGTGVvjzWds9ytUw2lRH1mjcbHH/9VerawmGrSkRsdTngEfyzLWnxQpD6LCoW8DZ44XLrN+4sBsxavEacYjbcLuU44qM/eMHgI+4f44bblIMeQXTFQlZprvxnZZJ2WpAYCSsPNjeCxuYbiJ49/Zuci1kDmv1LLTgK0L/+UceL6uUjWwMaLbR/EMminEErggYLgRqUnJE5hME+LvjaSlVfCA1UHj9G9d9Axkkoseo737yu4SjYyCVbEMLOuO1uOf+phkNQ2P4Qy9aq1AFKFiv6Q8A1U/GljoGJbwDxazi8s3hixSeOC7HSZNyZpo8yX4eMWNYRpD7cdZqp+EyJI/cQ0K48jUcJu/WY4kCQGeWkbvxK7tPVypFChZFJIgBvdzTTYA1gBYeiZul+cMHAXygg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(376002)(396003)(136003)(366004)(4326008)(107886003)(83380400001)(2906002)(86362001)(966005)(33656002)(9686003)(55016002)(316002)(71200400001)(5660300002)(52536014)(478600001)(110136005)(54906003)(6506007)(186003)(26005)(8936002)(8676002)(7696005)(76116006)(64756008)(66476007)(66446008)(66556008)(66946007)(30864003)(579004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: k4reF5tcu7wK0nVchbv8IePzMIOIUIzUkPDMAG7G4Wc7IrJHkPPHriOkhzVbBcistqrab8VHkBQIFwZESIkt2/KXrRkQdLvYufAHWGQj13Z1WcuF7WM83Z1PREtsBWgY6qAxn/CC5udK8x/UWB6/ud/bvevehTRB4KoSsE48OIG83Ms2bd7wiXFVltjyHw6RkIsIwp37y9UvJuWY6kWm4hJGOrn/9yOnllouNrNhaFg93jytnfIcHSkOOaiFJLsGA0n+ttNsv4j1I5eNSMIc4ztNvv1wUKOWZdPEgaiBcBSTPvZpS3ogcPjnladlQDdPKgiY1MDeMzxfzzAJK6jumRUHhj+5xvata5XrepOpFfaTgcn5d4dZrhdzuwSr1t3W5Sc6z8P/rLrbpT1gqyk809DWlUxH8KeArVdvrd6nfqs+zj0ZWPxNUsRgkVzht7lDJOI/5gcMHC4tm8B4zFInrIPH4HXV4PGkD9ZpUoT5ijHG6dOjbKpuas+zXhOmquhdqgt9sUjufQNmckQlArCGZkY3Nfnz5D06k9iRLOLVFtzuf+hwdMSqS95ToTri71s/ryVATrvdtkIciLnGPsKESopIVBA95zUp+sbUQLF0vRmmM4h0L1jCUjz996zfl8V9/a2SqcVdOryNe+aaz/w2tw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89f8c8b7-56ec-409f-9073-08d85e23c7ff X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2020 11:45:04.4106 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UdbwOi24X/nNB5pvDzuzIZbawVwM4B1NbTkeajKVQbRen1Ml2W2epOMrO7LEiV3mRleTncfeoOdhJNXWtUyiD79nEe1OSuEp6c1aQYnDM88= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2901 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [v2 1/2] cryptodev: support enqueue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > > > > > > In an eventdev world, multiple workers (with ordered queue) will > > > > > be working on IPsec ESP processing. The ESP header's sequence > > > > > number is unique and has to be sequentially incremented in an ord= erly > > manner. > > > > > This rises a need for incrementing sequence number in crypto stag= e > > > > > especially in event crypto adapter. By adding a user callback to > > > > > cryptodev at enqueue burst, the user callback will get executed i= n > > > > > the context of event crypto adapter. This helps the application t= o > > > > > increment the ESP sequence number atomically and orderly manner. > > > > > > > > > > This patch adds APIs to add/remove callback functions. The > > > > > callback function will be called for each burst of crypto ops > > > > > received on a given crypto device queue pair. > > > > > > > > > > v1->v2: > > > > > Moved callback related members to the end of cryptodev struct > > > > > Added support for RCU > > > > > > > > > > Signed-off-by: Abhinandan Gujjar > > > > > --- > > > > > config/common_base | 1 + > > > > > lib/librte_cryptodev/Makefile | 2 +- > > > > > lib/librte_cryptodev/rte_cryptodev.c | 157 > > > > +++++++++++++++++++++++++ > > > > > lib/librte_cryptodev/rte_cryptodev.h | 154 > > > > +++++++++++++++++++++++- > > > > > lib/librte_cryptodev/rte_cryptodev_version.map | 6 + > > > > > 5 files changed, 318 insertions(+), 2 deletions(-) > > > > > > > > > > diff --git a/config/common_base b/config/common_base index > > > > > fbf0ee7..f5ebde4 100644 > > > > > --- a/config/common_base > > > > > +++ b/config/common_base > > > > > @@ -599,6 +599,7 @@ > > > > CONFIG_RTE_LIBRTE_PMD_BBDEV_FPGA_5GNR_FEC=3Dy > > > > > # > > > > > CONFIG_RTE_LIBRTE_CRYPTODEV=3Dy > > > > > CONFIG_RTE_CRYPTO_MAX_DEVS=3D64 > > > > > +CONFIG_RTE_CRYPTODEV_CALLBACKS=3Dy > > > > > > > > > > # > > > > > # Compile PMD for ARMv8 Crypto device diff --git > > > > > a/lib/librte_cryptodev/Makefile b/lib/librte_cryptodev/Makefile > > > > > index > > > > > 73e77a2..514d552 100644 > > > > > --- a/lib/librte_cryptodev/Makefile > > > > > +++ b/lib/librte_cryptodev/Makefile > > > > > @@ -10,7 +10,7 @@ LIB =3D librte_cryptodev.a CFLAGS +=3D -O3 CF= LAGS > > > > > +=3D > > > > > $(WERROR_FLAGS) LDLIBS +=3D -lrte_eal -lrte_mempool -lrte_ring > > > > > -lrte_mbuf -LDLIBS +=3D -lrte_kvargs > > > > > +LDLIBS +=3D -lrte_kvargs -lrte_rcu > > > > > > > > > > # library source files > > > > > SRCS-y +=3D rte_cryptodev.c rte_cryptodev_pmd.c > > > > > cryptodev_trace_points.c diff --git > > > > > a/lib/librte_cryptodev/rte_cryptodev.c > > > > > b/lib/librte_cryptodev/rte_cryptodev.c > > > > > index 1dd795b..2fb3e35 100644 > > > > > --- a/lib/librte_cryptodev/rte_cryptodev.c > > > > > +++ b/lib/librte_cryptodev/rte_cryptodev.c > > > > > @@ -38,6 +38,7 @@ > > > > > #include > > > > > #include > > > > > #include > > > > > +#include > > > > > > > > > > #include "rte_crypto.h" > > > > > #include "rte_cryptodev.h" > > > > > @@ -499,6 +500,10 @@ struct > > > > rte_cryptodev_sym_session_pool_private_data { > > > > > return 0; > > > > > } > > > > > > > > > > +#ifdef RTE_CRYPTODEV_CALLBACKS > > > > > +/* spinlock for crypto device enq callbacks */ static > > > > > +rte_spinlock_t rte_cryptodev_enq_cb_lock =3D > > > > > +RTE_SPINLOCK_INITIALIZER; #endif > > > > > > > > > > const char * > > > > > rte_cryptodev_get_feature_name(uint64_t flag) @@ -1449,6 > > > > > +1454,158 > > > > @@ > > > > > struct rte_cryptodev * > > > > > rte_spinlock_unlock(&rte_cryptodev_cb_lock); > > > > > } > > > > > > > > > > +#ifdef RTE_CRYPTODEV_CALLBACKS > > > > > +int > > > > > +rte_cryptodev_rcu_qsbr_add(uint8_t dev_id, struct rte_rcu_qsbr > > > > > +*qsbr) { > > > > > + > > > > > + struct rte_cryptodev *dev; > > > > > + > > > > > + if (!rte_cryptodev_pmd_is_valid_dev(dev_id)) { > > > > > + CDEV_LOG_ERR("Invalid dev_id=3D%" PRIu8, dev_id); > > > > > + return -EINVAL; > > > > > + } > > > > > + > > > > > + dev =3D &rte_crypto_devices[dev_id]; > > > > > + dev->qsbr =3D qsbr; > > > > > + return 0; > > > > > +} > > > > > > > > So if I understand your patch correctly you propose a new working > > > > model for > > > > crypto-devs: > > > > 1. Control-plane has to allocate/setup rcu_qsbr and do > > > > rte_cryptodev_rcu_qsbr_add(). > > > > 2. Data-plane has somehow to obtain pointer to that rcu_qsbr and > > > > wrap > > > > cryptodev_enqueue() > > > > with rcu_qsbr_quiescent() or rcu_qsbr_online()/rcu_qsbr_offline= (). > > > Yes. I think, it is not a new model. It is same as RCU integration wi= th LPM. > > > Please refer: https://patches.dpdk.org/cover/73673/ > > > > I am talking about new working model for crypto-dev enqueue/dequeue. > > As I said above now it becomes data-plane thread responsibility to: > > -somehow to obtain pointer to that rcu_qsbr for each cryptodev it is u= sing. > > -call rcu sync functions (quiescent/online/offline) on a regular basis= . > It is not on regular basis. When data plane comes up, they report online. > They report quiescent when they are done with critical section or shared = structure. I understand that, but it means all existing apps have to be changed that w= ay. > All though, there is some dataplane changes involved here, I don't think,= it is major. I still think our goal here should be to make no visible changes to the dat= aplane. I.E. all necessary data-plane changes need to be hidden inside CB invocatio= n part. =20 >=20 > > Note that now data-plane thread would have to do that always - even if > > there are now callbacks installed for that cryptodev queue right now. > > All that changes behaviour of existing apps and I presume would reduce > > adoption of that fature. > There is always trade off involved! > In the previous patch, you suggested that some lazy app may not free up t= he > memory allocated by add cb. For such apps, this patch has sync mechanism > with some additional cost of CP & DP changes. Sigh, it is not about laziness of the app. The problem with current ethedev cb mechanism and yours V1 (which was just = a clone of it) - CP doesn't know when it is safe after CB removal to free related memory. > > I still think all this callback mechanism should be totally opaque to d= ata-plane > > threads - user shouldn't change his app code depending on would some > > enqueue/dequeue callbacks be installed or not. > I am not sure, how that can be implemented with existing RCU design. As I said below the simplest way - with calling rcu onine/offline inside CB= invocation block. That's why I asked you - did you try that approach and what is the perf num= bers? I presume with no callbacks installed the perf change should be nearly zero= . > @Honnappa Nagarahalli, Do you have any suggestions? >=20 > > > > > > > > > > > > > That seems quite a big change and I don't think it is acceptable fo= r > > > > most users. > > > > From my perspective adding/installing call-backs to the dev has to > > > > be opaque to the data-plane code. > > > > Also note that different callbacks can be installed by different > > > > entities (libs) and might have no idea about each other. > > > > That's why I thought it would be better to make all this RCU stuff > > > > internal inside cryptodev: > > > > hide all this rcu_qsbr allocation/setup inside cryptod somehow = to > > obtain pointer to that rcu_qsbr ev init/queue setup > > > > invoke rcu_qsbr_online()/rcu_qsbr_offline() inside > > cryptodev_enqueue(). > > > I have already tried exploring above stuffs. There are too many const= raints. > > > The changes don't fit in, as per RCU design. > > > > Hmm could you be more specific here - what constraints are you referrin= g > > to? > > > > > Moreover, having rcu api under enqueue_burst() will affect the > > performance. > > > > It most likely will. Though my expectation it will affect performance o= nly > > when some callbacks are installed. My thought here: > > callback function by itself will affect cryptdev_enqueue performance > > anyway, > With existing callback design, I have measured the performance(with crypt= o perf test) on xeon. > It was almost negligible and same was shared with Declan. I am asking about different thing: did you try alternate approach I describ= ed, that wouldn't require changes in the user data-plane code. > That is one of the reasons, I didn't want to add to many stuffs in to the= callback. > The best part of existing design is crypto lib is not much modified. > The changes are either pushed to CP or DP. >=20 > so adding extra overhead for sync is probably ok here. I think that extra overhead when callbacks are present is expected and probably acceptable. Changes in the upper-layer data-plane code - probably not. > > Though for situation when no callbacks are installed - perfomance shoul= d be > > left unaffected (or impact should be as small as possible). > > > > > The changes are more on control plane side, which is one time. > > > The data plane changes are minimal. > > > > I still think upper layer data-plane code should stay unaffected (zero > > changes). > > > > > > > > > > > + > > > > > +struct rte_cryptodev_enq_callback * > > > > > +rte_cryptodev_add_enq_callback(uint8_t dev_id, > > > > > + uint16_t qp_id, > > > > > + rte_cryptodev_enq_cb_fn cb_fn, > > > > > + void *cb_arg) > > > > > +{ > > > > > + struct rte_cryptodev *dev; > > > > > + struct rte_cryptodev_enq_callback *cb, *tail; > > > > > + > > > > > + if (!cb_fn) > > > > > + return NULL; > > > > > + > > > > > + if (!rte_cryptodev_pmd_is_valid_dev(dev_id)) { > > > > > + CDEV_LOG_ERR("Invalid dev_id=3D%" PRIu8, dev_id); > > > > > + return NULL; > > > > > + } > > > > > + > > > > > + dev =3D &rte_crypto_devices[dev_id]; > > > > > + if (qp_id >=3D dev->data->nb_queue_pairs) { > > > > > + CDEV_LOG_ERR("Invalid queue_pair_id=3D%d", qp_id); > > > > > + return NULL; > > > > > + } > > > > > + > > > > > + cb =3D rte_zmalloc(NULL, sizeof(*cb), 0); > > > > > + if (cb =3D=3D NULL) { > > > > > + CDEV_LOG_ERR("Failed to allocate memory for callback on " > > > > > + "dev=3D%d, queue_pair_id=3D%d", dev_id, qp_id); > > > > > + rte_errno =3D ENOMEM; > > > > > + return NULL; > > > > > + } > > > > > + > > > > > + cb->fn =3D cb_fn; > > > > > + cb->arg =3D cb_arg; > > > > > + > > > > > + rte_spinlock_lock(&rte_cryptodev_enq_cb_lock); > > > > > + if (dev->enq_cbs =3D=3D NULL) { > > > > > + dev->enq_cbs =3D rte_zmalloc(NULL, sizeof(cb) * > > > > > + dev->data->nb_queue_pairs, 0); > > > > > + if (dev->enq_cbs =3D=3D NULL) { > > > > > + CDEV_LOG_ERR("Failed to allocate memory for > > > > callbacks"); > > > > > + rte_errno =3D ENOMEM; > > > > > + rte_free(cb); > > > > > + return NULL; > > > > > + } > > > > > + } > > > > > + > > > > > + /* Add the callbacks in fifo order. */ > > > > > + tail =3D dev->enq_cbs[qp_id]; > > > > > + if (tail) { > > > > > + while (tail->next) > > > > > + tail =3D tail->next; > > > > > + tail->next =3D cb; > > > > > + } else > > > > > + dev->enq_cbs[qp_id] =3D cb; > > > > > + > > > > > + rte_spinlock_unlock(&rte_cryptodev_enq_cb_lock); > > > > > + > > > > > + return cb; > > > > > +} > > > > > + > > > > > +int > > > > > +rte_cryptodev_remove_enq_callback(uint8_t dev_id, > > > > > + uint16_t qp_id, > > > > > + struct rte_cryptodev_enq_callback *cb) { > > > > > + struct rte_cryptodev *dev; > > > > > + struct rte_cryptodev_enq_callback **prev_cb, *curr_cb; > > > > > + uint16_t qp; > > > > > + int free_mem; > > > > > + int ret; > > > > > + > > > > > + free_mem =3D 1; > > > > > + > > > > > + if (!cb) { > > > > > + CDEV_LOG_ERR("cb is NULL"); > > > > > + return -EINVAL; > > > > > + } > > > > > + > > > > > + if (!rte_cryptodev_pmd_is_valid_dev(dev_id)) { > > > > > + CDEV_LOG_ERR("Invalid dev_id=3D%" PRIu8, dev_id); > > > > > + return -EINVAL; > > > > > + } > > > > > + > > > > > + dev =3D &rte_crypto_devices[dev_id]; > > > > > + if (qp_id >=3D dev->data->nb_queue_pairs) { > > > > > + CDEV_LOG_ERR("Invalid queue_pair_id=3D%d", qp_id); > > > > > + return -EINVAL; > > > > > + } > > > > > + > > > > > + if (!dev->qsbr) { > > > > > + CDEV_LOG_ERR("Rcu qsbr is NULL"); > > > > > + return -EINVAL; > > > > > + } > > > > > + > > > > > + rte_spinlock_lock(&rte_cryptodev_enq_cb_lock); > > > > > + if (dev->enq_cbs =3D=3D NULL) { > > > > > + rte_spinlock_unlock(&rte_cryptodev_enq_cb_lock); > > > > > + return -EINVAL; > > > > > + } > > > > > + > > > > > + prev_cb =3D &dev->enq_cbs[qp_id]; > > > > > + for (; *prev_cb !=3D NULL; prev_cb =3D &curr_cb->next) { > > > > > + curr_cb =3D *prev_cb; > > > > > + if (curr_cb =3D=3D cb) { > > > > > + /* Remove the user cb from the callback list. */ > > > > > + *prev_cb =3D curr_cb->next; > > > > > + ret =3D 0; > > > > > + break; > > > > > + } > > > > > + } > > > > > + > > > > > + if (!ret) { > > > > > + /* Call sync with invalid thread id as this is part of > > > > > + * control plane API */ > > > > > + rte_rcu_qsbr_synchronize(dev->qsbr, > > > > > + RTE_QSBR_THRID_INVALID); > > > > > + rte_free(cb); > > > > > + } > > > > > + > > > > > + for (qp =3D 0; qp < dev->data->nb_queue_pairs; qp++) > > > > > + if (dev->enq_cbs[qp] !=3D NULL) { > > > > > > > > Some reference count (number of callbacks) seems like a better > > > > approach here. > > > Ok. > > > > > > > > > + free_mem =3D 0; > > > > > + break; > > > > > + } > > > > > + > > > > > + if (free_mem) { > > > > > + rte_free(dev->enq_cbs); > > > > > + dev->enq_cbs =3D NULL; > > > > > + } > > > > > + > > > > > + rte_spinlock_unlock(&rte_cryptodev_enq_cb_lock); > > > > > + > > > > > + return ret; > > > > > +} > > > > > +#endif > > > > > > > > > > int > > > > > rte_cryptodev_sym_session_init(uint8_t dev_id, diff --git > > > > > a/lib/librte_cryptodev/rte_cryptodev.h > > > > > b/lib/librte_cryptodev/rte_cryptodev.h > > > > > index 7b3ebc2..2c7a47b 100644 > > > > > --- a/lib/librte_cryptodev/rte_cryptodev.h > > > > > +++ b/lib/librte_cryptodev/rte_cryptodev.h > > > > > @@ -530,6 +530,32 @@ struct rte_cryptodev_qp_conf { }; > > > > > > > > > > /** > > > > > + * Function type used for pre processing crypto ops when enqueue > > > > > +burst is > > > > > + * called. > > > > > + * > > > > > + * The callback function is called on enqueue burst immediately > > > > > + * before the crypto ops are put onto the hardware queue for > > processing. > > > > > + * > > > > > + * @param dev_id The identifier of the device. > > > > > + * @param qp_id The index of the queue pair in which > > ops are > > > > > + * to be enqueued for processing. The > > value > > > > > + * must be in the range [0, > > nb_queue_pairs - 1] > > > > > + * previously supplied to > > > > > + * *rte_cryptodev_configure*. > > > > > + * @param ops The address of an array of *nb_ops* > > pointers > > > > > + * to *rte_crypto_op* structures which > > contain > > > > > + * the crypto operations to be > > processed. > > > > > + * @param nb_ops The number of operations to process. > > > > > + * @param user_param The arbitrary user parameter passed > > in by the > > > > > + * application when the callback was > > originally > > > > > + * registered. > > > > > + * @return The number of ops to be enqueued > > to the > > > > > + * crypto device. > > > > > + */ > > > > > +typedef uint16_t (*rte_cryptodev_enq_cb_fn)(uint16_t dev_id, > > > > > +uint16_t > > > > qp_id, > > > > > + struct rte_crypto_op **ops, uint16_t nb_ops, void > > > > *user_param); > > > > > + > > > > > +/** > > > > > * Typedef for application callback function to be registered by > > application > > > > > * software for notification of device events > > > > > * > > > > > @@ -853,7 +879,6 @@ struct rte_cryptodev_config { > > > > > enum rte_cryptodev_event_type event, > > > > > rte_cryptodev_cb_fn cb_fn, void *cb_arg); > > > > > > > > > > - > > > > > typedef uint16_t (*dequeue_pkt_burst_t)(void *qp, > > > > > struct rte_crypto_op **ops, uint16_t nb_ops); > > > > > /**< Dequeue processed packets from queue pair of a device. */ @= @ > > > > > -870,6 +895,17 @@ typedef uint16_t (*enqueue_pkt_burst_t)(void > > > > > *qp, > > > > > /** Structure to keep track of registered callbacks */ > > > > > TAILQ_HEAD(rte_cryptodev_cb_list, rte_cryptodev_callback); > > > > > > > > > > +/** > > > > > + * @internal > > > > > + * Structure used to hold information about the callbacks to be > > > > > +called for a > > > > > + * queue pair on enqueue. > > > > > + */ > > > > > +struct rte_cryptodev_enq_callback { > > > > > + struct rte_cryptodev_enq_callback *next; > > > > > + rte_cryptodev_enq_cb_fn fn; > > > > > + void *arg; > > > > > +}; > > > > > + > > > > > /** The data structure associated with each crypto device. */ > > > > > struct rte_cryptodev { > > > > > dequeue_pkt_burst_t dequeue_burst; @@ -898,6 +934,14 @@ > > struct > > > > > rte_cryptodev { > > > > > __extension__ > > > > > uint8_t attached : 1; > > > > > /**< Flag indicating the device is attached */ > > > > > + > > > > > +#ifdef RTE_CRYPTODEV_CALLBACKS > > > > > + struct rte_cryptodev_enq_callback **enq_cbs; > > > > > + /**< User application callback for pre enqueue processing */ > > > > > + > > > > > + struct rte_rcu_qsbr *qsbr; > > > > > + /** < RCU QSBR variable for rte_cryptodev_enq_callback */ > > > > > > > > Probably better to have both these fields per queue. > > > > Space for them can be allocated at dev_configure() or so. > > > enq_cbs is allocated during callback add. > > > Unlike ethdev, each cryptodev have their own max queue pair. There is= no > > macro for that. > > > I think, single RCU should be good enough, as it has mechanism to tra= ck all > > its reporting threads. > > > > > > > BTW, wouldn't it make sense to have ability to add callback for deq= ueue > > too? > > > As mentioned in the commit message, this patch was driven by a > > requirement. > > > If required, callback for the dequeue can be added in a separate patc= h. > > > > > > > > > +#endif > > > > > } __rte_cache_aligned; > > > > > > > > > > void * > > > > > @@ -1019,6 +1063,18 @@ struct rte_cryptodev_data { > > > > > struct rte_crypto_op **ops, uint16_t nb_ops) { > > > > > struct rte_cryptodev *dev =3D &rte_cryptodevs[dev_id]; > > > > > +#ifdef RTE_CRYPTODEV_CALLBACKS > > > > > + if (unlikely(dev->enq_cbs !=3D NULL && dev->enq_cbs[qp_id] !=3D > > > > NULL)) { > > > > > + struct rte_cryptodev_enq_callback *cb =3D > > > > > + dev->enq_cbs[qp_id]; > > > > > + > > > > > + do { > > > > > + nb_ops =3D cb->fn(dev_id, qp_id, ops, nb_ops, > > > > > + cb->arg); > > > > > + cb =3D cb->next; > > > > > + } while (cb !=3D NULL); > > > > > + } > > > > > +#endif > > > > > > > > > > rte_cryptodev_trace_enqueue_burst(dev_id, qp_id, (void **)ops, > > > > nb_ops); > > > > > return (*dev->enqueue_burst)( > > > > > @@ -1351,6 +1407,102 @@ struct rte_cryptodev_asym_session * > > > > > struct rte_cryptodev_sym_session *sess, union rte_crypto_sym_of= s > > > > ofs, > > > > > struct rte_crypto_sym_vec *vec); > > > > > > > > > > +#ifdef RTE_CRYPTODEV_CALLBACKS > > > > > +/** > > > > > + * @warning > > > > > + * @b EXPERIMENTAL: this API may change without prior notice > > > > > + * > > > > > + * Add a user callback for a given crypto device and queue pair > > > > > +which will be > > > > > + * called on crypto ops enqueue. > > > > > + * > > > > > + * This API configures a function to be called for each burst of > > > > > +crypto ops > > > > > + * received on a given crypto device queue pair. The return valu= e > > > > > +is a pointer > > > > > + * that can be used later to remove the callback using > > > > > + * rte_cryptodev_remove_enq_callback(). > > > > > + * > > > > > + * Multiple functions are called in the order that they are adde= d. > > > > > + * > > > > > + * @param dev_id The identifier of the device. > > > > > + * @param qp_id The index of the queue pair in which > > ops are > > > > > + * to be enqueued for processing. The > > value > > > > > + * must be in the range [0, > > nb_queue_pairs - 1] > > > > > + * previously supplied to > > > > > + * *rte_cryptodev_configure*. > > > > > + * @param cb_fn The callback function > > > > > + * @param cb_arg A generic pointer parameter which > > will be > > > > passed > > > > > + * to each invocation of the callback > > function on > > > > > + * this crypto device and queue pair. > > > > > + * > > > > > + * @return > > > > > + * NULL on error. > > > > > + * On success, a pointer value which can later be used to remo= ve the > > > > callback. > > > > > + */ > > > > > + > > > > > +__rte_experimental > > > > > +struct rte_cryptodev_enq_callback * > > > > > +rte_cryptodev_add_enq_callback(uint8_t dev_id, > > > > > + uint16_t qp_id, > > > > > + rte_cryptodev_enq_cb_fn cb_fn, > > > > > + void *cb_arg); > > > > > + > > > > > + > > > > > +/** > > > > > + * @warning > > > > > + * @b EXPERIMENTAL: this API may change without prior notice > > > > > + * > > > > > + * Remove a user callback function for given crypto device and q= ueue > > pair. > > > > > + * > > > > > + * This function is used to removed callbacks that were added to > > > > > +a crypto > > > > > + * device queue pair using rte_cryptodev_add_enq_callback(). > > > > > + * > > > > > + * Note: The callback expects a RCU QSBR to be configured to > > > > > +synchronize > > > > > + * to free the memory. Application is expected to configure RCU > > > > > +QSBR after > > > > > + * adding an enqueue callback. > > > > > + * > > > > > + * > > > > > + * @param dev_id The identifier of the device. > > > > > + * @param qp_id The index of the queue pair in which > > ops are > > > > > + * to be enqueued for processing. The > > value > > > > > + * must be in the range [0, > > nb_queue_pairs - 1] > > > > > + * previously supplied to > > > > > + * *rte_cryptodev_configure*. > > > > > + * @param cb Pointer to user supplied callback > > created via > > > > > + * rte_cryptodev_add_enq_callback(). > > > > > + * > > > > > + * @return > > > > > + * - 0: Success. Callback was removed. > > > > > + * - -EINVAL: The dev_id or the qp_id is out of range, or the= callback > > > > > + * is NULL or not found for the crypto device queu= e pair. > > > > > + */ > > > > > + > > > > > +__rte_experimental > > > > > +int rte_cryptodev_remove_enq_callback(uint8_t dev_id, > > > > > + uint16_t qp_id, > > > > > + struct rte_cryptodev_enq_callback *cb); > > > > > + > > > > > + > > > > > +/** > > > > > + * @warning > > > > > + * @b EXPERIMENTAL: this API may change without prior notice > > > > > + * > > > > > + * Associate RCU QSBR variable with a cryptodev. > > > > > + * > > > > > + * This function is used to add RCU QSBR to a crypto device. > > > > > + * The purpose of RCU is to help multiple threads to synchronize > > > > > + * with each other before initiating adding/removing callback > > > > > + * while dataplane threads are running enqueue callbacks. > > > > > + * > > > > > + * @param dev_id The identifier of the device. > > > > > + * @param qsr RCU QSBR configuration > > > > > + * @return > > > > > + * On success - 0 > > > > > + * On error - EINVAL. > > > > > + */ > > > > > + > > > > > +__rte_experimental > > > > > +int rte_cryptodev_rcu_qsbr_add(uint8_t dev_id, struct > > > > > +rte_rcu_qsbr *qsbr); #endif > > > > > + > > > > > #ifdef __cplusplus > > > > > } > > > > > #endif > > > > > diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map > > > > > b/lib/librte_cryptodev/rte_cryptodev_version.map > > > > > index 02f6dcf..46de3ca 100644 > > > > > --- a/lib/librte_cryptodev/rte_cryptodev_version.map > > > > > +++ b/lib/librte_cryptodev/rte_cryptodev_version.map > > > > > @@ -64,6 +64,7 @@ DPDK_20.0 { > > > > > rte_cryptodev_sym_capability_get; }; > > > > > > > > > > + > > > > > EXPERIMENTAL { > > > > > global: > > > > > > > > > > @@ -105,4 +106,9 @@ EXPERIMENTAL { > > > > > > > > > > # added in 20.08 > > > > > rte_cryptodev_get_qp_status; > > > > > + > > > > > + # added in 20.11 > > > > > + rte_cryptodev_add_enq_callback; > > > > > + rte_cryptodev_remove_enq_callback; > > > > > + rte_cryptodev_rcu_qsbr_add; > > > > > }; > > > > > -- > > > > > 1.9.1