From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A42DA04DD; Wed, 28 Oct 2020 15:57:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 749FBCB7A; Wed, 28 Oct 2020 15:57:15 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 58AEACB53 for ; Wed, 28 Oct 2020 15:57:12 +0100 (CET) IronPort-SDR: V+deiRPj38UdjnHpqlfcv6z31zJupmnw0vCT1/572cgLkb4ZqUTN7tIKTOOV3Fr1vzCTLzV5xs XjU2W1ymFi2Q== X-IronPort-AV: E=McAfee;i="6000,8403,9788"; a="252967479" X-IronPort-AV: E=Sophos;i="5.77,426,1596524400"; d="scan'208";a="252967479" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2020 07:57:11 -0700 IronPort-SDR: EwDTUn5DMH34WUtz6EFYD9+SPGEF5Y8+PlUrzrFQrB+6QuYNpxnqRLNJgSFlqFZFeqFp/xPgQ8 VjGIJXMlqE+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,426,1596524400"; d="scan'208";a="361774971" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga007.jf.intel.com with ESMTP; 28 Oct 2020 07:57:10 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 28 Oct 2020 07:57:10 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 28 Oct 2020 07:57:10 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 28 Oct 2020 07:57:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YkfoZIRUOv3xngQ9UVSGgW7aC0zhYMVWXDX1WhY8GtrCXuhoMEnrIImLeJWQsl7WRMIRqnZhnmjaK4xHeC4PpWY/2li9cxV5uhHtRlT4jMgfoQ2giQldGW0e9thQwE2bpqoxoCXAF4SOTZS4ZSD4gVk5O22BrR9toVRGd7M/kWNZ6grC24fsuDv1SuF0JtlekHF3u/KXMMWngqVr5N482bZYq69wGf2OV6eq2SbXaSHL22freiy+nUn9T4C//LMCa8w2AKJlTb7VTQkDXM41+lOftbs1ASb1ST1JrM2X6OH25ItUv/NcU+X3The0IGn6gVajbPQejTBWgb8k9igQwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9eNnLDelkao7/0Y8SwvJaCUXuddrxqpq+p5PNEp3jtc=; b=Hxl9HrYA4eUIGAXsBjAkzGwrd5YiqWXB+OKtU3WwRtPvsZy3P7SH7IAXClbBvHBb/jo1bDAABBVaSn3kM6R44cEr3BlGTO/zNS5KcS/QzqFiSnkeUTW9+P6aphMU3ViD1F5fAZSwMC0SU9SqD7hsOd4Wnf1cnqNxVTFPAMgXr0x8n0RnN7HmI3+I8fgZsX05lOIlKa2Oq63QA0dl2wngry+5e+n1qizM62A9wQ/4rQBdjinW8LoNCzKifymrcS9UhTIKKs7RwDkSU7Z5tPqnuGDETN+0veLHGCcpro1Sk61m/0KrEDgMWDtBph2lueGTIEcVt1ofP7tKK+oiR0PsAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9eNnLDelkao7/0Y8SwvJaCUXuddrxqpq+p5PNEp3jtc=; b=X9Hr7epVpq/d5Fim7WBpjaq6uicmGrZVuo47xgwQPxoNGDjZfr045zuRmn1oU57WvURDIjZvqOX+Q6lrcQ19dHrJPpUyIkVtd72c2zs9CnqzlfWVTHllRck42qaBDpSjndn/y8o0T2tNWWWyol3a4qQ/0rLJBpnzJdHc/zvZaEk= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by SJ0PR11MB4846.namprd11.prod.outlook.com (2603:10b6:a03:2d8::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.19; Wed, 28 Oct 2020 14:57:06 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f5a4:3f6b:ade3:296b]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f5a4:3f6b:ade3:296b%3]) with mapi id 15.20.3499.027; Wed, 28 Oct 2020 14:57:06 +0000 From: "Ananyev, Konstantin" To: Thomas Monjalon , "Ma, Liang J" , Jerin Jacob CC: dpdk-dev , "Ruifeng Wang (Arm Technology China)" , "Wang, Haiyue" , "Richardson, Bruce" , "Hunt, David" , Neil Horman , "McDaniel, Timothy" , "Eads, Gage" , "Marcin Wojtas" , Guy Tzalik , Ajit Khaparde , Harman Kalra , John Daley , "Wei Hu (Xavier" , Ziyang Xuan , "matan@nvidia.com" , Yong Wang , "david.marchand@redhat.com" Thread-Topic: [PATCH v10 0/9] Add PMD power mgmt Thread-Index: AQHWrHHIiDY8SQAY5UWYT2H68H2gNamrnCUAgAFpQ4CAAAQNgIAACQoAgAABRaA= Date: Wed, 28 Oct 2020 14:57:06 +0000 Message-ID: References: <1603494392-7181-1-git-send-email-liang.j.ma@intel.com> <20201028133507.GC29706@sivswdev09.ir.intel.com> <2373759.1G5EZAqFcn@thomas> In-Reply-To: <2373759.1G5EZAqFcn@thomas> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [46.7.39.127] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dcbdf648-ab35-4e88-a590-08d87b51bce4 x-ms-traffictypediagnostic: SJ0PR11MB4846: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: seefmayai9FZP+RXH7ZvKkkpBQt91ruvScBgxOVZ80atN7FOJ73DR1NVrhMInxwIBF8y6IpSxHSwzGwTExkcElIU+NUYy6LQndYpQ8hz5Tslh5jxjrb3b/dJGAbSZwioF9QT3EftsMs6fzYLN0FWiysQBBELU5I5in8CsoNtHBOv9Fmoih+Pc/yqd/xZ1vBx0ISEcreA5OZT2qKInrV7viuB3iE+tEmYxJ6R4tvnPI4M8smgSmwaVa8zxJYhdcXa5F7Gb1FRja8HdudqcoB5UG+2B4hwAhthqCNX5XkBdHAFqTNLAcoNnD4Q57ED2wxuf7NE/etSpfNbM8SSPapYmw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(346002)(366004)(396003)(376002)(136003)(4326008)(66476007)(66556008)(66446008)(64756008)(52536014)(5660300002)(33656002)(86362001)(8676002)(83380400001)(53546011)(316002)(6506007)(7696005)(110136005)(71200400001)(26005)(76116006)(186003)(8936002)(7416002)(2906002)(478600001)(55016002)(66946007)(54906003)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: fYDW+/FVcx62ftYHOwSBjx9Hi4eYnJAXbMYBfzGiPaILqlDpRUhGoilGucdyfqFOjZ+mKMWWR7Us9vlYcw/MVLJaINoWLKTZTYr4+lm2YNHrxGeYVjYjJt09ywMVWtxSxlVg/lQum3KrZzPJF1N+i6M6w7/xuk9f/bL3FGNDEH3y0POPs6gMlPfH2A+M3wwMofQgzVm0TRgECxGMwSS2miwuxXTTQF9+cg0o7JAwe+JU9tEPLpjhciUG1h2cdnW5xZ0SWtZL2e4odRBlSb4D2z458TWx9o1MTBCBqj4wMc4YLXqxqrnobA3ehM6ffJQQq7CRc7NHR5JDbhzFhgSvxBToSLlgn9O+CUg1M2ZkKMiEgcE7G5cEEtABfXQR79cSJUQnUz6ejCLNo5CI1ZY+1juuMljIoo9QdyarrHR8nyIsES0FvuaSOyXmaCtGizv9if/7w2BQsrazBR00u/VKJlc2PHpdg1f+8khRBtN5YfbBGK2tCu8cQrytO8W4hb3tk0WkJuiuQ405BoPGoPU6X8xJewZ54BJZfiUebHfP3fZUOsbaQRDHCdy/tVyOW2tY01UELGoH8orXYDR3GJ9VSNmABWW8g2mhUCTagfnUbssR6NDYd8ylGLGnKVD+nDmmHsaX6u/thRBhsdPjcaw2iQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dcbdf648-ab35-4e88-a590-08d87b51bce4 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2020 14:57:06.2025 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WzpZ5XuFMtX0QheaBiyAI3oHDrav1aQr3sNG3KZPZ6PpodjGFULYdFxrtJNki6qpbOvhTvb+hpll06c77VT+bfgBh7FnRLwuzQUB0nsyWP4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4846 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v10 0/9] Add PMD power mgmt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > 28/10/2020 14:49, Jerin Jacob: > > On Wed, Oct 28, 2020 at 7:05 PM Liang, Ma wrote: > > > > > > Hi Thomas, > > > I think I addressed all of the questions in relation to V9. I don't= think I can solve the issue of a generic API on my own. From the > Community Call last week Jerin also said that a generic was investigated = but that a single solution wasn't feasible. > > > > I think, From the architecture point of view, the specific > > functionally of UMONITOR may not be abstracted. > > But from the ethdev callback point of view, Can it be abstracted in > > such a way that packet notification available through > > checking interrupt status register or ring descriptor location, etc by > > the driver. Use that callback as a notification mechanism rather > > than defining a memory-based scheme that UMONITOR expects? or similar > > thoughts on abstraction. I think there is probably some sort of misunderstanding. This API is not about providing acync notification when next packet arrives= . This is about to putting core to sleep till some event (or timeout) happens= . >From my perspective the closest analogy: cond_timedwait(). So we need PMD to tell us what will be the address of the condition variabl= e we should sleep on. =20 > I agree with Jerin. > The ethdev API is the blocking problem. > First problem: it is not well explained in doxygen. > Second problem: it is probably not generic enough (if we understand it we= ll) It is an address to sleep(/wakeup) on, plus expected value. Honestly, I can't think-up of anything even more generic then that.=20 If you guys have something particular in mind - please share. >=20 > > > This API is experimental and other vendor support can be added as nee= ded. If there are any other open issue let me know? >=20 > Being experimental is not an excuse to throw something > which is not satisfying. >=20 >=20