From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A373BA04B7; Sun, 20 Sep 2020 17:18:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B622D1D9DD; Sun, 20 Sep 2020 17:18:21 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id CF6A51D5D5 for ; Sun, 20 Sep 2020 17:18:19 +0200 (CEST) IronPort-SDR: S6N5zw94JV/VidLgpwhajFmUFXk+dpIgTFZR5Uiu1ryBEOIVMPUiMmqpzAo9wV817npAYd1Jjn 8NHMWVnTYFag== X-IronPort-AV: E=McAfee;i="6000,8403,9750"; a="157631397" X-IronPort-AV: E=Sophos;i="5.77,283,1596524400"; d="scan'208";a="157631397" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2020 08:18:18 -0700 IronPort-SDR: 2gnoygmS36hwyAQQSEFDmuW6E5BDFh1gguSpRRiNdr3ngcH9S6YwmTwehkQ50xhfE2GKNUE+yK gBY4mwYxCm9A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,283,1596524400"; d="scan'208";a="411512326" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga001.fm.intel.com with ESMTP; 20 Sep 2020 08:18:18 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 20 Sep 2020 08:18:18 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Sun, 20 Sep 2020 08:18:17 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Sun, 20 Sep 2020 08:18:17 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Sun, 20 Sep 2020 08:18:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NGkNHiG//KjV2v5kSlSQI4NuAO+/KQRCxuu17Ra8PrpodN9NJlWvijVET3ABPJOoKU0axIbBxfnI/PRkihfpxlfGo2RcF+SxgwsCTlbk//ty5tIkKD53y+fSQLcy+GNs4U3WHpw1ne9UoskapYT8v+KX2J1zBBaHYs8jMP+SrjCdf+rQr64YM2YIQqoagcB4Stag32tr6vaWUI6eQ+db5tFperU2mGC19+Twu7O2N4atTfLJQ4C9+OJZ9Dhr4vJOKHggrmc0zpnfptzIcn8IRmrVTrj1T6XzPVItdNzW/6j3NvLdoRPkP3Y3tfiHCUSVOg7uTAtOi6sKCLNc72Ebiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qgkIHhWwC1NslsqoGShZ6nGVkgGLzoxHd3UIz3WK6Ag=; b=Lurhcii44vREU4cM+j6RDBeuu1M6SdkM0PsUqUOi50Hkzzg7TMaD700XTYQN6YRrgxAFnf8VcrChE2M9cdVhPbgnwSi+VgD8Im0yYsQAT/MUKaLYXLOl1qzwKZFx68W5DUHkzcF2hhKeWazf1qT9ZMzs/4nIl8z9VE84rrWfrOnjbj8sQdnuf7A9y7i2ABKf9gzkfdTxdd2KUw5bDPTaheXTHVqXRwXSxv5yJJUAf5PO5fvZKBpKFinPOnzfQ//3/cCiWS2CuKyg4KUvhZgkrt0LQdUPvHumpbS35WhKSR8xnuHaxp3r5q6lIPZKNhl/ZGtchOqOP9lWYc6lRdmrTQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qgkIHhWwC1NslsqoGShZ6nGVkgGLzoxHd3UIz3WK6Ag=; b=HoftdlfGIEBjQrHOtHNOuFRwsNEsv554i8TZoRGoyUMUcYxR0YRiB2OtiyXCaz7KaAmwmpPETd+XZj15uJ+HCa+dyfVd6rH7F5Yl+Ol4e7EcxGTGpx+qq3j/dCjw67Ud8+oX3J57UIG27ThAtHdv4iY28ZXMOKZagukmjeeNbBA= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB2535.namprd11.prod.outlook.com (2603:10b6:a02:be::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Sun, 20 Sep 2020 15:18:14 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f43b:a137:dab8:8b0b]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f43b:a137:dab8:8b0b%6]) with mapi id 15.20.3391.011; Sun, 20 Sep 2020 15:18:09 +0000 From: "Ananyev, Konstantin" To: Feifei Wang CC: "dev@dpdk.org" , "nd@arm.com" Thread-Topic: [dpdk-dev] [PATCH v6 0/7] Thread-Index: AQHWj0QcqqIJdK9zwkqKHt5ekn2IkKlxo7aQ Date: Sun, 20 Sep 2020 15:18:08 +0000 Message-ID: References: <20200729063105.11299-1-feifei.wang2@arm.com> <20200920114856.20697-1-feifei.wang2@arm.com> In-Reply-To: <20200920114856.20697-1-feifei.wang2@arm.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [46.7.39.127] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c154a7d5-8e08-495a-e65b-08d85d7861da x-ms-traffictypediagnostic: BYAPR11MB2535: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iCk+cXomp1gXEPc00w9DnJj1l8aOPmMo32TLPh4X71f6DXF5R9hqcdIqTDzZgLc+adqnpJObQwDAoEgk+SS+/SEbb3USbZxuUcxFwZF1MLUNcIVx/+/RtprOIcFZEs1rPYPNSOEm+Q2FoolK1zD6Ov0SPKdw+SZqJYf93f8ixK5oUseF4V0NteQjNqartsL55o7dAI6yy3HGhcAfp5kvmwMF3F1wfXjG6/2ul5H/M8dMIZ/wTWZMk3fHmOBJH19bELoGIhpl9eSBc9gd2bCRA2xC5MuYUT/osZ2S5xnydVrbqRD7hjnMgDBKyCU3IjFS x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(346002)(396003)(39860400002)(376002)(186003)(9686003)(76116006)(7696005)(478600001)(66946007)(86362001)(26005)(6506007)(316002)(4326008)(2906002)(33656002)(66476007)(66446008)(71200400001)(8676002)(8936002)(55016002)(5660300002)(83380400001)(54906003)(6916009)(64756008)(52536014)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: Gk3XLU1UjtoI9uPs4wBy7fLgVEsD5INbDHq7AIsDCaOXQMtUHMHHNvkm+JjatArTImXUp5vX0l73i7VpsZY8d7CTjHInQUSMU4McAp7fr0G/2pYomnshJzkBfgCcVooc0gI9o1AZVUJcmk3SDatQojObTHKASFF/WbkuwBMNDJkJZjYalF0S+9grmvHb635XuKFGNYcz4lLvBrP0o4qXSxVFhG3bdbiGaktbitUoU+ulOnP/TdeTNw2zMfv9cWNH8cG53bObYmOB9QpBrrtWnI2OZoMq7Eerm5jIok962+gaQpfKUKfnJGu0kngjLlrgkltjrKDsxGFB/bIFooXguxOo1HMtMCVP9REkcn99pXA/lWrNcZl9mDcrcfrLL4BwlDM5StJg5SFH10x3WAsfUE6Yb5tzpgu0mbVV5kXaA4tOjpZGSXhmxsyncX+Az+xaxUSjCHk7A0poS1rcwdaFXJjE5wRF6e33/CwpF43D2v7W7okJr5yQoWDFyob20r0cZBVuLdvHyBMIZD2HP/QBusKolQGhqEJeJA3sARHrGJ1K8cKF3foE9xt4Yj8jZh6rUueeUGUu4kJ2gmnHDd7boJXVK/MUIx6UdRHFIgVe2YLswzoNLteAZX1Ht9aHF1/JhEwd1psWE32rmT7aS9xZ/A== x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3301.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c154a7d5-8e08-495a-e65b-08d85d7861da X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Sep 2020 15:18:09.0520 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Z9y3et7FwoQgFNsPlnwKzzZBpQQGevGRjfyfCPwW7w+pRJ2Yl2NBUaho+Tex0aVnyFMl9D669CT6lMZ+HzQkGB0D04OJ1MSkKdwOnBux30M= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2535 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v6 0/7] X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > Several bugs in ring unit tests were identified and fixed. >=20 > Added data validation on objects after enqueue/dequeue operations for > data integration check. >=20 > Unit tests were enhanced by checking return value of enqueue/dequeue > operations and validating data integrity of objects. >=20 > v2: > 1. add check to validate the dequeued objects in test_ring.c and fix > some bugs of it. (David/Honnappa) > 2. remove the patch to change the description for the param of > rte_ring_[sp/mp]_enqueue APIs. (David/Konstantin/Honnappa) >=20 > v3: > 1. Adjust the 'check dequeued objects' patch from the last to the first > in the series. (Honnappa) > 2. Add the new function 'test_ring_mem_cmp to replace 'memset' and print > information of enqueue/dequeue elements if validation fails. (Honnappa) > 3. Add test to validate the whether the enqueue and dequeue operation is > successful for each time. (Honnappa) > 4. Expand the scope of application for the macro TEST_RING_VERIF, and > replace all ring APIs check with this macro. (Honnappa) >=20 > v4: > 1. Split the 'memcmp' bug fix patch into two patches, one is memcmp > issue patch, the other is to add new function 'test_ring_mem_cmp'. > (Honnappa) >=20 > v5: > 1. Adjust bug fixed patches to the first of the series, to ensure that > the back porting will go smooth. (Honnappa) >=20 > v6: > 1. Add extra parameter to the macro. (Konstantin) >=20 > Feifei Wang (7): > test/ring: fix wrong parameter passed to the enqueue APIs > test/ring: fix wrong number of enq/deq elements > test/ring: fix wrong size used in memcmp > test/ring: add check to validate dequeued objects > test/ring: validate the return value of enq/deq elements > test/ring: add new function to validate dequeue data > test/ring: improve the application of macro >=20 > app/test/test_ring.c | 362 ++++++++++++++++++++++--------------------- > app/test/test_ring.h | 6 +- > 2 files changed, 192 insertions(+), 176 deletions(-) Series acked-by: Konstantin Ananyev > -- > 2.17.1