From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A5A1A04FD; Tue, 9 Jun 2020 12:00:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E96E7288C; Tue, 9 Jun 2020 12:00:21 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 959B9262E for ; Tue, 9 Jun 2020 12:00:19 +0200 (CEST) IronPort-SDR: HeNDU7AzFBHjuu0hQ1XJDAj+r04DxpM1FD8RFGu8ZLNLUMrN0s2i98dU6FE+he+bcQec2wsfVV fyUez5rmG1+w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jun 2020 03:00:18 -0700 IronPort-SDR: DLtOPawcI5O/w6wsEQ8CW/YrSNRnEHNWnduCPer4Cl5HOaQBMakINRZy5Avq/6WHjcnl6O5vnJ p+JK71bLpAvw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,491,1583222400"; d="scan'208";a="288780791" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga002.jf.intel.com with ESMTP; 09 Jun 2020 03:00:18 -0700 Received: from orsmsx156.amr.corp.intel.com (10.22.240.22) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jun 2020 03:00:18 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX156.amr.corp.intel.com (10.22.240.22) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jun 2020 03:00:17 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 9 Jun 2020 03:00:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GlSZPT2ou9pFf6TIcb8ukP0/pUd355pp2oS1rByiO2EmDLVxXi0egFXqQmD9bOZC5T1eA1fJk4XN8qTkwRvd353bVhhE7WRkNMRAwjNTHsYL38cqTmtQCsNihVY44Lc143Jnm4A/yuahlUCON+DybRw94ssYj1J8uAyFadiVxwYQ5NKEVKprdJ0tcrKcqxpn76ePHAfpmxPYV5ma3uPiXjzGyXhiiCwDfllu+IwCjbEyHjdgOo2LCOaNxSJRQ6IYX4rgSuZNAnpf9C9DJGqaDWoGy3DWSv5T8O23Rtm4qqREgRto6MSz0z9aN9kNX07kaDLsI8orhGwfh02+z8Q3TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=piW/XpdlPntC3Z0mWG1NaiLcNXMrimNQltFnjuiCxSE=; b=jF0mvCy+vZS9ouCbaR02uROc0mycjeAMBveCFe32A1LJiRnLdR7BSWymcvX1QhT8eKhgH+DlLgBIkkvCq83k+fsLEzYlpuPa3ngsWLTVphfcNltpVXotpb8MynGfmy1KOwafSf5a0vmnslrIPiAWLGRQCoXe351k0/szzEfW3WdcEKk2XsKleyeK5TaDf5WYpYQJl2WAx57jPeYyXNRvBznaP00XfvXQVhA2xIBA8PhXvd0771ULEDOwvPV4TYSOjlDtu0BrzCkpydcW+zbPkn4XTQs8e999GgkkbIrsOD1AmQMvwG2HjWY97CEF9lerChiC6N4p0gUO5l2gVu7D6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=piW/XpdlPntC3Z0mWG1NaiLcNXMrimNQltFnjuiCxSE=; b=XF5s9QkdqEISyjCoRnbuYeENvhEXVQs+tH2SvrdPSd9uAPhFnODeO1Acz5+WH+lZiVPmQVC6xIX0FKD9rS0z5+8gXV3IICrAMvSxt8mniJWVJ1qzVCQuhd5jA0mXd+i/m2ehq/4O5KDZY733GcYue2kMb70Zb8ueamFZfCFcSmk= Received: from BYAPR11MB3301.namprd11.prod.outlook.com (2603:10b6:a03:7f::26) by BYAPR11MB3511.namprd11.prod.outlook.com (2603:10b6:a03:84::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3066.18; Tue, 9 Jun 2020 10:00:16 +0000 Received: from BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f160:29ab:b8f9:4189]) by BYAPR11MB3301.namprd11.prod.outlook.com ([fe80::f160:29ab:b8f9:4189%6]) with mapi id 15.20.3066.023; Tue, 9 Jun 2020 10:00:15 +0000 From: "Ananyev, Konstantin" To: "Richardson, Bruce" , Stephen Hemminger CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH RFC] devtools: increase default line length to 100 Thread-Index: AQHWPbSHYb4gUcPaGUu3JUlKdtBjc6jPF3aAgADuK4CAAAescA== Date: Tue, 9 Jun 2020 10:00:15 +0000 Message-ID: References: <20200608164640.189755-1-bruce.richardson@intel.com> <20200608121723.7a042105@hermes.lan> <20200609092949.GA1565@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200609092949.GA1565@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.166] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 82344c30-2716-4c70-0a84-08d80c5be8c1 x-ms-traffictypediagnostic: BYAPR11MB3511: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 042957ACD7 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Wvr7NGdSrPlie10Fzi45LHXKXcx32Gl/pm78MsvkWdpydtN3vMHpOKaN850mq5ntGkhVSjno+QjJn1ThCXWIh+2TjMkAFCoCL7PnDG7I6DuwZwSMQtqNpzk7xBjTprDpjclyccR3jLP+0eG2pud1StgnmmLt+e1HfPGIYDcniisr1LLHOofTIQJ2LWOkcg4SRoKk3UW3wX32/Wsu76OB6itQhNQJwZmWcjmQaVz19GjkS876qVSiZm4ZK8wxFPytEdoi/c3xE7umuW4GY4Cvo6Q+pV/GSDOa3uuLgHFAzhyYR9oEro7ehKwRATEjpW9UjFN6TQ137Un6K2bUElLGKixq9yLhgUt3oI/uoqZGjHqbUVkeIIrWy3PgVHNU8cC7Ep1MiDfedjDzd1XJ8fzz5w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3301.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(366004)(136003)(376002)(39860400002)(346002)(396003)(26005)(66476007)(966005)(66946007)(478600001)(110136005)(52536014)(76116006)(2906002)(316002)(64756008)(66446008)(66556008)(8676002)(8936002)(86362001)(4326008)(5660300002)(55016002)(6506007)(71200400001)(7696005)(83380400001)(33656002)(186003)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: vAA9kVcFIXZFEM2r+hzHq09PNR4qOp4Ymnw1n6v4AYqmjUH/j5a4f+42AJTqXLxaiDs1IldLm+Qtc7pIPbrofQw+ccOdoqb7GfY3rM4DLDXqAieTob5f9e6351SmmBP8tom6nhd6hTfqpqwq6S23/E4VUvTKbffvLG+u6D7hKHhnAR16Fe5qIIo7hFJ1GNijwYk4/fXFmT40/qKRdqzhamilrG8q4dLurGKnAfo7NK1NHR89S4UgxkAkMy54r/AfVgh08fI3YHa1hSctP4B5iOefraZY7Lx1M7VQuMg2tEW5d11XXipprkY8xWX4yn92SSwHa41PFqIQuildv4dweSUZRtj33wNjvcvvU33HxXr1bx/h5WO7YU5we0neoTvSIS+6ddjHG0JkL+uuBKu7oUxsjbdEwxJW/U/pgu/LIKFcoDQebggVWmqxYFoDhZDirdlbXaXWb32Plcwa69URvEVGtXGya8aD0Gt9UIfkLzjfffswa0bug6pnlP28KZAP Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 82344c30-2716-4c70-0a84-08d80c5be8c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jun 2020 10:00:15.7718 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WqkWcSd6kFbqA5gY1B0tfsmoVORTHjodGT5xAlIT8Cvj5th0TUW4vwgOl3AYUq7izRO8Uc7iKLJF/tZ6wsL+JATv3ZObI+D+yq6EKEamuA8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3511 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH RFC] devtools: increase default line length to 100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >=20 > On Mon, Jun 08, 2020 at 12:17:23PM -0700, Stephen Hemminger wrote: > > On Mon, 8 Jun 2020 17:46:40 +0100 > > Bruce Richardson wrote: > > > > > Rather than continuing to recommend an 80-char line limit, let's take= a hint > > > from the Linux kernel[1] and aim for an 100-char recommended limit in= stead. > > > > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.gi= t/commit/?id=3Dbdc48fa11e46f867ea4d75fa59ee87a7f48be144 > > > > > > Signed-off-by: Bruce Richardson > > > --- > > > devtools/checkpatches.sh | 2 +- > > > doc/guides/contributing/coding_style.rst | 2 +- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh > > > index 158087f1c..4970ed830 100755 > > > --- a/devtools/checkpatches.sh > > > +++ b/devtools/checkpatches.sh > > > @@ -15,7 +15,7 @@ VALIDATE_NEW_API=3D$(dirname $(readlink -f $0))/che= ck-symbol-change.sh > > > # Codespell can also be enabled by setting DPDK_CHECKPATCH_CODESPELL= to a valid path > > > # to a dictionary.txt file if dictionary.txt is not in the default l= ocation. > > > codespell=3D${DPDK_CHECKPATCH_CODESPELL:-enable} > > > -length=3D${DPDK_CHECKPATCH_LINE_LENGTH:-80} > > > +length=3D${DPDK_CHECKPATCH_LINE_LENGTH:-100} > > > > > > # override default Linux options > > > options=3D"--no-tree" > > > diff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/co= ntributing/coding_style.rst > > > index 4efde93f6..1db3a7bbe 100644 > > > --- a/doc/guides/contributing/coding_style.rst > > > +++ b/doc/guides/contributing/coding_style.rst > > > @@ -21,7 +21,7 @@ The rules and guidelines given in this document can= not cover every situation, so > > > * In the case of creating new files, the style should be consistent = within each file in a given directory or module. > > > * The primary reason for coding standards is to increase code readab= ility and comprehensibility, therefore always use whatever option > will make the code easiest to read. > > > > > > -Line length is recommended to be not more than 80 characters, includ= ing comments. > > > +Line length is recommended to be not more than 100 characters, inclu= ding comments. > > > [Tab stop size should be assumed to be 8-characters wide]. > > > > > > .. note:: > > > > I would even support going to 120 characters. > > > > Acked-by: Stephen Hemminger >=20 > I think 100 is enough. >=20 > In my case, I have a 1080p 24" monitor, and with two terminals side-by-si= de > 100 characters just fits inside each vim window. Going to 120 would be fi= ne > for single terminal at a time, but I would find awkward for e.g. > side-by-side diff comparison in meld etc. My preference would be to keep things as it is - 80 chars per line. Having multiple different formatting styles in one source file looks really awkward and make it hard to follow.