From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FD6B41DC6; Fri, 3 Mar 2023 11:58:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2368040687; Fri, 3 Mar 2023 11:58:30 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id F3CF4400D6 for ; Fri, 3 Mar 2023 11:58:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677841108; x=1709377108; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=9jrBG64OLCTZbvxyUxWUANGp1twvE7jxbIklhwiz3po=; b=XECenT0WPOK8U6vemN8Xkn0nk+POjw2RynZRmPTM7AG5bQ3upOLVGrms UYdF1wC66jcIWkfbWSYqZphJxb6/6Nf4yv3/JnsZH6Zb0YlKImutQvBgD J0bg4QPVRyfV7gLcrb5919m6tRM1zQhFxcqOybIa9h8ZZv5T6Mm+SN1o+ BbjX2sVePHfuY+4V+l6YAwx2Gbey4s/+Y4uVOfghKGkqmNpLWIF9v/aWz jZ43CRYGBLhwfScpYlB1Qlmde31qwVAn0JfRtNFThTeoI9/PC1zOUT82b xxgoRMOFhwsul2ur59yt4000jsF2fYk0KpOcCwVvGXX4Tzq1i0SKnH+kH g==; X-IronPort-AV: E=McAfee;i="6500,9779,10637"; a="318840168" X-IronPort-AV: E=Sophos;i="5.98,230,1673942400"; d="scan'208";a="318840168" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2023 02:58:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10637"; a="668616731" X-IronPort-AV: E=Sophos;i="5.98,230,1673942400"; d="scan'208";a="668616731" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga007.jf.intel.com with ESMTP; 03 Mar 2023 02:58:26 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 3 Mar 2023 02:58:26 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Fri, 3 Mar 2023 02:58:26 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.48) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Fri, 3 Mar 2023 02:58:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SqX1gheg7CE5kxRl9s/Ixu4e8VWvtbjU2T+22tX+uEiWu3Fp+ihTt8+oeM5mJYaFloizwxg6RVt+A3ht4+V+aQv1wgYE0RPC1uvF525oho/rQB/04lXSiCtElYiYImgkvQ7eL+k1ExITAmeKnd5ZdogvdE29bzJcMGBzS+FaUQa/L/vwgHGPK73HDSjzz4b3LgTRMw5nW3DTk/P1ucHbw/Z0VvHdkiDHTdyrIGKnQN9sCGGzxo8F47BXRm0qUA/czBLbUsO6+LQJIrSkvp9FEP84eBvjI/GYVr9hlVfa8kncIeZWhCu+o3aQSfpM7mBB+uP3W1cAZ036d1tJpbz8IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ykZW4ktNlfPtcxFBC3CSaGii6lQXhovHI+D4Z3Im/Dg=; b=X0OqyshQp72IdYI0blVDI6AC3CpVaVNTgJ8QnoftynmPgH5nir/4DbaOpGU8KWy65trgyNN7iAozWMq8f0W1H+yM51t2YZDZhsn1gZWeFPYJ6bydvfiwZw4NM3zGMAD1JJ3NC4Q51zmVLRD4e15PLw8llhV2+UJg8D72paQyAbbjlWTgdybbUy06gxY4MXb3FGblCx94cppyGUrO54VSbzZ2QALsbgWbaLTcei1G5XD4uSSQYPW8wtK9mz0fvBwSqL8iw8tlCZetk9/QMju9szvYKqoL+McbYrok6qGQA+GH6fb92XByH4rDVYfVbUm4JaevOdlFr728qw4c0aqdFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3366.namprd11.prod.outlook.com (2603:10b6:a03:7f::20) by DS7PR11MB6173.namprd11.prod.outlook.com (2603:10b6:8:9b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.19; Fri, 3 Mar 2023 10:58:24 +0000 Received: from BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::7d29:65ab:81a8:91b7]) by BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::7d29:65ab:81a8:91b7%7]) with mapi id 15.20.6156.018; Fri, 3 Mar 2023 10:58:24 +0000 From: "Pattan, Reshma" To: "Sevincer, Abdullah" , "dev@dpdk.org" CC: "jerinj@marvell.com" , "stephen@networkplumber.org" , "Sevincer, Abdullah" Subject: RE: [PATCH v6] app/procinfo: display eventdev xstats for PMD data Thread-Topic: [PATCH v6] app/procinfo: display eventdev xstats for PMD data Thread-Index: AQHZRyNlzm7pS/2fS0WmI+zTZ2QuwK7o0jXw Date: Fri, 3 Mar 2023 10:58:24 +0000 Message-ID: References: <20220409153056.1010236-1-timothy.mcdaniel@intel.com> <20230223010819.4164765-1-abdullah.sevincer@intel.com> In-Reply-To: <20230223010819.4164765-1-abdullah.sevincer@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB3366:EE_|DS7PR11MB6173:EE_ x-ms-office365-filtering-correlation-id: 989f7cec-4592-4aad-fa5f-08db1bd635c1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dPThXXj3OAjPhWU6qFkxzTurh7kefoIH1xyDAB5zqRpuM2JRp5vzCgPQeYt1Cq1+0Zl+0QSADaHiRM+lcRDgd/LPu++bIzRwJ+PrE74h7VeQP/576h61OUNBhbIvCFHCvvIZqmlGV7zLXillXcF/pTOcN/O8/hxZtAPeP91sch4Bc6NrlokU5QTC/C8zeyCxos0iSNWd9MN6UvWgO7t8fJvsD0+HSw2rV837d7amBq8h0Mvbhc1Wh4V2ui1XWfxQmocp29z+rHdJuwbrcE+g4jRri4ZESrNSbVc5Yc2XBp0yt0a2GpETwuJGH2sKf/+T59E0wgVJfgeAmXMSD2mpL+6hqgOUvjmGLP7Xr/26RCK96huhnp58lKau48+asf8wsEg/sqRoaIJ73lKS4ruZN8vwKwTrUM4boZEiY/f3BYuYOexfgBYZfjm8k6X8kzWr5s2d/DvZyP2gA50I9CP/y/o6qRGfhWgRCMdCYqQrzJeC4D68eqUakzwtrVsdLF8EHmS5l+vrgjydQZDrpJqkFLg67U4NNTPTmXGVo/gWTrOmsaNIgMMGzOZ3CgwcIeykKeU1h6Wibb9yGhrjDOhaEm61XYwcCSPJlWql2VqZCrjHkFxLxtAMz0mcFeWse/4ZSXPK8Wm12agb/1yBrS5Xo6SB1792cM0q6/5ZCh5R2mc5wvZ7ek7chH8Plind9yZn9rwE4sSFg9++1KIaPl4dheHpbGyMJ+F9ZJFzgtgnNNQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3366.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(376002)(396003)(136003)(366004)(346002)(39860400002)(451199018)(33656002)(107886003)(6506007)(9686003)(186003)(110136005)(54906003)(316002)(41300700001)(2906002)(64756008)(8676002)(66446008)(66946007)(7696005)(76116006)(4326008)(52536014)(478600001)(5660300002)(82960400001)(38100700002)(122000001)(71200400001)(8936002)(86362001)(38070700005)(55016003)(66476007)(66556008)(83380400001)(181643002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mA11ZwlzRkllIY9MEQcwy5aLgUzyDdLzTiM0kOVbGxmEpKwrgNpppXGc6WxR?= =?us-ascii?Q?kZdF/TJj2AoAF99cmn+jz6atvzQ4LEz7W9LLs6aE1qpZUJETELlYBYE+Vjhu?= =?us-ascii?Q?iVAJVm/kmjRcqNmkVXpqPiwCRLDzVyhv0CFohO7DdHDX/lNeqZFo9C3Pb+Yu?= =?us-ascii?Q?yMCt7Vjt12PPMrk/9fHJc3ySNuEV5DeKpdN8NFCFVQJRI+bud7Upn/a0bVn0?= =?us-ascii?Q?E6RzwZw1gSn93e3jFAYkdo7ROU2GlWAEQvV022Tge1r4JxwVcFR7JoE7nzO1?= =?us-ascii?Q?ZYSzzYJQMiESQRDcHvrzHz/WgODbY5Tb8YfhgYiFbNoMom1k4HfVQqXziqbJ?= =?us-ascii?Q?rqlv6eOdbEY1srJSQ731AxWmBraEW3ryfdx9E7o00Uw8FvZX7DPSS/GTV/W4?= =?us-ascii?Q?ZUqoqexgxJH9/9KM87l13Xod9vUR4MZSNzzy5dN6EQx5ROHmM8K4lrpK01Wj?= =?us-ascii?Q?CbalK+t3yzUQT5hwhHvl4rNChkWgal07w9SHoE3U3gaQOu8Iloz6EwghmpCp?= =?us-ascii?Q?/myG+uq1JYTFPOJgjWswJudtgQv/wC/ZYCFq3qCqwzTq/J0P4/K5K6CkRQ+U?= =?us-ascii?Q?lM3nz1kWJu7NCOb2l/o2EZzECbv4fjCiG4FwzSY8cmKfv8W/AEdFpZhLdqKt?= =?us-ascii?Q?8ii6miavOMqFFwx7ApY4HYZ+MMdZM913jQ5JfplJJBbXkBqhKisOJ+CfoGZM?= =?us-ascii?Q?qBJ7niGvs47k2arRLmz0c5CWrpaSNjVIcTxJt5vjE0CtWW+tqFxLRs2tA+w1?= =?us-ascii?Q?5/rHJemPKGyx0VZviYW29GHdNpHy57IzhLaQgWy+U9NoadfO6KtdPQH6v59X?= =?us-ascii?Q?uMFy3eoaK8I22qWu2OqfZt7mTdltePeniIYjIK1jQaSQPEFne9EdZmPG4Tyx?= =?us-ascii?Q?MCL0A2J+DFQ1NykF+hFmZnoWsTxGONFc7FJebxajG3i2hz/gFAIJE576h8Zx?= =?us-ascii?Q?//dbChBo7WDmnmVtbUbgtcatTzXOliW45byCGgtx397AMQN3gnUYHNl403u/?= =?us-ascii?Q?S0h2hIRnwYi7RLirZUvvoPT2oQJaZVb3EQM3guJi0TVupW3f4i4mEmms8Cih?= =?us-ascii?Q?Xp+K8WaoQjC40K11uCuV7zwa7mRuE6naJaoCeoD+jn0V3Mky0jfOw+LEGhw8?= =?us-ascii?Q?z8GqBW4GO31jqlQpnTtr2yiEX4qOOWAOUo66YPU/alp0ICa6E+shMgIwj2DG?= =?us-ascii?Q?xQvAfvu1+utuedP4MqNBHIZS7nXlpHUCI1P8X8emyPrkXejxC3Crybwvl6OV?= =?us-ascii?Q?frYfU5lfo6rEtwsNXcUTBnH5rtXgyfhvXNyYDeOG/iUfJQJ5R0pqourPoGSd?= =?us-ascii?Q?/JFqngXWTK4o8CNF/DUy8VojkLKp+CbgW3od4Z9jaz4qn7lbNYkKqAh0khMv?= =?us-ascii?Q?ho5k/4IOY0EpMwonysQVz8G7N4MrkSbsuiRgs6CsG2VRasDBSE6JEXr/coxQ?= =?us-ascii?Q?7RSE2HJifD2DZ3ugn4OtdCGO1Ihdqy5t6LphztsgvK6NQue2IX1e10fWaR0u?= =?us-ascii?Q?ZonhvlEpkioq0StsuwGWC/pd6dgqdjSetGi8GKM+wt4rsLCWXbY/KZN7hHUr?= =?us-ascii?Q?QDzNyvG6GPV8mwmgvLsxZgYME+oiBQxyr5FPD2GKtspBD6PjrlvZsH1zXpkU?= =?us-ascii?Q?w4LIteueLgV2R+M3PjYqWO4eLamr7jF8BNZCCdlJn7bN?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3366.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 989f7cec-4592-4aad-fa5f-08db1bd635c1 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2023 10:58:24.1600 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +wU4p5TyW6Q3uScMgaTMqn6fkFaEBqa7NorfOrw9G2t6VDTpQi4Tbp4uD8weyXj8onSKONb6bRjfQ7vRVNC6qQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6173 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Abdullah Sevincer > Subject: [PATCH v6] app/procinfo: display eventdev xstats for PMD data >=20 I see you are supporting evendev stats print.=20 You can make the heading clear by removing "PMD data" > +++ b/doc/guides/tools/proc_info.rst > @@ -22,7 +22,9 @@ The application has a number of command line options: > --show-ring[=3Dname] | --show-mempool[=3Dname] | --iter-mempool=3Dnam= e | > --show-port-private | --version | --firmware-version | --show-rss-ret= a | > --show-module-eeprom | --show-rx-descriptor queue_id:offset:num | > - --show-tx-descriptor queue_id:offset:num ] > + --show-tx-descriptor queue_id:offset:num | --edev-stats-enable | > + --all-edev-queues | --edev-queue=3Dqueue_num | --all-edev-ports | > + --edev-port=3Dport_num | --edev-dump | --edev-reset | > + --edev-device-stats] >=20 On the design , I guess command line parameters can be simplified. So you c= an simplify the code also. 1) What is the difference between "--edev-stats-enable" and "--edev-device= -stats" ?=20 2) You no need to have 2 parameters to specify the port info "--edev-port= =3Dport_num" and "--all-edev-ports" 3)Similarly no need to have 2 parameters to specify queue info "--all-edev-= queues and --edev-queue=3Dqueue_num" 4) No need of "--edev-stats-enable". 5)You can perhaps have only 2 commands as below in place of all above comma= nds. In the below commands user can pass which "eventdev id" and "queue id" the = stats should be displayed for. Example: a)show-eventdev-stats=3D(eventdev id, queue)=20 =09 show-eventdev-stats=3D(*,*) =3D> Display all stats for all queues of all= eventdev ids show-eventdev-stats=3D(*,1) =3D> Display stats of queue 1of all eventde= v ids=20 show-eventdev-stats=3D(1,*) =3D> Display stats of all queues of eventdev= id 1=20 show-eventdev-stats=3D(1,1) =3D> Display stats of queue1 of eventdev id = 1=20 b)reset-eventdev-stats=3D( eventdev id, queue) Thanks, Reshma