DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Kearney, Tadhg" <tadhg.kearney@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "Hunt, David" <david.hunt@intel.com>,
	"Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: RE: [PATCH v2 1/3] power: add uncore API to power library
Date: Wed, 20 Jul 2022 16:10:07 +0000	[thread overview]
Message-ID: <BYAPR11MB33664D40F822B02D431551D9FF8E9@BYAPR11MB3366.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220713140706.4143705-2-tadhg.kearney@intel.com>



> -----Original Message-----
> From: Kearney, Tadhg <tadhg.kearney@intel.com>
> diff --git a/config/x86/meson.build b/config/x86/meson.build index
> +dpdk_conf.set('RTE_MAX_NUMA_DIE', 1)
> +dpdk_conf.set('RTE_MAX_UNCORE_FREQS', 32)

Check if these flags should be added to other platforms.

<snip>


> +Abstract
> +~~~~~~~~
> +Up to 60% power saving can be achieved by reducing the uncore frequency
> to its lowest value.

Might be give some intro on this before specifying directly the power saving.  Would be good to say power savings achieved instead of specific with any %.
Also

> +With later kernels, there is now a sysfs entry to allow adjustment of uncore
> frequency.

Kernel provides the driver "intel-uncore-frequency to control the uncore frequency limits for x86 platform. The driver is available from the kernel version 5.6 and above.

> diff --git a/lib/power/rte_power_uncore.c b/lib/power/rte_power_uncore.c
> +static int
> +set_uncore_freq_internal(struct uncore_power_info *ui, uint32_t idx) {
<snip>

> +	open_core_sysfs_file(&ui->f_cur_max, "rw+",
> POWER_UNCORE_SYSFILE_MAX_FREQ,

You have already this f_cur_max opened , you can re-use, instead of opening again.

Thanks,
Reshma

  reply	other threads:[~2022-07-20 16:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-13 14:07 [PATCH v2 0/3] add uncore api to be called through l3fwd-power Tadhg Kearney
2022-07-13 14:07 ` [PATCH v2 1/3] power: add uncore API to power library Tadhg Kearney
2022-07-20 16:10   ` Pattan, Reshma [this message]
2022-07-21  9:01     ` Bruce Richardson
2022-07-26 16:21       ` Kearney, Tadhg
2022-07-13 14:07 ` [PATCH v2 2/3] test/power: add unit tests for uncore API Tadhg Kearney
2022-07-13 14:07 ` [PATCH v2 3/3] l3fwd-power: add option to call " Tadhg Kearney
2022-07-21 12:15   ` Pattan, Reshma
2022-07-21 16:48   ` Pattan, Reshma
2022-09-06 10:51   ` Hunt, David
2022-09-19  9:05 ` [PATCH v3 0/3] add uncore api to be called through l3fwd-power Tadhg Kearney
2022-09-19  9:05   ` [PATCH v3 1/3] power: add uncore frequency control API to the power library Tadhg Kearney
2022-09-19  9:05   ` [PATCH v3 2/3] l3fwd-power: add option to call uncore API Tadhg Kearney
2022-09-19  9:05   ` [PATCH v3 3/3] test/power: add unit tests for " Tadhg Kearney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB33664D40F822B02D431551D9FF8E9@BYAPR11MB3366.namprd11.prod.outlook.com \
    --to=reshma.pattan@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=tadhg.kearney@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).