From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3378DA00C5; Wed, 20 Jul 2022 18:10:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C84C240697; Wed, 20 Jul 2022 18:10:13 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id D0AC340042 for ; Wed, 20 Jul 2022 18:10:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1658333412; x=1689869412; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=RtYXnVLssuQ1TNuYTVptx4pbxtggOorQCR948pgIYbc=; b=Z/ZA/AlGZkajDcAY0nBh0lY1FLvIHqxw3Qq24Jr73PLWdkwyOlDd85nf sHq8/zy5pDHanPCzmlDk2fJlH+ln66p3SAherFaCHM2Cosj301yhGD3PB wMLQrUKq2nZQvWFMNPis/5OKkfFkDQy/gMBGov3ujEk5IUitvcRdm4NPb 68S+rB+UjUyz7FSfPZsQ7HrDINdWz2uhqCV1QJUIBOrCFZpr+Mk0nPGQb c5UIuvX/rf68FWqjv1kW96vtCpm7PAeIKUGas87y79TKD6xPAcb4P5Vk3 iPn3XnNuT0brQpc799X5c5fBsYKrSTnXkuJicweFEYp3SE/Fexsvzqyuf A==; X-IronPort-AV: E=McAfee;i="6400,9594,10414"; a="266594809" X-IronPort-AV: E=Sophos;i="5.92,286,1650956400"; d="scan'208";a="266594809" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2022 09:10:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,286,1650956400"; d="scan'208";a="625724895" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga008.jf.intel.com with ESMTP; 20 Jul 2022 09:10:10 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Wed, 20 Jul 2022 09:10:09 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Wed, 20 Jul 2022 09:10:09 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 20 Jul 2022 09:10:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cWtoibl01HcNObp/M003wF4USTB0Huh0pshBsvvi++D4pEkV15FFIPw3QUJFa7deKzwqihM/ycUs1HMtiF5B+hSY14Jrtj62sBS+zm9gMdZOd8FnBJqMWlJvXhwLLM6hjydjWxv6GsUibkOo7Sef8P/IF8GqNRmYRU8Su9pTnlEWcaagQZC0dAgnXJDOiuN9/kUbIWXlEvONd/9hpGbO7nW9pTTLhqv7YMOyjpfBi0B+zqR9MuPWGl3gy5YTXwjZ7hr6eFvcwoiSqOr89LQbmHqJhUSVRVww6EHZNoSTxg3Q1mhcoiirJHXcqRCcz01KraH1M/IA74ueFGhhAE/hOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DEqqhaXiP+hUOPp1no1uC1CYCcTz2sSLe1Vjxfr+A98=; b=niOVIU9amVyQes2lThAX3ecZw/jq7CWmcHwixAZGb1L2DaNK4emBB1LxOdrgDSOCOt7vYrK5HHCp6MtOitnmHtQ1T7kSHcvpi0V82EXzJF+ZRtsVm65U9Bg2U4iZaungEAZ1Q7DCYfoUn+1yTLhDUsPxkxqgyuqdcvTTlNwze5JLV7MkdRPLMr22/OF47+KPsFtvHTHl1DQpjYON3MDUZRfseGnmloM4B2d+2Tyt/SSPc+GFrfWFKG5wwkPaKp0EUL9o+GOwZ6A5Y0ThMUSTl9WG/fePn8qlI37SCje2UkGKlLOprBEQSICfDEFfx+nFTmSt9YF8sEv8PrP750eZuQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3366.namprd11.prod.outlook.com (2603:10b6:a03:7f::20) by BN6PR1101MB2260.namprd11.prod.outlook.com (2603:10b6:405:53::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5458.18; Wed, 20 Jul 2022 16:10:07 +0000 Received: from BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::cb0:d200:dc4c:29a9]) by BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::cb0:d200:dc4c:29a9%7]) with mapi id 15.20.5438.023; Wed, 20 Jul 2022 16:10:07 +0000 From: "Pattan, Reshma" To: "Kearney, Tadhg" , "dev@dpdk.org" CC: "Hunt, David" , "Burakov, Anatoly" Subject: RE: [PATCH v2 1/3] power: add uncore API to power library Thread-Topic: [PATCH v2 1/3] power: add uncore API to power library Thread-Index: AQHYlsHnj8rlBUa0KEqEY3wBcaWoY62HXGgw Date: Wed, 20 Jul 2022 16:10:07 +0000 Message-ID: References: <20220713140706.4143705-1-tadhg.kearney@intel.com> <20220713140706.4143705-2-tadhg.kearney@intel.com> In-Reply-To: <20220713140706.4143705-2-tadhg.kearney@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e9876733-b880-456c-8ba0-08da6a6a5033 x-ms-traffictypediagnostic: BN6PR1101MB2260:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZbfqHA0+e1xnnE0oDJy6JONPTB+/PLkNkVfmm56ILdxbnwbSX22DtKcScsxZrLgvj+4K8tTkui+8ZKlzFSSHpBPL6eq9FeWWGeIYmBcsiP4lgZQoPrSNM1iosJ4+wptruCz2N+LJWAC8OEk+5IU9Uhynn0E4GkzSfJxFyf9SBtKxSdhbymHqluOCLW4iIJSkbGgbK4b82VvOARiNDpXLlfQSwbIe06Zb9ggjV7AgclPyu2Q3Muo3RvjdGoJojIwj49QdR1L4L2kVW2a7WI/wvuQyQ3kJwFXgdrngIJ6zayFEO026ZGyjdKqAmjEYt01vR9hAwKsG/MkhMh2zWvlCL4ZuUak2P88upTThrnnvYuSPIEWRLJdjAw86oDdRKYh5384Fj2xLxmDGkvYF00ZMkpFhn9kIV8GMY00G+A47LdCUBreUMxDRKwMFaCWYSjidLfLTKEZ09+ycHj3f4Y0AiGZwcVdq72jGq7eydJNiGnhtR3oMk17FaYuhBoQYqqGN0m3Xxf3A/1Y9Rng/csU7KKzvUuXIrBefAVhUvYnfP3B3bbuDs8XY8N/dv7gV9kP1+UFkZQXyI8e4tZu3vjNPQyWJDX7Mfo7LPwWVSoMdgigNmD7xCkajzJe9UgWq87+Nef8fKgSeDe/iqmGiFjh5DEP3fpSxBnuSc6LF7YZQPR5PT/sq9g+7Y0dJr/wo5QxIGCLJVLzQGALG1howt+OVNsVSX0Sdp3EikIps2PrrE2N/plZ+0LmCsfoe23dIIh9uxGtDCjYzV6G+XdTHJ9l1yoNZMgVgTwf51Ie4fPhVjtRdYIsWjf2xI+IAewSwLLqA x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3366.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(376002)(396003)(136003)(366004)(346002)(52536014)(4326008)(66946007)(66556008)(76116006)(41300700001)(2906002)(66476007)(8936002)(64756008)(66446008)(316002)(33656002)(122000001)(8676002)(478600001)(55016003)(71200400001)(5660300002)(82960400001)(107886003)(186003)(110136005)(6506007)(54906003)(86362001)(83380400001)(38100700002)(26005)(9686003)(7696005)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?r0rnv0V4Ygqp/3nR1G+VPsWpJMllGlQtcjT1z1ffgryZOBKZSGUGcx+PMJzT?= =?us-ascii?Q?OEObGLVYhEaIvIzbD2xtnjIChqgEpcK8U7m1nQ26x4okgaaw0gjXvlqtgepB?= =?us-ascii?Q?SCVemoRsOq4FSam/h7gG7KrLftq9aS1xsucj9FS4kxC/mrjGa6TZge7yWbEp?= =?us-ascii?Q?r+aTmz9ojpEwvRie9MstpEe3ah9QrNYXLpHv6kUkdwsza2PRvT04itq0q2JD?= =?us-ascii?Q?4djCLMLf3bOar+/z7COMtLUZBB1FPmmy7Tn5nDEiSuHkR6CCTSUATcW6xF0U?= =?us-ascii?Q?Khmx8zWbIsUQHXMY6VjlZ0eWwyJKoDEC2c2pq0vioQ1Y1Rx/tWGYkGioWXVz?= =?us-ascii?Q?5JizbBtPkBaIBYZvReWsVzS3rbXDQl3dGFayJbsfcuC/qyGMJuGoG5RxBA/F?= =?us-ascii?Q?Fjwg9DO8TcFB7XjC42e33p1Veq8rQxSv/j6likXP8IpbtWaRK1dv/2zT2uqp?= =?us-ascii?Q?RLja9iXWzQyD01AktGoE+Wbed2mINouXqLUiOnbivT1zpsD6ct6cf6lAjKma?= =?us-ascii?Q?QMYT/FqgoJn7xTxYhFeZDPdare1RswId4JC7smlEv1PTC1VO18FpKVLDv2Ob?= =?us-ascii?Q?APpyI7jsiYyll2IF0whY7by5ji3yNO0TNXuOmr60VNbhVPbdPEe578kA1/+A?= =?us-ascii?Q?P69ax/t5kgcREW0van8bLxu4RkjS362nrQ3D7tXomJYYv5EFeYMN+WwaVSBq?= =?us-ascii?Q?pjbEbC1yqQOk8yd2EBvvlCtq/90w/ShFNRkm0+6IsyHwl1hGAcJdpjRDjBsd?= =?us-ascii?Q?+QLJ/JgEjjKalipS7+K6f8qZapuEcaFXBiW0iy7z/TGp3J8z7R036SztrGCH?= =?us-ascii?Q?ms/VATa+KBaSv2sfpWpnUyvXWo3VNrnR31PgTsFM7o0KgdJC5UuR6Wyx6j2D?= =?us-ascii?Q?ZYOEhP9R54+Clcqrks8/NHrklA1LyEeIH5Do4xhIEZrSphNXqQs6wZC3qX5g?= =?us-ascii?Q?CYvlgyPjSoXqL0m4NgTD0ijIb42S302YwJALpP/1Efs+2+rug4Pn8eIvT95M?= =?us-ascii?Q?29vji1eZak9rHb5YmnWKdSHkr+0jrX0VdS+O2kGByR+4FAImtpxxy1DPdV0H?= =?us-ascii?Q?dfXLly84sC6VGUv2DM4b1+NbqqVpcNdhAeEH1rSHM5SXNWxKM6RAHeeJcP5/?= =?us-ascii?Q?slPAV93OXnRwMgP/apU7DNKF6gXQSqFkMhCdbxr3MmOw6CAUViGnYt88GbJW?= =?us-ascii?Q?Oocvi+I3s4Z/XxUFXRhFNGsv2fmMJ/fsxaNGqZsDu0v5qvcST1wWS7sU9zKe?= =?us-ascii?Q?ad6THBsizVQfhE0rNXxvJCLbAb4oo1mufFuVd1Q2pFw5LNoIFBDq4q71tfV+?= =?us-ascii?Q?QeU30b0V3rZ29N71LiLILF7QS/w3VLZ9m7gNt1egvQ2KTl8MaMn9WIdXDahG?= =?us-ascii?Q?YVt687Rcus9ExIQice4EPvQT9nT/wA8HgCXgS/KfmvHgD6/q/+Ci1syu7fch?= =?us-ascii?Q?qLXonIFt8vjtRJT5ygwiT3UW7ED4Ry1HPYMDjGLBZERhxrfaAyi/KyCzxmIp?= =?us-ascii?Q?kwPchU9tl9qjuBCtKnqgfHAABACaVrjE9zCMuDvRnNS7GDKEdqg3izQxON8C?= =?us-ascii?Q?JszXmtqBe9X8CSJBl3TZaJ7xbfHbOytvUxao86Tf?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3366.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e9876733-b880-456c-8ba0-08da6a6a5033 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2022 16:10:07.0823 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5wIgLZwWQg0QjPgPhw9S32jy/DXDtaEgVMu/j2T2xcbMczlq5IUU4aYKD1tiJhnF2ZdHyebyTFBmWfXfp3JdOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2260 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Kearney, Tadhg > diff --git a/config/x86/meson.build b/config/x86/meson.build index > +dpdk_conf.set('RTE_MAX_NUMA_DIE', 1) > +dpdk_conf.set('RTE_MAX_UNCORE_FREQS', 32) Check if these flags should be added to other platforms. > +Abstract > +~~~~~~~~ > +Up to 60% power saving can be achieved by reducing the uncore frequency > to its lowest value. Might be give some intro on this before specifying directly the power savin= g. Would be good to say power savings achieved instead of specific with an= y %. Also > +With later kernels, there is now a sysfs entry to allow adjustment of un= core > frequency. Kernel provides the driver "intel-uncore-frequency to control the uncore fr= equency limits for x86 platform. The driver is available from the kernel ve= rsion 5.6 and above. > diff --git a/lib/power/rte_power_uncore.c b/lib/power/rte_power_uncore.c > +static int > +set_uncore_freq_internal(struct uncore_power_info *ui, uint32_t idx) { > + open_core_sysfs_file(&ui->f_cur_max, "rw+", > POWER_UNCORE_SYSFILE_MAX_FREQ, You have already this f_cur_max opened , you can re-use, instead of opening= again. Thanks, Reshma