From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Kaur, Arshdeep" <arshdeep.kaur@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: RE: [PATCH] SCSY-192443 Fix DPDK-dumpcap for XRAN Library
Date: Tue, 6 Sep 2022 16:31:14 +0000 [thread overview]
Message-ID: <BYAPR11MB33665CB634D1D85176D02AB4FF7E9@BYAPR11MB3366.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220829074821.283063-1-arshdeep.kaur@intel.com>
> -----Original Message-----
> From: Kaur, Arshdeep <arshdeep.kaur@intel.com>
> Subject: [PATCH] SCSY-192443 Fix DPDK-dumpcap for XRAN Library
> <snip>
> Issue: By default, dpdk-dumpcap tries to listen to
> /var/run/dpdk/rte/mp_socket, whereas in flexran a socket is created at
> /var/run/dpdk/<file-prefix>/mp_socket. File prefix is provided to flexran via
> config files which is used in EAL options. There is no way in dpdk-dumpcap
> today to provide file-prefix.
>
> Fix: Added a new parameter "-m" to handle this requirement. User needs to
> provide "-m <file-prefix> as first argument to dpdk-dumpcap.
Remove SCSY* from heading
Heading should beging with the example name that you are modifying that is "dumpcap:".
Tell exactly what you are adding in this patch. No need to add for whom you are doing this patch and all.
So, Heading can be as simple as "dumpcap: add the mutiprocess fileprefix support"
With these changes you can send the V2.
This is not the issue and you are not fixing it. This is some new support you are adding. So need to reframe your commit message.
Thanks,
Reshma
next parent reply other threads:[~2022-09-06 16:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220829074821.283063-1-arshdeep.kaur@intel.com>
2022-09-06 16:31 ` Pattan, Reshma [this message]
[not found] ` <20220907162659.260812-1-arshdeep.kaur@intel.com>
2022-09-12 8:54 ` [PATCH v2] dumpcap: add the mutiprocess fileprefix support Kaur, Arshdeep
2022-09-12 12:43 ` Arshdeep Kaur
2022-09-12 14:50 ` Stephen Hemminger
2022-09-12 19:03 ` [RFT] dumpcap: add file-prefix option Stephen Hemminger
2022-09-16 8:19 ` Kaur, Arshdeep
2022-09-16 12:51 ` Ben Magistro
2022-09-16 15:35 ` Stephen Hemminger
2022-09-19 11:19 ` Kaur, Arshdeep
2022-09-23 11:46 ` Kaur, Arshdeep
2022-10-17 5:08 ` Kaur, Arshdeep
2022-10-20 10:43 ` Kaur, Arshdeep
2022-10-20 15:40 ` Stephen Hemminger
2022-10-20 11:55 ` Kaur, Arshdeep
2022-10-21 13:07 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB33665CB634D1D85176D02AB4FF7E9@BYAPR11MB3366.namprd11.prod.outlook.com \
--to=reshma.pattan@intel.com \
--cc=arshdeep.kaur@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).