From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07ABEA0C3F; Thu, 15 Apr 2021 19:05:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C13CF16240A; Thu, 15 Apr 2021 19:05:49 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id F2DBF162409 for ; Thu, 15 Apr 2021 19:05:47 +0200 (CEST) IronPort-SDR: boo7HSXyRtqR9/T2kAcZux0RagKsVBgVCNYSeK6FPPiZJDekMwOnAI6I4hcQXe4/eP3QPdS6sk XrTcJ+hHsung== X-IronPort-AV: E=McAfee;i="6200,9189,9955"; a="215406758" X-IronPort-AV: E=Sophos;i="5.82,225,1613462400"; d="scan'208";a="215406758" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2021 10:05:07 -0700 IronPort-SDR: urzQd53g+jUdCK2BwW99R4JeNSESMzx0JYK0fmpYlM24t7YEpNS+pzua+mDw+3rMG4399QXtxj 1GMG2HNlR1sQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,225,1613462400"; d="scan'208";a="399635595" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga002.jf.intel.com with ESMTP; 15 Apr 2021 10:05:06 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 15 Apr 2021 10:05:06 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 15 Apr 2021 10:05:06 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Thu, 15 Apr 2021 10:05:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JsNgmc4Na753w0C4KKFoXsategx0eWHtlahhasXaV9g6b97RP5sTlHz4Bw2Kvg4xfPPk+AT1Z15UclGqbGrwO6xZEnlnLd9HYaOCFKecD7Nps6oWPWmhZl9r/Xq3pZb7pZQoQrI2AM3CEMFiRSKEoiI5ikG58bRAPhBY6PBBUIoRLuOdBG9eKBn2EzeNMlz3zQNrTK+iQdaYyufXcGac3A8punfFNO0cq2s7YliVJ3F/d4WOHJ66hL+qDacpK8YHgxvmpZxKdnVtx0iZp8X2NEk6ZR2k3MMlPL5Dw02NsztV5uSB7BDbBUtHvIBiFZtPdbCAjFB4aIh23TN6qXwmuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z0KEZJwk6RNwc0PVTz9PZ74uiM0V0IcTWOsEZffIRLg=; b=h3MO6SdWrFY1DBdn24m0XCUQZ6MMSdF2NuX0OnzdyuM55jMzp9SxCrXdp2sBonAFsgyAyAWnjuToK3ESgmddudWdAHvWutFb5oJfiiSf2k/pRR3sYIKJXbCcM2GHzzUjM+wBPkCL+HaW83z/JL7XDUqJnVppVQ+Tn+SEQ0Sg2XlxjXK0fvux0SVnWkbHipM2JaZlY0B/JlCaG+ygqMAZHFQKnd3x5Ai5CxXa4sexBZA19/MM0agzcLUwbN9QvppOn+vr7oneRwyQfptZTsrWfgRbdfkxVOiz84rjsQAxXahjOfy8w0qy+w/zcSW/jqR7FImW10uXvZQp0S6GCi3zPw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z0KEZJwk6RNwc0PVTz9PZ74uiM0V0IcTWOsEZffIRLg=; b=TkFXynUaosy0nOwIjuDZFt5U5EhKMixIiq+H4xh+Kf07xBvKrluX4NE94/X3MKh0gV9vbwz5560xqRRELefWL6VODDP+NEcvzvEyAXfxF5jEvPCVuajtdA8iToKwi3d0UhuMbGx5DHD4y9fVERbt2C9hA9IMaDZLcGjbl65HThk= Received: from BYAPR11MB3366.namprd11.prod.outlook.com (2603:10b6:a03:7f::20) by SJ0PR11MB5149.namprd11.prod.outlook.com (2603:10b6:a03:2d1::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.18; Thu, 15 Apr 2021 17:05:04 +0000 Received: from BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::ed18:33:3d2b:36d0]) by BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::ed18:33:3d2b:36d0%6]) with mapi id 15.20.4042.016; Thu, 15 Apr 2021 17:05:04 +0000 From: "Pattan, Reshma" To: "Min Hu (Connor)" , "dev@dpdk.org" CC: "Yigit, Ferruh" , "Power, Ciara" , "david.marchand@redhat.com" Thread-Topic: [PATCH v3 2/2] test: fix missing check for thread creation Thread-Index: AQHXMe2JgLrT8nXcw06fjWkMoBDduKq1y6Uw Date: Thu, 15 Apr 2021 17:05:04 +0000 Message-ID: References: <1618051453-21264-1-git-send-email-humin29@huawei.com> <1618487412-26678-1-git-send-email-humin29@huawei.com> <1618487412-26678-3-git-send-email-humin29@huawei.com> In-Reply-To: <1618487412-26678-3-git-send-email-humin29@huawei.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [93.107.9.168] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e3046828-eee1-41d1-1cec-08d900309d37 x-ms-traffictypediagnostic: SJ0PR11MB5149: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yUl3tkjvWcoaINYh1TTs3Euq5vNesJQVeOAoorBwCGe+fEwHSCEEuFJs6HPXDGqjTFj3HDSywKbW+Mm0ThTdNAEMIahPMEagDMbwxMv2ThjBOi4eBLTdXBKS5g4+ycixzTRs/TAIKOpd2DNeENBgJ8CjYfjl8qexUU2qDj0MO610Feh2DuiGqKX7LOvyyIEpLeuuFNiJpBzxq6Y6Cn+AvCPzQxboyV5exZCY1ADxgEHe858PWpQzWbDlh5ve2AjaIe0bzXpiaRAX5Hg+IiqwPDqIHY8elzbpiOw2bm9d/nYJCBILEPXOXnJERQVzV55VoondrLAlqbmrGCf3j0ouN/I405/15OhcBo0hfOJB8ioGPVqClG/DI+DkaLUMuWcaypZb11rUILOpa1Vau2/z20kEynMcrBjOPNn8w5nYignBygDge3XGTwfVK28ySpzBMEosoDH1f6WWcXCcnKrS9BF39ZG4ifNVGkF3ftl23qRIMP9NJnAE2Efw/iULCaAK2nTk7rF31wOQm3MmBaTnRsASCRKetk7OPdwK2UCd8JXDwg2cRJuuQXxCNjZ/w9DqEu34KF/0zxCvT9Ai416xVvQnjBdTidvOWzctnz1Vzhg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3366.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(396003)(376002)(136003)(39860400002)(366004)(52536014)(66446008)(6506007)(7696005)(64756008)(83380400001)(8676002)(110136005)(26005)(8936002)(33656002)(316002)(478600001)(54906003)(4744005)(9686003)(122000001)(2906002)(4326008)(5660300002)(86362001)(38100700002)(76116006)(66556008)(66946007)(71200400001)(55016002)(186003)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?XZhQCXcsGX+pX42/IDGtYsMVLZHlzdJ4h4blho6yQ5x3ufQhsrXKirOIJoDa?= =?us-ascii?Q?GIv8fqVfAFh+tD9h9w1+mBFOmwbPw4g3gIWoAhcaaGh4nWrosNccWWrDMX3h?= =?us-ascii?Q?jJJpRrXFTvJHXz25dPIpggg9NaHJzVGUuYvNHt86zlO0Fvt5C6IztpVubVcj?= =?us-ascii?Q?HXYR7y7nrJ23k/qa2y/ndnu8e+jpmqtvSM5sujxBHTHJ2AFrjV5o3WHyVajb?= =?us-ascii?Q?obI10ZMUNAgfzlHnbmK5RZsSJ4G3kzITK2IZMdc2g1NsbiLm9nONlpoAYaiG?= =?us-ascii?Q?rR3eBa4ztocJzNqVTnSDgN4LpYDO7S97rsfetIR5gIzeSi3H71A7HOxddyF3?= =?us-ascii?Q?IQF+PMWUtj1EjORMpl6FW886OY6DmYL5PRqd6lySTmB4a+lLGtwIfffrehZb?= =?us-ascii?Q?kQ29EIFyQkAAuOgtUYPJRMoBio3gyiu766XdamXfbQ6HQy0UqBg7LMKYYxsH?= =?us-ascii?Q?B6aCZzLlwlqJ+rgQQREy6qelFt6q+rchRocO4MRW3Y+y6tM87FBP5wvObfcP?= =?us-ascii?Q?e4yHfXKv4zsJhF69Hi9gLobIEiJFB7zJaalyLTN13jVK5wjJU3J1J3ZY3PPY?= =?us-ascii?Q?zeyly9sdvRaWw/8SdjeogfLvs6izjR5HYnyQFmTtOJhEtQFC2h/PWufSy9EI?= =?us-ascii?Q?9YM8sGN45QfoKBOraLW5vqQ2gRp2TBIaWZVaK9+megAUz4wl517PsIIloO1G?= =?us-ascii?Q?dDf/SKAKZ0Q0qvvw6em5OFoAsm/OnbJqAeNQg9PhwGalpGzJTPPk23Q47s5E?= =?us-ascii?Q?tAA65IdwxH6n8hJbjYHaolndryJVoGfSXiNXY3C5ukQGwAy6inzeAjbPDYs4?= =?us-ascii?Q?PcUqF6k4QKKEuPhyhSA87qkp2zua50eDkgOOltej+ULhNhrgPWN2+vEPUcYg?= =?us-ascii?Q?kdaN/1RADFc3simW02nEQCj9C+65qE3jH7vXxMMOgsqFWmxTBfBHydw/tiZt?= =?us-ascii?Q?yUiBDVLDTIWDrpd7B3or+hPXkL+pXZBqxH5pUj5PEUscB8JXggGLkWl0WjU5?= =?us-ascii?Q?kcd3P1Y0n9eY+FdP5ov0rbYFTKRMZL6DkRNeFxt+MKqqfE+wfYNqWnfWH3h6?= =?us-ascii?Q?jW1dMhRe9PYOSVCpANVxoCKroeEqSBcl5cSY9dsgapuv2ui9A7hd2sF4+JLL?= =?us-ascii?Q?M5nrUiWATylRCWCNH4tznvGfkfTRW7QxyzauWn/BVxfVw0mTkDCDHB4v3iIV?= =?us-ascii?Q?sRdE/B0uCu/j0Xup8R7ncVmpfpzs0QIIVGJxhrxx9Wc2A+zRtN8RhSUS6+hj?= =?us-ascii?Q?GrujRlgqHUIAxbYVLRJAKked/in2csXT/03915+YmXa7XJWsaauHDIsPhE73?= =?us-ascii?Q?DY0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3366.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e3046828-eee1-41d1-1cec-08d900309d37 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2021 17:05:04.4731 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: hxaL8R8lwHq1aayhXDCBAviB6BImL/NBrWjs9IfailzUmVyacQImCj1xfByol7WWWyBVmiK+flEZAca2OQ5prw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5149 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 2/2] test: fix missing check for thread creation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Min Hu (Connor) > + if ((strcmp(env_value, "run_pdump_server_tests") =3D=3D 0)) { > + rc =3D pthread_create(&thread, NULL, &send_pkts, NULL); > + if (rc !=3D 0) > + rte_panic("Cannot start send pkts thread\n"); > + } I think you still have not addressed the David comment on previous version = of the patch.=20 So , can you change this to something like below Option1) rc =3D pthread_create(&thread, NULL, &send_pkts, NULL); If ( rc ! =3D 0 ) { rte_panic("Cannot start send pkts thread : %s\n", strerror(rc)); } Or=20 Option2) If ( pthread_create(&thread, NULL, &send_pkts, NULL) !=3D0 ) rte_panic("Cannot start send pkts thread\n"); Also,=20 >> test: fix missing check for thread creation Change this subject line to "test/pdump: fix missing check for thread crea= tion" Thanks, Reshma