From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94F5E41DD2; Sat, 4 Mar 2023 08:18:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E4C440E6E; Sat, 4 Mar 2023 08:18:06 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id E51C740E25 for ; Sat, 4 Mar 2023 08:18:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677914284; x=1709450284; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=QrZL/64CvFA9KSt/nIoOZJuWkTUOS9tTqaHkHtOMuh4=; b=Voqz1TC2Sn/f5TgSZwETZSAUjvCOcp4cFmZ9tlmPbUN7nRGDhc5KxAD+ yHbnPvgEC8lT7lF5zZN6RCnkkjPhozTbiy0HGyN5/fsZrhmzAM/fq5FVr fJ+cvuwk16j2UWn7l1nsxw7sXFblRRVC7l09vceiA4ICdtVCrG7u5c04A XEEroB2PnMUZ/JancCwKi/aQWGRLZCxUaTvi9gxBigfC7SZMDE3e2/7cH kDsQxDbkIoLNHlAn1N+QffonjiPSfIVuyafOeZVG7ZAr2m+wF2ORL7G/A sVIt3pSlPwZVmXkkceLfq/e/C6UyGrWre2i8uSyVMwduE4nNj03fE9QSB w==; X-IronPort-AV: E=McAfee;i="6500,9779,10638"; a="337552160" X-IronPort-AV: E=Sophos;i="5.98,233,1673942400"; d="scan'208";a="337552160" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2023 23:18:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10638"; a="705887771" X-IronPort-AV: E=Sophos;i="5.98,233,1673942400"; d="scan'208";a="705887771" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga008.jf.intel.com with ESMTP; 03 Mar 2023 23:18:02 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 3 Mar 2023 23:18:02 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 3 Mar 2023 23:18:01 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Fri, 3 Mar 2023 23:18:01 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Fri, 3 Mar 2023 23:18:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l0PeFYxEJ4mgQgWutlYjbwSeF9n7YMTaYuDRwZ95/iVMoegpPJ4irU3JX/0OtJgYpF6E3j6xIJc0vV71RydXuMvl5KYaeNAbS+vXGj4y+Xtj5+o+RJwaFGsea338Qo+zorzUp9lYsZRJPX4+tRTbwpIwJvdDcGvV0dKf2EVZCusD//0uiMck4DaWMPwQ7t/2o3Uj8WLQnAECKR1UJcqoQA5yVu9QyvSo83ZWK5zgPvm5Hw05hFTMrTpX1a+ZqA+Hr2g0CLbX/LqK6IVi+EqqM9Y6Ip8SffuVCm3/FDUursMO3PlGlTQb99Jb5P9rIwlUe1lyM4QRF+pnBtyo1uNZ9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0zHvuoFXS+ij53bqYMwxAzdHFDXptboNx/g56bQzd/U=; b=hr/vUJtAQWh0gAC+G8HnwsRRjxVhZzDatai/QS74laWcK84HtdFLmC8QmaIW1UBNDx1rlExrk+hE5Uq6snAJn0bON+8TNmHoeXdi1fKvk0t6F1tqwCHArkZvRoYK0WNl7oD0hLahkpS+ca8oP0tuprYr8KiUZnRafhUNAWI28Gq9N5P1tfzeCnDhfFyWhbT/ZQgYKy6D+QiXUIxJ9RmRwSwuYQoiKTXKlCmX786JwbPayVQgUCx7Un2UsbGkArnRmAA3XPcRATdYTBgSJm4WruYSo6ZMmV1FMRRHKfk9/V4cpoCfjItJxQgh+NWk2xSKpMI76ANHbY9eZQOSFhI27A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3366.namprd11.prod.outlook.com (2603:10b6:a03:7f::20) by DS0PR11MB7358.namprd11.prod.outlook.com (2603:10b6:8:135::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.21; Sat, 4 Mar 2023 07:17:59 +0000 Received: from BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::7d29:65ab:81a8:91b7]) by BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::7d29:65ab:81a8:91b7%7]) with mapi id 15.20.6156.018; Sat, 4 Mar 2023 07:17:59 +0000 From: "Pattan, Reshma" To: "Sevincer, Abdullah" , "dev@dpdk.org" CC: "jerinj@marvell.com" , "stephen@networkplumber.org" Subject: RE: [PATCH v6] app/procinfo: display eventdev xstats for PMD data Thread-Topic: [PATCH v6] app/procinfo: display eventdev xstats for PMD data Thread-Index: AQHZRyNlzm7pS/2fS0WmI+zTZ2QuwK7o0jXwgAB4O4CAAPMGgA== Date: Sat, 4 Mar 2023 07:17:59 +0000 Message-ID: References: <20220409153056.1010236-1-timothy.mcdaniel@intel.com> <20230223010819.4164765-1-abdullah.sevincer@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB3366:EE_|DS0PR11MB7358:EE_ x-ms-office365-filtering-correlation-id: b18e49e0-5e22-41b4-2649-08db1c80958e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aNZAitSjYFytdmEdMg9SW9wrFo5pcvfEJcqiQFYQTGra+/ns1vj1PSRXR71CXH9uRpVtoMflyoTkE07nvr+8Qa5LQ+44O9vqcFEV9ErA0e5PQZG5Q+auSWc+rLwxZI2DyK32sjUnkqFwLxF8qAiHztlAoZnP8+l3t1y8V2s3v9DIaCoa53J1E/frsEdN9M9VDlgnd0KesGavNdk8gtfuODMmcNhM5KnT0aWgF8KnVXlc2cmVLBqRgiXNBVHhiZuajxo4DheYD4U6hgucZbAT+tos2Yyk4T5x5Nl0ZdQYtVh/7sJm0GU/YKZOn0yZxyV4ES588osE6NiWASwYfRSHWZIIC/Zg/pUwUZw0b+MBXWrvLt06s0R5LT18lndXJXapQIb5NwbeEmtwVYpPCXDXMVQTxrtOW+DVHCbAezrKdJ+ChQhS/fbI23lMpT4sPZXObaH+OosL26zTTkIwvqGNxpvdtgRSxaaZYhTDNbgWXGSzMPsXyCM6CU9mT90FtKJv7HBeFNCBcprw9q6xuAmaAZ6Tx2TWnvlNQg/8WY/N0fo++icY67mAN8Sl5naKVf0WelV1nuFSRIXxlH8UURF96wTvjKFQjlUVqqBRHzG2Lu8Os05P/grDZEazYSkqMjbRMAoo13kRYWMiYn71xwvvYRxRASnxGDjNKJ0DThMvP7vrfVqhKwCExE48CpWRO/PORsGhcVsOwae+s8WHnf0flsbrAsiQ98IMy3QEeyQDhL8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3366.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(39860400002)(346002)(376002)(136003)(366004)(396003)(451199018)(110136005)(54906003)(316002)(55016003)(83380400001)(33656002)(86362001)(6506007)(66446008)(186003)(9686003)(2906002)(76116006)(5660300002)(66556008)(8936002)(66946007)(4326008)(8676002)(64756008)(41300700001)(478600001)(66476007)(7696005)(71200400001)(122000001)(52536014)(82960400001)(38100700002)(38070700005)(181643002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fKrlSjaIkJe29rNQqf9okuJgxKyIY1eTZ6aCrFVQAgixGKtMf1nsWBpRZ85H?= =?us-ascii?Q?Jb5YtNnGsuXY9SEJQMJABz2L/UlyR9QEJ0TYG5thDFstxexb/qCRt5n+onla?= =?us-ascii?Q?BaHhLwmTMjsA6DzCIYYgBihOe7335FxrAbR3A4OK2yBHIq1RaKFeD1hEzwgM?= =?us-ascii?Q?WHvGKjUjoUKG26Z/n4h6kJeNWGCAXvJaIQLLlGVRfARtoG+rYEVP4wzVrVhJ?= =?us-ascii?Q?vofmMDGi8rE2Tes78sQaEsjxmkbBYbT3kEBrwF13gZKUEdGRFeR3DBAWlhox?= =?us-ascii?Q?raUiAHNu/3m7d85WmcOtSF49RUtth3WJuX8QzwQjKDqVD7Qmerz8ZqjlY8+Z?= =?us-ascii?Q?aVVW1QWD02fB8n6ERh7HXQ4RrWBEREq4eqK0C6Ml+H4UyS4a7sJBn7JnT171?= =?us-ascii?Q?jOuB97zGRdxIHJVETCjoFyFiAPNQJoUWfG53nqVf82xCJGm9XL90w2xKqhh7?= =?us-ascii?Q?Trpy3Yq9xZ4T5PimqPJ8HWnAw6BqYBk4aNYnhnaF6nnHFDPrzcO3VFS2ckd/?= =?us-ascii?Q?IqpI/E5xesiqCUD8JSUehBQgYHvqy0qyAGNxRUDRxNR/iVTSJVMaHpj+Tjml?= =?us-ascii?Q?ZkVkr01Jt6GqJpwk4Bvih7nnSb2Zkxw5QTMXAQ3Za2mAoo90hgwsvp0X+1l/?= =?us-ascii?Q?MSXnv/MkUUUlZDphArS2bqKLbs70B1TViAmucM21SmwVoQPNiktxE83zA9Wy?= =?us-ascii?Q?IdAU8rCjG2udhuhKS5f/C+hFEn4JjDEU/YWzG9jvQWPStcBpUU/r8rMIDpha?= =?us-ascii?Q?deakXn8inekHR73VEO1vzhPsT+LL/TkCtHKj6RX7YFXjB8o94TeTHUzo9su+?= =?us-ascii?Q?oH3zLvHtydoMy2EZf/XJUseFlLydcM326hNs97I0MMG8xMNM9T8ybv1rwUfW?= =?us-ascii?Q?kbOWiqdoMi38m2twvwP1WyO8CSZQj0sAff96T/4QNahkKZv5r33t0H7yp7Sq?= =?us-ascii?Q?b4A187MbDEResBIUaq8l4xRih5SWQxWhyHcSWcIkADTF+6tCc0oua0MS/wVr?= =?us-ascii?Q?a8PhFQDzVWvrCIbF1hYGef2HLh8v+2XNSZJQx3BjMDIeZre8QdMygmbL0As0?= =?us-ascii?Q?KK49v5tuS90oVq0/u3rQ7gy0qc2/M/L+YYEYUpuFkitJ1Sn2514kh8ov6NoB?= =?us-ascii?Q?usYlJE6h5tmKGWpQaGMRUlJrEJLpi+sEecBo8o989TeZ/W9URUpkmeVRy9LT?= =?us-ascii?Q?eFc8x3Z4DjSsgbHRAUX55Z2IdB8DBqHBhDFrrFUpad3dl+RK4Yo/bA56OhmP?= =?us-ascii?Q?DSuZlkIMdQhJ+GLZyKrCyKXTrUHhYRZWqYJk3baFHX1jM/ncvPSNzrTOb8WD?= =?us-ascii?Q?/t/aAIt+VME9Ot6OTz7aFQ7Ok06NLXEXMg2ufYplxxUj7s5P1lQ4eUks+GKo?= =?us-ascii?Q?PfPJTBxiZaYBD1csumEFyK9VBget6/gVT+DC3/B9Yo7CZ+AqaZi7smIlQMvy?= =?us-ascii?Q?tViL2NqLM+B69AWiBx5FebHfTB9qkDQ4XLOW/8SvDS8a+Y9bL9nkoqb66ZzD?= =?us-ascii?Q?Xz7toxKM2Q81MS+k1oI7RAHiWco0z8WVTN1/vPpCCy47DzAmqlaigTEukFyz?= =?us-ascii?Q?MnLsOzhfNmMKDM8X2/RSzuNi4Mi0BkePw5DZ5PKRRRAMkRivzaMH/cv95l4T?= =?us-ascii?Q?VJUEr/mIvf6IVQdJShJvqlkuBRkOqlcmRWBBXP2AzetL?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3366.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b18e49e0-5e22-41b4-2649-08db1c80958e X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Mar 2023 07:17:59.2944 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6RElz9WPx51S1NUcbSpJWaFyvkoPKQQIBKet2gio8iU1evo1FyWBCTrCwum76ya1E1LymjDucpey//eopOltfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7358 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Sevincer, Abdullah > 1) What is the difference between "--edev-stats-enable" and "--edev-devi= ce- > stats" ? > --edev-stats-enable enables xstats for evendev and exits from proc-info > application (when this flag is enabled) after displaying xstats. It is l= ike show > mempool flag so we don't want bunch of different information is dumped to > the console. The intent of the flag is distinguish dump information betwe= en > eventdev and eth dev. If this flag is not passed no eventdev info will be > displayed. So you are displaying xstats. I guess the naming of the commands should be = renamed. Should start with "show" something like show_evdev_xtsats =20 > --edev-device-stats is a flag that dumps device stats like the other flag= s/commands introduced with this change. Can you please clarify a little bit on which flags and commands this displ= ay? Is this like help command for eventdev commands that you have added? However this also should start with show_evdev_flags something like that. --snip-- >=20 > 2)Too all other comments following to simplify the code: > Indeed all other commands in proc-info can be simplified but with > below style we wanted easiness for user to remember commands and pass > chain of commands. It is a trade of for user need to remember the format > instead passing a name. I agree there is too much command in proc-info no= w. I > will try to simplify command and code also considering something easy to > remember from the users perspective. >=20 >=20 In my opinion I see scope for simplifying this . if not what I have suggested earlier about command format, you can follow = the other existing command format like below , to pass on the port and queu= e information to your eventdev commands. Ex: --show-tx-descriptor queue_id:offset:num ---snip--- Also, please do inreply to the email , do not reply on top of the email thr= ead. Regards, Reshma