RE: [PATCH v12] app/procinfo: display eventdev xstats

["Pattan, Reshma" <reshma.pattan@intel.com>]

> -----Original Message-----
> From: Sevincer, Abdullah <abdullah.sevincer@intel.com>
> >+Ex:
> >+struct eventdev_params {
> >+           	unit8_t eventdev_id;
> >+           	unit8_t ports[MAX_PORTS_QUEUES]
> >+          	 unit8_t queues[MAX_PORTS_QUEUES]
> >+          	 static uint8_t num_queues
> >+          	 static uint8_t num_ports
> >+
> >+	static uint32_t enable_shw_all_eventdev_queues;
> >+	static uint32_t enable_shw_all_eventdev_ports;
> >+	static uint32_t enable_dump_eventdev_xstats;
> >+	static uint32_t enable_eventdev_reset_xstats;
> >+	static uint32_t enable_shw_eventdev_device_xstats;
> >+}
> 
> Also, all global variables are tied to a command itself like "static uint32_t
> enable_shw_port_priv" or "static uint32_t enable_shw_ring" . I also want the
> same for eventdev params to be called a command like the others in the file. If
> user wants he/she can chain commands. The "struct desc_param" is handling
> one command only but its 3 parameters (queue_id, offset and num) are put in
> the structure, for easy parsing. None of the command line arguments, hence
> global variables are handled/put in a structure. Would you like to change that
> for proc app going forward?
> 

Having structure like suggested not only help-s simple data handling but also would help for the cases like below , where you need to maintain different event ids in the code. 
With the current patch version the below scenario is not possible as you have only one global variable for the eventdev id which always holds the latest evet id in the command , from below example evetdev id 2.


Ex 1: Where you want to show queue 0 xstats of eventdev 2 and port0 xstats of eventdev 1
./proc --show-evendev-port-xtstas=0:1 --show-evendev-queue-xsats=0:2

Thanks.
Reshma