From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 120ED41E9F; Wed, 15 Mar 2023 12:57:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E20B840A7A; Wed, 15 Mar 2023 12:56:59 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 8575140141 for ; Wed, 15 Mar 2023 12:56:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678881418; x=1710417418; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ew80Emk+C0KY0jImq+dIPDYmFlZuVzrcSJpw1uJDLVw=; b=S+2eFJOAwoE7BGeQdC7wq/Lv+n0c9GyxPLinRolYphAbrKX5q+NCQJK0 miP2ZAmabCHnFijcjCz4fgTR25/vIY11fPiPWx/egmJZlbK0E6E3Uwntt vNESNIT/bIar/rcI5WFBa0lA/2yjw6Qe6yKK7eLCwVldCfw53pCUSBu8I gH4D13I+buFWC4b0hegR09Y2tHXRjc5J1Z9qSO6naT/YKLVAxnrDCDbFc WUJQDhectHz+jFi1vXaZuaE+djG6gBm3w/pXyDD33KDPtlczNAGN634DU HXhTMoHtWsdXW3ona0/DzsCNmw3m/Pn+gKtW0Ma1SeVPYoHZlY9Wg8YjZ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="318074945" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="318074945" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2023 04:56:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="748400339" X-IronPort-AV: E=Sophos;i="5.98,262,1673942400"; d="scan'208";a="748400339" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga004.fm.intel.com with ESMTP; 15 Mar 2023 04:56:56 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 15 Mar 2023 04:56:56 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 15 Mar 2023 04:56:55 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Wed, 15 Mar 2023 04:56:55 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Wed, 15 Mar 2023 04:56:55 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZSQgtIlBYLwO962pAAq/yhWF9Ec+lMPv6iE3OxGb6By7IZnOv98IwKjxNlNBHQgZ1EkyCCDR/75F/2QLEvmboIyOHgB8HW5utPHjbZb99HB2My+SxzR5rdjEnxFntb0pR3A+SObU8v+Fg2tOKL4VBJSGbu9egTAoDIDD+Ad+LZl7hR5SOyrSseko345n6SvUY42czRTGiwIV9A9YPi510eN9jatIFM0zTseB4oreyvLmYOTXohejDVleeoUoTEqXGmRFbGFu0zWah8Qp5ruYxUoOn9ywABdyIXxMxpctTAzZFd5waL1oGCU12234A0XCBRyH4AkV7XbtSnt/SLHmlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gb0YmzjW1HqCXjKRq8UtSEiaDbueu2Ojg/S3J8NtWMc=; b=DF51VMyj5GdG6h7me57QfWe19sZANSCne1btqXbc4h9P9f3FiGlfYstnFO2PXyTtz9LQ0Zh5C2QB9zgbIvo209tFhuvnFRw9tujei0r4Jse1pqi3CnXBu9e/tl3TKFLZE7aIfHT1gU9dk87sojvrrpHPu7Bwf4TWai7i23hL4gIW4EGans/9R0to51ZZodmnUnwXxOV+1EG0shaCbojg1ulGwPCVH6k4KigvJNFQOsGqeO8fzExIH924ApJU4xs9sS8f4fqFXyET/YVEJ3cs6aQA5pzZMZunSoE0PZBgzdVpuQfA6t97u/aNimtjBAGXL2Ii7Wqe2M20KFPm89OybQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3366.namprd11.prod.outlook.com (2603:10b6:a03:7f::20) by DM4PR11MB5342.namprd11.prod.outlook.com (2603:10b6:5:391::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.29; Wed, 15 Mar 2023 11:56:53 +0000 Received: from BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::7d29:65ab:81a8:91b7]) by BYAPR11MB3366.namprd11.prod.outlook.com ([fe80::7d29:65ab:81a8:91b7%7]) with mapi id 15.20.6178.019; Wed, 15 Mar 2023 11:56:53 +0000 From: "Pattan, Reshma" To: "Sevincer, Abdullah" , "dev@dpdk.org" CC: "jerinj@marvell.com" Subject: RE: [PATCH v8] app/procinfo: display eventdev xstats Thread-Topic: [PATCH v8] app/procinfo: display eventdev xstats Thread-Index: AQHZUrg3EIsFsS6FGE+/Q6xuEk1Zka77wbGg Date: Wed, 15 Mar 2023 11:56:53 +0000 Message-ID: References: <20230223010819.4164765-1-abdullah.sevincer@intel.com> <20230309185143.1006949-1-abdullah.sevincer@intel.com> In-Reply-To: <20230309185143.1006949-1-abdullah.sevincer@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BYAPR11MB3366:EE_|DM4PR11MB5342:EE_ x-ms-office365-filtering-correlation-id: 8092cbf4-73ab-4554-202b-08db254c5e78 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9y0vB92dnPxo48qSWt83iONLTD4CJs51GBRUecdrQzrh3wRe6mBWR8qWc0osyHZsEqBujum7skZyItl7YhwM6eguV31QIDYlEu6Styw1Tou6PqenlthxpR1mwXpRP5BUgKDCE64Sv22aKS3RvrGKXH7XgOEpH07YaRC4qO2SohsxmEPrNA3PAY6R2qkFOE+SWYEAwPdT+XdOR9NNUq5atmsgg15R6GsikTUWzcOlNr6dALWR+smRQq6K36j2eyWWXKhSCGxZXLxYJ1NwymDor27OZiLIBMCgwUIZRvw+Vb0iEsTXwpsai2lgdghpZ0h3Ce3WziUzQwv6MKTz3Uh3xpR+SB7tlrXpNJ55wydodcz+uhj8rN89DavrEvKbysoezt0FGP8EJNbMbR+QkkgXAlCaIPbKACQ+D8/9xbpPXMQvgfUhUxf1N4oVrPWLU5Kri9GSt6MU2vPqK4dGF/Dd1N90H2ZgNnitsJN4Mwi+TrpbxnRj6oMx4Lin7dAWq0g/JLrOjzdfdYEmhjMF29GP81hsAW/Zfqg4vlqKr5NYcawLHpBydivKcunK/sr+fZr1c+GxIsY4Se44gMfPxhi4ydFtzNB0R1f4siSq1f27lh2fSvMF2gnAB9ujY0oRscfQbKteAb47GITg/sNw7Ww2KlTfHuh/MLV7d1Spe+hcwNNZTR0mB+lHiM/+6gYJo6Rp1WOrM2ia3+Js/koVPtcy2w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3366.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(366004)(396003)(346002)(39860400002)(376002)(136003)(451199018)(33656002)(55016003)(110136005)(478600001)(26005)(186003)(316002)(6506007)(71200400001)(9686003)(7696005)(41300700001)(38100700002)(82960400001)(122000001)(5660300002)(86362001)(8936002)(52536014)(38070700005)(83380400001)(2906002)(66446008)(66476007)(66556008)(76116006)(66946007)(4326008)(8676002)(64756008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Jq0+q/jL81i4MExtxRHqyPpS+/XflAgdseUXjmuI9k5mYP2sEnmuCsnlPh09?= =?us-ascii?Q?IxIZ1WjmI2XMJOtRmr/+QP3kqLcu2smknt5qh7giL6yDlLVSLrv0CGkaL/Yq?= =?us-ascii?Q?ywqWs7n85tX1AJHMwcmKqcyqNtXU1Kev0FLqkplkZH+tDLHCenlCcWqp9iyl?= =?us-ascii?Q?QcSpcDKTszPbliRSqQsfrwRlHh8Hjub63MlklZdzWyELE12086eX9hsMretK?= =?us-ascii?Q?8JcAyTyhqFpGuBCfOzPGeylyWtrMXw6fIk3+CmgflCBO0eekUOE9GRr5U1pt?= =?us-ascii?Q?Astvy+fZ7Qa7icESDCnrWXxjjHMtetl39DfzgTUyicm20rt53ra+YmyTXQwh?= =?us-ascii?Q?ytm+VLwmsaU1toqsBKYb26ODso9XvuOENxxkBodLLRG1DwSOZ2wInDSqM4Y5?= =?us-ascii?Q?Qty1Y9iWk3Ji0ycP9T7hmXDMS7Yzy9k07fX+RB9tCB459KIDPTcqBZaR5DQf?= =?us-ascii?Q?KAu2I0UKOUDW+mLUB9eqMIiFooEomNfOHs3SvrAeTdVt+5K7SmQ9NYDzOyJ8?= =?us-ascii?Q?WzKop7BsXND25yU6ecTVwNyshsiYok0RdnBZHDpMC4DZmRZwi7dvYAcmgl6B?= =?us-ascii?Q?448exr5Brf1T6bITHRUYPX1gnVREVlN0xRRPo+/lWtnLiCBLXRZB7Z5Vt086?= =?us-ascii?Q?h8qcsXHEJIMZdLHnwUYC05uKs8Owq1Rs1EgvK6I0MqNJQdWVwVuQz+b2lxBY?= =?us-ascii?Q?a8hGk8zvRHRz5aMMRyIYmuoTrcHeJl871av82Y5tQzZhZPVi3qpwiTtFRQ6J?= =?us-ascii?Q?6JfaYpyPTsN1pDS30FbiuP/7TyN6Boo6/SBtlqoM+uo/kRj7GGdAp+H8phcC?= =?us-ascii?Q?yFtqkIg9+8COddUOod/2YFwGxZ2xlK8mD9Y3y9AKOqZRYjV2grVSij/oKyPk?= =?us-ascii?Q?+oxnSkkvftiPW9JSXP5R390M+qMWwZVQzszhGLtkp+V4KMuOXcRIS50uA51L?= =?us-ascii?Q?1XoEl9a8uGLXQRFtputwGhDJA6C4VDWdTiYHmDJIL1ZmdYHx3zUZ7NQrzvMN?= =?us-ascii?Q?J96cz1/1Vm8FVuR6fAyE+Io9XVx1dHCBInvs2hknFc+nl+bLZEERJ3WKQG7N?= =?us-ascii?Q?zU4b+AIFTwC6tRwrChwx9avQsJQQJuuMUmnCTY2vblGGt+aWItNSgSlkcDt9?= =?us-ascii?Q?H5yQ47IA6PoryTfLevb/8Bq3zTqJNwUcgFAIFzHM3fU28/su40tALwtGdPDQ?= =?us-ascii?Q?oS2iWrbgStrVfLHQWj7A/ghZpGOQkAC/HOa4Aa0AggvvWdjaSMHiXONLsIng?= =?us-ascii?Q?F6MegBSpTnYuualW/3n5FviVfz8kR0x/j3qinBTIRwhmggW4IjdpcDeDgm2l?= =?us-ascii?Q?vW+2at/yaPNhgTYuwRW+WjsyP/cqF6uks/qxJga1XI+BFSXCOEETRJ1UMvAe?= =?us-ascii?Q?ktrmw5aEGSWl1jM9+Ob7l9WV5GYqfh5RGtCJHMEjZTUpwyf6ZMrFhbcfLmNr?= =?us-ascii?Q?76umpMg3f8BypXgPGjjnQRQLtRQjscFtl0OoZH0MxD92ZqTapWuNCFZVMc9S?= =?us-ascii?Q?si4XWwvdaoa64MmJXVbOfes9p3ncjDO3e63ZrNqcVceFFEakYALWFSzORI/X?= =?us-ascii?Q?13fyr0czP07OWy4RPgJIFpdsY600ZGCv/yrDdj9B?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3366.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8092cbf4-73ab-4554-202b-08db254c5e78 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2023 11:56:53.5573 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4P4rFEV+aV3g+J2iU9ZQNTihvBQSYJoZfBNfRMKvw+LrlWt3OmY2UBiuKe1Bd0IgwOGJIC06q0b24Cv4qvFGpA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5342 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > app/proc-info/main.c | 210 ++++++++++++++++++++++++++++++++- > + {"edev-reset-xstats", 0, NULL, 0}, > + {"show-edev-device-xstats", 0, NULL, 0}, We should support the eventdev id as argument to this command and display = stats for the given eventdev id. > + if (show_edev_xstats()) { > + const uint8_t ndevs =3D rte_event_dev_count(); > + > + if (ndevs =3D=3D 0) > + rte_panic("No event devs found. Do you need" > + " to pass in a --vdev flag?\n"); > + > + if (ndevs > 1) > + printf("Warning: More than one event dev, but using > idx 0\n"); Why do we need to restrict to only eventdev 0? .I guess you should support = displaying stats for any eventdev, not only the eventdev with index0. =20 > diff --git a/doc/guides/tools/proc_info.rst b/doc/guides/tools/proc_info.= rst > + --show-edev-port-xstats=3Dport_num | --edev-dump-xstats | --edev-rese= t- > xstats | > + --show-edev-device-xstats] >=20 For "--show-evdev-device-xstats" why don't we have eventdev id as argument = ? There can be more than one eventdev can exists right on the system? > +**--show-edev-queue-xstats** > +The show-edev-queue-xstats parameter enables stats for specified queue o= r > all queues. Here and in below text replace "stats" to "xstats", because stats and xsta= ts are different.=20