From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Kaur, Arshdeep" <arshdeep.kaur@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: RE: [PATCH] SCSY-192443 Bug fix DPDK-dumpcap for interface parameter
Date: Tue, 6 Sep 2022 16:17:48 +0000 [thread overview]
Message-ID: <BYAPR11MB3366DC2E3DEF3C93A8CC399BFF7E9@BYAPR11MB3366.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220829084956.288858-1-arshdeep.kaur@intel.com>
> -----Original Message-----
> From: Kaur, Arshdeep <arshdeep.kaur@intel.com>
> Subject: [PATCH] SCSY-192443 Bug fix DPDK-dumpcap for interface
> parameter
>
> Bug: IF condition to handle -i parameter was not incorrect.
>
Hi ,
Remove SCSY* from heading
No need to add *Bug word in the heading.
Heading should have the example name that you are fixing that is "dumpcap".
So, Heading can be as simple as "dumpcap: fix interface parameter check"
Need to add fixes line to the commit message for any fix. Refer the section 7.7 in the link on how to add the fixes line. https://doc.dpdk.org/guides/contributing/patches.html
With these changes you can send the V2.
Thanks,
Reshma
next parent reply other threads:[~2022-09-06 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220829084956.288858-1-arshdeep.kaur@intel.com>
2022-09-06 16:17 ` Pattan, Reshma [this message]
2022-09-12 12:53 ` [PATCH v2] dumpcap: fix interface parameter check Arshdeep Kaur
2022-09-12 13:06 ` Pattan, Reshma
2022-09-15 8:16 ` [PATCH v3] " Arshdeep Kaur
2022-09-15 8:44 ` Pattan, Reshma
2022-10-31 13:45 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB3366DC2E3DEF3C93A8CC399BFF7E9@BYAPR11MB3366.namprd11.prod.outlook.com \
--to=reshma.pattan@intel.com \
--cc=arshdeep.kaur@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).