DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/ice: fix incorrect firmware version
@ 2020-08-06  8:25 Shougang Wang
  2020-08-06  9:15 ` Yang, Qiming
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Shougang Wang @ 2020-08-06  8:25 UTC (permalink / raw)
  To: dev; +Cc: qiming.yang, qi.z.zhang, Shougang Wang, stable

Kernel driver shows firmware version as hex but ice PMD shows
as decimal. This patch fixes the issue to make consistent with
kernel driver.

Fixes: ac882a0eda69 ("net/ice/base: store NVM version in extracted format")
Cc: stable@dpdk.org

Signed-off-by: Shougang Wang <shougangx.wang@intel.com>
---
 drivers/net/ice/ice_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 8d435e889..88b8428b9 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -4388,7 +4388,7 @@ ice_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size)
 	build = hw->nvm.orom.build;
 
 	ret = snprintf(fw_version, fw_size,
-			"%d.%d 0x%08x %d.%d.%d",
+			"%x.%02x 0x%08x %d.%d.%d",
 			hw->nvm.major_ver,
 			hw->nvm.minor_ver,
 			hw->nvm.eetrack,
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2020-09-11  3:37 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-06  8:25 [dpdk-dev] [PATCH] net/ice: fix incorrect firmware version Shougang Wang
2020-08-06  9:15 ` Yang, Qiming
2020-08-06 10:37   ` Wang, ShougangX
2020-08-06 10:28 ` [dpdk-dev] [PATCH v2] " Shougang Wang
2020-08-07  1:45   ` Yang, Qiming
2020-09-11  2:40 ` [dpdk-dev] [PATCH v3] " Shougang Wang
2020-09-11  3:37   ` Zhang, Qi Z

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).