From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A29D7A0518; Fri, 24 Jul 2020 04:34:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4952D1D5F7; Fri, 24 Jul 2020 04:34:49 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id AB5511D5F6; Fri, 24 Jul 2020 04:34:47 +0200 (CEST) IronPort-SDR: 1PsdF0vBolujCFBEJ9/76NTE6pl0Y6Vse1JNKOo7R8Gaz5j2u6Jg9eLO21W2pJ/O4tSEvA2zqH 09K5CmgjliOQ== X-IronPort-AV: E=McAfee;i="6000,8403,9691"; a="138149301" X-IronPort-AV: E=Sophos;i="5.75,389,1589266800"; d="scan'208";a="138149301" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2020 19:34:46 -0700 IronPort-SDR: HZV+/Y1lUfdOEGpSrmW6dymX/KBYEGfpZXw5fi6rFRNkQV4EO0xVLTRhVBCKbQMgZNnWvipkry DomGUKJL2hrA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,389,1589266800"; d="scan'208";a="320865893" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga002.fm.intel.com with ESMTP; 23 Jul 2020 19:34:46 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 23 Jul 2020 19:34:45 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 23 Jul 2020 19:34:45 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.52) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 23 Jul 2020 19:34:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gzSsGe+ca4qoaT7jkMwu1aLRh+SF/h8btTqlqbl0shVk8ZYWuI2Wqqki/2dd0wPGnwoU0UcqGyANaSv0S2vxUj5nW8v+jeiD+2JwjM1yxk4UfgrG1a2gYGddQ5ig7f1EEdFbCJO0r/PalL34l0Fi0ety5U1DaJ1xMnpuDxDV+GYiGCBjQvje+hLmt6JEA2NVjHKYsYz67LEXNPKhOPhYpUHLt6YeTzOidYqmOn0Gvl0d8hhv536/N3cuk5dBL9tiGkiDpTjseCxkh+Y2dDwLkceBms8ms0APwovcncHCqUyrKh3V+YzYieU8GAlT2Sb2lPzyuOh7vHeh2FuwkcQIhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Jo+x90FsE5X3FTIE9B2apcwEOIVyVII4t9GkN51ikI=; b=Kr1ZZJ2SThkDfNcq0R4ix+NwpZgOZRoXhjdR5yvItixtrR1fDK4LPXA/2YHAvr7S7mk5ODggPCB4kE1STzbc1ZGbAO7nvkj1iJeM3SHq1nRd7FqtH9nFMg1Yua+SEdDcb5imCS/XnR/hQaUq8fiRJeULn5G/A/d3YIoUAtM2dhYmLrFK49x5U0+An4s9/7Ue8xsT21ZCW8KNFgVvgG9Yp/miBuKERhQseUauVuGB9gJ1cohlZF5bCppCrwFxkT6VsHDHxIjeDm8tQq8d6ZepWvJk1mA2ltfO3UB5+l0CoX7z3XC1ig4O4Hv/Odw8U3TEfAf0beyhLQr3RfC/oij54Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3Jo+x90FsE5X3FTIE9B2apcwEOIVyVII4t9GkN51ikI=; b=qywjOQD7zoqA1cMofbHmVwfkqOQBYnwmo306SnydE5tuTautJc5TUPToDmKRsHHVhw2CyMznQfgQhrPqRzTjR7yHgN8RpkwCQLUKZTUINSGT7QWrxzChYrO1nJaqura6vRwNk9EtVp83fnjNB8+9G8gSua6OzdZBhtYNgm6RxZU= Received: from BYAPR11MB3477.namprd11.prod.outlook.com (2603:10b6:a03:7c::28) by BY5PR11MB4104.namprd11.prod.outlook.com (2603:10b6:a03:18f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3195.17; Fri, 24 Jul 2020 02:34:41 +0000 Received: from BYAPR11MB3477.namprd11.prod.outlook.com ([fe80::11b9:abd9:39e0:f26a]) by BYAPR11MB3477.namprd11.prod.outlook.com ([fe80::11b9:abd9:39e0:f26a%3]) with mapi id 15.20.3195.025; Fri, 24 Jul 2020 02:34:41 +0000 From: "Wang, ShougangX" To: "Zhang, Qi Z" , "Yang, Qiming" , "dev@dpdk.org" CC: "Xing, Beilei" , "Guo, Jia" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look up table Thread-Index: AQHWYALKaaCtjgyuVU6tPDq42bQ4mKkUaRmAgAC3YICAAOIScA== Date: Fri, 24 Jul 2020 02:34:41 +0000 Message-ID: References: <20200715063515.9262-1-shougangx.wang@intel.com> <20200722081543.52396-1-shougangx.wang@intel.com> <039ED4275CED7440929022BC67E7061154864F86@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061154864F86@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.46] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 82f77296-559a-4189-e083-08d82f7a1e84 x-ms-traffictypediagnostic: BY5PR11MB4104: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2449; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Vz75K40QQHk0/OBpy+XiJmUKh3o8wO0ie+XAEOE4N5GI2TIbcLl06ZxPJ/4XO2yMPLixcyagqbrKOlg20f/IAiMYWklgfKgr17D8WSrfnkOiXCXOZmyuB9vruYkA9y4kUpsoHyNqzycG1vUicF0sJnss93TRMibSdCq2H60PeLQv9jEabH0kTdduXYlBzLBo+xNt2lvQd5OV6XdihUOTLcwUpKgpP6xXmM5fxfx4+4rTnU4g1eD7k3U1iFWQJPn4WLk3mtPKDXPuwcPHbSd1/s3NewlZDQPDcnlH7qTaooVtBo3o0K4btOxjiaHDe9wcw+pGsxjVTkcYH8jJjA33vg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3477.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(39860400002)(366004)(136003)(346002)(396003)(376002)(66476007)(64756008)(66556008)(450100002)(66446008)(478600001)(83380400001)(53546011)(186003)(8676002)(5660300002)(9686003)(33656002)(6506007)(110136005)(2906002)(52536014)(4326008)(7696005)(55016002)(71200400001)(54906003)(66946007)(76116006)(86362001)(8936002)(316002)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: RSFEqNkwR5FT8TBNPqnKVHi9gJlHbI00af3H7Hp15VPLY7zzPP+BF6w9tYs6HvUJXxOGAhN5+4TK2swFA3s9ssn10+8QtIfRUEdSixpL3QbqXA3U62/REOsA1JnQRcckyX6TZtYo8tuFrUqdjaXhyxPsYikPmHHRpFq+zwRTZZtGGXs/LZ83ePmaM5CEWp+3rvMRSsJRdt6XZcHjqfrQA+aZKuTBiJPoXEC1RDS9wTyf54BDSruxG3nNqpseck+RdQ0JsjxrtuJDZ89VFTWGGVTakZNLg6ta+L+GBnv57LdafF/Ndv7R6cnnBoSUZJD/oxNMLWDUY1TWuyVcQU8oAcAJpLQ4Sfmn1qZBC0mjcsVigRtSLhOj3oJrqY4Pgt4xhx0qUeYm9Vjht0pCDIWmAYVqYKLIaDm3WH6ENSVgGHlMiG/zO5NJU+QBRj143csxTD1zOJnypQIqPwOG5Yc0AMKeEE5K/TqkvNbfI2tikGg= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3477.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 82f77296-559a-4189-e083-08d82f7a1e84 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Jul 2020 02:34:41.6426 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yp/DKFmJUjZID/aL3VUUE15PufczRVyGMA33tv4o7hI70UgE3kB7jAXuE0OCVa5SJdRjd3oo5NC3I7qBHdjF4sRx4Ymq6FkDgVgqjZmQp+0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4104 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look up table X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, Qi Z > Sent: Thursday, July 23, 2020 8:53 PM > To: Yang, Qiming ; Wang, ShougangX > ; dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; W= ang, > ShougangX ; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look up t= able >=20 >=20 >=20 > > -----Original Message----- > > From: dev On Behalf Of Yang, Qiming > > Sent: Thursday, July 23, 2020 9:57 AM > > To: Wang, ShougangX ; dev@dpdk.org > > Cc: Xing, Beilei ; Guo, Jia > > ; Wang, ShougangX ; > > stable@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix incorrect hash look > > up table > > > > I don't understand why you add new function and new function mostly do > > the same thing. > > Why don't add fix in original code. > > > > > static int > > > i40e_pf_config_mq_rx(struct i40e_pf *pf) { > > > - int ret =3D 0; > > > + int ret; > > > enum rte_eth_rx_mq_mode mq_mode =3D pf->dev_data- > > > >dev_conf.rxmode.mq_mode; > > > > > > + /* Initialize hash look up table */ > > > + ret =3D i40e_pf_init_rss_lut(pf); > > > + if (ret) > > > + return ret; > > > + > > > /* RSS setup */ > > > if (mq_mode & ETH_MQ_RX_RSS_FLAG) >=20 > I agree with Qiming, if we move this check into i40e_pf_config_rss, dose = that > looks we don't need to create a new function? Indeed, I will do like this. >=20 > > > ret =3D i40e_pf_config_rss(pf); > > > -- > > > 2.17.1 >=20