From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8FEDDA052B; Fri, 31 Jul 2020 04:37:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3E96B1BFFD; Fri, 31 Jul 2020 04:37:53 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2C006A69; Fri, 31 Jul 2020 04:37:51 +0200 (CEST) IronPort-SDR: WEsc31YAAQx4NGZ95Hu9QjvdnoOSlRjNluwLq/EnNdnRL2MO0BSKjHN+BIet9L+OReADwJhDZV gV6LShVG3UNQ== X-IronPort-AV: E=McAfee;i="6000,8403,9698"; a="139707113" X-IronPort-AV: E=Sophos;i="5.75,416,1589266800"; d="scan'208";a="139707113" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jul 2020 19:37:50 -0700 IronPort-SDR: YknMpUM9y/4A7Hi9HdTCYlzK2AMBgKXadYRQ9kNooSniaAM8dqvTQy9yUUoSqo2M62x4ZfH6oC GDwiHGEopgmw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,416,1589266800"; d="scan'208";a="304804667" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga002.jf.intel.com with ESMTP; 30 Jul 2020 19:37:50 -0700 Received: from orsmsx158.amr.corp.intel.com (10.22.240.20) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Jul 2020 19:37:49 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX158.amr.corp.intel.com (10.22.240.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Jul 2020 19:37:49 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.56) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 30 Jul 2020 19:37:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cqq5OEYcN3RegYFu816yJw5u02g07GqF6sGVAioGu9ekaFOqsDDIh0s3yk8iU7aA7CannVFdHZrf0u/FfmIEAZ+oyO0YapQjvzK14TThleF9xTQ8p5ueDW1+v31jm3bdDmXSGq/HOkPy4nj/e0UG9s4TXBInLWYrF9n4N2E7/T16Pf219+6xuTZfuN9W0kLuATCImKqg9ktaHcDTJUimNCcpG3T+GZAqmdh/LxQmvq7+f2LI/709VJC1NlD8spYuoX6fbYylazRSuCXdAok58M6awtwjMCOTQLbnAgyFKUUB/5twOxAGfcpw3Wu1SVpo6KBU0nBhaDHuQlSF5JhqMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zybdEW3SbSVnSFmcHT3IrcYPjOnPsJJH5eJCxAbmX0I=; b=j4tUKm05JG9g5/fKth+IN65v0w5hPhHYY0xQaaYNw/D8w7HhrIUDC9keqp039wQkaDGFsZe3HaqjYJIrvCXOFXY5mMEYhbBynbZuN14PrGrYpD5Oh2q8NqgAXHtG2K0dJKjNBEnXQolCLPsX6fWOy0sk9CepeNcV4SYoRuBXmgzcIo+2MeudW+xW9UtnfSVviU2Dwujn+O9nKDKGNXCST+kT9OLJJxgEPc3jXLDxgk86A5kNXwUpz8TUg68T3KQ+ZUC2MdIP8gpRoHCbBtqnRUVMI5mF4tg7qPvcz9+xkvCiKXN8MC0xAtBeK9X2qdpGbqMVVDy/rb//CE5vvsJFXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zybdEW3SbSVnSFmcHT3IrcYPjOnPsJJH5eJCxAbmX0I=; b=C5N6JsAzrbF5XaIHci6yraijRW29CqwSJYdLwI8DeNf8vXvSt+QjsAK3JKTpIeZT38nBFWBZHqI6R9XKaFHDCLyP30PQukYhLYmDBGkg86KxoTb68CKo9WFzcM8fz6zTslMJ1F+4qVdqerqk+RH1TvLe0riFiAKawv5ARD/w0AQ= Received: from BYAPR11MB3477.namprd11.prod.outlook.com (2603:10b6:a03:7c::28) by BYAPR11MB3352.namprd11.prod.outlook.com (2603:10b6:a03:1d::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.26; Fri, 31 Jul 2020 02:37:46 +0000 Received: from BYAPR11MB3477.namprd11.prod.outlook.com ([fe80::885a:3870:e38b:572f]) by BYAPR11MB3477.namprd11.prod.outlook.com ([fe80::885a:3870:e38b:572f%6]) with mapi id 15.20.3216.034; Fri, 31 Jul 2020 02:37:46 +0000 From: "Wang, ShougangX" To: "Xing, Beilei" , "Sun, GuinanX" , "Guo, Jia" , "dev@dpdk.org" CC: "Sun, GuinanX" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] net/i40e: fix link status Thread-Index: AQHWZl0lS2MqPozo2UuN9HhkewQQ+qkg+CaAgAAA3mA= Date: Fri, 31 Jul 2020 02:37:46 +0000 Message-ID: References: <20200730082539.24104-1-guinanx.sun@intel.com> <20200730102527.49884-1-guinanx.sun@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 23d7c9ea-1d7b-4624-ff7c-08d834fab59d x-ms-traffictypediagnostic: BYAPR11MB3352: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:506; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nX8FJag1PgO3T3P+uaA5nJ/1mTL5YjuUpdQOWs9eSgF5IB6N4l8DnKsLP1y/VMlybCYkUvuVmRsSXUDFzfmSyicQPMhq4S8wDibDjBo1Zwo5n+0AeiRTAs0S/hTRNnrG47GIO0zciV9s89fJsBYax6X7VFS5cQAbTR7XZ6W2qPL3jgdUurew5smx+qotAe49l3xIimtUY/hkU5GdQIjXSL4zWEgDT7Px3cjcuwqsSRaIf7aJeSu+znskHEqxzLo6yPqBO7mY2xMnB37tWsyeoenGZM3LGmogbfpVuCFgWiPOfj7hdIqC7Nv57tNITpyX x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3477.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(396003)(346002)(366004)(136003)(376002)(39860400002)(52536014)(86362001)(26005)(478600001)(66946007)(66556008)(66476007)(8676002)(66446008)(6506007)(64756008)(9686003)(7696005)(8936002)(5660300002)(186003)(55016002)(53546011)(71200400001)(54906003)(110136005)(83380400001)(316002)(76116006)(33656002)(450100002)(2906002)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: FWCReS/NwY9hCTNHdb6GslmtRBvj5CpB57JgJGkwkEX9VPOQwmvftrLMB5MARXF8NvOQ2+/UzWecRkFDASiCvswuNyhH/RsguDs4ccxEV7A0htLhtxwTg6/WjheND+bOBSLcN3l74DlpZbhzuGBofS+H94nBZMVX0f8jU3Y0VvrZ86Ks8g+F1ott6c7ZxS4Nh8M9Gds4Vm6CM6fBouA2EZ0r/j78mMmcvLz2+luC4tyu4wHsnaBH3l5NstN9ss4K/YvCS4MhlUKRpyOPad2BrwPGYAwDj2+bJAf8Neb4uEBE7WkFogSqVuls5hBQ04kjITMEIxVAX4HdCi6Yz9MO/lQr1nYRew+hbqScRbznkQy6s/dDEgofxoUhb1R9o2kku691e9jpXE7R1zfyTrqz2Lv+3q0Bwf+707+3vEVZ7pTFYsYy3yaBsKaMM78Ltw+33WdNEpOHwhgiHQnDkGxn2YokRPrhjShRCN9sEXczxdurObleLa5Ydf3j7sT4Y8Ut Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3477.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 23d7c9ea-1d7b-4624-ff7c-08d834fab59d X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jul 2020 02:37:46.4705 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: llxXbxG7J2ZhRpurw+vcB8KAQFCTImJ6uMTKz4kX9BJZDCiw1WWV/jAG7FNNKKueoDqyPPOWvSeUkgMIJS/2yjZHw47arUp8QXiBkTYWQHQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3352 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix link status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Beilei > -----Original Message----- > From: dev On Behalf Of Xing, Beilei > Sent: Friday, July 31, 2020 10:30 AM > To: Sun, GuinanX ; Guo, Jia ; > dev@dpdk.org > Cc: Sun, GuinanX ; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix link status >=20 >=20 >=20 > > -----Original Message----- > > From: dev On Behalf Of Guinan Sun > > Sent: Thursday, July 30, 2020 6:25 PM > > To: Xing, Beilei ; Guo, Jia > > ; dev@dpdk.org > > Cc: Sun, GuinanX ; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix link status > > > > If the PF driver supports the new speed reporting capabilities then > > use link_event_adv instead of link_event to get the speed. > > > > Fixes: 2a73125b7041 ("i40evf: fix link info update") > > Cc: stable@dpdk.org > > > > Signed-off-by: Guinan Sun > > --- > > v2: > > * Modify commit log. > > * Add code comments. > > * Delete useless codes. > > --- > > drivers/net/i40e/base/virtchnl.h | 16 +++++++++++- > > drivers/net/i40e/i40e_ethdev_vf.c | 42 > +++++++++++++++++++++++++++++-- > > 2 files changed, 55 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/net/i40e/base/virtchnl.h > > b/drivers/net/i40e/base/virtchnl.h > > index 4f498ca45..9c64fd469 100644 > > --- a/drivers/net/i40e/base/virtchnl.h > > +++ b/drivers/net/i40e/base/virtchnl.h > > @@ -240,7 +240,8 @@ VIRTCHNL_CHECK_STRUCT_LEN(16, > > virtchnl_vsi_resource); > > #define VIRTCHNL_VF_OFFLOAD_ENCAP 0X00100000 > > #define VIRTCHNL_VF_OFFLOAD_ENCAP_CSUM 0X00200000 > > #define VIRTCHNL_VF_OFFLOAD_RX_ENCAP_CSUM 0X00400000 > > - > > +/* Define below the capability flags that are not offloads */ > > +#define VIRTCHNL_VF_CAP_ADV_LINK_SPEED 0x00000080 >=20 > You defined the new capability VIRTCHNL_VF_CAP_ADV_LINK_SPEED in the > patch, but didn't request the capability for i40evf? This capability is given by i40e kernel pf if VIRTCHNL_VF_CAP_ADV_LINK_SPEE= D is defined. So vf doesn't need to request it. Thanks. Shougang