From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C99B2A04B5; Fri, 11 Sep 2020 05:06:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A78678F96; Fri, 11 Sep 2020 05:06:21 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 9DC50255 for ; Fri, 11 Sep 2020 05:06:19 +0200 (CEST) IronPort-SDR: HRoeeT6XZ8IC4SAo3LqNQ79Yqwgdg4fBAmA3ep/HnZ/opSuslR2Cdq23d10lDPZe++C0K/x5fg G9MVoeeuB1Xg== X-IronPort-AV: E=McAfee;i="6000,8403,9740"; a="243504336" X-IronPort-AV: E=Sophos;i="5.76,413,1592895600"; d="scan'208";a="243504336" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Sep 2020 20:06:15 -0700 IronPort-SDR: S8xBT05eKODgPprcq/T+pN7XGf7+mjoVsEiT5WclhR7p61lTwzsmQRzFsa5SEdiZlqd3e094Rs rjXji7s/hqig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,413,1592895600"; d="scan'208";a="329601088" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga004.fm.intel.com with ESMTP; 10 Sep 2020 20:06:15 -0700 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 10 Sep 2020 20:06:14 -0700 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 10 Sep 2020 20:06:14 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 10 Sep 2020 20:06:13 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.46) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 10 Sep 2020 20:06:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iIBHjYessTauBoH/sB6GO5PFtSP9nWFDHLGodp/nCzwYuECu4O3EEYSum3jcehnEIAq6cNLBmu72X7HzExltr7Adpmv2f1QGj8zPR2POqPCV1z2vYisGnmh/NIkGmUhkgfDXOtSc6znHGJZ2Pfa8sSz/ceb9ovBwaRxBcH0aTa6vU7MmyguiFCBDzTsPTTMz7OENkYwsM1oVAyYOgBPs2gVa6cWq7Gx/D3EASoeGAnzwVjvL0+NWnaBNv4FZ6WgvxuYi03FsjyMrzEMctGM2dRnAzVqeV7qIWGGQ3ZsBxJXjzAVkqatY6MpI/oyzKxHM/lJR6i1VpDmRabRqE+/32A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/YC9l7zrQK35dy2vywC9p+5wuyoHRrprMcXNEPGTtgU=; b=G7MIXduemhwhgOHa9XZJeMb9BIY6A0XQR4a1fwst9Mc3vI4rKfqci9qdceBA05PmD5cWtaPtRNkJ8JmSBe1koD/wSggSx8M+iCcnzAF3KrPGiPhDLsEQeb1ZtRMJ6mdRPcoX5IyPahDVykDb3QRbD9zfVi60ag49GuBMOCzSTj+4zVl9Y8EG4VUMkAXgOYo7RMpfZzxpNv/dr+RrQH/b96cCzB9rhGWHbQ7sh+qYUWM0DyGGjxPj5WF8iBChJZbAFlENpdMQhlfaQ5G7VOL5kzvmpZWyJKdbsyEojpPSjf+la9UgY2hf1hySd3sPguYfXStCJKjbGeVeOhT3UgbniA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/YC9l7zrQK35dy2vywC9p+5wuyoHRrprMcXNEPGTtgU=; b=oka07srhCnrL3a0CaiPvK8Xa8SVeoaRkku8ViiGvJXgnThfT0F5sjHXC1a0hTc/CF2jJNJSCyF9UX8doYZx489Br4a2/4EkjRLyKP20lAHjwdwm2iqC0+OiyNbkZz1CdhyJ51FUE31nbj0MCy9c1BB92h8QnOg72yA/9l9j4KNM= Received: from BYAPR11MB3493.namprd11.prod.outlook.com (2603:10b6:a03:81::16) by BYAPR11MB3126.namprd11.prod.outlook.com (2603:10b6:a03:89::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3326.23; Fri, 11 Sep 2020 03:06:11 +0000 Received: from BYAPR11MB3493.namprd11.prod.outlook.com ([fe80::ade3:f409:e1eb:8586]) by BYAPR11MB3493.namprd11.prod.outlook.com ([fe80::ade3:f409:e1eb:8586%6]) with mapi id 15.20.3326.030; Fri, 11 Sep 2020 03:06:11 +0000 From: "Lu, Wenzhuo" To: "Richardson, Bruce" CC: "dev@dpdk.org" , "Rong, Leyi" Thread-Topic: [PATCH 1/3] net/iavf: enable AVX512 for legacy RX Thread-Index: AQHWhzeZizOccIMD3UW3e4Vaj/44F6lhm3WAgAEm0gA= Date: Fri, 11 Sep 2020 03:06:11 +0000 Message-ID: References: <1599717545-106571-1-git-send-email-wenzhuo.lu@intel.com> <1599717545-106571-2-git-send-email-wenzhuo.lu@intel.com> <20200910092957.GE1789@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20200910092957.GE1789@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.206] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 215b6d43-c7bc-4b3c-93cf-08d855ffa33d x-ms-traffictypediagnostic: BYAPR11MB3126: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: NiyjZ9+lUQO/77NFdlVa2zj2jnP4Rz8hcezXescdFWSZWJ07qIKtNWc62tRAJiSv+tGP8et/mh0rvz8Yn8+2ESUVWXDJ+H05ZPaN2TDstQLBhYQddi4/33NWIndEY6YR/r8mKGBH2+Ledg8RTt2bjvZ6REBavPKnkeIoSJbNAUQUH3KLV3XIV++h+TnylVYdrjC9yBTrszvgrjOGx4x5oERjCn2cFOXWRALj83jI4PoWbouOKUvXamtLjibNHmOdCugF9aVq/iemaP3hmVLKpG1HHgC3IPo5YrPefgWPXqharG5VlQLpAOPHm5j0cE/79deeHMU4yFkew+FOguTUDUwLO2lwRQ+2I1+VxMkw7uCu3TVqq4SNzFpnTiTvnXap x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3493.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(346002)(136003)(39860400002)(396003)(6636002)(54906003)(66446008)(64756008)(7696005)(478600001)(186003)(26005)(55016002)(6506007)(53546011)(5660300002)(9686003)(52536014)(316002)(33656002)(71200400001)(76116006)(8936002)(107886003)(66476007)(2906002)(83380400001)(6862004)(8676002)(4326008)(86362001)(66946007)(66556008)(83323001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: DSMhSfCK1G/plDEAfzEB4rwXkwb8Xxr5FLRWw9hqr4d1RVFgQZBXQq8GuWGpnam2jejgNk5G0pf9mEWfpmJLWsl180IMklFHz9wmT35LvJ4ZdW2ebF3tgznaPeFg29WITyEbQi2hiC3ftocVNg3tD/kAhMV/xsIG886nj9f0qipPfxMGI563CsaDJjQfn8Lal94TX/gD19nGIRS5hQMC4FbmC/noIDxPIui4jZcbM9se3zUGxDPzE5uVqsOhbVdNL/IWfeEe98X4627/qlG5otf/qwviutwcFhiCwHERWsLsi4qzAb3CmSLwJVhc9q8EDFi6j5kIXtzR+S9kKS9OrC35BoTrRu3ITWfrIP3xF/7wnhb27hwZQrzMB6NZnUIbPnMc/6rgYmy0YLFXZhi86qI2qUI8MaieijedYYnnhNtwuwdIhVuN4dJCg5mAGlxH/L4XZXyGwHI8pwf3hXj1EvwOXZtqee9OYcO4X/PGOHIjGTmZTUxnEX8W4Rdn2A+IaccMxH9FUTO15a8TPGSgmAMetpM3niNNF+kBklG02c01897JqmruOI+fTHXnPnmpYinVhWyOjjp4IMFdAdjKde2DraXq6n9A4Nd5O7cHMc2LsQ7xqeit0H/XFU1/BiGvGb0OlC054bCsbLAmpRKaFA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3493.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 215b6d43-c7bc-4b3c-93cf-08d855ffa33d X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Sep 2020 03:06:11.5688 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3wNmTeRIW4iZgcdeVuYSpKgOd3oSAdqz7I8bdAkKFdi75CrrEmGubm93UrzlTggvBwBTPQpHra3jAu7MVuNmGg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3126 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/3] net/iavf: enable AVX512 for legacy RX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bruce, > -----Original Message----- > From: Bruce Richardson > Sent: Thursday, September 10, 2020 5:30 PM > To: Lu, Wenzhuo > Cc: dev@dpdk.org; Rong, Leyi > Subject: Re: [PATCH 1/3] net/iavf: enable AVX512 for legacy RX >=20 > On Thu, Sep 10, 2020 at 01:59:03PM +0800, Wenzhuo Lu wrote: > > To enhance the per-core performance, this patch adds some AVX512 > > instructions to the data path to handle the legacy RX descriptors. > > > > Signed-off-by: Wenzhuo Lu > > Signed-off-by: Bruce Richardson > > Signed-off-by: Leyi Rong > > --- > > drivers/net/iavf/iavf_rxtx.c | 27 +- > > drivers/net/iavf/iavf_rxtx.h | 5 + > > drivers/net/iavf/iavf_rxtx_vec_avx512.c | 720 > ++++++++++++++++++++++++++++++++ > > drivers/net/iavf/meson.build | 7 + > > 4 files changed, 755 insertions(+), 4 deletions(-) create mode > > 100644 drivers/net/iavf/iavf_rxtx_vec_avx512.c > > > > > diff --git a/drivers/net/iavf/meson.build > > b/drivers/net/iavf/meson.build index a3fad36..6427885 100644 > > --- a/drivers/net/iavf/meson.build > > +++ b/drivers/net/iavf/meson.build > > @@ -34,4 +34,11 @@ if arch_subdir =3D=3D 'x86' > > c_args: [cflags, '-mavx2']) > > objs +=3D iavf_avx2_lib.extract_objects('iavf_rxtx_vec_avx2.c') > > endif > > + > > + if dpdk_conf.has('RTE_MACHINE_CPUFLAG_AVX512F') > > + cflags +=3D ['-DCC_AVX512_SUPPORT'] > > + cflags +=3D ['-mavx512f'] > > + cflags +=3D ['-march=3Dskylake-avx512'] > > + sources +=3D files('iavf_rxtx_vec_avx512.c') > > + endif >=20 > This logic is probably not what you want, since if the machine cpuflag va= lue is > set, then AVX512 instructions are already available, meaning you don't ne= ed to > add in the mavx512 and march flags. Instead the logic should be handling = the > case where it's not enabled, but the compiler supports it. > Use the AVX2 build logic as a reference. Thanks for the review. I'll send a new version. >=20 > > endif > > -- > > 1.9.3 > >