From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5A11CA04DD; Wed, 28 Oct 2020 17:25:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B791268C0; Wed, 28 Oct 2020 17:25:14 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 5406B4C73; Wed, 28 Oct 2020 17:25:12 +0100 (CET) IronPort-SDR: v26dUSGuI2zeo9I+MRMKSn3UrPnyBQl9QLyMdPzV7KHor51EHWwzQ0rRUjmoKQbFR+gd1XJF0x HV8NnL5KueOA== X-IronPort-AV: E=McAfee;i="6000,8403,9788"; a="165698800" X-IronPort-AV: E=Sophos;i="5.77,427,1596524400"; d="scan'208";a="165698800" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2020 09:25:10 -0700 IronPort-SDR: dsimyM3MBZc9D4iGopJrKgF8ZRJ9qBGeyUvHs+s5jN7nYMJ85Job8KFSQQGqwuQPErNexiIpjN OGapqlt/uwSA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,427,1596524400"; d="scan'208";a="526384174" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga005.fm.intel.com with ESMTP; 28 Oct 2020 09:25:09 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 28 Oct 2020 09:25:08 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 28 Oct 2020 09:25:08 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 28 Oct 2020 09:25:08 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 28 Oct 2020 09:25:06 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JQbAIrbmZmCOsX60Nh0NvqSxNEav5MIVL5Dutuy0V64jximqUvxxrgG74VC1dOjmEJ4omcG/Zb8++dp9WtKsOgEbIbDdYZI0haFlHJ78AUU8g0avlSm3XhlDrtdViCQtZDOGGmp9r5QEqnmcxX8huzdjH+QgS6+k02Pc0b+MNnVOVLa3gHjAfnetOLwyGVMc2SnjTWJq7W+IGFtiOr+ZHk3kLfm01baAUrzPV/fooi3kdCinDFRTTpPSgWREee8MEoYJqv/kSklbfeWQtW300qkzmi4ilPFxR5tsiawsMSq6jH1p2XAYR5SRPhd6ALereygvzHKUxJBZ7x/uRbWTRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xafvxDXs99y+rrY0rCK0GiJj4OcRNfOBbyd89FmAVJ0=; b=ThtpIdf78PfIgEZcgAct53vagQbgjN2w54tGEDV37tOt6GxzOqp5ceNynVihihrFBw9iWB2OtYISblgyhikWU/UZpvdNYtVq5UwVIO8TmuJ3kFDFL/OCxpsBYqUvKvbngilMZCt776v/sLpncsx/H8FyQWSf2Eq4QkZHKeGr0c4c7YsQJr2w8FA7uLLjTOP9fTlZF01Gs4ANnnlsDDtk4QvEXOnRXNqkecMbi/vsW3tY/X6H/A8LJpY/M/9O/UUIkVLUQ9+dAlyqW10aypaYd/PwSd+3+4AH4YW7wTJ/RmDc/W5X7xNuYkJjk8dLmNxcS825v/G+rN7hlLsUyHG3sA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xafvxDXs99y+rrY0rCK0GiJj4OcRNfOBbyd89FmAVJ0=; b=Bw+FZuD3MNE1oLMJFQtcThNnhVW/0DBVAYJpoTwjENochHIrKtuiS5X6CyAy+ghTOU+Rc1TgJHNde7FhQmpMWrVXHJG9XmzyUmt7P59jLG/wiUp+Ep9P+MIYfMuYqYPvzAvO0tsPSwJF+aw/g+ScUNDAuOkAKLAqHhHo7m5/OSY= Received: from BYAPR11MB3494.namprd11.prod.outlook.com (2603:10b6:a03:86::15) by BYAPR11MB3527.namprd11.prod.outlook.com (2603:10b6:a03:8b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.24; Wed, 28 Oct 2020 16:25:00 +0000 Received: from BYAPR11MB3494.namprd11.prod.outlook.com ([fe80::5886:71de:a26f:8060]) by BYAPR11MB3494.namprd11.prod.outlook.com ([fe80::5886:71de:a26f:8060%4]) with mapi id 15.20.3477.028; Wed, 28 Oct 2020 16:25:00 +0000 From: "Wang, Yipeng1" To: wangyunjian , "dev@dpdk.org" , "Gobriel, Sameh" CC: "Richardson, Bruce" , "dharmik.thakkar@arm.com" , "jerry.lilijun@huawei.com" , "xudingke@huawei.com" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] hash: fix dereference before null check Thread-Index: AQHWrGAgXXDLMUcJXUuSESporLQwgqmtNNDw Date: Wed, 28 Oct 2020 16:25:00 +0000 Message-ID: References: <166b4a84232777b5ff3dd5d659140dab104e3f77.1603782481.git.wangyunjian@huawei.com> In-Reply-To: <166b4a84232777b5ff3dd5d659140dab104e3f77.1603782481.git.wangyunjian@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [108.161.24.24] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b789133b-2166-4660-9632-08d87b5e0471 x-ms-traffictypediagnostic: BYAPR11MB3527: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1775; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XPOgNryqkdH9A8mAIMm2/SCmlI362c0HEtkFVhJmo4YjJulB6dS02QmCuYr7nfYVJiGaRQGixgDckGMPcYw1yKEi82Wqsya1IC6RMoyAUAvTy/U2bC+g6eF694gkqsAYVEfNCUcVIeE25dCmZ7Vokz6KnKhJak5oOHA4rWsavrSAVK7mlZbUDOnOdAyqPNAFJ3UXsApLGe8qXs4MepqCGM7Ssc8oURQUHYGqOEUp45RzTe5ycvwPGsoyJaXHmIHfNq5M6vqk1VA/6gJZsNS/oFPRPY55DImbgnHGodAV3URymwY6/WXTYLXfEgDcrX8OQWdn8S/dy8UfF7Qzd8X8KQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3494.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(346002)(366004)(376002)(396003)(2906002)(186003)(54906003)(8936002)(55016002)(316002)(7696005)(4744005)(110136005)(33656002)(26005)(9686003)(5660300002)(83380400001)(6506007)(53546011)(86362001)(4326008)(76116006)(71200400001)(6636002)(64756008)(66446008)(66556008)(66476007)(66946007)(478600001)(8676002)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: W3XE8xw+u+YY73I1H6Fx8StB7Eued9Irsz7Qvqgzz2nT3bgWeR4Y18RYDsqDhPt6W1nCTICaVWtJnPUpmIAgRma0VaTsTvvrzOMqvF3dWV4+fgQMZSeokJneZEy3vRgyxEd/OVj0T4ihKqer+h7hvN+DavEK53pyg3u0jEltKEDo2g2PCAVi7GoBTW1WCidYijvmvg5vODBDXQ0rF79S+m9sD+4Y66tNHX70MqcYYZ3pN5ez+nasq6cH0zFu2d1F67RzLY4tU8mCDtzIFVyWwo2bHI5q78bmLSyv2KpCnWTnau8BC9F4dQEZ6u1BuWL7DVUmxhe/Thyxjnqy4MCaHsy+d8DjyXF12OmSBSZqHvp5/kgqIawtJjm8iKxaMJydmBYgm5fK1xQdHmG34LT8QVjYwRbQ3gHLk9nba7EQUmOj97ToPU303yUaz7FOxRya9Sf/pbSMIG2utCMiy+iUKEb6n/SJA90KIBaif1FLS/ec1DcwMvmoSksINtZDRWsBoaqGxshJXqyGUPYAqT0+1B5ikGOUGD8TQjkEw4GNXHdos198PZAG4t8BpaI2E+2G568yrYblz1SlYuCQ9I17+XTlBlIkzKv3M9PTIkGBF4bYLKZ1OjwjKGXMU2gxEjWs0gfUEr5nyk3eTHnIM4NUoQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3494.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b789133b-2166-4660-9632-08d87b5e0471 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Oct 2020 16:25:00.3361 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5qYUiO7ofkwpKk544PDncEoBPGOnUtz0npRpZVlXyqU4MoaxoNjnD86ZS9Yv+oPvyv1dDK+n4nm9mkD/CMx3hg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3527 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] hash: fix dereference before null check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: wangyunjian > Sent: Tuesday, October 27, 2020 5:51 AM > To: dev@dpdk.org; Wang, Yipeng1 ; Gobriel, Sameh > > Cc: Richardson, Bruce ; > dharmik.thakkar@arm.com; jerry.lilijun@huawei.com; xudingke@huawei.com; > Yunjian Wang ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] hash: fix dereference before null check >=20 > From: Yunjian Wang >=20 > Coverity flags that 'h' variable is used before it's checked for NULL. Th= is patch > fixes this issue. >=20 > Coverity issue: 363625 > Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation") > Cc: stable@dpdk.org >=20 > Signed-off-by: Yunjian Wang [Wang, Yipeng]=20 Thanks for the fix! Acked-by: Yipeng Wang