From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 59DC3A0526; Tue, 21 Jul 2020 22:24:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 36FAB1C0B1; Tue, 21 Jul 2020 22:24:18 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 4F94B1C030; Tue, 21 Jul 2020 22:24:16 +0200 (CEST) IronPort-SDR: 9nd7qxYxK3+Ozm+Tn0rECKF2/5vwcZJHiaCVF+XZzZhtIcl8vW+Ji2bkhnZEOjRmnOPdWAP7Wp vCtb/g3qBJlg== X-IronPort-AV: E=McAfee;i="6000,8403,9689"; a="211769058" X-IronPort-AV: E=Sophos;i="5.75,380,1589266800"; d="scan'208";a="211769058" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2020 13:24:15 -0700 IronPort-SDR: rxxUx+TXHDvJvZ6+Sv6ZZu8Xuxo2EtDudeTshLiktlvYq7d8qqo+odZJ+I5luknoSd/F+LDCRE CeBnBLT2NTgw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,380,1589266800"; d="scan'208";a="301728330" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga002.jf.intel.com with ESMTP; 21 Jul 2020 13:24:15 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Jul 2020 13:24:14 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Jul 2020 13:24:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hpAwgB23ZXTYsRPfebcPGGXb0S0sJkzkOWA6w53oe/nB+mb34kNsZBM9wi9bjNQ/fFdIYMqSPp5dyJGfiEvgsy5qB2WLvAYO28nY6xZuGK4JcSoh4TyCDcoZTh/nhdeTteFng39LQf43ZkmXB9r4GL+mtPevp8Ysj0WVjr+keOgkf6QB5BByREaey/NwcX73bslvbLcPJR25Wgb8tsX1DO3ef0hK5aMMd/14a7vAPWVGcfJ7o7K3fWIFPmOy0jqnFiEglyZdmcNh+pHWIOVUiEyOs0pb+pRgsydvWj52MNPYPOsDbjhSudoZCUVIZmxBgkixbgkMmhdQ7DED8rVVZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CM9CgbS5noSwy7h9g2uH/Is0e1PkjDknp3xzzOnmzJQ=; b=LWXghxaMk3iH9J0qryEazsrbzXq/oRBK95xTLrQ7eBru4mRwcbGU2i+wPDwd7zb+tqy+Usn6DTEjS7i8ExfOKTgu/O7eszzkgNfTW2ek8/wmu+zQKt30Php1pMmFWhMYRRxSda0osBaNZTPFxkRTJoweyz7Pbfs4J36jxB7y2I1YCvm9Hmw/1rHgMZQxHKapSOyueUzxvIKEsyygY/cZpv6mxTrArgdaZ3zMUbwsAaw9SbBg8gIoVSR25xvJE7VFk3Vlr+CAmcCBA2YGB6O+YBPV6Da1p0w68/kF8qOg+DCb55Qbxk5ClgUrpxTU7uzGzB2ffSFMMqYkcnDDD9fWQA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CM9CgbS5noSwy7h9g2uH/Is0e1PkjDknp3xzzOnmzJQ=; b=bTkO8b/pPa001q0SM76VOSPxuzvgv/+MsIX8kH/bEWJBkt5oL5BB0VdNk8askn5lM1nbbuLaIKDLT0R9ebhEBnt//bx5je4nhSJ9qBJL399o9CUA2oTIGYcLeZeyaSO8n1zwQe/pGCsr5AfMAvGFNHHECUy5jjfG+l3eWYvsylQ= Received: from BYAPR11MB3494.namprd11.prod.outlook.com (2603:10b6:a03:86::15) by BY5PR11MB3941.namprd11.prod.outlook.com (2603:10b6:a03:183::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3216.20; Tue, 21 Jul 2020 20:24:12 +0000 Received: from BYAPR11MB3494.namprd11.prod.outlook.com ([fe80::69d4:7531:329e:ec8c]) by BYAPR11MB3494.namprd11.prod.outlook.com ([fe80::69d4:7531:329e:ec8c%7]) with mapi id 15.20.3195.026; Tue, 21 Jul 2020 20:24:12 +0000 From: "Wang, Yipeng1" To: Honnappa Nagarahalli , wangyunjian , "dev@dpdk.org" CC: "Gobriel, Sameh" , "Richardson, Bruce" , "jerry.lilijun@huawei.com" , "xudingke@huawei.com" , "stable@dpdk.org" , nd Thread-Topic: [dpdk-dev] [PATCH] hash: fix return value of null not checked Thread-Index: AQHWX4QzWFgPoNTG8kuIpJFvxkt0PakSee9A Date: Tue, 21 Jul 2020 20:24:11 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [108.161.24.24] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9f97a38e-5925-4417-721e-08d82db407dd x-ms-traffictypediagnostic: BY5PR11MB3941: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: umHNeUTVliOI/F6vaxv840PRIFpnAHC5vmDwe8A5Qsc3dOkrc37ZaUDQTLgS4AH6XP8PGASFLKa1IFF2hoSYpKWjxHRDvHCKcgLDZISvKPc32ubt2A3iDuqe7yx9lLIZNtelxGv5rBs1T6V8hqjylsfIDUYCD8Ai7RLPpWq+FHEP25sd7ffn1e0FcifjLC0YSOdQlwjLlFKFQvLk1HvpubEVPJDOeVDFmYPzYrbTjaQnwQxdHrXlr9da4B5jlqQNxDkpA4DpcSKyV1el/HyR4ZRsLO1/THr1+SZeijg7zFDxRBoFwa1EGSdjfECLdxaET/i6dtih//+bOwkmZ5GyWw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3494.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(136003)(346002)(376002)(396003)(366004)(39860400002)(71200400001)(4326008)(86362001)(33656002)(64756008)(66476007)(66946007)(66556008)(76116006)(66446008)(8676002)(8936002)(478600001)(54906003)(53546011)(7696005)(186003)(26005)(83380400001)(9686003)(55016002)(5660300002)(2906002)(6506007)(52536014)(110136005)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: M5FYtKHkg4rVrcBdkcwX/VeqA3fF3dz1Vx/sKe/P+OpDsbQL6OkzLxWUS0PkdWcKcBr8XIDuKJpnCk6sfa1BHaoj5ua+oT7tU1OMIpR4ZD86tnsItN59kbqwsAmfy++48tHeKxBFX9qfjOxfAh1Yh76QnhK0EgEeGdUjFeLu6wI8g6SuILwdStr86JsUVZQGOLqrjJDETmsA8/Q+aAxcefcCfVkTYRD4TzsO2xLjhpMANEEGZ0QDskuCxCbYkZO79xfi5Or8oDS1J8TK9hsqdRYLP/jtVhhYZHjCV+IP+359c2t5SlfHN8lzvGrHthvm5+aKsm67JUF1TSpmzNUJ3KxSJg+wjXMdK2q6hH+gegV/SHy1BkheoD8x2YyOsQ2DkxBezfHovyh/6WbnHqztQqJZswUmR3pXusnrnJH0yQ1FV4U74mIbVgi5kUFNHnGor6N9wz1kqto9h7ZisQddO/UF6moGs821iFMPuCyivag= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3494.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f97a38e-5925-4417-721e-08d82db407dd X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2020 20:24:12.0272 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WaKnwJ0Oxu1vYzQESwcy70XZBrCHqJQ3b/viVnm6eWhJ9yaMPzIypwm8CgiH4Ya2054ljrFWtPukbq6OJjgo4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB3941 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] hash: fix return value of null not checked X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Honnappa Nagarahalli > Sent: Tuesday, July 21, 2020 10:27 AM > To: wangyunjian ; dev@dpdk.org > Cc: Wang, Yipeng1 ; Gobriel, Sameh > ; Richardson, Bruce = ; > jerry.lilijun@huawei.com; xudingke@huawei.com; stable@dpdk.org; nd > ; Honnappa Nagarahalli ; > nd > Subject: RE: [dpdk-dev] [PATCH] hash: fix return value of null not checke= d >=20 >=20 >=20 > > -----Original Message----- > > From: dev On Behalf Of wangyunjian > > Sent: Tuesday, July 21, 2020 8:32 AM > > To: dev@dpdk.org > > Cc: yipeng1.wang@intel.com; sameh.gobriel@intel.com; > > bruce.richardson@intel.com; jerry.lilijun@huawei.com; > > xudingke@huawei.com; Yunjian Wang ; > > stable@dpdk.org > > Subject: [dpdk-dev] [PATCH] hash: fix return value of null not checked > > > > From: Yunjian Wang > > > > The function rte_zmalloc_socket() could return NULL, the return value > > need to be checked. > > > > Fixes: 5915699153d7 ("hash: fix scaling by reducing contention") > > Cc: stable@dpdk.org > > > > Reported-by: HuangBin [Wang, Yipeng] missed a space in name? > > Signed-off-by: Yunjian Wang > Good catch > Reviewed-by: Honnappa Nagarahalli [Wang, Yipeng]=20 Thanks for the fix! Acked-by: Yipeng Wang