From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: Feifei Wang <feifei.wang2@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "nd@arm.com" <nd@arm.com>,
Ruifeng Wang <ruifeng.wang@arm.com>
Subject: RE: [PATCH 3/3] net/ixgbe: reduce redundant store operation
Date: Mon, 20 Dec 2021 07:24:42 +0000 [thread overview]
Message-ID: <BYAPR11MB349526D8EA4CE25F23E597B5F77B9@BYAPR11MB3495.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211220055039.4035627-4-feifei.wang2@arm.com>
> -----Original Message-----
> From: Feifei Wang <feifei.wang2@arm.com>
> Sent: Monday, December 20, 2021 13:51
> To: Wang, Haiyue <haiyue.wang@intel.com>
> Cc: dev@dpdk.org; nd@arm.com; Feifei Wang <feifei.wang2@arm.com>; Ruifeng Wang <ruifeng.wang@arm.com>
> Subject: [PATCH 3/3] net/ixgbe: reduce redundant store operation
>
> For free buffer in ixgbe driver, it is unnecessary to store 'NULL' into
> txep.mbuf. This is because when putting mbuf into Tx queue, tx_tail is
> the sentinel. And when doing tx_free, tx_next_dd is the sentinel. In all
> processes, mbuf==NULL is not a condition in check. Thus reset of mbuf is
> unnecessary and can be omitted.
>
> Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
> drivers/net/ixgbe/ixgbe_rxtx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c
> index d7c80d4242..9f3f2e9b50 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -120,7 +120,6 @@ ixgbe_tx_free_bufs(struct ixgbe_tx_queue *txq)
> for (i = 0; i < txq->tx_rs_thresh; ++i, ++txep) {
> /* free buffers one at a time */
> m = rte_pktmbuf_prefree_seg(txep->mbuf);
> - txep->mbuf = NULL;
Not sure, but at least found:
static void __rte_cold
ixgbe_tx_queue_release_mbufs(struct ixgbe_tx_queue *txq)
{
unsigned i;
if (txq->sw_ring != NULL) {
for (i = 0; i < txq->nb_tx_desc; i++) {
if (txq->sw_ring[i].mbuf != NULL) { <---------------------------- ?
rte_pktmbuf_free_seg(txq->sw_ring[i].mbuf);
txq->sw_ring[i].mbuf = NULL;
}
}
}
}
>
> if (unlikely(m == NULL))
> continue;
> --
> 2.25.1
next prev parent reply other threads:[~2021-12-20 7:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 5:50 [PATCH 0/3] reduce redundant store operation for Tx free Feifei Wang
2021-12-20 5:50 ` [PATCH 1/3] net/i40e: reduce redundant store operation Feifei Wang
2021-12-20 5:50 ` [PATCH 2/3] net/ice: " Feifei Wang
2021-12-20 5:50 ` [PATCH 3/3] net/ixgbe: " Feifei Wang
2021-12-20 7:24 ` Wang, Haiyue [this message]
2021-12-21 6:55 ` 回复: " Feifei Wang
2022-01-27 7:40 ` [PATCH v3] net/i40e: reduce redundant reset operation Feifei Wang
2022-01-28 6:54 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB349526D8EA4CE25F23E597B5F77B9@BYAPR11MB3495.namprd11.prod.outlook.com \
--to=haiyue.wang@intel.com \
--cc=dev@dpdk.org \
--cc=feifei.wang2@arm.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).