From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E45A5A0509; Wed, 13 Apr 2022 13:49:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 834A640694; Wed, 13 Apr 2022 13:49:28 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id DE33D4068B; Wed, 13 Apr 2022 13:49:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649850567; x=1681386567; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=yHu2Ee4LlB7NULlnIoNF3jFchuBxYkL+b3hda+Kw9nQ=; b=BixH+OZxOzCzGnESucTS7ByEiVEUKG3Q98T6/R27wxZoX4F4yHim450h SED8qpyzw99p/QFHgpQee90qLyudWKlza+yDn1vqI0l/0m8vogCLgreI8 UpRDGK+Qr4Bkx5fG4nYoH8X3E0GcQQpnpWZD9QAdte7Xu/G4Dc10CPUNi 2R46snme2gNVOuoAMv5k+C2Y9XPwcjuebs6xh2GZSAcPsZvYgpkm7Apy1 cDBvGibGo4tvp43cfqgMMyL/i230z8G0fHSJBwvZaiF62KpYkHcDgOWQS SxowdS3b+rlT3exn5AC3C82Jf+UB9WNxnVIX7Auo9rfOUSXXeP2btXgyD w==; X-IronPort-AV: E=McAfee;i="6400,9594,10315"; a="325548080" X-IronPort-AV: E=Sophos;i="5.90,256,1643702400"; d="scan'208";a="325548080" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2022 04:49:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,256,1643702400"; d="scan'208";a="559718167" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga007.fm.intel.com with ESMTP; 13 Apr 2022 04:49:25 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 13 Apr 2022 04:49:25 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 13 Apr 2022 04:49:25 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.177) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 13 Apr 2022 04:49:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DY9zAD8ghj9eIuALAvo2CvPO5fbD+QUOzb3dsLnkszSsGOPTM2fxjRKShTPyiiarkRk/bnTHA9lWtxEUyG7DCeKeQyoyd1hxBsVGmeHjzAB96OsibC6VHGWjERPOKdF2K/Rd7YLyYQX+mrMDFbD6AJfVc3Fljab3Hl6JH9lZ69sl+uspSPhQpvu7P6ezNUPcE7l/IvxhsLnUuYp2/er3IF5ZP3WiQKmI3QbQFC2YXmrReGzRi4awa7gBeMHNj8w5swSQKmocyfkizjQJ8ygFHVm5ai84WtrMC3+0Lw7SXkF+/nlEqquo9SSdj/SXvnN+qYYWQgzH2TyDUT+L3hM/Hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yHu2Ee4LlB7NULlnIoNF3jFchuBxYkL+b3hda+Kw9nQ=; b=H++wj4cdYW2gkQQWoWuI0nvcBSxs/3/wGyHphmVS3RD99sKpzx5S2aOOB4wCnSGuX/TSwoz1ltpVTUF33NSh6D/JdWo7Sr6Uto9R5x+OWXP2SE6Sk2AMB8Y2bOAPfKBYyVPzhCP+Y9uiIFOAnKdxwmU0Ubf+HG7i/giM8PC1YG4PafhxyQoZzA/xoxdHJsnSe3eutEoXe+yYx0uwMLjBKVIsMG3T34wYx+fFffsFNtAb9hOVxXl5YjSeb3Lei/5QQS+ya+Gyj7M5Y5hQ0O9Cm5/D87wVgg+dAUjYu2g8YjQolrBasHviRARAZxRkRB2OeA4/1UpaFtarcctzWEKbUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3495.namprd11.prod.outlook.com (2603:10b6:a03:8a::14) by BY5PR11MB4136.namprd11.prod.outlook.com (2603:10b6:a03:192::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Wed, 13 Apr 2022 11:49:22 +0000 Received: from BYAPR11MB3495.namprd11.prod.outlook.com ([fe80::784a:cab8:f035:d8ca]) by BYAPR11MB3495.namprd11.prod.outlook.com ([fe80::784a:cab8:f035:d8ca%6]) with mapi id 15.20.5144.029; Wed, 13 Apr 2022 11:49:22 +0000 From: "Wang, Haiyue" To: =?iso-8859-1?Q?Morten_Br=F8rup?= , "Daly, Jeff" , "dev@dpdk.org" CC: "stable@dpdk.org" , Stephen Douthit , "Yang, Qiming" Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug Thread-Topic: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on hotplug Thread-Index: AQHYTpWG7ngQWSPahkCox1ZHMx0Ya6ztIqNAgABE6pCAAAO7MIAAAnFAgABMqIA= Date: Wed, 13 Apr 2022 11:49:22 +0000 Message-ID: References: <20220228152937.21247-1-jeffd@silicom-usa.com> <20220412174220.31195-1-jeffd@silicom-usa.com> <20220412174220.31195-3-jeffd@silicom-usa.com> <98CBD80474FA8B44BF855DF32C47DC35D86FD6@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35D86FD8@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D86FD8@smartserver.smartshare.dk> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7d75ce12-ee3b-42a5-2ce8-08da1d43a6b2 x-ms-traffictypediagnostic: BY5PR11MB4136:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jYri9mMbaXq+MxTPZe/OBierbtQ2WS4dq2MQtV5ZLjrbSseBsy93FZMMPioxNT3b+QEEL9F6cXkuScDgfGtse4K9vBtrV3/0RBeeNkcH52upbJv+k4lX0uUABXn/EZ5tZUc/V0BUXUmQ2Hm/+VhCHdIG/90NEefIRmnP1gdR6BkhSvfDJ+2/GlnYPSq9PARONHiq2X60tPHtGln73g7u6nw7KiMvBzyNq045ggez3xKXRC+7uw6EnhG0leTSQH4+S189e0zd3UF1+2temvK2YBYvt+rgG6QYswI6yaUTq9AQlvcwlIT32i/dK2wqdGzgydgKHdLsKTMrfStQVDDZwSEvLUqw3TUW14lOq0q2n7Ov7xjOYf5JqdJCBbhlcJMYMHNnQP1T5m2Pwi5WSDiOqhWb581eS/ZrTG3dgnph4D6kH3xSstIcjetPJO5PZL4pq2xFcorcJues4fLJ0QRKXCYLIi9x5qtPbu+3gUJpClUIdh7CIVwEMjHnFFTagdYnVdX9mSvIYHizD7q64vFKshb3j24fZ5YPlstze9s9V7xjBvYz5l6eO5so2wwfjfE4M9WabrgjGegXpLqgcmB99+HokNcnkGoKIxCviV6fTiBCRQWQqoSs662SvF5haCc8smeonTugH9alLk5WqysqQbrObhZ2UuZf+dQIys/JqD4IC2mCrvufkDPegmxatgb4oBrCJ4pqPN32x2AqxhsugA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3495.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(54906003)(316002)(55016003)(66574015)(9686003)(110136005)(6506007)(107886003)(83380400001)(38070700005)(508600001)(52536014)(33656002)(38100700002)(122000001)(82960400001)(71200400001)(86362001)(76116006)(53546011)(7696005)(2906002)(5660300002)(186003)(64756008)(26005)(66476007)(66446008)(4326008)(8676002)(8936002)(66946007)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?Ak0Jj1PK9f3IE/nmqa18mY4/TH18wBZ8XsEoK4TH0UpC7hfweLm6UvHau0?= =?iso-8859-1?Q?riUGYtbdUeR5TzIPPORvKwubCUc35WDtOyBE00tlYdwP9RBHtu0GHzb7oh?= =?iso-8859-1?Q?gh8s+E5pI3RsZxQ9L5xVyhdaGYETWHpa33DFkBNYULTY/Pi3HnzDJuwZoW?= =?iso-8859-1?Q?U0RJC7OS9tLBUQWaXkELR09LoFKA9nuTzIRV6gi0MGsnR4lhnuSQOVPUfL?= =?iso-8859-1?Q?gc6OLRPfKSYA69XGEy79ZgfFCr6jFW3ivPDUSxruuHpPSpLDvHbqg5mGBk?= =?iso-8859-1?Q?QY7G525sHeD1UbdWq5ULK8akfQmkUu0T3lW9BEWgRhr/jFh0k2llFs469+?= =?iso-8859-1?Q?kxA9mZeqifpP8bG4v2Y7ZalFc30gyogyq0iE0g9lW/6eovayQ/IsEHTAqP?= =?iso-8859-1?Q?ER58nnWWcVogPLVgVwf08TQANFmCQSRBKmuFelBpx58ElprZnD21m5LUDX?= =?iso-8859-1?Q?IY53kMKwyipXXqoUXcpWsrhCNoktJE0SbMveydb9QY5DaG7VdNuy3UJfJF?= =?iso-8859-1?Q?7GaWu8GCUfywfo9QgIoNzE81aQSd0aPO2xoMEpaPYBvX94JV6Qup+tIBf/?= =?iso-8859-1?Q?Nc3P77NGdjNRlxNxQm2Gj7Iu16/qOaxY65ELTtVRKCm34bFty1N7qA2ZT7?= =?iso-8859-1?Q?cxCW6Vo0SjSoQLjuE0fPTsJ027lxsOEYfykivROyJguV2KaUf3+rQEELwp?= =?iso-8859-1?Q?8irZq27MtDydrkCV/Yh56wrNrhn5qmp0/FyRmYWWO8CVRzkTa49IUWiRts?= =?iso-8859-1?Q?gXoDoFTD4+XjlFnkknAYzfz65KVV7RF9/JFd7pBCMyK/Rt+l4uEpLL/tqb?= =?iso-8859-1?Q?d/5ijefQGwEleRuHwCk1Ao2UxmPIuthVm2efkOLQxtZe1GtTZWaMzAjZbR?= =?iso-8859-1?Q?oXpHnFcueQ9gwLmLs6ebtwwmbIs5rLMbGqAdoyS9qugtKh3FzfBO72nkQj?= =?iso-8859-1?Q?ETfJpmoQRP7Zy3xj4wAs5LGMUQl9BOtj9rJw5BVUCfgn2MxJqT/ZWjYlJC?= =?iso-8859-1?Q?in2jyNaM0CS9sUvUxvbMbgpOpsmXegSMBhBkSX6qp/ixJUTb7BFfzBE0S0?= =?iso-8859-1?Q?+p0O0kwEHEuHvKrqByR++AwhkPNU75VFPF0Sj7gvZvAMw10RSA+GSHuvMW?= =?iso-8859-1?Q?A9sBiC6MzJwCwVsDm9Ab4+ZgGU+KuxlmqIFKKySRNAxf+CUR1PMj/cpJ2q?= =?iso-8859-1?Q?cwBFdmlaFvp95ldIIK8KlGt83ZVRscBdqYBY5/IaJ5QBsYaa1h3uCrJGUR?= =?iso-8859-1?Q?MMMfOyq/uSwG1KaKZjt6qavgSs4TCNVOIN4eD1eVtnT0xCv1Kr7hzZE93z?= =?iso-8859-1?Q?Rh01Nvf4fN1TbY4BGhOCaW4XTl/N4tXHUibGF7nnwI6NyAuJVQNJbvl/8+?= =?iso-8859-1?Q?/LCyQWVYsLkRKkmXudwyRsWeNOiG929FOeRvh68NKaT1r9r+G1nGnUHmix?= =?iso-8859-1?Q?1Lkje7gZ1aJQ4C5gqPSz1KcZmHrSGS3RaP5f0gugMyDIS/smwmo4RAMRyS?= =?iso-8859-1?Q?kqerMPWGfffu0MCWM9G4Sk729oSyoU4rWN57FvBM9WxK3vSadeOoUQ3B1I?= =?iso-8859-1?Q?copkKLvfCjj26bxqfjCQvASf/mDogUwjPjVJ4dLFEOJcXDUXNkYgTjd/Kx?= =?iso-8859-1?Q?z4s2UvEg23RPprhXPhR393mU6W/XvWDW+qgliiHUd42xSSpIu74XAmMQya?= =?iso-8859-1?Q?zt4qLRsEz/cFufN0aEZ6t4U+YTNhPvBUvNPclsYym5CoQk4Tz5au4XY1Af?= =?iso-8859-1?Q?auWzt22EnwaRQdMiOkLP/epZ1agLaBRtm8EwOmnnS1iHpwUFA6UEQ+GLSF?= =?iso-8859-1?Q?3VnkUdi/GA=3D=3D?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3495.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d75ce12-ee3b-42a5-2ce8-08da1d43a6b2 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Apr 2022 11:49:22.2430 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 3x10aMilFxiBvz8V9OTx2Ma2QSMZI4f7Hl6d1HkBQSOgWzRKYlm9aQuFrbL1Vz3HurmmZHML1o8711Tt1/JYug== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR11MB4136 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Morten Br=F8rup > Sent: Wednesday, April 13, 2022 15:20 > To: Wang, Haiyue ; Daly, Jeff ; dev@dpdk.org > Cc: stable@dpdk.org; Stephen Douthit ; Yang, Qi= ming > Subject: RE: [PATCH v6 2/2] net/ixgbe: Fix SFP detection and linking on h= otplug >=20 > > From: Wang, Haiyue [mailto:haiyue.wang@intel.com] > > Sent: Wednesday, 13 April 2022 09.02 > > > > > From: Morten Br=F8rup > > > Sent: Wednesday, April 13, 2022 14:58 > > > > > > > From: Wang, Haiyue [mailto:haiyue.wang@intel.com] > > > > Sent: Wednesday, 13 April 2022 04.47 > > > > To: Daly, Jeff; dev@dpdk.org > > > > Cc: stable@dpdk.org; Stephen Douthit; Yang, Qiming > > > > > > > > > From: Jeff Daly > > > > > Sent: Wednesday, April 13, 2022 01:42 > > > > > To: dev@dpdk.org > > > > > Cc: stable@dpdk.org; Stephen Douthit ; > > > > Wang, Haiyue > > > > > > > > > > Currently the ixgbe driver does not ID any SFP except for the > > first > > > > one > > > > > plugged in. This can lead to no-link, or incorrect speed > > conditions. > > > > > > > > > > For example: > > > > > > > > > > * If link is initially established with a 1G SFP, and later a > > 1G/10G > > > > > multispeed part is later installed, then the MAC link setup > > functions > > > > are > > > > > never called to change from 1000BASE-X to 10GBASE-R mode, and the > > > > link > > > > > stays running at the slower rate. > > > > > > > > > > * If link is initially established with a 1G SFP, and later a 10G > > > > only > > > > > module is later installed, no link is established, since we are > > still > > > > > trasnsmitting in 1000BASE-X mode to a 10GBASE-R only partner. > > > > > > > > > > Refactor the SFP ID/setup, and link setup code, to more closely > > match > > > > the > > > > > flow of the mainline kernel driver which does not have these > > issues. > > > > In > > > > > that driver a service task runs periodically to handle these > > > > operations > > > > > based on bit flags that have been set (usually via interrupt or > > > > userspace > > > > > request), and then get cleared once the requested subtask has > > been > > > > > completed. > > > > > > > > > > Fixes: af75078fece ("first public release") > > > > > Cc: stable@dpdk.org > > > > > > > > > > > > > So BIG change for new platform, DON'T CC to stable! > > > > > > What do you mean by "new platform"? The ixgbe hardware and driver is > > not new. > > > > > > > It's soc NIC, ixgbe not support before. >=20 > If the patch only fixes the driver for a new NIC that not supported by ol= der DPDK versions, and that > NIC is not going to be supported by older DPDK versions, then I agree tha= t there is no point in > backporting it or CC'ing stable. >=20 > However, if the patch could also apply to any other ixgbe NIC that is pot= entially supported by older > DPDK versions, then it should be backported. It's hard to say, these years, I see many ixgbe link related fixes. At least now, no big link fix for normal ixgbe NICs. This patch still have some kind of TODOs. And this is not acceptable for us to maintain this kind of code for released stable DPDK version. I don't want to see many follow fixes ... And we have two DPDK development cycle (22.07 22.11) to make it for next stable release. >=20 > > > > > This patch fixes a bug (with a serious impact when occurring), so it > > should be backported. The size of > > > the patch does not disqualify it for backporting. > > > > > > -Morten > >