From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED176A0508; Thu, 14 Apr 2022 14:14:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8EF8B40687; Thu, 14 Apr 2022 14:14:02 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 473F540041 for ; Thu, 14 Apr 2022 14:14:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649938441; x=1681474441; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gDhncRhpgNotcwmonbj9ojy9yjQPHcbntiqH/xgA/ZE=; b=XcnSuzSzULLK0jnTvov6Wp3HBMJugArQseHKwyelHXH4pNenmyc7F9tq gkiXWbY7/8iDCns4JYjCj4lZpwmB+WIVzwnS3ndiGeJ29L38ZKS65z7Ly RlrNxOs40/zVJADX1GXsXi9y8xKqm/Ws/7IhxUerRhaNEa1mu9wuThdwY yL1A09mVzzRMfcyZN5gyeybIo2se6u63iw8MDZ3+4HwdnnvG9Bkk7Fwpr nrzHw02EqG2244dM32LGyywHP43sauc1K+b9yj8vxf6o9TCyqWAsYnoUF 6KzZ0/re28XpoYb0pMOF4+6UPUk/ROvofHEEdiM01IxISisEFraYPonEh g==; X-IronPort-AV: E=McAfee;i="6400,9594,10316"; a="262359809" X-IronPort-AV: E=Sophos;i="5.90,259,1643702400"; d="scan'208";a="262359809" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2022 05:13:59 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,259,1643702400"; d="scan'208";a="527375158" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga006.jf.intel.com with ESMTP; 14 Apr 2022 05:13:59 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 14 Apr 2022 05:13:58 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 14 Apr 2022 05:13:58 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 14 Apr 2022 05:13:58 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 14 Apr 2022 05:13:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iy7wuluU/q7F67gHr+0QFX+Ab20NnVBPbHxQ8B/+gmRBkq7w7xMm0PA+1ODSJ6oEIWAIdd7DRemaUr7oLC9Nhhlx4jSeTmr9oivp5wNXSmJUsoSrSilcPSox303pZ2PtnuXCR6fbjNQ1ClJMGLe4PXDVgaKgSQHIXTr8+uHk53lTy97rB8llbSsvnlE8leWXb8nx0s0udj5yI1Ks2WaG182B7UQwJOOYAi5RqJO5iD51Fmog80k2UN+6LRrUeZw7ABn0SFJHPNSUfe58Ra2pJ0MW+/mbHaoAQaw5qh4to6iNlIunOSJP4ACLewAvVBjve4f/hAJRtA1s/xVTzoH3yA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=JO73zQRmBeBSBvRpnCKol8S3IST2iA3WuhVls/n8zzU=; b=kTJkQmxxRu59YG7Fh+DuEicequITixcIEpa+UbPj+67PqPxOV7R1DWr8xe03dxw78dLifTXeaXUC2V2mcykiRVAVWxWRLL7Xy0Swfm7zeq6wLjTais7XXEwyJzHOkmvLiknrR3n+jGRF1gGF0xGqWJ168I2HwteGKNup9YEtJX2JtEgtLcVsNBVNT8IAtY4UJJJ+aCLw9ibai33dgJt5DDcI92GLxNLUmp0PLQyDO0Z56rJ3IXjMsCSt4hEqKvvnY/GWnNf4h5h0oLQi43cMr4r0PWmtV6XRqeVYV8a2m1ALwZir2LLE776hgXphU4oy9VvzWSLj9SsRLYH6eERkHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BYAPR11MB3495.namprd11.prod.outlook.com (2603:10b6:a03:8a::14) by DM6PR11MB4427.namprd11.prod.outlook.com (2603:10b6:5:1db::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.29; Thu, 14 Apr 2022 12:13:56 +0000 Received: from BYAPR11MB3495.namprd11.prod.outlook.com ([fe80::784a:cab8:f035:d8ca]) by BYAPR11MB3495.namprd11.prod.outlook.com ([fe80::784a:cab8:f035:d8ca%6]) with mapi id 15.20.5164.020; Thu, 14 Apr 2022 12:13:55 +0000 From: "Wang, Haiyue" To: Thomas Monjalon CC: "Daly, Jeff" , "dev@dpdk.org" , Stephen Douthit Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Topic: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices Thread-Index: AQHYMnOuiff82ZUQlEWL3X/zT2fgs6zu2SEggACJxICAACmoMA== Date: Thu, 14 Apr 2022 12:13:55 +0000 Message-ID: References: <20220307223442.28012-1-jeffd@silicom-usa.com> <1889452.fIoEIV5pvu@thomas> In-Reply-To: <1889452.fIoEIV5pvu@thomas> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.401.20 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9c9e9075-f946-4d80-499d-08da1e103f4c x-ms-traffictypediagnostic: DM6PR11MB4427:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ROTwv+AP4M6F7TdXMhdIN1ky/6+OwX2k5oHBBeCXlQ5g1+IXZ54Zt2UVhKqAXBrdjx4jYs5Euh7HfAZ1pUL+mcHpurUv2dCY+BuW7mhJw1W802oEgy7Px/BkQCwS34/+tK3u4hSbtMo9XXoi1WPZZFkwFsDopMIRF2JVGkS4AR0l5Kmn0UCou3HoqC5S3QVAExBjnBN4JCVKz2VZ5EOsgb37fv6qCi44u0OaFxeVoNpz9xasSaeRS0A5h36xNW71QSCkYI2CsXa+Zg7TfyvyDdbE9MXj+GGYVZHHDBIPaEi8rRtn9lt9ZCyALUqFZcv/6Wh3CXQ3hHsSlqzowQ2TsHzsKaR+us1r6PdQCUfhdUuQ6wGDm9YaPbd/jgNgzgUqVggr34PHfoViC8I9bOPGIfMQOMYMXGzGtTLSTi4UquUU4Izac7sttn8mSseCwLNqe6BXS7bFC1J+1//OuWl1bJ6ZpkAnye6vZDlopt1whMSjzlHhzwvMF/3L1kRKvoCr/Da6XRC603lKMoOoXSkzlaIYXBMeFiYKppcKGQqSgYxshZqpBiAvZGkU7mq3BUt9gzFJo0KtAdr0xVD/SGZrC1qljK1pLiqC3EAGmc6t1p0gIk43Rv6+jdvmn0OSAcYjVtdnnyMZoe8KfRu9vrMAhVPTiiZiePgFnMdBTDOmcq88E5MnOyNDMRHrNdCqa4WD/Jsd9ppQzRqGKmo6Yry9Vw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3495.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(316002)(8936002)(66476007)(76116006)(66946007)(66556008)(64756008)(7696005)(53546011)(2906002)(54906003)(8676002)(86362001)(38070700005)(6916009)(4326008)(5660300002)(71200400001)(66446008)(508600001)(52536014)(26005)(33656002)(122000001)(83380400001)(38100700002)(9686003)(82960400001)(6506007)(55016003)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YZTsOSxfr3JETAOAqoFgsxxCakcsO+hYtbWxcxnnxDTZHoCxunhYjmfl7Cbh?= =?us-ascii?Q?ecnuQTfLBb3zm3amgHsbfBA+C2JYUCPO8xZa1hgCxoerlWO53kEBGUso8s3y?= =?us-ascii?Q?ZeG8WsFqTtzc4TmsCzWH4kOSGA0JP5mK2snsXExbunoYQC4aDi4sIvq7jbk8?= =?us-ascii?Q?b3wM4bsaq/BpLxhGOFHyKCi84WNDsGovACXZOQPBqaZLzFJl8Pf7xU5i3D8+?= =?us-ascii?Q?clBu+zVYyQFCPf/zCcs+GbqYMvgcxAITkNejYvuyBHm4SNO95bUSSKR/CBDA?= =?us-ascii?Q?6teh5CI3Tc0lf8WBBMTKQlAenKn2RlY+apPPK1t4CwPreMVD1OPiHSBC8WvS?= =?us-ascii?Q?jSoVFr5m8E6Sqrf30FFCuXMqMMFqJyAe7WOx2kWZ4iIrd2qnL3NBhVqC+2Cp?= =?us-ascii?Q?dc0WDR/BwtMpbbwns41jArl2lCotWDzT48U/aTZAb3fCDu0ihoBPqJ1k0f0M?= =?us-ascii?Q?yOIEAs8pAq6WxmSyKzqvnoEapYgKAamEX35pHK/w/Ko42bE9ht5dc6BIC2Ly?= =?us-ascii?Q?439omztN9pZgZQ9p4F4t94+pEvTEyO4hEe1bnj/5QBgdfGcE06mybYwHny3S?= =?us-ascii?Q?RClSkDEspddIDpX8VqksaqDNx4+5nIMxYuuV5g2pCVqjBsEPbBsab+bWiURP?= =?us-ascii?Q?3mjWf4tJrbZPwzNYjXAzfRhXxRWaPojoGFMwdHXJ1TKF5yUs3oGvFElO7Dyr?= =?us-ascii?Q?lLt9zCPJ1KvzL9RYvwY38QlAiuN5fjl3QnCeK42UU17xf2GB23wpKIMsF4/E?= =?us-ascii?Q?hEU34Au5wlJOmXkLanFjBJ54HwQWElIbEIEyTTvxjI0ycA+px6QgWADkBZl5?= =?us-ascii?Q?XPplM+X1yGsMwhJcfKOEmP1U28VOWs3VqjMs1z34bINuT19TBjJgTuwjP6kw?= =?us-ascii?Q?BEX9D7ds+5KixG0d8RC8RPd35f+S9IuAv6jFd5gJFKviv+7IIkokHcj4NX9I?= =?us-ascii?Q?VTE2rfXvOAtQDnysAIecz/aTePL4p7wM7Y5SeW2BjPLO4q2/ldacot5q4Fdc?= =?us-ascii?Q?ISeo2OwlA0xKbgqJHwqHZDKOxb9VyezfXn6XcmDsAO4JKA2hJa8SRA0VuDXi?= =?us-ascii?Q?3eU1FzzvKHOReOaIMxXnR8KKRksOLML534hY0Zc13JW+DJY8u/KuhHlVx6JW?= =?us-ascii?Q?o26KKDroUAtbCRXeUGtliiNuEeLViJSNFSsarIm+qST9KVAucWbtwP6RKcru?= =?us-ascii?Q?AMdP0I+EuS0Vn8GHrQ1+ZeyUO32IMiNXiaWxeA9PkUDwMtvzj53AQ/pp0qGQ?= =?us-ascii?Q?1+tVKcHd0pPrArn3OTUGo7bFOl+CfHnfi094gwhI4K4oefScl8awbD3F3tRv?= =?us-ascii?Q?prTHy1D433XDyEp26U9EJZsRw63ROIlrt66ogxrmmYn6FzIfqcZISZkorpIJ?= =?us-ascii?Q?GXjKa+OgErBBTCGwY5EWHADsdHlRK3/sqsZGrVE664UuTaeaAXyzYlry9WCr?= =?us-ascii?Q?GLbYy3kOVSnRS1BJC27Vf+/VUJjFSea1Y9UC4YTJ/mPpiu4aE13I5OfWAE6f?= =?us-ascii?Q?x4ZQQEaPKAj/9azBew+a6iuYX/wdHE12RjhVd3JG3AR4YDRCTBDTCcgCzbUi?= =?us-ascii?Q?E24xwvJDF3MPAr5Mpj7pSxDEoH4o6I/dofBR0s/p0S2J49dy1fQ1sHrFGZR7?= =?us-ascii?Q?fmSgc8y+dzd0IaEvrnsBmOOinmTUdDJ0+ZmvWc+4uaX5UwJCGPnVcZc82kbA?= =?us-ascii?Q?84A1C2LpSPUSebxAa2BFAJAaV+ZU1ycVN23SErg59V6NVW05okysXpVrz2xD?= =?us-ascii?Q?gcQZlUNwDA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3495.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9c9e9075-f946-4d80-499d-08da1e103f4c X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Apr 2022 12:13:55.6152 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SXlK8E1wxFYs6Am+wq/bwb1rJx6vDLS9mRbVw38jQcaVphLsnET66AVjSuVlpwWbeRy3WV9mLfe75D5mRjuunQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4427 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon > Sent: Thursday, April 14, 2022 17:42 > To: Wang, Haiyue > Cc: Daly, Jeff ; dev@dpdk.org; Stephen Douthit > Subject: Re: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 dev= ices >=20 > 14/04/2022 03:31, Wang, Haiyue: > > From: jeffd@silicom-usa.com > > > From: Stephen Douthit > > > > > > 1G Cu SFPs are not officially supported on the X552/X553 family of de= vices > > > but treat them as 1G SX modules since they usually work. Print a war= ning > > > though since support isn't validated, similar to what already happens= for > > > other unofficially supported SFPs enabled via the allow_unsupported_s= fps > > > parameter inherited from the mainline Linux driver. > > > > > > Signed-off-by: Stephen Douthit > > > Signed-off-by: Jeff Daly > > > --- > > > drivers/net/ixgbe/base/ixgbe_x550.c | 14 +++++++++++++- > > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/= base/ixgbe_x550.c > > > index 8810d1658e..8d1bc6c80d 100644 > > > --- a/drivers/net/ixgbe/base/ixgbe_x550.c > > > +++ b/drivers/net/ixgbe/base/ixgbe_x550.c > > > @@ -1538,9 +1538,21 @@ STATIC s32 ixgbe_supported_sfp_modules_X550em(= struct ixgbe_hw *hw, bool > *linear) > > > > NACK. > > > > As for 1G Cu SFP treating it as 1G SX, some 1G-Base-T SFP modules requi= re the use > > of RX_ILOS and some Intel Ethernet products don't support that. >=20 > So what is the solution? >=20 > > And the DPDK keeps the same design with kernel. >=20 > It should not be a justification for limiting DPDK features. Um, this is upstream version driver to keep the same behavior. There are also some kind of custom release ... >=20