DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wang, Haiyue" <haiyue.wang@intel.com>
To: "Zhou, YidingX" <yidingx.zhou@intel.com>,
	"Yang, Qiming" <qiming.yang@intel.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH] net/ice: fix gcc error with -DRTE_LIBRTE_ICE_16BYTE_RX_DESC
Date: Mon, 7 Feb 2022 13:14:18 +0000	[thread overview]
Message-ID: <BYAPR11MB3495D44F638F716B494F1B6FF72C9@BYAPR11MB3495.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220207164801.2768734-1-yidingx.zhou@intel.com>

> -----Original Message-----
> From: Yiding Zhou <yidingx.zhou@intel.com>
> Sent: Tuesday, February 8, 2022 00:48
> To: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] net/ice: fix gcc error with -DRTE_LIBRTE_ICE_16BYTE_RX_DESC
> 
> gcc will report error "unused parameter 'rxq'" when the macro
> RTE_LIBRTE_ICE_16BYTE_RX_DESC is defined. use "(void)rxq" to avoid it
> 
> Fixes: 7a340b0b4e03 ("net/ice: refactor Rx FlexiMD handling")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Yiding Zhou <yidingx.zhou@intel.com>
> ---
>  drivers/net/ice/ice_rxtx.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
> index 58700f1b92..97572d5952 100644
> --- a/drivers/net/ice/ice_rxtx.c
> +++ b/drivers/net/ice/ice_rxtx.c
> @@ -163,6 +163,8 @@ ice_rxd_to_pkt_fields_by_comms_aux_v1(struct ice_rx_queue *rxq,
>  			*RTE_NET_ICE_DYNF_PROTO_XTR_METADATA(mb) = metadata;
>  		}
>  	}
> +#else
> +	(void)rxq;
>  #endif
>  }
> 
> @@ -201,6 +203,8 @@ ice_rxd_to_pkt_fields_by_comms_aux_v2(struct ice_rx_queue *rxq,
>  			*RTE_NET_ICE_DYNF_PROTO_XTR_METADATA(mb) = metadata;
>  		}
>  	}
> +#else
> +	(void)rxq;
>  #endif
>  }
> 

" __rte_unused struct ice_rx_queue *rxq" could make the fix clean.

> --
> 2.25.1


  reply	other threads:[~2022-02-07 13:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-07 16:48 Yiding Zhou
2022-02-07 13:14 ` Wang, Haiyue [this message]
2022-02-07 13:46   ` Bruce Richardson
2022-02-08  5:35     ` Zhou, YidingX
2022-02-10  3:09       ` Ling, WeiX
2022-02-10  9:30         ` Zhang, Qi Z
2022-02-10 10:12           ` Ferruh Yigit
2022-02-08 15:42 ` [PATCH v2] " Yiding Zhou
2022-02-10  2:36   ` Ling, WeiX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB3495D44F638F716B494F1B6FF72C9@BYAPR11MB3495.namprd11.prod.outlook.com \
    --to=haiyue.wang@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=yidingx.zhou@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).