From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFAFEA057C; Fri, 27 Mar 2020 13:18:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EFAC81C1A7; Fri, 27 Mar 2020 13:18:32 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id F373B1C1A4 for ; Fri, 27 Mar 2020 13:18:30 +0100 (CET) IronPort-SDR: +1Bd0Pkht9BVDjqqEd0D3wY+5a8sR77tLcl2LC/m2ZgIkNCpFS4gHmVKCU/usaBWdJHelPwq6p iXr7WTX+lHlA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2020 05:18:30 -0700 IronPort-SDR: +qdwRcNDvtNspNElkvQAo8kpL2mjFywuPmMDUU+sTg2N7/wo8unt5ftMSsFvmvXf+fwGFdAp/U nAlZSFMud/jA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,312,1580803200"; d="scan'208";a="240947547" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga008.fm.intel.com with ESMTP; 27 Mar 2020 05:18:29 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 27 Mar 2020 05:18:29 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 27 Mar 2020 05:18:29 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.53) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 27 Mar 2020 05:18:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EeOkRdPx8E3JIyrqseGpUd/rH6CjCDohDMfMf841HJnYo1J7ws+Kifvt+S0X3klXydMn/VEBeR0d3m31MQGm2DVxky1bQCeRrbyA5MwTWkZe7ok1Nn4EDMxwvPsI4MZPYzibm7TQkcZ8+44seYB1XUV277JSAfNz+ak5ZuHI81cbAxiGNnmpN7R5AdI5szciD9GbzXLrF/WnPby8t3uewdlFnrqpAZv5ZAI90F1aLLu+U0wGUYcW4gKa1/9AXeGvyhRxWqT+qJz/VrsUurqNt68S3GvNIW1+YSXTvmsgCMjf15mJ/FYwiYh1zlVG+Ryf6w0XGqDMPl9EytFNB5+6Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qJASZyUPOzNs1ULZCjiLWWZ7W9tCy2Z32Qi8oFLsugA=; b=iBWy65b52ZYWFuhsBveVvKaz3ye75VouU2CgQqmG0Jc3gyV/x738LrpqVr0BtZ0Mvd8sy2S3o+2BEBWrhhOXWuphwgpaOwfqh9T++we8/JdbfrxZPpvX/IQ3p+4zD12fpgTa28aWuLuBU3KouWP5VxWuVV3vpR0EH7XJAd9roddI7mPUej9SLiVDGuyx7+bUXR2I1oMViM5LccEDq+SkNCTQkWCZqVF0oIyQRE0RVN3/FLFQ5BP9L+yZ5THka31DzD7/ZZeNoXEXahQp8sVkFVR02JV3ehQmnn6QFBNfKCRLCKPXq1XthRj+fC03M1w16++mjKaw4/Rq2xzCT9GBFQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qJASZyUPOzNs1ULZCjiLWWZ7W9tCy2Z32Qi8oFLsugA=; b=PSSurYxAy8fqKZGoKmeXScHrHDqNojvojXWArBHKaIPlEjmnuR4gRPbTgeYRUhtGK2gYYzpaFr/X+JtjxcuEuw009DpfFbkgxJ0ZuIVzR0YO6Q/x7R06V5hDyJboIih1tyKP9PmM/kkt740RZmD7Oi4zhK3sXT8XiGRGWTDoK/U= Received: from BYAPR11MB3541.namprd11.prod.outlook.com (2603:10b6:a03:f5::16) by BYAPR11MB3590.namprd11.prod.outlook.com (2603:10b6:a03:b2::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19; Fri, 27 Mar 2020 12:18:27 +0000 Received: from BYAPR11MB3541.namprd11.prod.outlook.com ([fe80::e8ad:5730:3ad0:87c6]) by BYAPR11MB3541.namprd11.prod.outlook.com ([fe80::e8ad:5730:3ad0:87c6%7]) with mapi id 15.20.2835.025; Fri, 27 Mar 2020 12:18:27 +0000 From: "Xing, Beilei" To: "Cui, LunyuanX" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "Wu, Jingjing" Thread-Topic: [PATCH v2] net/i40e: enable MAC address as FDIR input set Thread-Index: AQHV/NW7DIczjLSsb0mAZ8kjj1twe6hcYksw Date: Fri, 27 Mar 2020 12:18:27 +0000 Message-ID: References: <20200316004722.5323-1-lunyuanx.cui@intel.com> <20200318031506.79773-1-lunyuanx.cui@intel.com> In-Reply-To: <20200318031506.79773-1-lunyuanx.cui@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=beilei.xing@intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7fc78430-beb7-4dd0-97b4-08d7d248f453 x-ms-traffictypediagnostic: BYAPR11MB3590: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4502; x-forefront-prvs: 0355F3A3AE x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(396003)(136003)(376002)(39860400002)(346002)(366004)(9686003)(52536014)(54906003)(66446008)(316002)(64756008)(81166006)(66476007)(66556008)(2906002)(55016002)(66946007)(81156014)(5660300002)(8676002)(6506007)(107886003)(33656002)(71200400001)(76116006)(186003)(7696005)(110136005)(26005)(53546011)(86362001)(8936002)(478600001)(4326008); DIR:OUT; SFP:1102; SCL:1; SRVR:BYAPR11MB3590; H:BYAPR11MB3541.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HPr44jEe1rlRf/ts/5BKers4VZzZVAxQJUdNlaSoByLbhU1kNADWT3dVdmCHNo8t8RKSJRLTssLaW6Oj0W+vVwvb0EzjxkJ2YecTqfAVA0E2JMtf8oJrfTDDxIV5hJZ0JkOpqEVOYzASRdNG3HB7jHnbevUh5mqH3GwqEGaFlh3LberR1/qwcIB/aMI5+jfmWY4AB0sLfvC26K4CU2gTPqP4U0PcPGfpe3D/hK98dOrnWnDrCcM2MPzW+P50OI9gmTamL+xoCQzxFWiF51kckJCo+SgTqFs81Bib+GllwOMd7swDyR9iYpgwj51cqX9Fpg+JGpuSgH84K/++o7aF3Jdsk2I2uUR/VyR/l6moELiE/6aviXaCCwMc9y332m953ruQ71hcmV91C6tEFuCDkfkf59hwAGp1pT+CYdXrFVHL1dgRW+/9/YWSMIm3zRgx x-ms-exchange-antispam-messagedata: qnMl0gXNJxXrGvi18vYuanM4edNJFTsk/HN9PvyRoOoqm4nxrKvBFZ5g49JyO9PEc3rrcHdMQzgP1nAF17pwQgEd/g5jBOO6Ad//HJVetKFqMQ83kmGjnVWGYiEZx3sA2emBcEwGx/eZ5+AaffciLw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 7fc78430-beb7-4dd0-97b4-08d7d248f453 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2020 12:18:27.3312 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cvKF5pkv266Tz8KGNJwYdxLZMpW13YIW76s3S9VyG3mYKfWJaJ871qRu/nvcKNyzg2UiYPruNhaNw2POuUR16Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3590 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: enable MAC address as FDIR input set X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Cui, LunyuanX > Sent: Wednesday, March 18, 2020 11:15 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Qi Z ; > Wu, Jingjing ; Cui, LunyuanX > > Subject: [PATCH v2] net/i40e: enable MAC address as FDIR input set >=20 > FVL enable both src MAC address and dst MAC address as FDIR's input set > for ipv4-other. And FVL enable only dst MAC address as FDIR's input set f= or > ipv4-other.=20 Why emphasize input set 'src MAC address and dst MAC address' and ' dst MAC= address ' as input set? Can't we support src MAC only? When OVS-DPDK is working as a pure L2 switch, Both two ways > match offload with Mark+RSS action would help the performance speed up. > And FVL FDIR supports to change input set as both two ways. >=20 > Signed-off-by: Lunyuan Cui >=20 > --- > v2: > - Enable src MAC address as FDIR's input set > --- > doc/guides/rel_notes/release_20_05.rst | 7 +++ > drivers/net/i40e/i40e_ethdev.c | 1 + > drivers/net/i40e/i40e_ethdev.h | 18 +++++++- > drivers/net/i40e/i40e_fdir.c | 22 +++++++-- > drivers/net/i40e/i40e_flow.c | 63 +++++++++++++++++++------- > 5 files changed, 89 insertions(+), 22 deletions(-) >=20 > diff --git a/doc/guides/rel_notes/release_20_05.rst > b/doc/guides/rel_notes/release_20_05.rst > index 2190eaf85..f0efc5295 100644 > --- a/doc/guides/rel_notes/release_20_05.rst > +++ b/doc/guides/rel_notes/release_20_05.rst > @@ -56,6 +56,13 @@ New Features > Also, make sure to start the actual text at the margin. > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > +* **Updated Intel i40e driver.** > + > + Updated i40e PMD with new features and improvements, including: > + > + * enable only dst MAC address as FDIR input set for ipv4-other > + * enable both src MAC address and dst MAC address as FDIR input set > + for ipv4-other > + >=20 Same here. > Removed Items > ------------- > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 9fbda1c34..d11df8d83 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -9373,6 +9373,7 @@ i40e_get_valid_input_set(enum i40e_filter_pctype > pctype, > I40E_INSET_SRC_PORT | I40E_INSET_DST_PORT | > I40E_INSET_SCTP_VT, > [I40E_FILTER_PCTYPE_NONF_IPV4_OTHER] =3D > + I40E_INSET_DMAC | I40E_INSET_SMAC | > I40E_INSET_VLAN_OUTER | I40E_INSET_VLAN_INNER | > I40E_INSET_IPV4_SRC | I40E_INSET_IPV4_DST | > I40E_INSET_IPV4_TOS | I40E_INSET_IPV4_PROTO | diff --git > a/drivers/net/i40e/i40e_ethdev.h b/drivers/net/i40e/i40e_ethdev.h index > aac89de91..e8b98b67e 100644 > --- a/drivers/net/i40e/i40e_ethdev.h > +++ b/drivers/net/i40e/i40e_ethdev.h > @@ -544,12 +544,19 @@ struct i40e_ipv6_l2tpv3oip_flow { > uint32_t session_id; /* Session ID in big endian. */ }; >=20 > +/* A structure used to define the input for l2 dst type flow */ struct l2 dst type flow? > +i40e_eth_l2_flow { Flow other names, use i40e_l2_flow here. > + struct rte_ether_addr dst; > + struct rte_ether_addr src; > + uint16_t ether_type; /**< Ether type in big endian */ > +}; > + > /* > * A union contains the inputs for all types of flow > * items in flows need to be in big endian > */ > union i40e_fdir_flow { > - struct rte_eth_l2_flow l2_flow; > + struct i40e_eth_l2_flow l2_flow; > struct rte_eth_udpv4_flow udp4_flow; > struct rte_eth_tcpv4_flow tcp4_flow; > struct rte_eth_sctpv4_flow sctp4_flow; > @@ -628,6 +635,13 @@ struct i40e_fdir_action { > uint8_t flex_off; > }; >=20 > +/* Ether input set kinds */ > +enum i40e_fdir_eth_inset { > + I40E_ETH_INSET_NULL =3D 0, > + I40E_ETH_INSET_DMAC, > + I40E_ETH_INSET_SMAC_DMAC, > +}; What's the enumeration's purpose? Could you follow the original code for input set configuration and packet c= onstruct?