From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DA0FA0350; Mon, 11 May 2020 07:12:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 49C2D1C43C; Mon, 11 May 2020 07:12:22 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id AB93349E0; Mon, 11 May 2020 07:12:19 +0200 (CEST) IronPort-SDR: Acw5O0uC5m/Yfa2HpJR6Lvt/uC2bijfDxzxrbGQBtgqIf/4v4SaKQXFfBuWCRMFRO97tu9YJ6f y05czZHKGziw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 May 2020 22:12:18 -0700 IronPort-SDR: 7x08J88yk6po6a3+R5WmV31eikMeGacVxdpFFKPuAOQvrQ44WWGaS7Arx+lSqqoj/6rKd71PSL ftE9JzJY9KiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,378,1583222400"; d="scan'208";a="251054355" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by fmsmga007.fm.intel.com with ESMTP; 10 May 2020 22:12:17 -0700 Received: from orsmsx123.amr.corp.intel.com (10.22.240.116) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 10 May 2020 22:12:14 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX123.amr.corp.intel.com (10.22.240.116) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 10 May 2020 22:12:14 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.58) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 10 May 2020 22:12:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ThRGrBCDpwm4fZxIgmWnJ8UFa2Rk2xefYokPPpv3/NDKB97qL4jAc8cB3H09QMCU9rLlQw6S/lWTdY5LlKeUqUeFg0u9JQ7+EkwxODqJ7CVjpIoGcVw/MKxMQIpcMgb8Ua7d7katYqPucZ4hslad0gTKFK83SHiFRRS6zrmuCeif7Pa4c9XpjDvOBbszMKrzLBP9SdEGTntXw+vixmVNangiHqi1SBk6kYSIfhWthGJzwVAlrpx2nG/CsRv2qyUaE0Nti64qB85nReLS4oFxeEIszKnfbccsE0KAYVAnPZPnUyu96RFJjE0YHMJsRI6NXsjy2SsMTR91ArkD7ukfIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tdexvQMFlzBH+Qs9ZjqunN+WODlZW/mey0Yd9QJAy60=; b=FqnvwBtbalpTPopYA0PeOGSzaB2IXs3EBygu0gA+ddsw0tOQB0W4CXO8BJ0RqVIBHDSlGwJXhgeFS0pEsr6u4nMLxerlpAJbDaox9znCpCTIN82lnTWoaMPSKJMM7vaKAefeKSWuB3sy/u8B1nh+Ms/9xvLHssuSEGOYHKSMw8A4dwa/aAttWblRm6Lcmlp3PN6AsV5lR0tzUOo8JZ1oiXqXR4LhYQAcpiUMukLBOE69zhSVMnvOCeA8MSkzrhbdKCNJs61ts8MGz7o6MtCxvaMrnezqIKEHgUeAY12oE6EakOdMitMLOxZv32Wl1o+FmUQU9M2IiKBAEp6NIYupDw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tdexvQMFlzBH+Qs9ZjqunN+WODlZW/mey0Yd9QJAy60=; b=A1Wtg1EliWt8Tqb0S8KjWqLryaQLFBCn+1cU2CK/UyTIYsVxthM4L1EhadRawY/TxBr84NFu+hE++QJlma/rslW/cwUj11qRCZIyYnIzMhdJJnRQxYTJ7t3q5qRHdZp9a94rrjHFsWyGbq6cAybD9R9HiROMOgnELl+HKtxtOVk= Received: from BYAPR11MB3541.namprd11.prod.outlook.com (2603:10b6:a03:f5::16) by BYAPR11MB3527.namprd11.prod.outlook.com (2603:10b6:a03:8b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.28; Mon, 11 May 2020 05:12:10 +0000 Received: from BYAPR11MB3541.namprd11.prod.outlook.com ([fe80::9d22:d78d:bdf2:313f]) by BYAPR11MB3541.namprd11.prod.outlook.com ([fe80::9d22:d78d:bdf2:313f%4]) with mapi id 15.20.2979.033; Mon, 11 May 2020 05:12:10 +0000 From: "Xing, Beilei" To: "Xu, Ting" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Iremonger, Bernard" , "stable@dpdk.org" Thread-Topic: [PATCH v1] app/testpmd: fix DCB set failure in FreeBSD by clang Thread-Index: AQHWJzuLNDK5u+h9h0O2PizyHLF0LaiiVrAA Date: Mon, 11 May 2020 05:12:10 +0000 Message-ID: References: <20200511102504.23936-1-ting.xu@intel.com> In-Reply-To: <20200511102504.23936-1-ting.xu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.38] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 92599efb-14c8-4b78-7c45-08d7f569dbf0 x-ms-traffictypediagnostic: BYAPR11MB3527: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-forefront-prvs: 04004D94E2 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PW/fJRtDWcI0aDxv1KkJRQ13sirtt9y+BOyVI1yQkX9DFprXmL1Af2/Irgc6EZG4iVlvY98OfwlYjKwygeg28Mulursas/BlSg8dzLt4mq7dpFWLb6RfVaPU817oFJn5Pg/Tz9DBm1xIslh7IlrKg3RE/4tVhoowwO5jvXbgYS7wDF2nzxOZ1ON+VeHP/pHhvKyZlRCouv9tqOdPw7yTahjJ/Yzfwg4pQ95GWdo96bp/zP+tXEYAZYrpKbpUPbdBjMjtSRhKtcvkzTe3xeZTVpBUVPI91vIDwnx6XtYRpLtxYfklI9Ah4YxgUqhCav/IuwhHtxnXiYMtZzVbYAPV6XDJcvoHwo3jL67XLlokLC5mYUJ7yK3B/vdIkcpM7X+JUS+UowO05BmwX2PiDVdrOhgXz5fVbFUP90lLqUKm6eRcG+sYOssV5M7WeBZJ8/6mbnMrRLvZLwpZzk6uExtD8P+2Uc0rL6vCJFdUSrJ9JB5lWFVeR7SYMDomARnoCIYda2gJ7vFx0pbEpPLAKw2WZw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3541.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(39860400002)(396003)(136003)(366004)(376002)(346002)(33430700001)(66446008)(66946007)(64756008)(66556008)(33440700001)(53546011)(6506007)(52536014)(8676002)(76116006)(316002)(9686003)(450100002)(186003)(71200400001)(2906002)(55016002)(66476007)(7696005)(4326008)(5660300002)(26005)(54906003)(86362001)(8936002)(478600001)(110136005)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 3aEug+1mlQ9dja49V9FIGdnd3SOcUDnkqaByIY0wGDyigdANNVKFkaUqFstxXlUgJJ4/ArfbwfXQ6qPreeI4RwKJHNQf1WQOk2zQtBrDqPRsKEd/Z8anrdv7zJbPib7VbGNNdl+neZW9OpfJV5p5zBb5wJSV4b+JkTgnuQyfOHkYsOcg0Gevm7+Db7wLZSWc12w+8dOEnfV6VM8ntSZNBTtOivnYfYH5J5dn3+CZ7BVrzcwhU62vFpW4GwPU88ygH15vZa7ip05QLB672kKYWOuf66Zj6ElNx2UrFefmj/LAZ63tUVDQ1i1ADv82G8QJ+qNL24pG/7EX0MzSNbWHiyJpmEBWAM1oYfkDV2f4cayWhP3VkAC+pfMLiHVE6OgtLEiElTN6Zqjc6NMwz88+/vec7HJgaIfwzscTJ8N9Dy7RDhKodyy/hY8dt1Gmx934BXtpWpbWhE3A+wMtlF5uUHsBn/rg4qHI6/0XOfEKu6CI7NQeWmhSkQZIUAw++rN8 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 92599efb-14c8-4b78-7c45-08d7f569dbf0 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 May 2020 05:12:10.4927 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eZMvfWR202T1nU7zvV3AImRQmpItlbYw59cb2TPxwi73rej/xvYyvJaGYztrKvuDb8rOvQ/3sxuucaH3WGtGnw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3527 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1] app/testpmd: fix DCB set failure in FreeBSD by clang X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Xu, Ting > Sent: Monday, May 11, 2020 6:25 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Xing, Beilei > ; Iremonger, Bernard > ; stable@dpdk.org > Subject: [PATCH v1] app/testpmd: fix DCB set failure in FreeBSD by clang >=20 > When set DCB in testpmd by clang, there is a segmentation fault. > It is because the local variable rss_conf in get_eth_dcb_conf() is not cl= eared, > so that the pointer member variable rss_key has a random address, which > leads to an error in the following processing. This patch initialized the= local > variable rss_conf to avoid random address. >=20 > Fixes: b57b66a97ebf ("app/testpmd: support mbuf dynamic flag") > Cc: stable@dpdk.org >=20 > Signed-off-by: Ting Xu > --- > app/test-pmd/testpmd.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 99bacddbf..1276476ca 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -3408,6 +3408,7 @@ get_eth_dcb_conf(portid_t pid, struct rte_eth_conf > *eth_conf, > int32_t rc; > struct rte_eth_rss_conf rss_conf; >=20 > + memset(&rss_conf, 0, sizeof(struct rte_eth_rss_conf)); > /* > * Builds up the correct configuration for dcb+vt based on the vlan > tags array > * given above, and the number of traffic classes available for use. > -- > 2.17.1 Acked-by: Beilei Xing