From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9368A0577; Wed, 15 Apr 2020 07:31:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 533671C43C; Wed, 15 Apr 2020 07:31:32 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id B93531C221 for ; Wed, 15 Apr 2020 07:31:30 +0200 (CEST) IronPort-SDR: QvoKuu/BrePzZke0J6T4D1YWC0FRLBNkOqqjAdjviygaMUwaRz+M2o+mGYANv+Kg7mjaHpwisM 67wJc7++NY7g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Apr 2020 22:31:29 -0700 IronPort-SDR: nvr7ZFIn3y5km84Cas432PrPmyJGodaCfohMjU8HsVzrIyDM1vjEbdAWZsnZ4Pc7VKOICG518f MIdfZ/a0ZzRQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,385,1580803200"; d="scan'208";a="363580720" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 14 Apr 2020 22:31:29 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Apr 2020 22:31:29 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 14 Apr 2020 22:31:29 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 14 Apr 2020 22:31:29 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.173) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 14 Apr 2020 22:31:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A6r2WC99G6GMxg9jMRRl3Iqc+61KIk0CtYYOxmBk5HmT1IMfQoAAx0dcDBFS2kdabz2EJB4xL5zwoDEnBnxuTsYyTcq/5X0RD5Ub+ftUU8ZJTS3CuydVFYeleGRX9ixBb51RQvc6/aek8Rq49hw6zpHhvJKpG3R7Sg2q2PtsPQKKPcEhRu6dDJzaeSsQ9ulSvPmHqu8JIOBHupy/FyxLfblr68NBxghTNLEGdHne3NJS25Fwfr9MgKFhGNhJDBNIZGumT+duUPmpwjelGRWdW3dUPid+7wRTc6IsmtehwvKViHxyMdkbwLNifWup4c3D9RqTfZYYVFMhmdhyiJLNCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0Dol68KoDZWtR8N8xXm1g0dUzTvfFMfm3kExDK/Rv1E=; b=n9+rXBDXFZ/YRlpSTVXoe6Rub2756zd+uf5Iees1yiuY73sBmNS/Hx4YQWUr1W8rv6LKjkiwN0oza8GO6GqiqlyReV8+em4E4kz1ZK2uPCdxw9d7No0E321TzIx4mNmo5U6pKZ9em5LHBoa0n0RB5/Z6bSJL0N9nN9zexeNlXTQbqZN14bkYlEfZ4+jOd/97gzltbZ6hJGwlcUt2I69CEwI6ktnUVtHIrs7ZBcL+TCIbGfpz0fQIjPSxuN/E8E9iIKqELWPXwRCysB5UkuAXrptZRdYxABA1rGTr40bY39u3TIeohpLSRtAwbMouwb+hr86rcFMIP3cOpObAi8ubwA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0Dol68KoDZWtR8N8xXm1g0dUzTvfFMfm3kExDK/Rv1E=; b=t1Q/GVrczOaAxz+WRRc3uQXa4yFBwod1Smo1M8xcw5baE1TnjUyfwh91PVLvJX4evi7RwLqJxCXO4opIEDVKygJw4dB8Q7v+QHq29OFGWlaX3VGM2yTQwuuyARJLndfd81JLnskdj75nXy1QgyDjYjPtzVtd6NtMOuDq1mi2nNM= Received: from BYAPR11MB3541.namprd11.prod.outlook.com (2603:10b6:a03:f5::16) by BYAPR11MB3638.namprd11.prod.outlook.com (2603:10b6:a03:f8::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.18; Wed, 15 Apr 2020 05:31:22 +0000 Received: from BYAPR11MB3541.namprd11.prod.outlook.com ([fe80::2c4f:22b:b8b0:27f9]) by BYAPR11MB3541.namprd11.prod.outlook.com ([fe80::2c4f:22b:b8b0:27f9%5]) with mapi id 15.20.2900.028; Wed, 15 Apr 2020 05:31:22 +0000 From: "Xing, Beilei" To: "Di, ChenxuX" , "dev@dpdk.org" Thread-Topic: [PATCH v8] net/i40e: enable advanced RSS Thread-Index: AQHWEiglNnHs9RT5AUCDXlohrrmAl6h5qRKg Date: Wed, 15 Apr 2020 05:31:22 +0000 Message-ID: References: <20200318014710.13577-1-chenxux.di@intel.com> <20200414063648.86590-1-chenxux.di@intel.com> In-Reply-To: <20200414063648.86590-1-chenxux.di@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=beilei.xing@intel.com; x-originating-ip: [192.102.204.45] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bf959185-9d31-4c88-8e50-08d7e0fe3bd1 x-ms-traffictypediagnostic: BYAPR11MB3638: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0374433C81 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR11MB3541.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(366004)(396003)(376002)(39860400002)(346002)(136003)(86362001)(186003)(55016002)(66946007)(66476007)(8676002)(26005)(66556008)(66446008)(81156014)(316002)(64756008)(76116006)(8936002)(33656002)(5660300002)(478600001)(2906002)(7696005)(71200400001)(9686003)(6506007)(53546011)(110136005)(52536014); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9elSOE7eY4JNqRLOb0sL9Ye49b3F9lnXUGNQblSMBHVqic+HBrK0Pk5mLUYDP2AtuYsQE8aWN59nvlC/LDEcnZZHlMJqHG9N7fTdgY8WACsJjo0ePqIkVFeQQYM8HI4jSU7roMogp9aNDRKU4FmB79rDEmBO8YAn6h3HsJFKdmFoZrwTvcZV8FrMsPyBvgego7OZvSRGGhC8S5s+2Gg8RvXKO9CHZrZiOmE8Ln1EEwE5ttm3OkBsOVF8H4QZxWvbb0Jlu0sRY4R1MBDnd0vq53F5WnT+JC0HxsOADU+eTBZGtC7lCcbGuioXNPFnFIb+YmI1OA/sU4Ef/FsmTpMga/ztQnZd4TbAM9xtx+Kd8Bjwdm94NtBl/+8j4ncRnA/Rb2mCbknHRyD3gC23FxslqBmx6hYB9oGPKnhXg/uHVMDeSi396t80pIkiYYrFHYU6 x-ms-exchange-antispam-messagedata: uN6Rp5rOIhkhCWB9JxQhoJ9fBHAV7uVAYq9y7UaAeh2OltoYWaOMUoR2cDf2VHMguHFLWt1V0AaJxhLYZVO4OQEuaTCOOUXZ0QlhBRSA4ZrLDdL1Q7nmBYT8G+SLF3zjA9XDQMawrkYjRAT/wci05Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: bf959185-9d31-4c88-8e50-08d7e0fe3bd1 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2020 05:31:22.4409 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JBKMgLUw4vxVSXIc9eTQn5V01LcC0juy3KKrEph4gEtyMWk3kAoMqTfsP3ninsqLC34XQnEk4byvfj5p31nLOQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3638 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v8] net/i40e: enable advanced RSS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Di, ChenxuX > Sent: Tuesday, April 14, 2020 2:37 PM > To: dev@dpdk.org > Cc: Xing, Beilei ; Di, ChenxuX > Subject: [PATCH v8] net/i40e: enable advanced RSS >=20 > This patch supports: >=20 > - symmetric hash configuration > - Input set configuration >=20 > Signed-off-by: Chenxu Di > --- > doc/guides/nics/i40e.rst | 35 ++ > doc/guides/rel_notes/release_20_05.rst | 7 + > drivers/net/i40e/i40e_ethdev.c | 509 ++++++++++++++++++++++--- > drivers/net/i40e/i40e_ethdev.h | 22 +- > drivers/net/i40e/i40e_flow.c | 199 ++++++++-- > 5 files changed, 683 insertions(+), 89 deletions(-) >=20 > diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index > d6e578eda..1f8fca285 100644 > --- a/doc/guides/nics/i40e.rst > +++ b/doc/guides/nics/i40e.rst > @@ -569,6 +569,41 @@ details please refer > to :doc:`../testpmd_app_ug/index`. > + > +/* Enable RSS according to the configuration */ static int > +i40e_rss_enable_hash(struct i40e_pf *pf, > + struct i40e_rte_flow_rss_conf *conf, > + struct rte_eth_rss_conf *rss_conf) I think one parameter for RSS configuration is enough, why need two paramet= ers here? Beilei > +{ > + struct i40e_rte_flow_rss_conf *rss_info =3D &pf->rss_info; > + > + if (!(rss_conf->rss_hf & pf->adapter->flow_types_mask)) > + return -ENOTSUP; > + > + /* Configure hash input set */ > + if (i40e_rss_conf_hash_inset(pf, rss_conf->rss_hf)) > return -EINVAL; > + > + if (rss_conf->rss_key =3D=3D NULL || rss_conf->rss_key_len < > + (I40E_PFQF_HKEY_MAX_INDEX + 1) * sizeof(uint32_t)) { > + /* Random default keys */ > + static uint32_t rss_key_default[] =3D {0x6b793944, > + 0x23504cb5, 0x5bea75b6, 0x309f4f12, 0x3dc0a2b8, > + 0x024ddcdf, 0x339b8ca0, 0x4c4af64a, 0x34fac605, > + 0x55d85839, 0x3a58997d, 0x2ec938e1, 0x66031581}; > + > + rss_conf->rss_key =3D (uint8_t *)rss_key_default; > + rss_conf->rss_key_len =3D (I40E_PFQF_HKEY_MAX_INDEX + 1) * > + sizeof(uint32_t); > + PMD_DRV_LOG(INFO, > + "No valid RSS key config for i40e, using default\n"); > } >=20 > + rss_conf->rss_hf |=3D rss_info->conf.types; > + i40e_hw_rss_hash_set(pf, rss_conf); > + > + if (conf->conf.func =3D=3D > RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ) > + i40e_rss_config_hash_function(pf, conf); > + > + i40e_rss_mark_invalid_rule(pf, conf); > + > + return 0; > +} > +